ping
On Wed, Jul 5, 2017 at 8:21 AM, Yuri Benditovich <
yuri.benditov...@daynix.com> wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1425961
> If attached new device when one device with the same vid
> and pid already present, the notification is ignored and
> attached device is not redirect
Signed-off-by: Uri Lublin
---
vdagent/vdagent.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
index cd49755..b71919b 100644
--- a/vdagent/vdagent.cpp
+++ b/vdagent/vdagent.cpp
@@ -1053,8 +1053,8 @@ bool VDAgent::handle_clipboard_gr
It can happen that new_size, although double the previous
io.size is still not big enough.
Signed-off-by: Uri Lublin
---
vdagent/imagepng.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/vdagent/imagepng.cpp b/vdagent/imagepng.cpp
index 7108675..de0eb2f 100644
--- a/vdagent/imagepng.cp
If one does not have gdb installed it's nicer
to simply get the error message (and some
debug messages).
Signed-off-by: Uri Lublin
---
vdagent/imagetest.cpp | 99 ++-
1 file changed, 83 insertions(+), 16 deletions(-)
diff --git a/vdagent/imagetest
vd_printf adds __FUNCTION__
Signed-off-by: Uri Lublin
---
vdagent/vdagent.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
index b71919b..f00fbf5 100644
--- a/vdagent/vdagent.cpp
+++ b/vdagent/vdagent.cpp
@@ -513,11 +513,11 @@
This patchset is extending Frediano's "Rewrite image support and other patches"
https://lists.freedesktop.org/archives/spice-devel/2017-July/038524.html
Patch 1 adds information to a clipboard log message
Patch 2 is unrelated to images
Patch 3 fixes an allocation problem [RFC]
Patch 4 changes the
On 07/06/2017 04:31 PM, Frediano Ziglio wrote:
CxImage is used for image conversion for clipboard support.
CxImage have currently some issue:
- library is old and unsupported;
- required an old libpng library.
Currently the MingW binary we distribute due to some
issue have PNG disabled (so no cli
Hi,
On Wed, Jun 14, 2017 at 11:55:54PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The spice-controller was a small library to let NPAPI browser plugins
> communicate with the spice client. Due to usage of vala, the library
> could not promise ABI stability, and was al
Signed-off-by: Victor Toso
Signed-off-by: Pavel Grunt
---
po/POTFILES.in | 13 +
src/channel-main.c | 15 ++-
src/channel-port.c | 4 +++-
src/channel-usbredir.c | 8
src/giopipe.c
On Fri, 2017-06-09 at 11:33 +0200, Christophe de Dinechin wrote:
> >
> > On 8 Jun 2017, at 23:17, Jonathon Jongsma
> > wrote:
> >
> > Calling spice_util_get_debug() from the SPICE_DEBUG() macro is
> > unnecessary since g_log() will already check whether the message
> > will
> > actually be print
On Tue, Jul 11, 2017 at 09:47:31AM +0200, Christophe Fergeau wrote:
> On Mon, Jul 10, 2017 at 05:52:07PM +0200, Victor Toso wrote:
> > From: Victor Toso
> >
> > On GST_MESSAGE_STREAM_START our stream is about to start and it seems
> > a good moment to debug GStreamer pipeline if requested.
> >
>
Hi,
On Tue, Jun 20, 2017 at 01:10:43PM +0200, Victor Toso wrote:
> From: leaboy
Although it isn't a hard requirement, it is desirable to have your real
name on commits.
AFAIK, this is the only thing lacking to have your fix upstream.
Cheers,
>
> The current code deadlocks when a USB error occ
On Mon, Jul 10, 2017 at 05:52:06PM +0200, Victor Toso wrote:
> From: Victor Toso
>
> On channel-display.c, for each SpiceVideoCodecType we need:
> - Its enum type;
> - The associated capability;
> - A name;
>
> On channel-display-gst.c, for each SpiceVideoCodecType we need:
> - Associated de
On Tue, Jul 11, 2017 at 09:47:31AM +0200, Christophe Fergeau wrote:
> On Mon, Jul 10, 2017 at 05:52:07PM +0200, Victor Toso wrote:
> > From: Victor Toso
> >
> > On GST_MESSAGE_STREAM_START our stream is about to start and it seems
> > a good moment to debug GStreamer pipeline if requested.
> >
>
This reverts commit 73cd553fb0fbd213b64d72f8b4289ed8a17fc6c0.
It may be an optimization, but it complicates turning off
the capslock once it is enabled.
https://bugs.freedesktop.org/show_bug.cgi?id=101344
---
src/channel-inputs.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff
Hi,
On Tue, Jul 11, 2017 at 09:21:53AM +0200, Pavel Grunt wrote:
> ---
> v2:
> - Use ngettext for error messages in plural
> - rebased on top of Victor's patch
Looks good
Acked-by: Victor Toso
> ---
> po/POTFILES.in | 4
> src/channel-main.c | 9 +++--
> s
On Tue, 2017-07-11 at 12:42 +0200, Victor Toso wrote:
> From: Victor Toso
>
> With SpiceFileTransferTask we suggest that Spice clients watch
> (signal) SpiceMainChannel::new-file-transfer so they can follow the
> transfer's progress till the moment it is finished.
>
> The signal SpiceFileTransfe
From: Victor Toso
With SpiceFileTransferTask we suggest that Spice clients watch
(signal) SpiceMainChannel::new-file-transfer so they can follow the
transfer's progress till the moment it is finished.
The signal SpiceFileTransferTask::finished informs if an error happens
to the application.
Thi
On Tue, Jul 11, 2017 at 11:39:57AM +0200, Pavel Grunt wrote:
> Hi,
>
> On Mon, 2017-07-03 at 15:28 +0200, Victor Toso wrote:
> > From: Victor Toso
> >
> > With SpiceFileTransferTask we suggest that Spice clients watch
> > (signal) SpiceMainChannel::new-file-transfer so it can follow the
> ... so t
Hi,
On Mon, 2017-07-03 at 15:28 +0200, Victor Toso wrote:
> From: Victor Toso
>
> With SpiceFileTransferTask we suggest that Spice clients watch
> (signal) SpiceMainChannel::new-file-transfer so it can follow the
... so they can..
> transfer's progress till the moment it is finished.
>
> On (si
From: Frediano Ziglio
Avoid VDAgentMessage::size integer overflows.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/server/reds.c b/server/reds.c
index ec2b6f475..656f518ff 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -1131,6 +1131,9
From: Frediano Ziglio
Total message size received from the client was unlimited. There is
a 2kiB size check on individual agent messages, but the MonitorsConfig
message can be split in multiple chunks, and the size of the
non-chunked MonitorsConfig message was never checked. This could easily
lea
Hey,
These 3 patches are fixing CVE-2017-7506 for which the embargo was lifted
today. One needs to have successfully established a SPICE connection (including
authentication) before this can become an issue.
Thanks to Frediano for noticing this, and working on the patches! I'll push
these shortly
From: Frediano Ziglio
It was also possible for a malicious client to set
VDAgentMonitorsConfig::num_of_monitors to a number larger
than the actual size of VDAgentMOnitorsConfig::monitors.
This would lead to buffer overflows, which could allow the guest to
read part of the host memory. This might
On Mon, Jul 10, 2017 at 05:52:07PM +0200, Victor Toso wrote:
> From: Victor Toso
>
> On GST_MESSAGE_STREAM_START our stream is about to start and it seems
> a good moment to debug GStreamer pipeline if requested.
>
> That we can do with GST_DEBUG_BIN_TO_DOT_FILE() which iterates
> recursively in
On Tue, Jul 11, 2017 at 08:27:38AM +0200, Pavel Grunt wrote:
> ---
> src/usb-device-manager.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c
> index bbe2391..dfac5a0 100644
> --- a/src/usb-device-manager.c
> +++ b/s
---
v2:
- Use ngettext for error messages in plural
- rebased on top of Victor's patch
---
po/POTFILES.in | 4
src/channel-main.c | 9 +++--
src/channel-port.c | 4 +++-
src/channel-usbredir.c | 2 +-
src/smartcard-manager.c| 5 +++
On Tue, 2017-07-11 at 08:12 +0100, André Rodier wrote:
> Hello Victor.
> Thank you for your prompt answer. I will see what we can do.
Hi,
you can use a tool `recordmydesktop` to record windows of an application. Take a
look at its man page, it has several examples of usage (you can give it an id o
Hello Victor.
Thank you for your prompt answer. I will see what we can do.
Kind regards,
André.
On 11 Jul 2017 07:22, "Victor Toso" wrote:
> Hi André,
>
> On Tue, Jul 11, 2017 at 07:12:08AM +0100, André Rodier wrote:
> > Hello everyone,
> >
> > I am using Spice on Debian Stretch, with libvirt. I
29 matches
Mail list logo
