[Spice-devel] [PATCH spice-gtk] usb-manager: Fix docstring annotation

2017-07-10 Thread Pavel Grunt
--- src/usb-device-manager.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c index bbe2391..dfac5a0 100644 --- a/src/usb-device-manager.c +++ b/src/usb-device-manager.c @@ -635,9 +635,9 @@ static void spice_usb_device_man

Re: [Spice-devel] Recording the screen output of a spice channel

2017-07-10 Thread Victor Toso
Hi André, On Tue, Jul 11, 2017 at 07:12:08AM +0100, André Rodier wrote: > Hello everyone, > > I am using Spice on Debian Stretch, with libvirt. I need to record the > screens of the virtual machines, in MPEG4. > > I wondered if there is a solution to record the screen output of a spice > channel,

Re: [Spice-devel] [spice-gtk v2] file-xfer: Error messages should always be translated

2017-07-10 Thread Pavel Grunt
On Tue, 2017-07-11 at 08:05 +0200, Pavel Grunt wrote: > On Mon, 2017-07-10 at 17:57 +0200, Victor Toso wrote: > > From: Victor Toso > > > > Signed-off-by: Victor Toso > > Acked-by: Pavel Grunt I forgot about a patch (acked) about this /o\ The comment about ngettext is still valid https://li

[Spice-devel] Recording the screen output of a spice channel

2017-07-10 Thread André Rodier
Hello everyone, I am using Spice on Debian Stretch, with libvirt. I need to record the screens of the virtual machines, in MPEG4. I wondered if there is a solution to record the screen output of a spice channel, and to convert it to MP4. I know there is already a package to transcode a VNC chann

Re: [Spice-devel] [spice-gtk v2] file-xfer: Error messages should always be translated

2017-07-10 Thread Pavel Grunt
On Mon, 2017-07-10 at 17:57 +0200, Victor Toso wrote: > From: Victor Toso > > Signed-off-by: Victor Toso Acked-by: Pavel Grunt > --- > src/channel-main.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/src/channel-main.c b/src/channel-main.c > index 4edd575

[Spice-devel] [spice-gtk v2] file-xfer: Error messages should always be translated

2017-07-10 Thread Victor Toso
From: Victor Toso Signed-off-by: Victor Toso --- src/channel-main.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/channel-main.c b/src/channel-main.c index 4edd575..68ec62e 100644 --- a/src/channel-main.c +++ b/src/channel-main.c @@ -1900,7 +1900,7 @@ static

[Spice-devel] [PATCH spice-gtk 1/2] channel-display: keep one struct array for video-codecs data

2017-07-10 Thread Victor Toso
From: Victor Toso On channel-display.c, for each SpiceVideoCodecType we need: - Its enum type; - The associated capability; - A name; On channel-display-gst.c, for each SpiceVideoCodecType we need: - Associated decoding elements for the pipeline; - Associated GstCaps, also for the video pip

[Spice-devel] [PATCH spice-gtk 2/2] display-gst: Debug video pipeline on stream-start message

2017-07-10 Thread Victor Toso
From: Victor Toso On GST_MESSAGE_STREAM_START our stream is about to start and it seems a good moment to debug GStreamer pipeline if requested. That we can do with GST_DEBUG_BIN_TO_DOT_FILE() which iterates recursively in the whole pipeline and generates a dot file with all the information, the

[Spice-devel] [PATCH spice-gtk 0/2] Debug GStreamer's pipeline

2017-07-10 Thread Victor Toso
From: Victor Toso Improved version from previous 7/7 patch from playbin series https://lists.freedesktop.org/archives/spice-devel/2017-June/038420.html Cheers, Victor Toso (2): channel-display: keep one struct array for video-codecs data display-gst: Debug video pipeline on stream-start mes

Re: [Spice-devel] [PATCH spice-gtk 1/2] file-xfer: Error messages should always be translated

2017-07-10 Thread Pavel Grunt
On Mon, 2017-07-03 at 15:28 +0200, Victor Toso wrote: > From: Victor Toso > There are more untranslated error messages in the channel-main.c related to file-xfer (search for g_error_new) > Signed-off-by: Victor Toso > --- > src/channel-main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

Re: [Spice-devel] [vdagent-win PATCH 3/7] Move image handling to a separate file

2017-07-10 Thread Pavel Grunt
On Thu, 2017-07-06 at 14:32 +0100, Frediano Ziglio wrote: > This will make easier to change code that handle images. > > Signed-off-by: Frediano Ziglio > --- > Makefile.am | 2 ++ > vdagent/image.cpp | 86 > + > vdagent/image.h |

Re: [Spice-devel] [PATCH spice-gtk v4 0/7] Always use Playbin to create the pipeline

2017-07-10 Thread Victor Toso
Hi, On Wed, Jun 28, 2017 at 02:42:57PM +0200, Victor Toso wrote: > From: Victor Toso > > -- v3->v4 > * Not many changes, the full diff from previous version is here: > https://paste.fedoraproject.org/paste/c6zbF4uDLpLsmCHAHkmULQ > > * Included a new PATCH for debugging purposes, it can genera

Re: [Spice-devel] [spice-gtk v5 6/7] display-gst: Use Playbin for GStreamer 1.9.0 onwards

2017-07-10 Thread Victor Toso
Hi, On Mon, Jul 10, 2017 at 01:47:56PM +0200, Pavel Grunt wrote: > On Fri, 2017-06-30 at 12:56 +0200, Victor Toso wrote: > > From: Victor Toso > > > > The Playbin can provide the full pipeline which reduces the > > overall maintenance in the code as we don't need to track which > > decoder can w

Re: [Spice-devel] [PATCH spice-gtk v4 5/7] display-gst: check GstRegistry for decoding elements

2017-07-10 Thread Victor Toso
Hi, On Wed, Jul 05, 2017 at 02:08:37AM +, Daimon Wang wrote: > Hi. > >G_GNUC_INTERNAL > >gboolean gstvideo_has_codec(int codec_type) > >{ > >-    gboolean has_codec = FALSE; > >+    GList *all_decoders, *codec_decoders; > >+    GstCaps *caps; > >+    GstElementFactoryListType type; > >+ > >+ 

Re: [Spice-devel] [spice-gtk v5 6/7] display-gst: Use Playbin for GStreamer 1.9.0 onwards

2017-07-10 Thread Pavel Grunt
On Fri, 2017-06-30 at 12:56 +0200, Victor Toso wrote: > From: Victor Toso > > The Playbin can provide the full pipeline which reduces the > overall maintenance in the code as we don't need to track which > decoder can work with our stream type. > > We need to maintain the GstCaps per SPICE_VIDEO

Re: [Spice-devel] [vdagent-win PATCH 2/7] Avoid log_level warning using a static const

2017-07-10 Thread Pavel Grunt
On Thu, 2017-07-06 at 14:31 +0100, Frediano Ziglio wrote: > Compiler warnings for unused static variable. > Not for constants. > > Signed-off-by: Frediano Ziglio Acked-by: Pavel Grunt > --- > common/vdlog.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/common

Re: [Spice-devel] [vdagent-win PATCH 1/7] Enable debug information build on spec file

2017-07-10 Thread Pavel Grunt
On Thu, 2017-07-06 at 14:31 +0100, Frediano Ziglio wrote: > The spec file cause the generation of debuginfo packages however > the build fails as the executables are not compiled with debugging > information. > > Signed-off-by: Frediano Ziglio Acked-by: Pavel Grunt > --- > mingw-spice-vdagent.