Re: [Spice-devel] [vdagent-win PATCH 1/4] Make some functions static

2017-07-07 Thread Christophe Fergeau
Minor nit in patch 4/4, for the series Acked-by: Christophe Fergeau On Fri, Jul 07, 2017 at 06:31:09AM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > vdservice/vdservice.cpp | 32 +--- > 1 file changed, 17 insertions(+), 15 deletions(-) > >

Re: [Spice-devel] [vdagent-win PATCH 4/4] Store agent process handle instead of using PROCESS_INFORMATION

2017-07-07 Thread Christophe Fergeau
On Fri, Jul 07, 2017 at 06:31:12AM +0100, Frediano Ziglio wrote: > @@ -695,20 +695,22 @@ bool VDService::launch_agent() > { > STARTUPINFO startup_info; > BOOL ret = FALSE; > +PROCESS_INFORMATION agent_proc_info; > > ZeroMemory(&startup_info, sizeof(startup_info)); > start

Re: [Spice-devel] [spice-common] Some steps toward quic_tmpl.c and quic_rgb_tmpl.c 'unification'

2017-07-07 Thread Christophe Fergeau
On Wed, Jul 05, 2017 at 10:27:18AM -0400, Frediano Ziglio wrote: > The problem of point 4) is that is worth but if we are not sure we are > not breaking stuff is not that great. We should have a test that test only > image compression/decompression. I now have such a test at https://cgit.freedeskt

[Spice-devel] [PATCH spice-gtk] Use designated struct initializer

2017-07-07 Thread Pavel Grunt
Silence -Wmissing-field-initializers warnings. --- imo it also makes the code more readable (especially tests/session.c) --- src/channel-display-gst.c | 3 +- src/channel-main.c| 4 +- src/channel-record.c | 16 +++-- src/spice-channel.c | 12 ++-- src/spice-gtk-session.c

Re: [Spice-devel] [spice-server] build-sys: Improve portability of appending to COMMON_CFLAGS

2017-07-07 Thread Frediano Ziglio
> > This is currently done through += in configure.ac, this commit switches > to using COMMON_CFLAGS="$COMMON_CFLAGS ..." for better portability. > > Signed-off-by: Christophe Fergeau Maybe for spice-server is not needed but does not hurt, Acked-by: Frediano Ziglio Frediano > --- > configu

Re: [Spice-devel] [spice-common v2] log: Define G_LOG_DOMAIN as early as possible

2017-07-07 Thread Frediano Ziglio
> > "log: Forbid the usage of obsolete SPICE_LOG_DOMAIN" introduced a small > regression, if G_LOG_DOMAIN is not set when glib.h is included, the > header will set it to a default value. Redefining it later in log.c is > going to cause a compile-time warning. > This commit adds the definition to S

Re: [Spice-devel] [PATCH v2 3/4] qxl-wddm-dod: Support ETW for release version

2017-07-07 Thread Frediano Ziglio
> > Add ability to produce ETW (Event Tracing for Windows) to release > version of the driver to be able to record binary traces in case > of problem in customer environment for further analysis. > Logging of debug build is not changed. > Why you decided to not change debug build? Frediano > S

Re: [Spice-devel] [PATCH v2 4/4] qxl-wddm-dod: Add scripts for ETW recording and parsing

2017-07-07 Thread Frediano Ziglio
> > QxlDodCollectTrace.bat intended for recording of binary traces > in end-user environment (end-user runs it when instructed). > It uses built-in Windows ability of collecting ETW data. > QxlDodParseTrace.bat is to be used by developer to convert > received binary traces to formatted text. > >

Re: [Spice-devel] [PATCH v2 4/4] qxl-wddm-dod: Add scripts for ETW recording and parsing

2017-07-07 Thread Christophe Fergeau
On Thu, Jul 06, 2017 at 01:22:58AM +0300, Yuri Benditovich wrote: > QxlDodCollectTrace.bat intended for recording of binary traces > in end-user environment (end-user runs it when instructed). > It uses built-in Windows ability of collecting ETW data. > QxlDodParseTrace.bat is to be used by develop

[Spice-devel] [spice-server] build-sys: Improve portability of appending to COMMON_CFLAGS

2017-07-07 Thread Christophe Fergeau
This is currently done through += in configure.ac, this commit switches to using COMMON_CFLAGS="$COMMON_CFLAGS ..." for better portability. Signed-off-by: Christophe Fergeau --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 9eb

[Spice-devel] [spice-common v2] log: Define G_LOG_DOMAIN as early as possible

2017-07-07 Thread Christophe Fergeau
"log: Forbid the usage of obsolete SPICE_LOG_DOMAIN" introduced a small regression, if G_LOG_DOMAIN is not set when glib.h is included, the header will set it to a default value. Redefining it later in log.c is going to cause a compile-time warning. This commit adds the definition to SPICE_COMMON_C

Re: [Spice-devel] [spice-common] log: Define G_LOG_DOMAIN as early as possible

2017-07-07 Thread Christophe Fergeau
On Fri, Jul 07, 2017 at 06:07:33AM -0400, Frediano Ziglio wrote: > > > > > "log: Forbid the usage of obsolete SPICE_LOG_DOMAIN" introduced a small > > regression, if G_LOG_DOMAIN is not set when glib.h is included, the > > header will set it to a default value. Redefining it later in log.c is > >

Re: [Spice-devel] [spice-common] log: Define G_LOG_DOMAIN as early as possible

2017-07-07 Thread Frediano Ziglio
> > "log: Forbid the usage of obsolete SPICE_LOG_DOMAIN" introduced a small > regression, if G_LOG_DOMAIN is not set when glib.h is included, the > header will set it to a default value. Redefining it later in log.c is > going to cause a compile-time warning. > This commit adds the definition to

[Spice-devel] [RFC spice-vdagent_win] Add initial seamless mode support

2017-07-07 Thread Jakub Janků
--- Demo: https://youtu.be/IX49z8VbD-c VDAgent: https://github.com/jjanku/win32-vd_agent/tree/seamless-mode Protocol: https://gitlab.com/xerus/spice-protocol/tree/seamless-mode Gtk: https://github.com/jjanku/spice-gtk/tree/seamless-mode This patch adds very basic implementation of seamless mode f

[Spice-devel] [spice-common] log: Define G_LOG_DOMAIN as early as possible

2017-07-07 Thread Christophe Fergeau
"log: Forbid the usage of obsolete SPICE_LOG_DOMAIN" introduced a small regression, if G_LOG_DOMAIN is not set when glib.h is included, the header will set it to a default value. Redefining it later in log.c is going to cause a compile-time warning. This commit adds the definition to SPICE_COMMON_C

Re: [Spice-devel] [vdagent-win PATCH] Update project URL

2017-07-07 Thread Pavel Grunt
On Fri, 2017-07-07 at 09:16 +0100, Frediano Ziglio wrote: > Uses secure version https://www.spice-space.org. > Avoid not secure and use same full name. > > Signed-off-by: Frediano Ziglio Acked-by: Pavel Grunt > --- > mingw-spice-vdagent.spec.in | 2 +- > spice-vdagent.wxs.in| 2 +- > 2

[Spice-devel] [vdagent-win PATCH v2] RFC: Add test for PNG files

2017-07-07 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- Makefile.am | 20 + test-png | 41 +++ vdagent/imagetest.cpp | 78 +++ 3 files changed, 139 insertions(+) create mode 100755 test-png create mode 100644

[Spice-devel] [vdagent-win PATCH] Update project URL

2017-07-07 Thread Frediano Ziglio
Uses secure version https://www.spice-space.org. Avoid not secure and use same full name. Signed-off-by: Frediano Ziglio --- mingw-spice-vdagent.spec.in | 2 +- spice-vdagent.wxs.in| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mingw-spice-vdagent.spec.in b/mingw-