Re: [Spice-devel] [PATCH] Replace HAVE_X11_XKBLIB_H with GDK_WINDOWING_X11

2017-07-06 Thread Pavel Grunt
On Thu, 2017-07-06 at 18:42 +0200, Daniel Albers wrote: > Thanks, Pavel. > I thought I had checked this against git master, but I missed entirely > that https://github.com/SPICE/spice-gtk is actually stale since Apr '16. unfortunately the github mirror is unmaintained. You can find the original

Re: [Spice-devel] [PATCH] Replace HAVE_X11_XKBLIB_H with GDK_WINDOWING_X11

2017-07-06 Thread Daniel Albers
Thanks, Pavel. I thought I had checked this against git master, but I missed entirely that https://github.com/SPICE/spice-gtk is actually stale since Apr '16. Cheers, Daniel On 2017-07-06 18:17, Pavel Grunt wrote: Hi Daniel, it's been already fixed in the spice-gtk git master: https://cgit.

[Spice-devel] Recording the screen output of a spice channel

2017-07-06 Thread André Rodier
Hello everyone, I wondered if there is a solution to record the screen output of a spice channel, and to convert it to MP4. Kind regards, André ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo

[Spice-devel] [vdagent-win PATCH 1/4] Make some functions static

2017-07-06 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- vdservice/vdservice.cpp | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index dc49ec5..e9bf1a2 100644 --- a/vdservice/vdservice.cpp +++ b/vdservice/vdservice

[Spice-devel] [vdagent-win PATCH 2/4] Close agent thread handle

2017-07-06 Thread Frediano Ziglio
This is not needed so we can close it Signed-off-by: Frediano Ziglio --- vdservice/vdservice.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index e9bf1a2..3de8111 100644 --- a/vdservice/vdservice.cpp +++ b/vdservice/vds

[Spice-devel] [vdagent-win PATCH 3/4] Use process handle to mark agent existence

2017-07-06 Thread Frediano Ziglio
Avoid extra field that could be out of sync. Having a valid process handle is enough. Signed-off-by: Frediano Ziglio --- vdservice/vdservice.cpp | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index 3de8111..5caed39 1

[Spice-devel] [vdagent-win PATCH 4/4] Store agent process handle instead of using PROCESS_INFORMATION

2017-07-06 Thread Frediano Ziglio
We just need the handle of the process. Signed-off-by: Frediano Ziglio --- vdservice/vdservice.cpp | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index 5caed39..0d358c2 100644 --- a/vdservice/v

Re: [Spice-devel] [PATCH] Replace HAVE_X11_XKBLIB_H with GDK_WINDOWING_X11

2017-07-06 Thread Pavel Grunt
Hi Daniel, it's been already fixed in the spice-gtk git master: https://cgit.freedesktop.org/spice/spice-gtk/commit/?id=a7381b0864b7e6b15e6d08f6 8e53bf3a429ab4ed Any feedback regarding issues on non X11 system is welcome. Thanks, Pavel On Thu, 2017-07-06 at 17:35 +0200, Daniel Albers wrote: > N

[Spice-devel] [PATCH] Replace HAVE_X11_XKBLIB_H with GDK_WINDOWING_X11

2017-07-06 Thread Daniel Albers
Not all systems with an XKBlib.h also have a GDK with X11 support. macOS can e.g. have HAVE_X11_XKBLIB_H without GDK_WINDOWING_X11, but GDK_WINDOWING_QUARTZ instead. --- Alternatively HAVE_GDK_GDK_X could be checked, but spice-gtk already depends on GDK_WINDOWING_X11 in other places. src/spice-gt

[Spice-devel] [vdagent-win PATCH v2 4/7] Initial rewrite of image conversion code

2017-07-06 Thread Frediano Ziglio
Remove CxImage linking. Support Windows BMP format. Signed-off-by: Frediano Ziglio --- Makefile.am | 4 +- configure.ac| 4 +- mingw-spice-vdagent.spec.in | 2 - vdagent/image.cpp | 182 ++-- vdagent/image.h

[Spice-devel] [vdagent-win PATCH 5/7] Write code to decode PNG format

2017-07-06 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- Makefile.am | 6 +- configure.ac | 3 + vdagent/image.cpp| 8 +- vdagent/imagepng.cpp | 244 +++ vdagent/imagepng.h | 25 ++ 5 files changed, 277 insertions(+), 9 deletions(-) cre

[Spice-devel] [vdagent-win RFC PATCH 7/7] RFC: Add test for PNG files

2017-07-06 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- Makefile.am | 17 ++- vdagent/imagetest.cpp | 78 +++ 2 files changed, 94 insertions(+), 1 deletion(-) create mode 100644 vdagent/imagetest.cpp diff --git a/Makefile.am b/Makefile.am index 175d8

[Spice-devel] [vdagent-win PATCH 6/7] Support encoding PNG images

2017-07-06 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- vdagent/imagepng.cpp | 133 --- 1 file changed, 127 insertions(+), 6 deletions(-) diff --git a/vdagent/imagepng.cpp b/vdagent/imagepng.cpp index 8f8203b..7108675 100644 --- a/vdagent/imagepng.cpp +++ b/vdagent/ima

[Spice-devel] [vdagent-win PATCH 4/7] Initial rewrite of image conversion code

2017-07-06 Thread Frediano Ziglio
Remove CxImage linking. Support Windows BMP format. Signed-off-by: Frediano Ziglio --- Makefile.am | 4 +- configure.ac | 3 - vdagent/image.cpp | 182 ++ vdagent/image.h | 13 4 files changed, 158 insertions(+), 44 delet

[Spice-devel] [vdagent-win PATCH 0/7] Rewrite image support and other patches

2017-07-06 Thread Frediano Ziglio
CxImage is used for image conversion for clipboard support. CxImage have currently some issue: - library is old and unsupported; - required an old libpng library. Currently the MingW binary we distribute due to some issue have PNG disabled (so no clipboard image support). Note that currently we sup

[Spice-devel] [vdagent-win PATCH 1/7] Enable debug information build on spec file

2017-07-06 Thread Frediano Ziglio
The spec file cause the generation of debuginfo packages however the build fails as the executables are not compiled with debugging information. Signed-off-by: Frediano Ziglio --- mingw-spice-vdagent.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mingw-spice-vdagent.

[Spice-devel] [vdagent-win PATCH 2/7] Avoid log_level warning using a static const

2017-07-06 Thread Frediano Ziglio
Compiler warnings for unused static variable. Not for constants. Signed-off-by: Frediano Ziglio --- common/vdlog.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/common/vdlog.h b/common/vdlog.h index 6d0413b..e645409 100644 --- a/common/vdlog.h +++ b/common/vdlog.h @

[Spice-devel] [vdagent-win PATCH 3/7] Move image handling to a separate file

2017-07-06 Thread Frediano Ziglio
This will make easier to change code that handle images. Signed-off-by: Frediano Ziglio --- Makefile.am | 2 ++ vdagent/image.cpp | 86 + vdagent/image.h | 46 vdagent/vdagent.cpp | 57 +--

Re: [Spice-devel] [spice-common] Some steps toward quic_tmpl.c and quic_rgb_tmpl.c 'unification'

2017-07-06 Thread Christophe Fergeau
Hey, On Wed, Jul 05, 2017 at 10:27:18AM -0400, Frediano Ziglio wrote: > > The main difference is that the former implementation handles a single > > channel, > > while the rgb implementation handles each color component separately. > > Besides > > that, > > the implementation is the same, but thi