[Spice-devel] [PATCH spice-gtk v2] win-usb-dev: fix device arrival event logic

2017-07-04 Thread Yuri Benditovich
https://bugzilla.redhat.com/show_bug.cgi?id=1425961 If attached new device when one device with the same vid and pid already present, the notification is ignored and attached device is not redirected (if auto share set) and not displayed in USB devices widget. This commit reverts older commit f963

Re: [Spice-devel] [PATCH spice-gtk v4 5/7] display-gst: check GstRegistry for decoding elements

2017-07-04 Thread Daimon Wang
Hi. >G_GNUC_INTERNAL >gboolean gstvideo_has_codec(int codec_type) >{ >-    gboolean has_codec = FALSE; >+    GList *all_decoders, *codec_decoders; >+    GstCaps *caps; >+    GstElementFactoryListType type; >+ >+    g_return_val_if_fail(gstvideo_init(), FALSE); >+    g_return_val_if_fail(VALID_VIDE

Re: [Spice-devel] [PATCH spice-common v3 2/2] log: Force format in log macro to be a string

2017-07-04 Thread Christophe Fergeau
On Tue, Jul 04, 2017 at 10:18:52AM +0100, Frediano Ziglio wrote: > Make sure format is a string and not a pointer. > This prevents usages like: > > spice_debug(NULL); > > This also prevents computed format strings too but on the other > hand allows the compiler to check argument types. This is

Re: [Spice-devel] [PATCH spice-common v3 1/2] log: Forbid the usage of obsolete SPICE_LOG_DOMAIN

2017-07-04 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Tue, Jul 04, 2017 at 10:18:51AM +0100, Frediano Ziglio wrote: > As we decided to not use multiple GLib domains, the SPICE_LOG_DOMAIN > macro is not really useful. This commit removes it. > Will be replaced by some different categorization. > > Signed-off-by: Fred

Re: [Spice-devel] [PATCH spice-gtk v4 5/7] display-gst: check GstRegistry for decoding elements

2017-07-04 Thread Victor Toso
Hi, On Tue, Jul 04, 2017 at 11:50:12AM +0200, Pavel Grunt wrote: > On Wed, 2017-06-28 at 14:43 +0200, Victor Toso wrote: > > From: Victor Toso > > > > With this patch, we can find all the elements in the registry that are > > video decoders which can handle the predefined GstCaps. > > > > Main

Re: [Spice-devel] [PATCH spice-gtk v4 5/7] display-gst: check GstRegistry for decoding elements

2017-07-04 Thread Pavel Grunt
On Wed, 2017-06-28 at 14:43 +0200, Victor Toso wrote: > From: Victor Toso > > With this patch, we can find all the elements in the registry that are > video decoders which can handle the predefined GstCaps. > > Main benefits are: > - We don't rely on a predefined list of GstElements. We don't ne

[Spice-devel] [PATCH spice-common v3 2/2] log: Force format in log macro to be a string

2017-07-04 Thread Frediano Ziglio
Make sure format is a string and not a pointer. This prevents usages like: spice_debug(NULL); This also prevents computed format strings too but on the other hand allows the compiler to check argument types. Signed-off-by: Frediano Ziglio --- Changes since v1: - extent commit message rational

[Spice-devel] [PATCH spice-common v3 1/2] log: Forbid the usage of obsolete SPICE_LOG_DOMAIN

2017-07-04 Thread Frediano Ziglio
As we decided to not use multiple GLib domains, the SPICE_LOG_DOMAIN macro is not really useful. This commit removes it. Will be replaced by some different categorization. Signed-off-by: Frediano Ziglio --- Changes since v2: - changed commit message. Changes since v1: - do not use SPICE_LOG_DOMA

Re: [Spice-devel] [PATCH 2/4] qxl-wddm-dod: add trace definition file for WPP

2017-07-04 Thread Frediano Ziglio
> On Mon, Jul 3, 2017 at 5:44 PM, Frediano Ziglio < fzig...@redhat.com > wrote: > > > > > > > Added file with Windows trace preprocessor definitions > > > > > > > > Signed-off-by: Yuri Benditovich < yuri.benditov...@daynix.com > > > > > --- > > > > qxldod/WppTrace.h | 51 > >

Re: [Spice-devel] [PATCH spice-common] quic: Fix typo in function names

2017-07-04 Thread Christophe Fergeau
On Tue, Jul 04, 2017 at 08:56:36AM +0100, Frediano Ziglio wrote: > reste -> reset Spotted the "reste" word, but was unable to figure out what this was meant to be /o\ Acked-by: Christophe Fergeau > > Signed-off-by: Frediano Ziglio > --- > common/quic.c | 12 ++-- > 1 file changed, 6

[Spice-devel] [PATCH spice-common] quic: Fix typo in function names

2017-07-04 Thread Frediano Ziglio
reste -> reset Signed-off-by: Frediano Ziglio --- common/quic.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/common/quic.c b/common/quic.c index d22a9b7..c188ed2 100644 --- a/common/quic.c +++ b/common/quic.c @@ -1061,7 +1061,7 @@ static int init_encoder(Encod

Re: [Spice-devel] [spice-common 2/2] quic: Use upper-case for 'evol' constant name

2017-07-04 Thread Frediano Ziglio
> > On Tue, Jul 04, 2017 at 01:02:39AM -0400, Frediano Ziglio wrote: > > > > > > Constants, especially when defined using #define usually use upper-case > > > naming. > > > > However this is not coherent with wmimax and wmiext. > > Maybe changing all? > > That would mean changing the various ar

Re: [Spice-devel] [spice-common 2/2] quic: Use upper-case for 'evol' constant name

2017-07-04 Thread Christophe Fergeau
On Tue, Jul 04, 2017 at 01:02:39AM -0400, Frediano Ziglio wrote: > > > > Constants, especially when defined using #define usually use upper-case > > naming. > > However this is not coherent with wmimax and wmiext. > Maybe changing all? That would mean changing the various arrays of constants too