On Wed, Jun 21, 2017 at 01:30:09PM +0100, Frediano Ziglio wrote:
> Make sure format is a string and not a pointer.
Having a rationale in the commit log would be useful ("Why do we want to
forbid that?") (I think the goal is to catch spice_debug(NULL)).
This breaks (arguably corner cases) usecases
On Wed, Jun 21, 2017 at 01:30:08PM +0100, Frediano Ziglio wrote:
> As we decided to not use GLib domains do not allow the usage of
I'd change the log to something like
"As we decided to not use multiple GLib domains, the SPICE_LOG_DOMAIN
macro is not really useful. This commit removes it"
Apart
On Thu, Jun 29, 2017 at 12:38:36PM +0200, Pavel Grunt wrote:
> Signed-off-by: Pavel Grunt
> ---
> src/spice-channel.c | 41 +
> 1 file changed, 25 insertions(+), 16 deletions(-)
>
> diff --git a/src/spice-channel.c b/src/spice-channel.c
> index b8cf19c..24
On Thu, Jun 29, 2017 at 12:38:35PM +0200, Pavel Grunt wrote:
> The commit babe5630d5d3242b1d186cccdd5b4d51debe78e9 forgot to update
> position of the caps pointer making remote caps to not be stored.
>
> That cause strange behavior in remote-viewer - it always opened window
> for each remote displ
For the series
Acked-by: Christophe Fergeau
On Thu, Jun 29, 2017 at 05:44:02PM +0200, Victor Toso wrote:
> From: Victor Toso
>
> Not sure if by design we want to get rid of all access to private structure of
> display-channel outside display-channel.c, see:
>
> $ grepi "display->priv" server
From: Victor Toso
To help avoid stream.c and dcc.c to access display-channel private
structure to get the nth Stream structure pointer.
Signed-off-by: Victor Toso
---
server/dcc.c | 2 +-
server/display-channel.c | 5 +
server/display-channel.h | 1 +
server/stream.c |
From: Victor Toso
Not sure if by design we want to get rid of all access to private structure of
display-channel outside display-channel.c, see:
$ grepi "display->priv" server/ | grep -v "display-channel\.c"
server/dcc.c:308:surface = &display->priv->surfaces[surface_id];
server/dcc.c:325:
From: Victor Toso
As we have a function for that, don't do the math elsewhere.
Signed-off-by: Victor Toso
---
server/stream.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/stream.c b/server/stream.c
index 838c6436..9a3a82d1 100644
--- a/server/stream.c
+++ b/server
Hi,
On Thu, Jun 29, 2017 at 04:35:30PM +0200, Christophe Fergeau wrote:
> On Thu, Jun 29, 2017 at 01:58:07PM +0200, Victor Toso wrote:
> > Hi,
> >
> > On Thu, Jun 29, 2017 at 10:59:16AM +0200, Pavel Grunt wrote:
> > > On Wed, 2017-06-28 at 14:43 +0200, Victor Toso wrote:
> > > > From: Victor Toso
On Thu, Jun 29, 2017 at 01:58:07PM +0200, Victor Toso wrote:
> Hi,
>
> On Thu, Jun 29, 2017 at 10:59:16AM +0200, Pavel Grunt wrote:
> > On Wed, 2017-06-28 at 14:43 +0200, Victor Toso wrote:
> > > From: Victor Toso
> > >
> > > The Playbin can provide the full pipeline which reduces the
> > > over
Hi,
On Thu, Jun 29, 2017 at 11:47:53AM +0200, Pavel Grunt wrote:
> On Wed, 2017-06-28 at 14:43 +0200, Victor Toso wrote:
> > From: Victor Toso
> >
> > On GST_MESSAGE_STREAM_START our stream is about to start and it
> > seems
> > a good moment to debug GStreamer pipeline if requested.
> >
> So thi
Hi,
On Thu, Jun 29, 2017 at 10:59:16AM +0200, Pavel Grunt wrote:
> On Wed, 2017-06-28 at 14:43 +0200, Victor Toso wrote:
> > From: Victor Toso
> >
> > The Playbin can provide the full pipeline which reduces the
> > overall maintenance in the code as we don't need to track which
> > decoder can w
The commit babe5630d5d3242b1d186cccdd5b4d51debe78e9 forgot to update
position of the caps pointer making remote caps to not be stored.
That cause strange behavior in remote-viewer - it always opened window
for each remote display.
Signed-off-by: Victor Toso
Signed-off-by: Pavel Grunt
---
the li
Signed-off-by: Pavel Grunt
---
src/spice-channel.c | 41 +
1 file changed, 25 insertions(+), 16 deletions(-)
diff --git a/src/spice-channel.c b/src/spice-channel.c
index b8cf19c..2422811 100644
--- a/src/spice-channel.c
+++ b/src/spice-channel.c
@@ -1884,1
On Wed, 2017-06-28 at 14:43 +0200, Victor Toso wrote:
> From: Victor Toso
>
> On GST_MESSAGE_STREAM_START our stream is about to start and it
> seems
> a good moment to debug GStreamer pipeline if requested.
>
So this is just for the debug purpose.
> That we can do with GST_DEBUG_BIN_TO_DOT_FI
On Wed, 2017-06-28 at 14:43 +0200, Victor Toso wrote:
> From: Victor Toso
>
> The Playbin can provide the full pipeline which reduces the
> overall maintenance in the code as we don't need to track which
> decoder can work with our stream type.
>
> We need to maintain the GstCaps per SPICE_VIDEO
On Wed, 2017-06-28 at 14:42 +0200, Victor Toso wrote:
> From: Victor Toso
>
> Inserting this check in channel-display-gst.c as the GStreamer
> decoder
> is the only one handling all the different video formats supported
> by
> spice-protocol.
>
> If a unsupported/bad codec type value was sent, s
17 matches
Mail list logo
