Re: [Spice-devel] [PATCH spice-gtk v2 1/2] usb-device-widget: Fix parent class type

2017-06-26 Thread Frediano Ziglio
> > The widget is defined as GTK_TYPE_BOX, use GtkBox instead of GtkVBox. Acked Really, no binary changes: $ strip src/.libs/usb-device-widget.o && md5sum src/.libs/usb-device-widget.o 071e9dfca20beb638cbc558b8051850d src/.libs/usb-device-widget.o $ git checkout -- src/usb-device-widget.c $ ma

Re: [Spice-devel] [PATCH spice-gtk v2 1/2] usb-device-widget: Fix parent class type

2017-06-26 Thread Pavel Grunt
On Mon, 2017-06-26 at 06:18 -0400, Frediano Ziglio wrote: > > > > The widget is defined as GTK_TYPE_BOX, use GtkBox instead of > > GtkVBox. > > Shouldn't you set the orientation to vertical too? I think the > default > is horizontal. the object is created with the vertical orientation, see the d

Re: [Spice-devel] [PATCH spice-gtk v2 1/2] usb-device-widget: Fix parent class type

2017-06-26 Thread Frediano Ziglio
> > The widget is defined as GTK_TYPE_BOX, use GtkBox instead of GtkVBox. Shouldn't you set the orientation to vertical too? I think the default is horizontal. Not that I think something would change, there are no reference to GtkVBox, only GtkBox so this seems more of a fix to me. > --- > src/

Re: [Spice-devel] [PATCH spice-gtk] usb-device-widget: Migrate to GtkContainer api

2017-06-26 Thread Pavel Grunt
On Mon, 2017-06-26 at 06:08 -0400, Frediano Ziglio wrote: > > > > Hi, > > > > On Fri, 2017-06-23 at 11:35 -0400, Frediano Ziglio wrote: > > > > > > > > GtkVBox is deprecated since Gtk 3.2, GtkBox is going to be > > > > deprecated. Switch to GtkContainer api if possible. > > > > --- > > > > src/

[Spice-devel] [PATCH spice-gtk v2 1/2] usb-device-widget: Fix parent class type

2017-06-26 Thread Pavel Grunt
The widget is defined as GTK_TYPE_BOX, use GtkBox instead of GtkVBox. --- src/usb-device-widget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/usb-device-widget.c b/src/usb-device-widget.c index b394499..747887c 100644 --- a/src/usb-device-widget.c +++ b/src/usb-devi

[Spice-devel] [PATCH spice-gtk v2 2/2] usb-device-widget: Migrate to GtkContainer api

2017-06-26 Thread Pavel Grunt
It is enough for us. Also GtkBox api has changed recently in gtk master. --- src/usb-device-widget.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/usb-device-widget.c b/src/usb-device-widget.c index 747887c..e87bdff 100644 --- a/src/usb-device-widget.c +++ b/s

Re: [Spice-devel] [PATCH spice-gtk] usb-device-widget: Migrate to GtkContainer api

2017-06-26 Thread Frediano Ziglio
> > Hi, > > On Fri, 2017-06-23 at 11:35 -0400, Frediano Ziglio wrote: > > > > > > GtkVBox is deprecated since Gtk 3.2, GtkBox is going to be > > > deprecated. Switch to GtkContainer api if possible. > > > --- > > > src/usb-device-widget.c | 15 --- > > > 1 file changed, 8 insertions

Re: [Spice-devel] [PATCH spice-gtk] usb-device-widget: Migrate to GtkContainer api

2017-06-26 Thread Pavel Grunt
Hi, On Fri, 2017-06-23 at 11:35 -0400, Frediano Ziglio wrote: > > > > GtkVBox is deprecated since Gtk 3.2, GtkBox is going to be > > deprecated. Switch to GtkContainer api if possible. > > --- > > src/usb-device-widget.c | 15 --- > > 1 file changed, 8 insertions(+), 7 deletions(-) >

Re: [Spice-devel] SSL-problem occurs with Spice-glib on Arch linux (when connecting from Proxmox)

2017-06-26 Thread Pavel Grunt
Hello, On Sun, 2017-06-25 at 01:15 +0200, AmigAsger wrote: > Dear Spice-Devel, > > I have been investigating an SSL-issue, which all of a sudden > occured on my Arch Linux distribution (when connecting to my proxmox > virtualization center). > > Something seems to break from spice-glib-0.33-3-x8

Re: [Spice-devel] [PATCH spice-gtk] usb-device-widget: Remove deprecated GTK_MISC

2017-06-26 Thread Pavel Grunt
On Fri, 2017-06-23 at 11:39 -0400, Frediano Ziglio wrote: > > > > --- > > src/usb-device-widget.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/usb-device-widget.c b/src/usb-device-widget.c > > index e87bdff..2d07468 100644 > > --- a/src/usb-device-widget.c >