Re: [Spice-devel] [PATCH spice-gtk] RFC: build-sys: remove the spice-controller library

2017-06-22 Thread Jeremy White
> > I think we should try to solve this at the virt-viewer level, and move > the > discussion to virt-tools list. > >>> >>> I guess a DBus interface could work equally well in this case? >>> >> >> I'm not enough of an expert in DBus to say for sure, but I don't think >> so. One

Re: [Spice-devel] [PATCH server] tests: Initialize all members of SpiceBaseInterface struct

2017-06-22 Thread Michal Privoznik
On 06/22/2017 05:20 PM, Frediano Ziglio wrote: >> >> When compiling, -Werror=missing-field-initializers is enabled. >> However, gcc fails to see that all the members of the >> SpiceBaseInterface struct are initialized: >> >> test-display-base.c:844:5: error: missing initializer for field >> 'descri

Re: [Spice-devel] [PATCH server] tests: Initialize all members of SpiceBaseInterface struct

2017-06-22 Thread Frediano Ziglio
> > When compiling, -Werror=missing-field-initializers is enabled. > However, gcc fails to see that all the members of the > SpiceBaseInterface struct are initialized: > > test-display-base.c:844:5: error: missing initializer for field > 'description' of 'SpiceBaseInterface' > [-Werror=missing-fi

[Spice-devel] [PATCH server] tests: Initialize all members of SpiceBaseInterface struct

2017-06-22 Thread Michal Privoznik
When compiling, -Werror=missing-field-initializers is enabled. However, gcc fails to see that all the members of the SpiceBaseInterface struct are initialized: test-display-base.c:844:5: error: missing initializer for field 'description' of 'SpiceBaseInterface' [-Werror=missing-field-initializers]

Re: [Spice-devel] [PATCH spice-server 1/2] gl: fix client mouse mode

2017-06-22 Thread Victor Toso
Hi, On Thu, Jun 22, 2017 at 04:00:47PM +0200, Victor Toso wrote: > Hi, > > On Thu, Jun 22, 2017 at 06:20:24AM -0400, Frediano Ziglio wrote: > > > > > > Hi, > > > > > > On Tue, Jun 13, 2017 at 05:18:41AM -0400, Marc-André Lureau wrote: > > > > > > - Original Message - > > > > > > > Since

Re: [Spice-devel] [PATCH spice-server 1/2] gl: fix client mouse mode

2017-06-22 Thread Victor Toso
Hi, On Thu, Jun 22, 2017 at 06:20:24AM -0400, Frediano Ziglio wrote: > > > > Hi, > > > > On Tue, Jun 13, 2017 at 05:18:41AM -0400, Marc-André Lureau wrote: > > > > > - Original Message - > > > > > > Since 2.8, QEMU now longer creates QXL primary surfaces when > > > > > > using GL. This

Re: [Spice-devel] [PATCH spice-html5 1/4] spiceconn: Add function to test channel capabilities

2017-06-22 Thread Uri Lublin
On 06/08/2017 05:27 PM, Pavel Grunt wrote: From: Tomáš Bohdálek This will be used in other commits. --- spiceconn.js | 19 +++ 1 file changed, 19 insertions(+) diff --git a/spiceconn.js b/spiceconn.js index 33e7388..d76f8e2 100644 --- a/spiceconn.js +++ b/spiceconn.js @@ -24

[Spice-devel] [PATCH spice-html5 v2 4/4] Display: Add support for the VP9 codec type

2017-06-22 Thread Pavel Grunt
From: Tomáš Bohdálek --- v2: Be consistent with '=='/'===' in the expressions --- display.js | 26 -- spiceconn.js | 2 ++ webm.js | 12 ++-- 3 files changed, 32 insertions(+), 8 deletions(-) diff --git a/display.js b/display.js index 0868f91..abd5b1a 100

Re: [Spice-devel] [PATCH] download: Add x11spice

2017-06-22 Thread Uri Lublin
On 06/22/2017 09:22 AM, Snir Sheriber wrote: On 06/22/2017 12:38 AM, Jeremy White wrote: Alright, it's up on gitlab now: https://gitlab.com/spice/x11spice Looks like there isn't any obvious way for me to ask to edit the pages; I was going to point to this link as a release file: https:

Re: [Spice-devel] [PATCH spice-gtk v3] main: Handle file-xfer detailed errors

2017-06-22 Thread Pavel Grunt
On Tue, 2017-06-06 at 23:23 +0200, Jakub Janků wrote: > Log appropriate error messages when we receive > VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED, > VD_AGENT_FILE_XFER_STATUS_VDAGENT_NOT_CONNECTED, > VD_AGENT_FILE_XFER_STATUS_DISABLED. Acked-by: Pavel Grunt Thanks, Pavel > --- > src/channel-mai

Re: [Spice-devel] [PATCH] download: Add x11spice

2017-06-22 Thread Pavel Grunt
On Thu, 2017-06-22 at 09:22 +0300, Snir Sheriber wrote: > > On 06/22/2017 12:38 AM, Jeremy White wrote: > > > > Alright, it's up on gitlab now: > > > >https://gitlab.com/spice/x11spice > > > > > > > > Looks like there isn't any obvious way for me to ask to edit > > > > the > > > > pages; I wa

Re: [Spice-devel] [PATCH spice-server 1/2] gl: fix client mouse mode

2017-06-22 Thread Frediano Ziglio
> > Hi, > > On Tue, Jun 13, 2017 at 05:18:41AM -0400, Marc-André Lureau wrote: > > > > - Original Message - > > > > > Since 2.8, QEMU now longer creates QXL primary surfaces when > > > > > using GL. This change broke client-side mouse mode, because > > > > > Spice server relies on primar

Re: [Spice-devel] [PATCH spice-server 1/2] gl: fix client mouse mode

2017-06-22 Thread Victor Toso
Hi, On Tue, Jun 13, 2017 at 05:18:41AM -0400, Marc-André Lureau wrote: > > > - Original Message - > > > > Since 2.8, QEMU now longer creates QXL primary surfaces when > > > > using GL. This change broke client-side mouse mode, because > > > > Spice server relies on primary surface conditi