Re: [Spice-devel] [PATCH spice-gtk] RFC: build-sys: remove the spice-controller library

2017-06-19 Thread Jeremy White
On 06/14/2017 03:46 PM, Marc-André Lureau wrote: > Hi Jeremy > > - Original Message - >> On 06/14/2017 02:55 PM, marcandre.lur...@redhat.com wrote: >>> From: Marc-André Lureau >>> >>> The spice-controller was a small library to let NPAPI browser plugins >>> communicate with the spice clie

[Spice-devel] [PATCH spice-server v4] gitignore: Reduce html files exclusion

2017-06-19 Thread Frediano Ziglio
Limit html files ignored only to autogenerated ones. Can happen that you are working on some html files on your main spice-server directory and it's not desirable to ignore them. For instance this can happen if you download a patch from patchwork. Signed-off-by: Frediano Ziglio --- .gitignore |

Re: [Spice-devel] [PATCH spice-server v2] gitignore: Reduce html files exclusion

2017-06-19 Thread Uri Lublin
On 06/19/2017 01:28 PM, Frediano Ziglio wrote: On 06/19/2017 09:40 AM, Pavel Grunt wrote: Hi, On Sun, 2017-06-18 at 05:06 -0400, Frediano Ziglio wrote: ping no reply to Uri's questions? Specifically, it's not clear why not ignore all .html files. Because html files are common and you w

Re: [Spice-devel] [PATCH spice-gtk] Allow to build without X11 gdk backend

2017-06-19 Thread Marc-André Lureau
- Original Message - > On Mon, 2017-06-19 at 10:06 -0400, Frediano Ziglio wrote: > > Question: can GDK have no X11? > chances are low but there may be a distro shipping gtk without the x11 > backend > > > I suppose only wayland compiled in? > or win32 or quartz (macOS). > > The issue I

Re: [Spice-devel] [PATCH spice-gtk v2] Unrealize egl display only if it has context

2017-06-19 Thread Marc-André Lureau
ack - Original Message - > Avoids a critical to be logged when closing remote-viewer: > "gl_make_current: assertion 'd->egl.context_ready' failed" > --- > src/spice-widget.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/spice-widget.c b/src/spice-widget.

[Spice-devel] [PATCH spice-gtk v2] Unrealize egl display only if it has context

2017-06-19 Thread Pavel Grunt
Avoids a critical to be logged when closing remote-viewer: "gl_make_current: assertion 'd->egl.context_ready' failed" --- src/spice-widget.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index 139510d..c335083 100644 --- a/src/spice-

Re: [Spice-devel] [PATCH spice-gtk] Allow to build without X11 gdk backend

2017-06-19 Thread Pavel Grunt
On Mon, 2017-06-19 at 10:06 -0400, Frediano Ziglio wrote: > Question: can GDK have no X11? chances are low but there may be a distro shipping gtk without the x11 backend > I suppose only wayland compiled in? or win32 or quartz (macOS). The issue I noticed was in egl - which can work with wayland

Re: [Spice-devel] [PATCH spice-gtk] Allow to build without X11 gdk backend

2017-06-19 Thread Pavel Grunt
Hi, On Mon, 2017-06-19 at 10:05 -0400, Marc-André Lureau wrote: > Hi, > > looks fine, how did you reproduce a build issue and make sure it > fixed it? > I noticed an "unguarded" usage of GDK_IS_X11_DISPLAY(), so i built gtk+ enabling only the wayland backend (and add the guards where needed).

Re: [Spice-devel] [PATCH spice-gtk] Allow to build without X11 gdk backend

2017-06-19 Thread Frediano Ziglio
Question: can GDK have no X11? I suppose only wayland compiled in? > > --- > src/spice-gtk-session.c | 2 +- > src/spice-widget-egl.c | 14 +- > src/spice-widget.c | 2 +- > 3 files changed, 15 insertions(+), 3 deletions(-) > > diff --git a/src/spice-gtk-session.c b/src/spic

Re: [Spice-devel] [PATCH spice-gtk] Allow to build without X11 gdk backend

2017-06-19 Thread Marc-André Lureau
Hi, looks fine, how did you reproduce a build issue and make sure it fixed it? - Original Message - > --- > src/spice-gtk-session.c | 2 +- > src/spice-widget-egl.c | 14 +- > src/spice-widget.c | 2 +- > 3 files changed, 15 insertions(+), 3 deletions(-) > > diff --

[Spice-devel] [PATCH spice-gtk] Allow to build without X11 gdk backend

2017-06-19 Thread Pavel Grunt
--- src/spice-gtk-session.c | 2 +- src/spice-widget-egl.c | 14 +- src/spice-widget.c | 2 +- 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/src/spice-gtk-session.c b/src/spice-gtk-session.c index 33db3c8..e338ce6 100644 --- a/src/spice-gtk-session.c +++ b/src

Re: [Spice-devel] [qxl] qxl: call provider init

2017-06-19 Thread Christophe Fergeau
I've now pushed this upstream. Christophe On Mon, Jun 19, 2017 at 12:08:33PM +0200, Christophe Fergeau wrote: > From: Dave Airlie > > This prevents crashes when multiple QXL devices are configured in a VM. > > https://bugzilla.redhat.com/show_bug.cgi?id=1428340 > --- > src/qxl_drmmode.c | 3 +

Re: [Spice-devel] [PATCH spice-gtk] Do not unrealize disabled egl

2017-06-19 Thread Marc-André Lureau
Hi - Original Message - > On Mon, 2017-06-19 at 06:00 -0400, Marc-André Lureau wrote: > > > > - Original Message - > > > > > > > > > - Original Message - > > > > Avoids a critical to be logged when closing remote-viewer: > > > > "gl_make_current: assertion 'd->egl.conte

Re: [Spice-devel] [PATCH spice-gtk] Do not unrealize disabled egl

2017-06-19 Thread Pavel Grunt
On Mon, 2017-06-19 at 06:00 -0400, Marc-André Lureau wrote: > > - Original Message - > > > > > > - Original Message - > > > Avoids a critical to be logged when closing remote-viewer: > > > "gl_make_current: assertion 'd->egl.context_ready' failed" > > > > ack, thanks > > actua

Re: [Spice-devel] unplug USB Device, guest Desktop will unresponsive

2017-06-19 Thread Christophe Fergeau
On Mon, Jun 12, 2017 at 05:44:45PM +0800, leaboy wrote: > hi, everyone. > when I unplug a USB Storage from client machine, the guest desktop > will unresponsive at thus case: > > 1. the USB Storage device with 16G or 32G has redir to the guest desktop, and > coping some big file. > then

Re: [Spice-devel] [PATCH spice-server v2] gitignore: Reduce html files exclusion

2017-06-19 Thread Frediano Ziglio
> > On 06/19/2017 09:40 AM, Pavel Grunt wrote: > > Hi, > > > > On Sun, 2017-06-18 at 05:06 -0400, Frediano Ziglio wrote: > >> ping > > > > no reply to Uri's questions? > > Specifically, it's not clear why not ignore all .html files. > > Uri. > Because html files are common and you want to ig

[Spice-devel] [qxl] qxl: call provider init

2017-06-19 Thread Christophe Fergeau
From: Dave Airlie This prevents crashes when multiple QXL devices are configured in a VM. https://bugzilla.redhat.com/show_bug.cgi?id=1428340 --- src/qxl_drmmode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qxl_drmmode.c b/src/qxl_drmmode.c index ff164cd..a2f84b1 100644 --- a/sr

Re: [Spice-devel] [PATCH spice-gtk] Do not unrealize disabled egl

2017-06-19 Thread Victor Toso
Hi, On Mon, Jun 19, 2017 at 11:50:45AM +0200, Pavel Grunt wrote: > Avoids a critical to be logged when closing remote-viewer: > "gl_make_current: assertion 'd->egl.context_ready' failed" > --- > src/spice-widget-egl.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/spice-widget-e

Re: [Spice-devel] [PATCH spice-gtk] Do not unrealize disabled egl

2017-06-19 Thread Marc-André Lureau
- Original Message - > > > - Original Message - > > Avoids a critical to be logged when closing remote-viewer: > > "gl_make_current: assertion 'd->egl.context_ready' failed" > > ack, thanks actually, why not check egl.context_ready? (you might be switch back to 2d, and still

Re: [Spice-devel] [PATCH spice-server v2] gitignore: Reduce html files exclusion

2017-06-19 Thread Uri Lublin
On 06/19/2017 09:40 AM, Pavel Grunt wrote: Hi, On Sun, 2017-06-18 at 05:06 -0400, Frediano Ziglio wrote: ping no reply to Uri's questions? Specifically, it's not clear why not ignore all .html files. Uri. - Original Message - From: "Uri Lublin" To: "Frediano Ziglio" , spice-

Re: [Spice-devel] [PATCH spice-gtk] Do not unrealize disabled egl

2017-06-19 Thread Marc-André Lureau
- Original Message - > Avoids a critical to be logged when closing remote-viewer: > "gl_make_current: assertion 'd->egl.context_ready' failed" ack, thanks > --- > src/spice-widget-egl.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/spice-widget-egl.c b/src/spice-wid

[Spice-devel] [PATCH spice-gtk] Do not unrealize disabled egl

2017-06-19 Thread Pavel Grunt
Avoids a critical to be logged when closing remote-viewer: "gl_make_current: assertion 'd->egl.context_ready' failed" --- src/spice-widget-egl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c index 7c21113..5951ae6 100644 --- a/src/spice-wid

Re: [Spice-devel] [PATCH spice-protocol v3] agent: Add new file-xfer statuses

2017-06-19 Thread Pavel Grunt
On Tue, 2017-06-06 at 23:21 +0200, Jakub Janků wrote: > Introduce new error statuses to report more info to clients: > VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED, > VD_AGENT_FILE_XFER_STATUS_VDAGENT_NOT_CONNECTED, > VD_AGENT_FILE_XFER_STATUS_DISABLED > > These are only sent to clients that feature >

Re: [Spice-devel] [PATCH spice-server v3] gitignore: Reduce html files exclusion

2017-06-19 Thread Christophe Fergeau
On Mon, Jun 19, 2017 at 08:15:24AM +0100, Frediano Ziglio wrote: > Limit html files ignored. Html files under docs/ are still ignored. > Can happen that you are working on some html files on your main > spice-server directory and it's not desirable to ignore them. > For instance this can happen if

Re: [Spice-devel] [PATCH spice-common 0/2] Remove obsolete environment usage

2017-06-19 Thread Frediano Ziglio
> Hi > On Tue, Jun 13, 2017 at 5:56 PM Jonathon Jongsma < jjong...@redhat.com > > wrote: > > On Tue, 2017-06-13 at 16:53 +0200, Victor Toso wrote: > > > > Hi, > > > > > > > > On Tue, Jun 13, 2017 at 03:47:52PM +0100, Frediano Ziglio wrote: > > > > > Following log discussion and Victor suggest

Re: [Spice-devel] [PATCH spice-common 0/2] Remove obsolete environment usage

2017-06-19 Thread Marc-André Lureau
Hi On Tue, Jun 13, 2017 at 5:56 PM Jonathon Jongsma wrote: > On Tue, 2017-06-13 at 16:53 +0200, Victor Toso wrote: > > Hi, > > > > On Tue, Jun 13, 2017 at 03:47:52PM +0100, Frediano Ziglio wrote: > > > Following log discussion and Victor suggestion about removing > > > these variable as already

Re: [Spice-devel] [PATCH spice-common 1/2] log: Forbid the usage of obsolete SPICE_LOG_DOMAIN

2017-06-19 Thread Marc-André Lureau
Hi - Original Message - > As we decided to not use GLib domains do not allow the usage of > this obsolete macro to use different logging domains. > Will be replaced by some different categorization. > > Signed-off-by: Frediano Ziglio > --- > common/log.c | 7 --- > common/

Re: [Spice-devel] [PATCH spice-common 2/2] log: Force format in log macro to be a string

2017-06-19 Thread Marc-André Lureau
Hi - Original Message - > Make sure format is a string and not a pointer. > > Signed-off-by: Frediano Ziglio Reviewed-by: Marc-André Lureau > --- > common/log.h | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/common/log.h b/common/log.h > index ed

[Spice-devel] [PATCH spice-common 2/2] log: Force format in log macro to be a string

2017-06-19 Thread Frediano Ziglio
Make sure format is a string and not a pointer. Signed-off-by: Frediano Ziglio --- common/log.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/common/log.h b/common/log.h index ed701ca..c6d260c 100644 --- a/common/log.h +++ b/common/log.h @@ -62,23 +62,23 @@ void

[Spice-devel] [PATCH spice-common 1/2] log: Forbid the usage of obsolete SPICE_LOG_DOMAIN

2017-06-19 Thread Frediano Ziglio
As we decided to not use GLib domains do not allow the usage of this obsolete macro to use different logging domains. Will be replaced by some different categorization. Signed-off-by: Frediano Ziglio --- common/log.c | 7 --- common/log.h | 25 - test

[Spice-devel] [PATCH spice-server v3] gitignore: Reduce html files exclusion

2017-06-19 Thread Frediano Ziglio
Limit html files ignored. Html files under docs/ are still ignored. Can happen that you are working on some html files on your main spice-server directory and it's not desirable to ignore them. For instance this can happen if you download a patch from patchwork. Signed-off-by: Frediano Ziglio --