Re: [Spice-devel] usbfilter for USB Select dialog

2017-06-04 Thread Snir Sheriber
Hi, On 06/05/2017 04:53 AM, leaboy wrote: hi, On the server side, it just control the USB connection is on or off, can not control some USB type can be use or not. Server side can also use the USB filter string, please look here: https://www.spice-space.org/usbredir.html under "Host Filter

Re: [Spice-devel] usbfilter for USB Select dialog

2017-06-04 Thread leaboy
hi, On the server side, it just control the USB connection is on or off, can not control some USB type can be use or not. For Example: case 1. I’m a admin user, I don’t want client user to use storage device and can use other usb device. the server side can’t handle it. case 2. I’m a admin

[Spice-devel] [PATCH spice-vdagent v7 3/3] file-xfer: change error log messages

2017-06-04 Thread Jakub Janků
Add prefix "file-xfer #id" prefix to log message in send_file_xfer_status(), so the message doesn't have to include file-xfer task id and it's always clear, what task is the message concerning. --- src/vdagentd/vdagentd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[Spice-devel] [PATCH spice-vdagent v7 2/3] file-xfer: Check free space before file transfer

2017-06-04 Thread Jakub Janků
Add function get_free_space_available that retrieves amount of free space in the given directory. The statvfs may fail even when there's enough free space (e.g. when not supported by system), in this case return G_MAXUINT64 so that the transfer isn't terminated groundlessly. When the file is too b

[Spice-devel] [PATCH spice-vdagent v7 1/3] file-xfer: Add support for sending detailed errors

2017-06-04 Thread Jakub Janků
Generalize send_file_xfer_status() to send all file xfer statuses, not just errors. Change send_file_xfer_status() to support sending detailed file xfer status messages with additional error data. --- configure.ac| 2 +- src/vdagentd/vdagentd.c | 60 --

Re: [Spice-devel] [PATCH spice-space-pages] More clear USB filter instructions

2017-06-04 Thread Uri Lublin
On 06/04/2017 01:14 PM, Snir Sheriber wrote: --- usbredir.rst | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) Ack. Uri. diff --git a/usbredir.rst b/usbredir.rst index 4c78ade..8d2f670 100644 --- a/usbredir.rst +++ b/usbredir.rst @@ -150,15 +150,17 @@ auto-connect.

[Spice-devel] [PATCH spice-space-pages] More clear USB filter instructions

2017-06-04 Thread Snir Sheriber
--- usbredir.rst | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/usbredir.rst b/usbredir.rst index 4c78ade..8d2f670 100644 --- a/usbredir.rst +++ b/usbredir.rst @@ -150,15 +150,17 @@ auto-connect. Client Filtering -Set a string specifying a f

Re: [Spice-devel] usbfilter for USB Select dialog

2017-06-04 Thread Snir Sheriber
Hi, On 06/02/2017 12:52 PM, leaboy wrote: hello, everyone. I found if I disable some USB device use usb_filter, it’s just take effect for the auto_connect. but when I open the USBSelectDialog, I can see the disabled device, and even I can checked it. So, I just modified a little code let the

Re: [Spice-devel] [PATCH spice v2] reds: Cancel unexpected xfer messages

2017-06-04 Thread Uri Lublin
On 06/02/2017 06:31 PM, Frediano Ziglio wrote: Inform client that transfer will not work, instead of only dropping the agent messages. The file transfer messages can be disabled using qemu cli option: "disable-agent-file-xfer" Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1373725 Si