[Spice-devel] [PATCH spice-gtk v2] main: Handle file-xfer detailed errors

2017-05-29 Thread Jakub Janků
Log appropriate error messages when we receive VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED, VD_AGENT_FILE_XFER_STATUS_AGENT_NOT_CONNECTED, VD_AGENT_FILE_XFER_STATUS_DISABLED. --- src/channel-main.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/channel-main.c b/src/channel-mai

[Spice-devel] [PATCH spice-vdagent v2] file-xfer: Send more detailed error messages

2017-05-29 Thread Jakub Janků
Send VD_AGENT_FILE_XFER_STATUS_AGENT_NOT_CONNECTED, VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED or VD_AGENT_FILE_XFER_STATUS_DISABLED instead of general error, when the given error occurs. send_file_xfer_status() ensures, these errors are sent only to clients with VD_AGENT_CAP_FILE_XFER_DETAILED_ERRO

[Spice-devel] [PATCH spice-protocol v2] agent: Add new file-xfer statuses

2017-05-29 Thread Jakub Janků
Introduce new error statuses to report more info to clients: VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED, VD_AGENT_FILE_XFER_STATUS_AGENT_NOT_CONNECTED, VD_AGENT_FILE_XFER_STATUS_DISABLED These are only sent to clients that feature VD_AGENT_CAP_FILE_XFER_DETAILED_ERRORS capability. --- spice/vd_agen

Re: [Spice-devel] [PATCH spice-gtk] main: Handle file-xfer detailed errors

2017-05-29 Thread Christophe Fergeau
Hey, On Mon, May 29, 2017 at 12:24:46PM +, Jakub Janků wrote: > Hi, > I copied the message concerning VD_AGENT_FILE_XFER_STATUS_NO_AGENT from the > linux vdagent. What message would you suggest instead? Perhaps something > like "Agent not connected, file-xfer cancelled."? It really depends on

Re: [Spice-devel] [PATCH v3 1/3] vdagent: move file xfer initialization to a function

2017-05-29 Thread Victor Toso
Hi, On Mon, May 29, 2017 at 03:05:49PM +0200, Christophe Fergeau wrote: > On Mon, May 29, 2017 at 02:43:26PM +0200, Victor Toso wrote: > > Hi, > > > > On Mon, May 29, 2017 at 01:31:35PM +0200, Christophe Fergeau wrote: > > > On Thu, May 18, 2017 at 12:21:55PM +0200, Victor Toso wrote: > > > > Fro

Re: [Spice-devel] [PATCH v3 1/3] vdagent: move file xfer initialization to a function

2017-05-29 Thread Christophe Fergeau
On Mon, May 29, 2017 at 02:43:26PM +0200, Victor Toso wrote: > Hi, > > On Mon, May 29, 2017 at 01:31:35PM +0200, Christophe Fergeau wrote: > > On Thu, May 18, 2017 at 12:21:55PM +0200, Victor Toso wrote: > > > From: Victor Toso > > > > > > This patch creates two functions: > > > - xfer_get_downlo

Re: [Spice-devel] [PATCH v3 1/3] vdagent: move file xfer initialization to a function

2017-05-29 Thread Victor Toso
Hi, On Mon, May 29, 2017 at 01:31:35PM +0200, Christophe Fergeau wrote: > On Thu, May 18, 2017 at 12:21:55PM +0200, Victor Toso wrote: > > From: Victor Toso > > > > This patch creates two functions: > > - xfer_get_download_directory() > > - vdagent_init_file_xfer() > > > > The logic should be sim

Re: [Spice-devel] [PATCH spice-protocol] agent: Add new file-xfer statuses

2017-05-29 Thread Pavel Grunt
Hello Jakub, On Sun, 2017-05-28 at 22:59 +0200, Jakub Janků wrote: > Introduce new error statuses to report more info to clients: > VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED, > VD_AGENT_FILE_XFER_STATUS_NO_AGENT When does it happen? if the agent disconnects during a file transfer? Maybe _STATUS_AGE

Re: [Spice-devel] [spice-gtk 5/4] gtk-session: move var declaration to the top

2017-05-29 Thread Victor Toso
Hi, On Thu, May 25, 2017 at 10:43:45AM -0500, Jonathon Jongsma wrote: > On Wed, 2017-05-24 at 14:32 +0200, Victor Toso wrote: > > From: Victor Toso > > > > Most of spice-gtk code tries to follow that. Doing this specifically > > to the clipboard_get_targets() due to the recent previous changes in

Re: [Spice-devel] [PATCH spice-gtk] main: Handle file-xfer detailed errors

2017-05-29 Thread Jakub Janků
Hi, I copied the message concerning VD_AGENT_FILE_XFER_STATUS_NO_AGENT from the linux vdagent. What message would you suggest instead? Perhaps something like "Agent not connected, file-xfer cancelled."? Thanks On Mon, May 29, 2017 at 12:17 PM Christophe Fergeau wrote: > On Sun, May 28, 2017 at 1

Re: [Spice-devel] [PATCH v3 2/3] vdagent: move file xfer finalize to a function

2017-05-29 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Thu, May 18, 2017 at 12:21:56PM +0200, Victor Toso wrote: > From: Victor Toso > > This patch creates vdagent_finalize_file_xfer() to finalize and stop > file xfer. Moving this code to a function removes some duplication. > > Signed-off-by: Victor Toso > --- >

Re: [Spice-devel] [PATCH v3 1/3] vdagent: move file xfer initialization to a function

2017-05-29 Thread Christophe Fergeau
On Thu, May 18, 2017 at 12:21:55PM +0200, Victor Toso wrote: > From: Victor Toso > > This patch creates two functions: > - xfer_get_download_directory() > - vdagent_init_file_xfer() > > The logic should be similar as it was before this patch, taking in > consideration the global variables fx_ope

Re: [Spice-devel] [PATCH spice-gtk] main: Handle file-xfer detailed errors

2017-05-29 Thread Christophe Fergeau
On Sun, May 28, 2017 at 11:36:34PM +0200, Jakub Janků wrote: > Log appropriate error messages when we receive > VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED or > VD_AGENT_FILE_XFER_STATUS_NO_AGENT. > --- > src/channel-main.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/src/cha

[Spice-devel] [PATCH spice-html5] Display: Add support for the VP9 codec type

2017-05-29 Thread Tomáš Bohdálek
--- display.js | 26 -- spiceconn.js | 2 ++ webm.js | 12 ++-- 3 files changed, 32 insertions(+), 8 deletions(-) diff --git a/display.js b/display.js index 0868f91..c458df6 100644 --- a/display.js +++ b/display.js @@ -543,7 +543,8 @@ SpiceDisplayConn.proto