Re: [Spice-devel] [PATCH spice-gtk] widget: Return early on cursor set without shape

2017-05-26 Thread Victor Toso
Hi, On Fri, May 26, 2017 at 04:39:49PM +0200, Pavel Grunt wrote: > A cursor pixbuf is required in other functions to work properly From what I checked, yes. Plus this is unlikely to happen (I never saw this warning for instance) Acked-by: Victor Toso > --- > src/spice-widget.c | 37 +++

[Spice-devel] [PATCH spice-gtk] widget: Return early on cursor set without shape

2017-05-26 Thread Pavel Grunt
A cursor pixbuf is required in other functions to work properly --- src/spice-widget.c | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index d42924b..1a1d5a6 100644 --- a/src/spice-widget.c +++ b/sr

Re: [Spice-devel] [PATCH spice-gtk v3] widget: Set cursor during construction

2017-05-26 Thread Victor Toso
Hi, On Fri, May 26, 2017 at 03:08:36PM +0200, Pavel Grunt wrote: > In a multimonitor environment can easily happen that a cursor is set > before some of the SpiceDisplays are created. IOW the first created > SpiceDisplay has the cursor but others don't. > > To avoid the issue set the initial curs

[Spice-devel] [PATCH spice-gtk v3] widget: Set cursor during construction

2017-05-26 Thread Pavel Grunt
In a multimonitor environment can easily happen that a cursor is set before some of the SpiceDisplays are created. IOW the first created SpiceDisplay has the cursor but others don't. To avoid the issue set the initial cursor using the "cursor" property of the SpiceCursorChannel. Resolves: https:/

Re: [Spice-devel] [PATCH 1/3] qxl-wddm-dod: Fix unmapping of physical memory

2017-05-26 Thread Frediano Ziglio
> > https://bugzilla.redhat.com/show_bug.cgi?id=1454866 > Due to wrong addresses passed to class driver, it never does > unmapping of physical memory, causing a leak of virtual address range. > On x86 systems the device fails to start due to failure to > map physical memory range after 10-50 cycle

[Spice-devel] [PATCH spice-html5 v2] Display: Implement change preferred compression message

2017-05-26 Thread Tomáš Bohdálek
--- display.js | 16 enums.js| 10 ++ spicemsg.js | 20 3 files changed, 46 insertions(+) diff --git a/display.js b/display.js index 7719b23..60c79b4 100644 --- a/display.js +++ b/display.js @@ -1245,3 +1245,19 @@ function listen_for_video_events

[Spice-devel] [PATCH spice-html5] spiceconn: Add function to test channel capabilities

2017-05-26 Thread Tomáš Bohdálek
This will be used in other commits. --- spiceconn.js | 19 +++ 1 file changed, 19 insertions(+) diff --git a/spiceconn.js b/spiceconn.js index 33e7388..d76f8e2 100644 --- a/spiceconn.js +++ b/spiceconn.js @@ -243,6 +243,9 @@ SpiceConn.prototype = else if (this.state == "l

[Spice-devel] [PATCH spice-html5] Display: Implement change preferred video codec type message

2017-05-26 Thread Tomáš Bohdálek
--- display.js | 16 enums.js| 10 ++ spicemsg.js | 24 3 files changed, 50 insertions(+) diff --git a/display.js b/display.js index 8a8f768..ee53288 100644 --- a/display.js +++ b/display.js @@ -1261,3 +1261,19 @@ SpiceDisplayConn.prototype.c

[Spice-devel] [PATCH spice-html5 v2] Add checkbox to toggle debug console

2017-05-26 Thread Tomáš Bohdálek
This allows show or hide debug console under spice screen. --- resize.js | 16 ++-- spice.html | 18 ++ 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/resize.js b/resize.js index 89b59ff..5559bcf 100644 --- a/resize.js +++ b/resize.js @@ -39,13 +39,25