Re: [Spice-devel] [PATCH spice-html5] Display: Implement change preferred compression message

2017-05-25 Thread Jeremy White
Hi Tomáš, This patch looks essentially correct to me. But could you also add constants for the image_compression enums? i.e. SPICE_IMAGE_COMPRESSION_INVALID and friends? Cheers, Jeremy On 05/24/2017 06:08 AM, Tomáš Bohdálek wrote: > --- > display.js | 9 + > enums.js| 1 + > s

Re: [Spice-devel] [PATCH spice-html5 3/3] Add checkbox to toggle debug console

2017-05-25 Thread Jeremy White
Hi Tomáš, On 05/23/2017 07:03 AM, Tomáš Bohdálek wrote: > This allows show or hide debug console under spice screen. > --- > resize.js | 12 ++-- > spice.html | 18 ++ > 2 files changed, 28 insertions(+), 2 deletions(-) > > diff --git a/resize.js b/resize.js > index 89b5

Re: [Spice-devel] [PATCH spice-html5 2/2] Make sure to not set to smaller height than is minimal

2017-05-25 Thread Jeremy White
On 05/23/2017 03:44 AM, Tomáš Bohdálek wrote: > Get minimal screen height from css file. The patch looks correct, but I'm not sure if we really want the functionality. When I originally set the minimum height in the css, I did it primarily to cause the 'non connected' screen size to come up reas

Re: [Spice-devel] [PATCH spice-html5 v2] Always show debug console

2017-05-25 Thread Jeremy White
Acked-by: Jeremy White On 05/24/2017 01:57 AM, Tomáš Bohdálek wrote: > Make sure to show both screen and console. > --- > resize.js | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/resize.js b/resize.js > index f5410d3..b572de7 100644 > --- a/resize.js > +++ b/r

Re: [Spice-devel] [PATCH v2] Don't close all but one display during reboot.

2017-05-25 Thread Jonathon Jongsma
On Thu, 2017-05-25 at 08:14 -0400, Frediano Ziglio wrote: > > > > When a guest is rebooted, the QXL driver gets unloaded at some > > point in > > the reboot process. When the driver is unloaded, the spice server > > sets a > > single flag to FALSE: RedWorker::driver_cap_monitors_config. This > > f

Re: [Spice-devel] [spice-gtk 5/4] gtk-session: move var declaration to the top

2017-05-25 Thread Jonathon Jongsma
On Wed, 2017-05-24 at 14:32 +0200, Victor Toso wrote: > From: Victor Toso > > Most of spice-gtk code tries to follow that. Doing this specifically > to the clipboard_get_targets() due to the recent previous changes in > this function. > > This patch also takes the opportunity to remove the array

Re: [Spice-devel] [PATCH spice-gtk v2 3/3] widget: Set cursor during construction

2017-05-25 Thread Victor Toso
Hi, On Thu, May 25, 2017 at 03:13:13PM +0200, Pavel Grunt wrote: > On Wed, 2017-05-24 at 09:22 +0200, Victor Toso wrote: > > On Tue, May 23, 2017 at 04:56:26PM +0200, Pavel Grunt wrote: > > > In a multimonitor environment can easily happen that a cursor is > > > set > > > before some of the SpiceD

Re: [Spice-devel] [PATCH spice-gtk v2 2/3] Deprecate "cursor-set" signal

2017-05-25 Thread Pavel Grunt
On Wed, 2017-05-24 at 09:11 +0200, Victor Toso wrote: > Hi, > > On Tue, May 23, 2017 at 04:56:25PM +0200, Pavel Grunt wrote: > > Use cursor notify instead > > > > Related: > > https://bugzilla.redhat.com/show_bug.cgi?id=1411380 > > --- > > src/channel-cursor.c | 4 +++- > > src/spice-widget.c

Re: [Spice-devel] [PATCH spice-gtk v2 3/3] widget: Set cursor during construction

2017-05-25 Thread Pavel Grunt
On Wed, 2017-05-24 at 09:22 +0200, Victor Toso wrote: > On Tue, May 23, 2017 at 04:56:26PM +0200, Pavel Grunt wrote: > > In a multimonitor environment can easily happen that a cursor is > > set > > before some of the SpiceDisplays are created. IOW the first > > created > > SpiceDisplay has the curs

[Spice-devel] [PATCH 1/3] qxl-wddm-dod: Fix unmapping of physical memory

2017-05-25 Thread Yuri Benditovich
https://bugzilla.redhat.com/show_bug.cgi?id=1454866 Due to wrong addresses passed to class driver, it never does unmapping of physical memory, causing a leak of virtual address range. On x86 systems the device fails to start due to failure to map physical memory range after 10-50 cycles of disable-

[Spice-devel] [PATCH 3/3] qxl-wddm-dod: Debug printouts of memory mapping

2017-05-25 Thread Yuri Benditovich
Print error case on proper level and fix typos. Signed-off-by: Yuri Benditovich --- qxldod/QxlDod.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 6b0cc5e..6f2ca88 100755 --- a/qxldod/QxlDod.cpp +++ b/qxldod/QxlDod.cpp @@ -34

[Spice-devel] [PATCH 2/3] qxl-wddm-dod: Prevent potential memory leak in class driver

2017-05-25 Thread Yuri Benditovich
In case the device initializes 4 memory bars, the driver maps physical memory of bar 4 and never unmaps it. Fixing it by immediate unmap of unused memory bars. Signed-off-by: Yuri Benditovich --- qxldod/QxlDod.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qxldod/QxlDod.cpp b/qxldod/Q

Re: [Spice-devel] [PATCH v2] Don't close all but one display during reboot.

2017-05-25 Thread Frediano Ziglio
> > When a guest is rebooted, the QXL driver gets unloaded at some point in > the reboot process. When the driver is unloaded, the spice server sets a > single flag to FALSE: RedWorker::driver_cap_monitors_config. This flag > indicates whether the driver is capable of sending its own monitors conf