On Wed, 2017-05-24 at 18:54 +0200, Victor Toso wrote:
> Hi,
>
> On Wed, May 24, 2017 at 11:36:55AM -0500, Jonathon Jongsma wrote:
> > I see Frediano acked this, but there are a couple issues with the
> > commit log if you haven't pushed yet.
> >
> > On Mon, 2017-05-22 at 20:08 +0200, Victor Toso
Hi,
On Wed, May 24, 2017 at 11:36:55AM -0500, Jonathon Jongsma wrote:
> I see Frediano acked this, but there are a couple issues with the
> commit log if you haven't pushed yet.
>
> On Mon, 2017-05-22 at 20:08 +0200, Victor Toso wrote:
> > From: Victor Toso
> >
> > By using 'num_types' variables,
I see Frediano acked this, but there are a couple issues with the
commit log if you haven't pushed yet.
On Mon, 2017-05-22 at 20:08 +0200, Victor Toso wrote:
> From: Victor Toso
>
> By using 'num_types' variables, we have a clear variable with a clear
> propose: It will track the number of VD_AG
When a guest is rebooted, the QXL driver gets unloaded at some point in
the reboot process. When the driver is unloaded, the spice server sets a
single flag to FALSE: RedWorker::driver_cap_monitors_config. This flag
indicates whether the driver is capable of sending its own monitors config
messages
Add function create_status_message() that allocates new
VDAgentFileXferStatusMessage with optional error data.
If an error occurs in function handle_start(), or handle_data(),
create appropriate status message - in case of lack of free space,
send message with VD_AGENT_FILE_XFER_STATUS_NOT_ENOUGH_
Add prefix "file-xfer #id" prefix to log message in send_file_xfer_status(),
so the message doesn't have to include file-xfer task id and it's always clear,
what task is the message concerning.
---
src/vdagentd/vdagentd.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
Add function get_free_space_available that retrieves amount of free
space in the given directory. The statvfs may fail even when there's
enough free space (e.g. when not supported by system), in this case
return G_MAXUINT64 so that the transfer isn't terminated groundlessly.
When the file is too b
Add prefix "file-xfer #id" prefix to log message in send_file_xfer_status(),
so the message doesn't have to include file-xfer task id and it's always clear,
what task is the message concerning.
---
src/vdagentd/vdagentd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/
Add function get_free_space_available that retrieves amount of free
space in the given directory. The statvfs may fail even when there's
enough free space (e.g. when not supported by system), in this case
return G_MAXUINT64 so that the transfer isn't terminated groundlessly.
When the file is too b
From: Victor Toso
Most of spice-gtk code tries to follow that. Doing this specifically
to the clipboard_get_targets() due to the recent previous changes in
this function.
This patch also takes the opportunity to remove the array
initialization of types[] which is not needed since 1b73ae3cf25bd4
Hi,
On Wed, May 24, 2017 at 05:05:47AM -0400, Frediano Ziglio wrote:
> >
> > From: Victor Toso
> >
> > By using 'num_types' variables, we have a clear variable with a clear
> > propose: It will track the number of VD_AGENT_CLIPBOARD types we are
> > storing in types[] array.
> >
> > This new v
---
display.js | 9 +
enums.js| 1 +
spicemsg.js | 20
3 files changed, 30 insertions(+)
diff --git a/display.js b/display.js
index 7719b23..501ef03 100644
--- a/display.js
+++ b/display.js
@@ -1245,3 +1245,12 @@ function listen_for_video_events(stream)
if
>
> >
> > >
> > > On Tue, 2017-05-23 at 07:01 -0400, Frediano Ziglio wrote:
> > > > >
> > > > > On Wed, May 17, 2017 at 12:57:34PM -0400, Frediano Ziglio wrote:
> > > > > > >
> > > > > > > >
> > > > > > > > ---
> > > > > > > > vdagent/file_xfer.cpp | 4 ++--
> > > > > > > > 1 file changed, 2
>
> >
> > >
> > > On Tue, 2017-05-23 at 07:01 -0400, Frediano Ziglio wrote:
> > > > >
> > > > > On Wed, May 17, 2017 at 12:57:34PM -0400, Frediano Ziglio wrote:
> > > > > > >
> > > > > > > >
> > > > > > > > ---
> > > > > > > > vdagent/file_xfer.cpp | 4 ++--
> > > > > > > > 1 file changed, 2
>
> From: Victor Toso
>
> As we will not be doing anything in case clipboard is already grabbed
>
> Signed-off-by: Victor Toso
> Signed-off-by: Victor Toso
> ---
> src/spice-gtk-session.c | 18 +++---
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/src/spice-
>
> From: Victor Toso
>
> By using 'num_types' variables, we have a clear variable with a clear
> propose: It will track the number of VD_AGENT_CLIPBOARD types we are
> storing in types[] array.
>
> This new variable helps:
> - removing one for that was counting the number stored types;
> - red
> On 24 May 2017, at 10:46, Christophe Fergeau wrote:
>
> On Tue, May 23, 2017 at 07:05:18PM +0200, Christophe de Dinechin wrote:
>>> , another alternative would be to have a --enable-alignment-debug,
>>
>> I tried that, but the problem is to keep that consistent between
>> spice-common and spi
On Tue, May 23, 2017 at 07:05:18PM +0200, Christophe de Dinechin wrote:
> > , another alternative would be to have a --enable-alignment-debug,
>
> I tried that, but the problem is to keep that consistent between
> spice-common and spice-gdk (they may have different configuration). Do
> you have a
> On 24 May 2017, at 10:09, Christophe Fergeau wrote:
>
> On Tue, May 23, 2017 at 12:55:13PM +0200, Victor Toso wrote:
>>>
>>> I only see -DNDEBUG being defined for cmake builds in rpm --showrc, and
>>> none of my 250 spec files have a -DNDEBUG in them, so I would not expect
>>> this to be set.
On Tue, May 23, 2017 at 12:55:13PM +0200, Victor Toso wrote:
> >
> > I only see -DNDEBUG being defined for cmake builds in rpm --showrc, and
> > none of my 250 spec files have a -DNDEBUG in them, so I would not expect
> > this to be set. I think we have SPICE_DEBUG already which might make
> > sens
Hey,
On Wed, May 24, 2017 at 08:38:53AM +0200, Pavel Grunt wrote:
> On Sun, 2017-05-21 at 15:19 +0200, Jakub Janků wrote:
> > Add function get_free_space_available that retrieves amount of free
> > space in the given directory. The statvfs may fail even when there's
> > enough free space (e.g. whe
On Tue, May 23, 2017 at 04:56:26PM +0200, Pavel Grunt wrote:
> In a multimonitor environment can easily happen that a cursor is set
> before some of the SpiceDisplays are created. IOW the first created
> SpiceDisplay has the cursor but others don't.
>
> To avoid the issue set the initial cursor us
Hi,
On Tue, May 23, 2017 at 04:56:25PM +0200, Pavel Grunt wrote:
> Use cursor notify instead
>
> Related:
> https://bugzilla.redhat.com/show_bug.cgi?id=1411380
> ---
> src/channel-cursor.c | 4 +++-
> src/spice-widget.c | 31 +--
> 2 files changed, 20 insertions(+)
On Tue, May 23, 2017 at 04:56:24PM +0200, Pavel Grunt wrote:
> It provides information about the remote cursor similar to the signal
> "cursor-set". The benefit over the signal is that the property can be
> queried at any time.
>
> Users of the "cursor-set" signal should migrate to "notify::cursor"
24 matches
Mail list logo
