[Spice-devel] [PATCH spice-html5 v2] Always show debug console

2017-05-23 Thread Tomáš Bohdálek
Make sure to show both screen and console. --- resize.js | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/resize.js b/resize.js index f5410d3..b572de7 100644 --- a/resize.js +++ b/resize.js @@ -33,17 +33,17 @@ function resize_helper(sc) { var w = document.getEleme

Re: [Spice-devel] [PATCH spice-vdagent v4] file-xfer: Check free space before file transfer

2017-05-23 Thread Pavel Grunt
Hi Jakub, On Sun, 2017-05-21 at 15:19 +0200, Jakub Janků wrote: > Add function get_free_space_available that retrieves amount of free > space in the given directory. The statvfs may fail even when there's > enough free space (e.g. when not supported by system), in this case > return G_MAXUINT64 so

Re: [Spice-devel] [PATCH spice-protocol v3] agent: Add support for reporting on free space

2017-05-23 Thread Pavel Grunt
On Sun, 2017-05-21 at 15:09 +0200, Jakub Janků wrote: > Agent can send VDAgentFileXferStatusMessage with result > VD_AGENT_FILE_XFER_STATUS_NOT_ENOUGH_SPACE to indicate lack of free > space. This enables more detailed error reporting, so the user knows > why the file transfer has failed. > > Add V

Re: [Spice-devel] [PATCH v2 2/2] Avoid clang warnings on casts with stricter alignment requirements

2017-05-23 Thread Christophe de Dinechin
> On 23 May 2017, at 11:51, Christophe Fergeau wrote: > > On Thu, May 18, 2017 at 03:24:41PM +0200, Christophe de Dinechin wrote: >>> @@ -140,6 +140,41 @@ size_t spice_strnlen(const char *str, size_t max_len); #endif +/* Cast to a type with stricter alignment constrai

Re: [Spice-devel] [PATCH spice-html5 1/2] Always show debug console

2017-05-23 Thread Tomáš Bohdálek
Sorry, yes it is typo. Dne 23. 5. 2017 5:28 odp. napsal uživatel "Christophe de Dinechin" < cdupo...@redhat.com>: > On 23 May 2017, at 10:44, Tomáš Bohdálek wrote: > > Meansure for better display screen with console. Not sure what “meansure” means? Is that a typo? > --- > resize.js | 8 --

Re: [Spice-devel] [PATCH spice-html5 1/2] Always show debug console

2017-05-23 Thread Christophe de Dinechin
> On 23 May 2017, at 10:44, Tomáš Bohdálek wrote: > > Meansure for better display screen with console. Not sure what “meansure” means? Is that a typo? > --- > resize.js | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/resize.js b/resize.js > index f5410d3..b572

Re: [Spice-devel] [PATCH spice-server] gstreamer: Check if ORC library can work

2017-05-23 Thread Christophe de Dinechin
> On 19 May 2017, at 13:23, Frediano Ziglio wrote: > > ORC lirabry is used internally by GStreamer to generate code > dynamically. > If ORC cannot allocate executable memory the failure cause > an abort(3) to be called. > This happens on some SELinux configuration that disable executable > memor

Re: [Spice-devel] [PATCH vd_agent_win] Use sprintf_s instead of sprintf to not crash

2017-05-23 Thread Frediano Ziglio
> > > > > On Tue, 2017-05-23 at 07:01 -0400, Frediano Ziglio wrote: > > > > > > > > On Wed, May 17, 2017 at 12:57:34PM -0400, Frediano Ziglio wrote: > > > > > > > > > > > > > > > > > > > > --- > > > > > > > vdagent/file_xfer.cpp | 4 ++-- > > > > > > > 1 file changed, 2 insertions(+), 2 delet

[Spice-devel] [PATCH spice-gtk v2 2/3] Deprecate "cursor-set" signal

2017-05-23 Thread Pavel Grunt
Use cursor notify instead Related: https://bugzilla.redhat.com/show_bug.cgi?id=1411380 --- src/channel-cursor.c | 4 +++- src/spice-widget.c | 31 +-- 2 files changed, 20 insertions(+), 15 deletions(-) diff --git a/src/channel-cursor.c b/src/channel-cursor.c index

[Spice-devel] [PATCH spice-gtk v2 1/3] cursor: Add cursor shape property

2017-05-23 Thread Pavel Grunt
It provides information about the remote cursor similar to the signal "cursor-set". The benefit over the signal is that the property can be queried at any time. Users of the "cursor-set" signal should migrate to "notify::cursor". Related: https://bugzilla.redhat.com/show_bug.cgi?id=1411380 --- v2

[Spice-devel] [PATCH spice-gtk v2 3/3] widget: Set cursor during construction

2017-05-23 Thread Pavel Grunt
In a multimonitor environment can easily happen that a cursor is set before some of the SpiceDisplays are created. IOW the first created SpiceDisplay has the cursor but others don't. To avoid the issue set the initial cursor using the "cursor" property of the SpiceCursorChannel. Resolves: https:/

Re: [Spice-devel] [PATCH] spicy: add gstreamer options to command line

2017-05-23 Thread Pavel Grunt
On Wed, 2017-05-17 at 14:12 +0200, Victor Toso wrote: > Hi, > > On Wed, May 17, 2017 at 01:59:44PM +0200, Pavel Grunt wrote: > > On Wed, 2017-05-17 at 13:51 +0200, Victor Toso wrote: > > > From: Victor Toso > > > > > > So we can see all available options with spicy --help-gst and > > > set > > >

Re: [Spice-devel] [PATCH vd_agent_win] Use sprintf_s instead of sprintf to not crash

2017-05-23 Thread Frediano Ziglio
> > On Tue, 2017-05-23 at 07:01 -0400, Frediano Ziglio wrote: > > > > > > On Wed, May 17, 2017 at 12:57:34PM -0400, Frediano Ziglio wrote: > > > > > > > > > > > > > > > > > --- > > > > > > vdagent/file_xfer.cpp | 4 ++-- > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > >

Re: [Spice-devel] [vdagent-win PATCH v2] spec: Add missing mingwXX-winpthreads-static dependency

2017-05-23 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Tue, May 23, 2017 at 02:04:08PM +0100, Frediano Ziglio wrote: > Without this dependency mock builds fails to build. > Tried Fedora 25, Fedora 26 and Rawhide (all x86-64) and all > mock builds are failing with "cannot find -lpthread" error. > > Signed-off-by: Fred

[Spice-devel] [vdagent-win PATCH v2] spec: Add missing mingwXX-winpthreads-static dependency

2017-05-23 Thread Frediano Ziglio
Without this dependency mock builds fails to build. Tried Fedora 25, Fedora 26 and Rawhide (all x86-64) and all mock builds are failing with "cannot find -lpthread" error. Signed-off-by: Frediano Ziglio --- mingw-spice-vdagent.spec.in | 2 ++ 1 file changed, 2 insertions(+) Changes since v1: -

Re: [Spice-devel] [vdagent-win PATCH] spec: Add missing mingwXX-winpthreads-static dependency

2017-05-23 Thread Christophe Fergeau
On Tue, May 23, 2017 at 01:11:10PM +0100, Frediano Ziglio wrote: > Without this dependency mock builds fails to build. On which distro? With what kind of errors? (not saying this is a wrong fix, I have vague memories of needing that, but the more details in the commit log, the better). Christophe

[Spice-devel] [vdagent-win PATCH] spec: Add missing mingwXX-winpthreads-static dependency

2017-05-23 Thread Frediano Ziglio
Without this dependency mock builds fails to build. Signed-off-by: Frediano Ziglio --- mingw-spice-vdagent.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mingw-spice-vdagent.spec.in b/mingw-spice-vdagent.spec.in index d1bcf70..d3ac53a 100644 --- a/mingw-spice-vdagent.spec.in +++ b

[Spice-devel] [PATCH spice-html5 3/3] Add checkbox to toggle debug console

2017-05-23 Thread Tomáš Bohdálek
This allows show or hide debug console under spice screen. --- resize.js | 12 ++-- spice.html | 18 ++ 2 files changed, 28 insertions(+), 2 deletions(-) diff --git a/resize.js b/resize.js index 89b59ff..481b22f 100644 --- a/resize.js +++ b/resize.js @@ -44,8 +44,16 @@ fu

Re: [Spice-devel] [PATCH spice-server] gstreamer: Check if ORC library can work

2017-05-23 Thread Frediano Ziglio
> > On Fri, May 19, 2017 at 12:23:40PM +0100, Frediano Ziglio wrote: > > ORC lirabry is used internally by GStreamer to generate code > > dynamically. > > If ORC cannot allocate executable memory the failure cause > > an abort(3) to be called. > > This happens on some SELinux configuration that di

Re: [Spice-devel] [PATCH vd_agent_win] Use sprintf_s instead of sprintf to not crash

2017-05-23 Thread Pavel Grunt
On Tue, 2017-05-23 at 07:01 -0400, Frediano Ziglio wrote: > > > > On Wed, May 17, 2017 at 12:57:34PM -0400, Frediano Ziglio wrote: > > > > > > > > > > > > > > --- > > > > > vdagent/file_xfer.cpp | 4 ++-- > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git

Re: [Spice-devel] [PATCH vd_agent_win] Use sprintf_s instead of sprintf to not crash

2017-05-23 Thread Frediano Ziglio
> > On Wed, May 17, 2017 at 12:57:34PM -0400, Frediano Ziglio wrote: > > > > > > > > > > > --- > > > > vdagent/file_xfer.cpp | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/vdagent/file_xfer.cpp b/vdagent/file_xfer.cpp > > > > index de1aea1..de98d

Re: [Spice-devel] [PATCH v2 2/2] Avoid clang warnings on casts with stricter alignment requirements

2017-05-23 Thread Victor Toso
On Tue, May 23, 2017 at 11:51:01AM +0200, Christophe Fergeau wrote: > On Thu, May 18, 2017 at 03:24:41PM +0200, Christophe de Dinechin wrote: > > > > > >> @@ -140,6 +140,41 @@ size_t spice_strnlen(const char *str, size_t > > >> max_len); > > >> > > >> #endif > > >> > > >> +/* Cast to a type wit

Re: [Spice-devel] [PATCH vd_agent_win] Use sprintf_s instead of sprintf to not crash

2017-05-23 Thread Christophe Fergeau
On Wed, May 17, 2017 at 12:57:34PM -0400, Frediano Ziglio wrote: > > > > > > > > --- > > > vdagent/file_xfer.cpp | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/vdagent/file_xfer.cpp b/vdagent/file_xfer.cpp > > > index de1aea1..de98d50 100644 > > > --- a

Re: [Spice-devel] [PATCH v2 2/2] Avoid clang warnings on casts with stricter alignment requirements

2017-05-23 Thread Christophe Fergeau
On Thu, May 18, 2017 at 03:24:41PM +0200, Christophe de Dinechin wrote: > > > >> @@ -140,6 +140,41 @@ size_t spice_strnlen(const char *str, size_t max_len); > >> > >> #endif > >> > >> +/* Cast to a type with stricter alignment constraints (to build with > >> clang) > >> */ > >> +extern void spi

Re: [Spice-devel] [PATCH spice-server] gstreamer: Check if ORC library can work

2017-05-23 Thread Christophe Fergeau
On Fri, May 19, 2017 at 12:23:40PM +0100, Frediano Ziglio wrote: > ORC lirabry is used internally by GStreamer to generate code > dynamically. > If ORC cannot allocate executable memory the failure cause > an abort(3) to be called. > This happens on some SELinux configuration that disable executabl

Re: [Spice-devel] [PATCH spice-gtk 1/2] cursor: Add cursor shape property

2017-05-23 Thread Christophe Fergeau
On Fri, May 12, 2017 at 01:00:00PM +0200, Pavel Grunt wrote: > It provides information about the remote cursor similar to the signal > "cursor-set". The benefit over the signal is that the property can be > queried at any time. > > Users of the "cursor-set" signal should migrate to "notify::cursor

[Spice-devel] [PATCH spice-html5 1/2] Always show debug console

2017-05-23 Thread Tomáš Bohdálek
Meansure for better display screen with console. --- resize.js | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/resize.js b/resize.js index f5410d3..b572de7 100644 --- a/resize.js +++ b/resize.js @@ -33,17 +33,17 @@ function resize_helper(sc) { var w = document.ge

[Spice-devel] [PATCH spice-html5 2/2] Make sure to not set to smaller height than is minimal

2017-05-23 Thread Tomáš Bohdálek
Get minimal screen height from css file. --- resize.js | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/resize.js b/resize.js index b572de7..89b59ff 100644 --- a/resize.js +++ b/resize.js @@ -32,9 +32,14 @@ **