---
vdagent/file_xfer.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/vdagent/file_xfer.cpp b/vdagent/file_xfer.cpp
index de1aea1..e877cca 100644
--- a/vdagent/file_xfer.cpp
+++ b/vdagent/file_xfer.cpp
@@ -113,8 +113,8 @@ void FileXfer::handle_start(VDAgentFileXferStart
>
> >
> > ---
> > vdagent/file_xfer.cpp | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/vdagent/file_xfer.cpp b/vdagent/file_xfer.cpp
> > index de1aea1..de98d50 100644
> > --- a/vdagent/file_xfer.cpp
> > +++ b/vdagent/file_xfer.cpp
> > @@ -113,8 +113,8 @@ void
On Tue, May 16, 2017 at 07:27:53PM +0200, Victor Toso wrote:
> From: Victor Toso
>
> This patch creates two functions:
> - xfer_get_download_directory()
> - vdagent_init_file_xfer()
>
> The logic should be similar as it was before this patch, taking in
> consideration the global variables fx_ope
On Tue, May 16, 2017 at 07:27:55PM +0200, Victor Toso wrote:
> From: Victor Toso
>
> As we already depend on glib, let's remove code that glib can take
> care. In this case, we don't need to handle commandline parsing
> ourselves.
>
> In regard the global variables:
>
> * static const char * ->
>
> ---
> vdagent/file_xfer.cpp | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/vdagent/file_xfer.cpp b/vdagent/file_xfer.cpp
> index de1aea1..de98d50 100644
> --- a/vdagent/file_xfer.cpp
> +++ b/vdagent/file_xfer.cpp
> @@ -113,8 +113,8 @@ void FileXfer::handle_start
---
vdagent/file_xfer.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/vdagent/file_xfer.cpp b/vdagent/file_xfer.cpp
index de1aea1..de98d50 100644
--- a/vdagent/file_xfer.cpp
+++ b/vdagent/file_xfer.cpp
@@ -113,8 +113,8 @@ void FileXfer::handle_start(VDAgentFileXferStart
From: Christophe de Dinechin
For example, something like this:
uint8_t *p8;
uint32_t *p32 = (uint32_t *) p8;
generates a warning like this:
spice-channel.c:1350:10: error: cast from 'uint8_t *' (aka 'unsigned char *')
to
'uint32_t *' (aka 'unsigned int *') increases required al
From: Christophe de Dinechin
Fixing a piece of code that does not match the style for the
rest of the source files
Signed-off-by: Christophe de Dinechin
---
common/sw_canvas.c | 96 +-
1 file changed, 45 insertions(+), 51 deletions(-)
diff -
From: Christophe de Dinechin
This patch set eliminates warnings detected by clang with respect
to type alignments. Vittorio Toso had submitted something
similar. In this version, I took into account comments by
Christophe Fergeau regarding how to know which casts were
aligned and which ones were
> On 17 May 2017, at 12:08, Frediano Ziglio wrote:
>
>>
>>
>>> On 17 May 2017, at 09:44, Frediano Ziglio wrote:
>>>
From: Christophe de Dinechin
For example, something like this:
uint8_t *p8;
uint32_t *p32 = (uint32_t *) p8;
generates a warnin
Thanks toso, downloaded it and attempted to build it out but getting an error
during make. Autogen and configure succeeded without issue.
In function `check_binary':
/home/btown/x11spice-master/src/tests/tests.c:83: undefined reference to `g_log'
/home/btown/x11spice-master/src/tests/tests.c:84:
Hi,
On Wed, May 17, 2017 at 01:59:44PM +0200, Pavel Grunt wrote:
> On Wed, 2017-05-17 at 13:51 +0200, Victor Toso wrote:
> > From: Victor Toso
> >
> > So we can see all available options with spicy --help-gst and set
> > them
> > as command line argument.
>
> Do you have an usage example?
Sure,
On Wed, 2017-05-17 at 13:51 +0200, Victor Toso wrote:
> From: Victor Toso
>
> So we can see all available options with spicy --help-gst and set
> them
> as command line argument.
Do you have an usage example?
Thanks,
Pavel
>
> Signed-off-by: Victor Toso
> ---
> tools/Makefile.am | 4
>
From: Victor Toso
So we can see all available options with spicy --help-gst and set them
as command line argument.
Signed-off-by: Victor Toso
---
tools/Makefile.am | 4
tools/spicy.c | 9 +
2 files changed, 13 insertions(+)
diff --git a/tools/Makefile.am b/tools/Makefile.am
i
Hi,
On Wed, 2017-05-10 at 22:34 +0200, Jakub Janků wrote:
> Add function get_free_space_available that retrieves amount of free
> space in the given directory. The statvfs may fail even when there's
> enough free space (e.g. when not supported by system), in this case
> return G_MAXUINT64 so that
On Wed, 2017-05-17 at 07:17 -0400, Frediano Ziglio wrote:
> >
> > Hi Jakub,
> >
> > On Tue, 2017-05-09 at 18:53 +0200, Jakub Janků wrote:
> > > Agent can send VDAgentFileXferStatusMessage with result
> > > VD_AGENT_FILE_XFER_STATUS_NOT_ENOUGH_SPACE to indicate lack of
> > > free
> > > space. This
>
> Hi Jakub,
>
> On Tue, 2017-05-09 at 18:53 +0200, Jakub Janků wrote:
> > Agent can send VDAgentFileXferStatusMessage with result
> > VD_AGENT_FILE_XFER_STATUS_NOT_ENOUGH_SPACE to indicate lack of free
> > space. This enables more detailed error reporting, so the user knows
> > why the file tra
Hi Jakub,
On Tue, 2017-05-09 at 18:53 +0200, Jakub Janků wrote:
> Agent can send VDAgentFileXferStatusMessage with result
> VD_AGENT_FILE_XFER_STATUS_NOT_ENOUGH_SPACE to indicate lack of free
> space. This enables more detailed error reporting, so the user knows
> why the file transfer has failed.
> On 17 May 2017, at 11:55, Christophe Fergeau wrote:
>
> On Wed, May 17, 2017 at 11:45:50AM +0200, Christophe de Dinechin wrote:
>>> I'm really sure no architecture on hearth can do check and print in
>>> a single machine instruction.
>>
>> This is not what I said. I said that the cost in the
Hi,
On Tue, May 16, 2017 at 10:00:15PM +, Town, Brian A. (GSFC-428.0)[Embedded
Flight Systems, Inc] wrote:
> I was pointed to the spice-space page by someone after discussing
> problems with VNC. I was under the impression spice only worked with
> KVM, I am working with an ESXI based VM envir
>
>
> > On 17 May 2017, at 09:44, Frediano Ziglio wrote:
> >
> >>
> >> From: Christophe de Dinechin
> >>
> >> For example, something like this:
> >>uint8_t *p8;
> >>uint32_t *p32 = (uint32_t *) p8;
> >>
> >> generates a warning like this:
> >> spice-channel.c:1350:10: error: cast
On Wed, May 17, 2017 at 11:45:50AM +0200, Christophe de Dinechin wrote:
> > I'm really sure no architecture on hearth can do check and print in
> > a single machine instruction.
>
> This is not what I said. I said that the cost in the likely case was one
> extra instruction.
>
> > Actually I don
> On 17 May 2017, at 09:44, Frediano Ziglio wrote:
>
>>
>> From: Christophe de Dinechin
>>
>> For example, something like this:
>>uint8_t *p8;
>>uint32_t *p32 = (uint32_t *) p8;
>>
>> generates a warning like this:
>> spice-channel.c:1350:10: error: cast from 'uint8_t *' (aka 'unsi
> On 17 May 2017, at 11:24, Christophe Fergeau wrote:
>
> On Wed, May 17, 2017 at 03:47:48AM -0400, Frediano Ziglio wrote:
>>>
>>> From: Christophe de Dinechin
>>>
>>> On macOS, neither of the two cases implemented in set_mouse_accel applies.
>>> We get the following eror message:
>>>
>>> C
On Wed, May 17, 2017 at 03:47:48AM -0400, Frediano Ziglio wrote:
> >
> > From: Christophe de Dinechin
> >
> > On macOS, neither of the two cases implemented in set_mouse_accel applies.
> > We get the following eror message:
> >
> > CC spice-widget.lo
> > spice-widget.c:944:26: error: un
On Wed, May 17, 2017 at 03:44:48AM -0400, Frediano Ziglio wrote:
> If these 2 hits you are going to have a message for every single pixel
> in the image, potentially millions.
> I'm still convinced, like in this case, that if we are sure that data
> should be aligned no check and warning should be
From: Christophe de Dinechin
On macOS, neither of the two cases implemented in set_mouse_accel applies.
We get the following eror message:
CC spice-widget.lo
spice-widget.c:944:26: error: unused variable 'd' [-Werror,-Wunused-variable]
SpiceDisplayPrivate *d = display->priv;
Signed-
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
configure.ac | 15 +++
1 file changed, 15 insertions(+)
diff --git a/configure.ac b/configure.ac
index ff00d73..62acafc 100644
--- a/configure.ac
+++ b/configure.ac
@@ -62,6 +62,18 @@ esac
AC_MSG_RESULT([$os_wi
From: Christophe de Dinechin
Without #include , calls to snprintf in the file
cause a warning. The file is left aside on purpose,
since src/usbutil.c may be compiled on Windows where this
file does not exist.
Signed-off-by: Christophe de Dinechin
---
src/usbutil.c | 2 +-
1 file changed, 1 in
From: Christophe de Dinechin
For example, something like this:
uint8_t *p8;
uint32_t *p32 = (uint32_t *) p8;
generates a warning like this:
spice-channel.c:1350:10: error: cast from 'uint8_t *' (aka 'unsigned char *')
to
'uint32_t *' (aka 'unsigned int *') increases required al
From: Christophe de Dinechin
This patch set contains various fixes that repair macOS builds for
spice-gtk (and presumably clang builds as a side effect), notably:
- Fixes for clang-specific warnings, notably on alignment
- Addition of macOS detection in configure script
- A couple minor portabli
I was pointed to the spice-space page by someone after discussing problems with
VNC. I was under the impression spice only worked with KVM, I am working with
an ESXI based VM environment though and looking for a promising VDI solution.
Is it possible to use spice in this set up?
>
> Hi,
>
> On Tue, May 16, 2017 at 12:29:16PM -0400, Frediano Ziglio wrote:
> > My script says (not checked):
>
> Can you share it? :)
>
This is the spice-server version
https://cgit.freedesktop.org/~fziglio/script-utils/tree/spice-server/unused.pl.
It's quite manual at the moment, I usually
>
> From: Christophe de Dinechin
>
> On macOS, neither of the two cases implemented in set_mouse_accel applies.
> We get the following eror message:
>
> CC spice-widget.lo
> spice-widget.c:944:26: error: unused variable 'd' [-Werror,-Wunused-variable]
> SpiceDisplayPrivate *d = disp
>
> From: Christophe de Dinechin
>
> Without #include , calls to snprintf in the file
> cause a warning. The file is left aside on purpose,
> since src/usbutil.c may be compiled on Windows where this
> file does not exist.
>
> Signed-off-by: Christophe de Dinechin
Acked-by: Frediano Ziglio
>
> From: Christophe de Dinechin
>
> For example, something like this:
> uint8_t *p8;
> uint32_t *p32 = (uint32_t *) p8;
>
> generates a warning like this:
> spice-channel.c:1350:10: error: cast from 'uint8_t *' (aka 'unsigned char
> *') to
> 'uint32_t *' (aka 'unsigned int *
On Wed, 2017-05-17 at 07:08 +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> Signed-off-by: Christophe de Dinechin
> ---
> configure.ac | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index 74b5811..ecab365 100644
>
On Wed, May 17, 2017 at 07:08:25AM +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> Signed-off-by: Christophe de Dinechin
> ---
> configure.ac | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index 74b5811..ecab365 10
On Wed, May 17, 2017 at 07:08:26AM +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> Signed-off-by: Christophe de Dinechin
> ---
> configure.ac| 3 ++-
> src/channel-cursor.c| 6 +++---
> src/channel-display-mjpeg.c | 2 +-
> src/continuation.h
>
> From: Christophe de Dinechin
>
> Signed-off-by: Christophe de Dinechin
Lot of hunks in this patch should be merged in previous patches.
Frediano
> ---
> configure.ac| 3 ++-
> src/channel-cursor.c| 6 +++---
> src/channel-display-mjpeg.c | 2 +-
> src/continua
On Wed, 2017-05-17 at 07:08 +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> On macOS, neither of the two cases implemented in set_mouse_accel
> applies.
hmm, it should be on wayland too.
> We get the following eror message:
>
> CC spice-widget.lo
> spice-widget.
Ack
On Tue, 2017-05-16 at 19:21 +0200, Victor Toso wrote:
> From: Victor Toso
>
> If we pass -X command line option which disables
> console-kit/systemd-logind integration, we will have the following
> critical being issued:
>
> CRITICAL **: session_info_is_user: assertion 'si != NULL' failed
42 matches
Mail list logo
