Re: [Spice-devel] [PATCH] download: Add x11spice

2017-05-04 Thread Jeremy White
On 04/25/2017 08:56 AM, Victor Toso wrote: > On Tue, Apr 25, 2017 at 08:18:53AM -0500, Jeremy White wrote: >> On 04/25/2017 04:40 AM, Victor Toso wrote: >>> Hey, >>> >>> On Mon, Apr 24, 2017 at 06:40:22PM +0300, Snir Sheriber wrote: --- Wouldn't be useful to have x11spice on the download page

[Spice-devel] [PATCH spice-gtk 4/5] display-gst: remove SPICE_GSTVIDEO_AUTO check

2017-05-04 Thread Victor Toso
From: Victor Toso By using this environment variable, we could use decodebin to let GStreamer automatically find the best elements to get the streaming decoded. It was disable by default, in an attempt to have a easy way to test it. Follow up patch will use Playbin to create the pipeline which d

[Spice-devel] [PATCH spice-gtk 2/5] display-gst: include capabilities for h264

2017-05-04 Thread Victor Toso
From: Victor Toso Although the comment in the code says that incomplete GstCaps could trigger errors, this seems to be working fine. Maybe the comment was on 0.10 version? The follow up patch will identify elements in GstRegistry based on GstCaps so this is a necessary change to have. This is a

[Spice-devel] [PATCH spice-gtk 3/5] display-gst: check GstRegistry for decoding elements

2017-05-04 Thread Victor Toso
From: Victor Toso With this patch, we can find all the elements in the registry that are video decoders which can handle the predefined GstCaps. Main benefits are: - We don't rely on predefined list of GstElements. We don't need to update them; - debugging: It does help to know what the regist

[Spice-devel] [PATCH spice-gtk 1/5] display-gst: move "caps=" from struct to pipeline

2017-05-04 Thread Victor Toso
From: Victor Toso This way we have a map of the necessary GstCaps to a given SPICE_VIDEO_CODEC_TYPE. This patch is also a preparatory patch to: - Identify which GstElements in GstRegistry can handle this GstCaps - Use Playbin as wrapper to all elements beside GstAppSrc and GstAppSink. In thi

[Spice-devel] [PATCH spice-gtk 5/5] display-gst: Use Playbin for GStreamer 1.9.0 onwards

2017-05-04 Thread Victor Toso
From: Victor Toso The Playbin can provide the full pipeline which reduces the overall maintenance in the code as we don't need to track which decoder can work with our stream type. We need to maintain the GstCaps per SPICE_VIDEO_CODEC_TYPE in order to tell Playbin the type of data we expect. Thi

[Spice-devel] [PATCH spice-gtk 0/5] Always use Playbin to create the pipeline

2017-05-04 Thread Victor Toso
From: Victor Toso Hi, First time using git-publish [0], sorry if anything goes wrong :) [0] https://github.com/stefanha/git-publish The main goal for this series is to have streaming working with hardware accelerated video decoding whenever is possible. The best way to achieve that is to let

Re: [Spice-devel] [PATCH spice-vdagent] file-xfer: Check free space before file transfer

2017-05-04 Thread Victor Toso
Hi, On Wed, May 03, 2017 at 04:27:30PM +0200, Jakub Janků wrote: > Add function get_free_space_available that retrieves amount of free > space in the given directory. The statvfs may fail even when there's > enough free space (e.g. when not supported by system), in this case > return G_MAXUINT64 s

Re: [Spice-devel] [PATCH spice-protocol] agent: Add support for reporting on free space

2017-05-04 Thread Victor Toso
Hi, On Wed, May 03, 2017 at 04:28:36PM +0200, Jakub Janků wrote: > Agent can send VDAgentFileXferStatusMessage with result > VD_AGENT_FILE_XFER_STATUS_NOT_ENOUGH_SPACE to indicate lack of free > space. This enables more detailed error reporting, so the user knows > why the file transfer has failed

Re: [Spice-devel] [PATCH spice-vdagent v2] vdagentd: Allow to compile without session info

2017-05-04 Thread Victor Toso
Hi, On Thu, May 04, 2017 at 11:52:25AM +0200, Pavel Grunt wrote: > Add a dummy implementation of session_info_session_is_locked > > configure supports --with-session-info=none, however the build fails: > src_spice_vdagentd-vdagentd.o: In function `do_client_file_xfer': > src/vdagentd/vdagentd.c:

[Spice-devel] [PATCH spice-vdagent v2] vdagentd: Allow to compile without session info

2017-05-04 Thread Pavel Grunt
Add a dummy implementation of session_info_session_is_locked configure supports --with-session-info=none, however the build fails: src_spice_vdagentd-vdagentd.o: In function `do_client_file_xfer': src/vdagentd/vdagentd.c:336: undefined reference to `session_info_

[Spice-devel] [PATCH spice-vdagent] vdagentd: Allow to compile without session info

2017-05-04 Thread Pavel Grunt
configure supports --with-session-info=none, however the build fails: src_spice_vdagentd-vdagentd.o: In function `do_client_file_xfer': src/vdagentd/vdagentd.c:336: undefined reference to `session_info_session_is_locked' --- src/vdagentd/vdagentd.c | 2 ++ 1 file