Re: [Spice-devel] [PATCH win-vdagent] Support file transfer for existing files

2017-04-26 Thread Frediano Ziglio
> > Previously, if the user attempted to transfer a file that had the same > name as a file that already exists on the guest, we would just fail the > transfer. This patch tries to match the behavior of the linux vdagent > where we try to append an integer onto the name of the new file to make > i

Re: [Spice-devel] [PATCH v2 6/6] sound: don't store client in SndChannel

2017-04-26 Thread Jonathon Jongsma
On Wed, 2017-04-26 at 06:33 -0400, Frediano Ziglio wrote: > > > > The base RedChannel already keeps a list of channel clients, so > > there's > > no need for the SndChannel to also keep track of the client itself. > > > > Since the SndChannel only supports a single client (whereas other > > chann

[Spice-devel] [PATCH win-vdagent] Support file transfer for existing files

2017-04-26 Thread Jonathon Jongsma
Previously, if the user attempted to transfer a file that had the same name as a file that already exists on the guest, we would just fail the transfer. This patch tries to match the behavior of the linux vdagent where we try to append an integer onto the name of the new file to make it unique. For

Re: [Spice-devel] [spice-server 3/3] Remove unneeded red_channel_client_is_blocked() call

2017-04-26 Thread Jonathon Jongsma
On Wed, 2017-04-26 at 18:07 +0200, Christophe Fergeau wrote: > Hey, > > On Tue, Apr 11, 2017 at 11:45:15AM -0500, Jonathon Jongsma wrote: > > On Tue, 2017-04-11 at 11:58 +0200, Christophe Fergeau wrote: > > > red_channel_client_msg_sent() always clears the > > > rcc->priv->send_data.blocked flag.

Re: [Spice-devel] [PATCH spice-server] sound: Use bool type coherently

2017-04-26 Thread David Jaša
On Wed, 2017-04-19 at 16:51 +0100, Frediano Ziglio wrote: > Many function already used bool as boolean type. > Change last gboolean occurrencies and values. Probably already merged, but: "occurrences" > > Signed-off-by: Frediano Ziglio > --- >  server/sound.c | 70 +-

Re: [Spice-devel] [spice-server 0/6] Don't expose non-public RedCharDeviceWriteBuffer members

2017-04-26 Thread Christophe Fergeau
On Tue, Apr 11, 2017 at 12:14:39PM +0200, Christophe Fergeau wrote: > This patch series is very straightforward, patch count is quite misleading. > Main goal was to hide the RedCharDeviceWriteBuffer members which were exposed > in a public header, but only used in char-device.c Ping? I'd prefer to

Re: [Spice-devel] [spice-server 3/3] Remove unneeded red_channel_client_is_blocked() call

2017-04-26 Thread Christophe Fergeau
Hey, On Tue, Apr 11, 2017 at 11:45:15AM -0500, Jonathon Jongsma wrote: > On Tue, 2017-04-11 at 11:58 +0200, Christophe Fergeau wrote: > > red_channel_client_msg_sent() always clears the > > rcc->priv->send_data.blocked flag. Hower, towards the end of it, > > I think the description above is just

Re: [Spice-devel] [RFC qxl-wddm-dod 0/3] Synchronization of display mode change and pushing drawables

2017-04-26 Thread Frediano Ziglio
The warning is mainly there to notify the guest is sending commands for a not existing surface. This should not create issues unless the surface is used as source for other commands. The warning was removed as this allows the guest to fill server logs and some drivers send some spurious comma

Re: [Spice-devel] USB redirection on W10 does not work (USB2 and USB3)

2017-04-26 Thread Radek Duda
I have problems of detecting USB3 devices in Win guests as well: https://bugzilla.redhat.com/show_bug.cgi?id=1444003 On Wed, Apr 26, 2017 at 9:10 AM, Snir Sheriber wrote: > Hi, > > On 04/26/2017 01:26 AM, Oscar Segarra wrote: > > Hi Pavel, > > With updated documentation I have configured the USB

Re: [Spice-devel] [PATCH v2 6/6] sound: don't store client in SndChannel

2017-04-26 Thread Frediano Ziglio
> > The base RedChannel already keeps a list of channel clients, so there's > no need for the SndChannel to also keep track of the client itself. > > Since the SndChannel only supports a single client (whereas other > channels may have some partial support for multiple clients), I've > provided a

Re: [Spice-devel] [PATCH] download: Add x11spice

2017-04-26 Thread Snir Sheriber
On 04/25/2017 04:56 PM, Victor Toso wrote: On Tue, Apr 25, 2017 at 08:18:53AM -0500, Jeremy White wrote: On 04/25/2017 04:40 AM, Victor Toso wrote: Hey, On Mon, Apr 24, 2017 at 06:40:22PM +0300, Snir Sheriber wrote: --- Wouldn't be useful to have x11spice on the download page too? The only

Re: [Spice-devel] USB redirection on W10 does not work (USB2 and USB3)

2017-04-26 Thread Snir Sheriber
Hi, On 04/26/2017 01:26 AM, Oscar Segarra wrote: Hi Pavel, With updated documentation I have configured the USB3 support (nec-xhci) After setting this configuration, my USB2 pen drive has begun working on my Windows 10 guest. Nevertheless, the USB3 is not working yet. Does both xhci & usb3