Re: [Spice-devel] USB redirection on W10 does not work (USB2 and USB3)

2017-04-25 Thread Oscar Segarra
Hi Pavel, With updated documentation I have configured the USB3 support (nec-xhci) After setting this configuration, my USB2 pen drive has begun working on my Windows 10 guest. Nevertheless, the USB3 is not working yet. 32104 ?Sl47:42 /usr/libexec/qemu-kvm -name one-62 -S -machine p

Re: [Spice-devel] USB redirection on W10 does not work (USB2 and USB3)

2017-04-25 Thread Pavel Grunt
On Tue, 2017-04-25 at 20:12 +0300, Yuri Benditovich wrote: > It looks like piix3-usb-uhci is full-speed controller. In could be > problematic to redirect high-speed devices to it. > Please try it with addition of ich9-ehci, for example (for USB2). > For USB3 you will need xhci model. > See also htt

Re: [Spice-devel] USB redirection on W10 does not work (USB2 and USB3)

2017-04-25 Thread Oscar Segarra
Maybe the best approach is changing all my uhci controllers for xhdi controllers. What do you think? Thanks a lot El 25 abr. 2017 7:12 p. m., "Yuri Benditovich" escribió: It looks like piix3-usb-uhci is full-speed controller. In could be problematic to redirect high-speed devices to it. Please

Re: [Spice-devel] USB redirection on W10 does not work (USB2 and USB3)

2017-04-25 Thread Yuri Benditovich
It looks like piix3-usb-uhci is full-speed controller. In could be problematic to redirect high-speed devices to it. Please try it with addition of ich9-ehci, for example (for USB2). For USB3 you will need xhci model. See also https://people.freedesktop.org/~teuf/spice-doc/html/ch02s06.html Thanks

Re: [Spice-devel] USB redirection on W10 does not work (USB2 and USB3)

2017-04-25 Thread Oscar Segarra
Hi, ps ax | grep qemu 11538 ?Sl 2:56 /usr/libexec/qemu-kvm -name one-58 -S -machine pc-i440fx-rhel7.0.0,accel=kvm,usb=off -cpu SandyBridge -m 2048 -realtime mlock=off -smp 2,sockets=2,cores=1,threads=1 -uuid 601a0119-1052-40e0-aa68-a1bbd0d78fce -no-user-config -nodefaults -chardev s

Re: [Spice-devel] USB redirection on W10 does not work (USB2 and USB3)

2017-04-25 Thread Yuri Benditovich
Sorry for unclear request. Please run on the host "ps ax | grep qemu", the output gives us the exact command line of qemu instance which creates guest system. This is what I asked for. Thanks On Tue, Apr 25, 2017 at 7:09 PM, Jonathon Jongsma wrote: > On Tue, 2017-04-25 at 18:03 +0200, Oscar Seg

Re: [Spice-devel] USB redirection on W10 does not work (USB2 and USB3)

2017-04-25 Thread Jonathon Jongsma
On Tue, 2017-04-25 at 18:03 +0200, Oscar Segarra wrote: > My guest system is a Windows 10... I think generic USB2 driver should > be installed by default... > > As it is a Windows guest... there is no "ps" command... :S The 'ps' command should be run on the host, not the guest. > > Thanks a lo

Re: [Spice-devel] USB redirection on W10 does not work (USB2 and USB3)

2017-04-25 Thread Oscar Segarra
My guest system is a Windows 10... I think generic USB2 driver should be installed by default... As it is a Windows guest... there is no "ps" command... :S Thanks a lot. Th 2017-04-25 18:00 GMT+02:00 Yuri Benditovich : > Hi Oscar, > > Can you please also submit to the bug exact qemu command-li

Re: [Spice-devel] USB redirection on W10 does not work (USB2 and USB3)

2017-04-25 Thread Yuri Benditovich
Hi Oscar, Can you please also submit to the bug exact qemu command-line for Win10 guest, for example output of "ps ax | grep qemu". Is it possible that your guest system does not have USB2 controller? Thanks Yuri On Tue, Apr 25, 2017 at 6:40 PM, Oscar Segarra wrote: > Sorry but I don't know ho

[Spice-devel] [PATCH v3] sound: Remove dead code in client constructors

2017-04-25 Thread Jonathon Jongsma
When a new PlaybackChannelClient or RecordChannelClient is created, there are several places where we make decisions based on whether the client is active or not. But these checks are done before the 'active' flag is ever set, so this code is effectively dead. This has been the case since commit 6f

Re: [Spice-devel] [PATCH v2 0/6] sound cleanups

2017-04-25 Thread Jonathon Jongsma
On Tue, 2017-04-25 at 12:04 +0200, Christophe Fergeau wrote: > On Tue, Apr 25, 2017 at 09:39:26AM +0200, Pavel Grunt wrote: > > Hi Jonathon, > > > > I don't see a benefit of removing ("inlining") on_new_{playback, > > record}_channel_client. I actually prefer shorter functions even if > > it > > m

Re: [Spice-devel] [client v2 4/5] streaming: Remove the video decoder's dependency on SpiceMsgIn messages

2017-04-25 Thread Christophe Fergeau
Still makes sense to me, though I'd appreciate another pair of eye on this one. Acked-by: Christophe Fergeau Christophe On Thu, Apr 06, 2017 at 04:02:53PM +0200, Francois Gouget wrote: > This improves the separation between networking and the video decoding > components. > It also makes it eas

Re: [Spice-devel] USB redirection on W10 does not work (USB2 and USB3)

2017-04-25 Thread Oscar Segarra
Sorry but I don't know how to do it... I have installed vistual studio in guest and the WDK... but I don't know how to check it... Is there any detailed step by step document that I can follow to debug the driver? Thanks a lot. 2017-04-25 17:37 GMT+02:00 Victor Toso : > Hi, > > On Mon, Apr 24,

Re: [Spice-devel] USB redirection on W10 does not work (USB2 and USB3)

2017-04-25 Thread Victor Toso
Hi, On Mon, Apr 24, 2017 at 11:34:07PM +0200, Oscar Segarra wrote: > Hi, bug opened! Bug is: https://bugs.freedesktop.org/show_bug.cgi?id=100778 Debug says: GSpice-DEBUG: src/usbdk_api.c:62 UsbDk driver is installed. GSpice-DEBUG: src/usbdk_api.c:86 Loading UsbDk API DLL GSpice-DEBUG: src/usb-d

Re: [Spice-devel] [PATCH v2 6/6] sound: don't store client in SndChannel

2017-04-25 Thread Pavel Grunt
On Mon, 2017-04-24 at 12:09 -0500, Jonathon Jongsma wrote: > The base RedChannel already keeps a list of channel clients, so > there's > no need for the SndChannel to also keep track of the client itself. > > Since the SndChannel only supports a single client (whereas other > channels may have som

Re: [Spice-devel] [PATCH] download: Add x11spice

2017-04-25 Thread Victor Toso
On Tue, Apr 25, 2017 at 08:18:53AM -0500, Jeremy White wrote: > On 04/25/2017 04:40 AM, Victor Toso wrote: > > Hey, > > > > On Mon, Apr 24, 2017 at 06:40:22PM +0300, Snir Sheriber wrote: > > > --- > > > Wouldn't be useful to have x11spice on the download page too? > > The only difference I can spot

Re: [Spice-devel] [PATCH v2 3/6] sound: Remove dead code in client constructors

2017-04-25 Thread Jonathon Jongsma
On Tue, 2017-04-25 at 14:49 +0200, Christophe Fergeau wrote: > On Mon, Apr 24, 2017 at 12:09:38PM -0500, Jonathon Jongsma wrote: > > When a new PlaybackChannelClient or RecordChannelClient is created, > > there are several places where we make decisions based on whether > > the > > client is active

Re: [Spice-devel] [PATCH] download: Add x11spice

2017-04-25 Thread Jeremy White
On 04/25/2017 04:40 AM, Victor Toso wrote: Hey, On Mon, Apr 24, 2017 at 06:40:22PM +0300, Snir Sheriber wrote: --- Wouldn't be useful to have x11spice on the download page too? The only difference I can spot is that the other packages are versioned and released. But I agree its nice to add a r

Re: [Spice-devel] [PATCH spice-gtk] Remove redundant space from error message

2017-04-25 Thread Victor Toso
Hi, On Tue, Apr 25, 2017 at 04:24:25PM +0300, Snir Sheriber wrote: > --- > As asked in rhbz#1365736 > --- > src/spice-channel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/spice-channel.c b/src/spice-channel.c > index e42e560..3b6231e 100644 > --- a/src/spice-cha

[Spice-devel] [PATCH spice-gtk] Remove redundant space from error message

2017-04-25 Thread Snir Sheriber
--- As asked in rhbz#1365736 --- src/spice-channel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice-channel.c b/src/spice-channel.c index e42e560..3b6231e 100644 --- a/src/spice-channel.c +++ b/src/spice-channel.c @@ -1203,7 +1203,7 @@ static void spice_channel_fail

Re: [Spice-devel] [PATCH v2 3/6] sound: Remove dead code in client constructors

2017-04-25 Thread Christophe Fergeau
On Mon, Apr 24, 2017 at 12:09:38PM -0500, Jonathon Jongsma wrote: > When a new PlaybackChannelClient or RecordChannelClient is created, > there are several places where we make decisions based on whether the > client is active or not. But these checks are done before the 'active' > flag is ever set

Re: [Spice-devel] [PATCH v2 6/6] sound: don't store client in SndChannel

2017-04-25 Thread Christophe Fergeau
On Mon, Apr 24, 2017 at 12:09:41PM -0500, Jonathon Jongsma wrote: > The base RedChannel already keeps a list of channel clients, so there's > no need for the SndChannel to also keep track of the client itself. > > Since the SndChannel only supports a single client (whereas other > channels may hav

Re: [Spice-devel] [PATCH v2 0/6] sound cleanups

2017-04-25 Thread Christophe Fergeau
On Tue, Apr 25, 2017 at 09:39:26AM +0200, Pavel Grunt wrote: > Hi Jonathon, > > I don't see a benefit of removing ("inlining") on_new_{playback, > record}_channel_client. I actually prefer shorter functions even if it > means that some other function is called only once. It is also > recommended i

Re: [Spice-devel] [PATCH] download: Add x11spice

2017-04-25 Thread Victor Toso
Hey, On Mon, Apr 24, 2017 at 06:40:22PM +0300, Snir Sheriber wrote: > --- > Wouldn't be useful to have x11spice on the download page too? The only difference I can spot is that the other packages are versioned and released. But I agree its nice to add a reference somewhere to it. > --- > downlo

Re: [Spice-devel] [PATCH v2 5/6] sound: Change snd_playback_start/snd_record_start

2017-04-25 Thread Pavel Grunt
On Mon, 2017-04-24 at 12:09 -0500, Jonathon Jongsma wrote: > The content of these functions alsmost exclusively deals with > channel client functionality except one line where the channel's > active > state is set to TRUE. > s/alsmost/almost/ > These functions are called in two different places.

Re: [Spice-devel] [PATCH v2 4/6] sound: use GList for global list of sound channels

2017-04-25 Thread Pavel Grunt
Ack, Pavel On Mon, 2017-04-24 at 12:09 -0500, Jonathon Jongsma wrote: > Instead of putting a 'next' link within the channel structure > itself, > just use a generic GList structure to keep a list of active sound > channels. > --- >  server/sound.c | 26 +- >  1 file changed,

Re: [Spice-devel] [PATCH v2 0/6] sound cleanups

2017-04-25 Thread Pavel Grunt
Hi Jonathon, I don't see a benefit of removing ("inlining") on_new_{playback, record}_channel_client. I actually prefer shorter functions even if it means that some other function is called only once. It is also recommended in the style document: https://www.spice-space.org/spice-project-coding-st