Re: [Spice-devel] [RFC PATH 0/3] Experimental patch to send video stream from guest to server

2017-04-24 Thread Jonathon Jongsma
FYI: the email subject doesn't indicate which repository this applies to. Looks like spice-protocol. Also, PATH -> PATCH. On Wed, 2017-04-19 at 16:26 +0100, Frediano Ziglio wrote: > This will be used to stream from device pass through. > > Frediano Ziglio (3): >   Add protocol to send streams to

Re: [Spice-devel] [RFC PATCH 02/15] stream-device: Add device to handle streaming

2017-04-24 Thread Jonathon Jongsma
On Wed, 2017-04-19 at 16:31 +0100, Frediano Ziglio wrote: > Add a stub device in guest. > The aim of this device is make possible for the guest to send > a stream through a DisplayChannel (in the sense of protocol > channel). > This stub allows the guest to send some data and you can > see some deb

Re: [Spice-devel] USB redirection on W10 does not work (USB2 and USB3)

2017-04-24 Thread Oscar Segarra
Hi, bug opened! Thanks a lot! 2017-04-24 8:10 GMT+02:00 Victor Toso : > Hi, > > On Mon, Apr 24, 2017 at 07:47:35AM +0200, Oscar Segarra wrote: > > Hi Victor, > > > > thanks for your quick answer: > > > > Can you confirm that you are using virt-viewer 5.0? > > Yes > > > > Which kind of device are

Re: [Spice-devel] [RFC qxl-wddm-dod 0/3] Synchronization of display mode change and pushing drawables

2017-04-24 Thread Yuri Benditovich
It would be very helpful to receive a feedback regarding this problem, especially: - Do you see the reason why this erroneous flow on 'old' spice server (0.12.4, for example) can lead to significant device memory leak. - If yes: Is spice server 0.12.4 still actual in the field? - The warning was re

[Spice-devel] [PATCH v2 6/6] sound: don't store client in SndChannel

2017-04-24 Thread Jonathon Jongsma
The base RedChannel already keeps a list of channel clients, so there's no need for the SndChannel to also keep track of the client itself. Since the SndChannel only supports a single client (whereas other channels may have some partial support for multiple clients), I've provided a convenience fu

[Spice-devel] [PATCH v2 0/6] sound cleanups

2017-04-24 Thread Jonathon Jongsma
This is an updated and expanded series of patches cleaning up some stuff related to the sound channels. The first three were included in the first patch series and have only minor changes from Frediano's review. The 4th patch from the first series ("remname 'connection' to 'client'") was removed an

[Spice-devel] [PATCH v2 5/6] sound: Change snd_playback_start/snd_record_start

2017-04-24 Thread Jonathon Jongsma
The content of these functions alsmost exclusively deals with channel client functionality except one line where the channel's active state is set to TRUE. These functions are called in two different places. The first place is from the public API spice_server_record_start() and spice_server_playb

[Spice-devel] [PATCH v2 4/6] sound: use GList for global list of sound channels

2017-04-24 Thread Jonathon Jongsma
Instead of putting a 'next' link within the channel structure itself, just use a generic GList structure to keep a list of active sound channels. --- server/sound.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/server/sound.c b/server/sound.c index

[Spice-devel] [PATCH v2 2/6] sound: Remove on_new_record_channel_client()

2017-04-24 Thread Jonathon Jongsma
It is only called from the constructor, so move all of the code into that function. Signed-off-by: Jonathon Jongsma --- server/sound.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/server/sound.c b/server/sound.c index 0e48255..3eb6a03 100644 ---

[Spice-devel] [PATCH v2 1/6] sound: Remove on_new_playback_channel_client()

2017-04-24 Thread Jonathon Jongsma
This function is only called from the constructor, so move all of that code into the constructor. Signed-off-by: Jonathon Jongsma --- server/sound.c | 48 1 file changed, 20 insertions(+), 28 deletions(-) diff --git a/server/sound.c b/server/soun

[Spice-devel] [PATCH v2 3/6] sound: Remove dead code in client constructors

2017-04-24 Thread Jonathon Jongsma
When a new PlaybackChannelClient or RecordChannelClient is created, there are several places where we make decisions based on whether the client is active or not. But these checks are done before the 'active' flag is ever set, so this code is effectively dead. This has been the case since the very

Re: [Spice-devel] [PATCH 3/4] sound: Remove dead code in client constructors

2017-04-24 Thread Jonathon Jongsma
On Fri, 2017-04-21 at 05:10 -0400, Frediano Ziglio wrote: > > > > When a new PlaybackChannelClient or RecordChannelClient is created, > > there are several places where we make decisions based on whether > > the > > client is active or not. But these checks are done before the > > 'active' > > fla

Re: [Spice-devel] [PATCH 3/4] sound: Remove dead code in client constructors

2017-04-24 Thread Jonathon Jongsma
On Fri, 2017-04-21 at 05:10 -0400, Frediano Ziglio wrote: > > > > When a new PlaybackChannelClient or RecordChannelClient is created, > > there are several places where we make decisions based on whether > > the > > client is active or not. But these checks are done before the > > 'active' > > fla

Re: [Spice-devel] [client v2 5/5] streaming: Separate the network code from the display_stream management

2017-04-24 Thread Christophe Fergeau
On Thu, Apr 06, 2017 at 04:03:01PM +0200, Francois Gouget wrote: > This makes it easier to reuse display_streams for other types of > video streams should the need arise. > > Signed-off-by: Francois Gouget > --- > src/channel-display.c | 110 > --

Re: [Spice-devel] [client v2 3/5] streaming: Rename SpiceFrame to SpiceGstFrame in the GStreamer decoder

2017-04-24 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Thu, Apr 06, 2017 at 04:02:30PM +0200, Francois Gouget wrote: > This emphasizes that this structure is specific to the GStreamer > decoder. > > Signed-off-by: Francois Gouget > --- > > I also removed the underscore in the SpiceFrame struct. It's not used > any

Re: [Spice-devel] [client v2 2/5] streaming: Move SpiceMsgIn parsing to display_handle_stream_create()

2017-04-24 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Thu, Apr 06, 2017 at 04:00:40PM +0200, Francois Gouget wrote: > This regroups all the parsing in one place and makes the rest of the > display_stream code independent from the network messaging details. > > Signed-off-by: Francois Gouget > --- > src/channel-dis

[Spice-devel] [PATCH] download: Add x11spice

2017-04-24 Thread Snir Sheriber
--- Wouldn't be useful to have x11spice on the download page too? --- download.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/download.rst b/download.rst index c498744..b54f00e 100644 --- a/download.rst +++ b/download.rst @@ -36,6 +36,7 @@ Download .. _usbredir-0.7.1.tar.bz2: http:

Re: [Spice-devel] qxl_ram_set_dirty: Assertion `offset < qxl-vga.vram_size' failed.

2017-04-24 Thread Frediano Ziglio
Possibly related to https://bugs.launchpad.net/qemu/+bug/1635339 Frediano - Original Message - > From: "Mr.Pine" > To: spice-devel@lists.freedesktop.org > Sent: Monday, April 24, 2017 10:17:33 AM > Subject: [Spice-devel] qxl_ram_set_dirty: Assertion `offset < > qxl-vga.vram_size' fail

[Spice-devel] qxl_ram_set_dirty: Assertion `offset < qxl-vga.vram_size' failed.

2017-04-24 Thread Mr.Pine
Hi I got this error msg when try to start my vm with qxl display driver ... (vm start until spice vdagent wants to auto resize screen) This error raised when I enabled huge page on my host. I want to use huge page as back-end for my win10-64 . /builddir/build/BUILD/qemu-kvm-0.12.1.2/hw/qxl.c:442:

Re: [Spice-devel] [PATCH spice-server v2] build-sys: Do not abort on warnings

2017-04-24 Thread Christophe Fergeau
On Fri, Apr 21, 2017 at 12:54:39PM +0100, Frediano Ziglio wrote: > This causes some tests to fail when run on Valgrind. > In the code warnings are not supposed to cause crashes. > This change avoid overriding entirely G_DEBUG definition but > just append gc-friendly which make Valgrind more effecti