On Fri, 2017-04-21 at 12:54 +0100, Frediano Ziglio wrote:
> This causes some tests to fail when run on Valgrind.
> In the code warnings are not supposed to cause crashes.
> This change avoid overriding entirely G_DEBUG definition but
> just append gc-friendly which make Valgrind more effective.
>
This causes some tests to fail when run on Valgrind.
In the code warnings are not supposed to cause crashes.
This change avoid overriding entirely G_DEBUG definition but
just append gc-friendly which make Valgrind more effective.
Signed-off-by: Frediano Ziglio
---
m4/ax_valgrind_check.m4 | 2 +-
On Fri, 2017-04-21 at 12:00 +0100, Frediano Ziglio wrote:
> This causes some tests to fail when run on Valgrind.
> In the code warnings are not supposed to cause crashes.
And criticals ? And the fact that it ignores previously set G_DEBUG
etc... It should be submitted upstream (autoconf-archive)
P
This causes some tests to fail when run on Valgrind.
In the code warnings are not supposed to cause crashes.
Signed-off-by: Frediano Ziglio
---
m4/ax_valgrind_check.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/m4/ax_valgrind_check.m4 b/m4/ax_valgrind_check.m4
index 1c1c
>
> ---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 66b9a17c8..9ebcfd04f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -82,7 +82,7 @@ if test "x$enable_gstreamer" != "xno" && test
> "x$enable_gstreamer" != "x
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 66b9a17c8..9ebcfd04f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -82,7 +82,7 @@ if test "x$enable_gstreamer" != "xno" && test
"x$enable_gstreamer" != "x0.10"; t
[ena
>
> Since this field holds the SndChannelClient, rename this variable
> 'client' to make the code a bit easier to understand.
>
> Signed-off-by: Jonathon Jongsma
Acked
> ---
> server/sound.c | 56
> 1 file changed, 28 insertions(+), 28
>
> When a new PlaybackChannelClient or RecordChannelClient is created,
> there are several places where we make decisions based on whether the
> client is active or not. But these checks are done before the 'active'
> flag is ever set, so this code is effectively dead. This has been the
> case si
>
> Fixes `make syntax-check`
>
> https://gitlab.com/spice/spice/builds/14346626
> ---
> server/display-channel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/display-channel.c b/server/display-channel.c
> index 5f4caf925..bfff413b8 100644
> --- a/server/disp
Fixes `make syntax-check`
https://gitlab.com/spice/spice/builds/14346626
---
server/display-channel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/display-channel.c b/server/display-channel.c
index 5f4caf925..bfff413b8 100644
--- a/server/display-channel.c
+++ b/serv
>
> It is only called from the constructor, so move all of the code into
> that function.
>
> Signed-off-by: Jonathon Jongsma
> ---
> server/sound.c | 23 +--
> 1 file changed, 9 insertions(+), 14 deletions(-)
>
> diff --git a/server/sound.c b/server/sound.c
> index c24911f
>
> This function is only called from the constructor, so move all of that
> code into the constructor.
>
> Signed-off-by: Jonathon Jongsma
> ---
> server/sound.c | 47 ---
> 1 file changed, 20 insertions(+), 27 deletions(-)
>
> diff --git a/server/s
12 matches
Mail list logo
