Re: [Spice-devel] [spice-gtk v2 1/2] Fix possible multimedia time overflow

> On 16 Mar 2017, at 11:49, Marc-André Lureau > wrote: > > Hi > > - Original Message - >> The multimedia time can easily overflow as is encoded in an >> unsigned 32 bit and have a unit of milliseconds so it wrap >> up every 49 days. Use some math that allow th

Re: [Spice-devel] [spice-gtk 1/2] Fix possible multimedia time overflow

> > On 16 Mar 2017, at 11:56, Frediano Ziglio < fzig...@redhat.com > wrote: > > > > - Original Message - > > > > > > > > Hi > > > > > > > > > > > > > > > - Original Message - > > > > > > > > > > > > > > > > The multimedia time can easily overflow as is encoded in an >

Re: [Spice-devel] KVM-SPICE: View youtube videos smoothly

Hi, Bug open at: https://bugs.freedesktop.org/show_bug.cgi?id=100251 Thanks a lot! 2017-03-17 9:55 GMT+01:00 Pavel Grunt : > Hi Oscar, > > I have a guess but I really need more info and this is going off > topic, can you please open a bug > https://bugs.freedesktop.org/enter_bug.cgi?product=S

Re: [Spice-devel] [spice-server v2 2/3] tests: Port test-qxl-parsing to GTest

On Thu, 2017-03-16 at 16:10 +0100, Christophe Fergeau wrote: > test-qxl-parsing is really a series of several tests. Porting it to > GTest makes this more obvious. This also has the side-effect of > making > it more friendly to 'make check-valgrind' (which would fail on > SIGALRM, > and on unexpect

[Spice-devel] [PATCH spice] Do not ignore errors

--- I am not an expert on auto* and make, but `-k` should be enough to keep going over all the tests. Example of ci output thanks to this change: https://gitlab.com/xerus/spice/builds/12448734 https://gitlab.com/xerus/spice/commits/valgrind --- m4/ax_valgrind_check.m4 | 2 +- 1 file changed,

Re: [Spice-devel] [spice-server v2 0/3] Add make check-valgrind target

On Fri, 2017-03-17 at 11:52 +0100, Pavel Grunt wrote: > Hi, > > all the tests are failing for me (F26) - probably many false > positives > https://da.gd/XUKa3  Fixed by installing debuginfos > > I tried to add it to our ci: > https://gitlab.com/xerus/spice/builds/12438066 > but it also fails >

Re: [Spice-devel] [spice-gtk 1/2] Fix possible multimedia time overflow

> On 16 Mar 2017, at 11:56, Frediano Ziglio > wrote: > >> >> - Original Message - Hi - Original Message - > The multimedia time can easily overflow as is encoded in an > unsigned 32 bit and have a unit of milliseconds so i

Re: [Spice-devel] [spice-server v2 0/3] Add make check-valgrind target

Hi, all the tests are failing for me (F26) - probably many false positives https://da.gd/XUKa3  I tried to add it to our ci: https://gitlab.com/xerus/spice/builds/12438066 but it also fails On Thu, 2017-03-16 at 16:10 +0100, Christophe Fergeau wrote: > This adds a make check-valgrind target afte

Re: [Spice-devel] [spice-server v2 3/3] build-sys: Add make check-valgrind target

Hi Christophe, the return code is wrong for failing tests. It is always 0. Pavel On Thu, 2017-03-16 at 16:10 +0100, Christophe Fergeau wrote: > This allows to run automatically our test-suite with valgrind to > test > for memory leaks. --- >  Makefile.am |   3 + >  configure.

Re: [Spice-devel] [spice-server v2 1/3] reds-stream: Don't use sendmsg with uninitialized memory

Ack, Pavel On Thu, 2017-03-16 at 16:10 +0100, Christophe Fergeau wrote: > On my 64 bit Fedora 25, CMSG_SPACE() adds 4 bytes of padding after > the > file descriptor in the control data. This causes warnings when ran > under > valgrind as we set msg_controllen to CMSG_SPACE(). > > This commit fill

Re: [Spice-devel] KVM-SPICE: View youtube videos smoothly

Hi Oscar, I have a guess but I really need more info and this is going off topic, can you please open a bug https://bugs.freedesktop.org/enter_bug.cgi?product=Spice&component=spi ce-gtk please provide rpm versions: rpm -q virt-manager spice-gtk3 debug logs domain xml `virsh dumpxml VM` Thanks,

Re: [Spice-devel] KVM-SPICE: View youtube videos smoothly

Hi, I attach logs of virt-manager. I'd like to add that virt-viewer look work correctly. 2017-03-17 9:04 GMT+01:00 Pavel Grunt : > On Fri, 2017-03-17 at 01:40 +0100, Oscar Segarra wrote: > > Hi Pavel, > > > > I have installed the latest nightly build but I have not seen any > > difference to ad

Re: [Spice-devel] KVM-SPICE: View youtube videos smoothly

On Fri, 2017-03-17 at 01:40 +0100, Oscar Segarra wrote: > Hi Pavel,  > > I have installed the latest nightly build but I have not seen any > difference to adjust spice options: > The options to enable streaming are not there, use `virsh edit` as mentioned earlier if the vm is in the user sessi