Re: [Spice-devel] [spice-server 1/2] smartcard: Remove unneeded 'dispose' implementation

> > --- > server/smartcard-channel-client.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/server/smartcard-channel-client.c > b/server/smartcard-channel-client.c > index bfd05bf..05ad49b 100644 > --- a/server/smartcard-channel-client.c > +++ b/server/smartcard-channel-client.c >

[Spice-devel] [spice-server 1/2] smartcard: Remove unneeded 'dispose' implementation

--- server/smartcard-channel-client.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/server/smartcard-channel-client.c b/server/smartcard-channel-client.c index bfd05bf..05ad49b 100644 --- a/server/smartcard-channel-client.c +++ b/server/smartcard-channel-client.c @@ -73,11 +73,6 @@ sta

Re: [Spice-devel] gtk client side timeouts

>> I looked for past discussions on spice-devel; I only readily >> found discussion of the keepalive parameters on the server side, >> and it looks like we take the idle timer down to 10 minutes now, >> from 2 hours. I didn't find discussion of something similar >> client side. >> >> Have we cons

Re: [Spice-devel] [PATCH spice-gtk] spicy: make codec to string a bit safer

Hi - Original Message - > Hi, > > On Mon, Mar 13, 2017 at 08:02:36AM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > Hi Marc-André, > > > > > > On Mon, 2017-03-13 at 07:40 -0400, Marc-André Lureau wrote: > > > > Hi > > > > > > > > - Original Message

Re: [Spice-devel] [spice-gtk v1 1/2] Revert "spicy: improve status label with stream information"

- Original Message - > From: Victor Toso > > This reverts commit 9a7ae78aa94f4eada3fa85e9fd7dfac681aadd6d. > > As we are going to revert 00f56647a97a95 "channel-display: new > stream-video-codec-type property" > > Signed-off-by: Victor Toso ack series, thanks > --- > tools/spicy.c

[Spice-devel] [spice-gtk v1 2/2] Revert "channel-display: new stream-video-codec-type property"

From: Victor Toso This reverts commit 00f56647a97a95342f235ef6d107ac8216aa9e49. As this take no consideration to multiple streams. Signed-off-by: Victor Toso --- src/channel-display.c | 29 - 1 file changed, 29 deletions(-) diff --git a/src/channel-display.c b/src

[Spice-devel] [spice-gtk v1 1/2] Revert "spicy: improve status label with stream information"

From: Victor Toso This reverts commit 9a7ae78aa94f4eada3fa85e9fd7dfac681aadd6d. As we are going to revert 00f56647a97a95 "channel-display: new stream-video-codec-type property" Signed-off-by: Victor Toso --- tools/spicy.c | 43 ++- 1 file changed, 2 ins

Re: [Spice-devel] [PATCH spice-gtk] spicy: make codec to string a bit safer

Hi, On Mon, Mar 13, 2017 at 08:02:36AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > Hi Marc-André, > > > > On Mon, 2017-03-13 at 07:40 -0400, Marc-André Lureau wrote: > > > Hi > > > > > > - Original Message - > > > > Hi > > > > > > > > - Original Message

Re: [Spice-devel] [PATCH spice-gtk] spicy: make codec to string a bit safer

Hi - Original Message - > Hi Marc-André, > > On Mon, 2017-03-13 at 07:40 -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > Hi > > > > > > - Original Message - > > > > Hi, > > > > > > > > On Mon, Mar 13, 2017 at 07:11:02AM -0400, Marc-André Lureau

Re: [Spice-devel] [PATCH spice-gtk] spicy: make codec to string a bit safer

Hi Marc-André, On Mon, 2017-03-13 at 07:40 -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > Hi > > > > - Original Message - > > > Hi, > > > > > > On Mon, Mar 13, 2017 at 07:11:02AM -0400, Marc-André Lureau > > > wrote: > > > > Hi > > > > > > > > - Original

Re: [Spice-devel] [PATCH spice-gtk] spicy: make codec to string a bit safer

Hi - Original Message - > Hi > > - Original Message - > > Hi, > > > > On Mon, Mar 13, 2017 at 07:11:02AM -0400, Marc-André Lureau wrote: > > > Hi > > > > > > - Original Message - > > > > Hi, > > > > > > > > On Mon, Mar 13, 2017 at 07:05:08AM -0400, Frediano Ziglio wrote

Re: [Spice-devel] [PATCH spice-gtk] spicy: make codec to string a bit safer

Hi - Original Message - > Hi, > > On Mon, Mar 13, 2017 at 07:11:02AM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > Hi, > > > > > > On Mon, Mar 13, 2017 at 07:05:08AM -0400, Frediano Ziglio wrote: > > > > > > > > > > From: Marc-André Lureau > > > > >

Re: [Spice-devel] [PATCH spice-gtk] spicy: make codec to string a bit safer

Hi, On Mon, Mar 13, 2017 at 07:11:02AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > Hi, > > > > On Mon, Mar 13, 2017 at 07:05:08AM -0400, Frediano Ziglio wrote: > > > > > > > > From: Marc-André Lureau > > > > > > > > Handle unknown values instead of out-of-array a

Re: [Spice-devel] [spice-gtk v3 2/3] channel-display: new stream-video-codec-type property

Hi, On Mon, Mar 13, 2017 at 07:09:43AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > Hi, > > > > On Mon, Mar 13, 2017 at 10:58:17AM +, Marc-André Lureau wrote: > > > Hi > > > > > > On Thu, Mar 2, 2017 at 2:37 PM Victor Toso wrote: > > > > > > > From: Victor Toso >

Re: [Spice-devel] [PATCH spice-gtk] spicy: make codec to string a bit safer

Hi - Original Message - > Hi, > > On Mon, Mar 13, 2017 at 07:05:08AM -0400, Frediano Ziglio wrote: > > > > > > From: Marc-André Lureau > > > > > > Handle unknown values instead of out-of-array access. > > > > > > Signed-off-by: Marc-André Lureau > > > --- > > > tools/spicy.c | 28 ++

Re: [Spice-devel] [spice-gtk v3 2/3] channel-display: new stream-video-codec-type property

Hi - Original Message - > Hi, > > On Mon, Mar 13, 2017 at 10:58:17AM +, Marc-André Lureau wrote: > > Hi > > > > On Thu, Mar 2, 2017 at 2:37 PM Victor Toso wrote: > > > > > From: Victor Toso > > > > > > This is a per channel-display property that stores and notifies the > > > video

Re: [Spice-devel] [PATCH spice-gtk] spicy: make codec to string a bit safer

Hi, On Mon, Mar 13, 2017 at 07:05:08AM -0400, Frediano Ziglio wrote: > > > > From: Marc-André Lureau > > > > Handle unknown values instead of out-of-array access. > > > > Signed-off-by: Marc-André Lureau > > --- > > tools/spicy.c | 28 +++- > > 1 file changed, 19 inse

Re: [Spice-devel] [PATCH spice-gtk] spicy: make codec to string a bit safer

> > From: Marc-André Lureau > > Handle unknown values instead of out-of-array access. > > Signed-off-by: Marc-André Lureau > --- > tools/spicy.c | 28 +++- > 1 file changed, 19 insertions(+), 9 deletions(-) > > diff --git a/tools/spicy.c b/tools/spicy.c > index a41a1a

Re: [Spice-devel] [spice-gtk v3 2/3] channel-display: new stream-video-codec-type property

Hi, On Mon, Mar 13, 2017 at 10:58:17AM +, Marc-André Lureau wrote: > Hi > > On Thu, Mar 2, 2017 at 2:37 PM Victor Toso wrote: > > > From: Victor Toso > > > > This is a per channel-display property that stores and notifies the > > video-codec type being used if a stream is being used or 0 i

Re: [Spice-devel] [spice-gtk v3 2/3] channel-display: new stream-video-codec-type property

Hi On Thu, Mar 2, 2017 at 2:37 PM Victor Toso wrote: > From: Victor Toso > > This is a per channel-display property that stores and notifies the > video-codec type being used if a stream is being used or 0 if there is > no ongoing stream. > It doesn't handle well multiple streams. I think we s

Re: [Spice-devel] [PATCH spice-gtk] spicy: make codec to string a bit safer

On Mon, Mar 13, 2017 at 02:51:46PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau Acked-by: Victor Toso > > Handle unknown values instead of out-of-array access. > > Signed-off-by: Marc-André Lureau > --- > tools/spicy.c | 28 +++- > 1 file changed

[Spice-devel] [PATCH spice-gtk] spicy: make codec to string a bit safer

From: Marc-André Lureau Handle unknown values instead of out-of-array access. Signed-off-by: Marc-André Lureau --- tools/spicy.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/tools/spicy.c b/tools/spicy.c index a41a1a3..2f6be4e 100644 --- a/t

Re: [Spice-devel] [spice-gtk v3 0/3] channel-display with new stream-video-codec property

Hi, it looks good & useful. Ack the series. Pavel On Thu, 2017-03-02 at 11:36 +0100, Victor Toso wrote: > From: Victor Toso > > Hi, > > The main idea is to be able to easily see the video-codec changing. > Spicy uses thes new property and set the information in its status > label. > > v1->v

[Spice-devel] [PATCH spice-server] reds-stream: Small syscall optimisation

Handle single chunk writev as normal write. From some test more than 60% of the times writev is called with 1 as counter. We can easily and very cheaply turn this call to a simpler write avoiding the need to pass the array to the kernel. Signed-off-by: Frediano Ziglio --- server/reds-stream.c |

Re: [Spice-devel] [PATCH] README: Update link to virt-viewer

Ack On 03/13/2017 08:50 AM, Pavel Grunt wrote: --- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README b/README index 408c2f2..2ab5b67 100644 --- a/README +++ b/README @@ -21,7 +21,7 @@ libspice-client-gtk-3.0 spicy a gtk test client. The recommended