Hi,
On Mon, Mar 06, 2017 at 03:29:14PM +0100, Victor Toso wrote:
> From: Victor Toso
>
> gdk_seat_grab() expects that the widget is visible otherwise it will
> always fail with GDK_GRAB_NOT_VIEWABLE. This means that we can check if
> display is realized before running gdk_seat_grab().
>
> Fixes
On Tue, Mar 07, 2017 at 03:23:08PM +, Frediano Ziglio wrote:
> The nested if could be confusing, no needs for them.
>
> Signed-off-by: Frediano Ziglio
Acked-by: Victor Toso
> ---
> server/reds.c | 13 +++--
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/server/
On 03/06/2017 02:39 AM, Pavel Grunt wrote:
> Any comments?
ACK, and pushed; a clear improvement, and the patches look sound.
Although this still leaves a lot of work to be done for the html5 client
to look nice.
Cheers,
Jeremy
>
> Thanks,
> Pavel
>
> On Tue, 2017-01-10 at 22:54 +0100, Pavel
ACK
Thanks,
Pavel
On Tue, 2017-03-07 at 13:08 -0600, Jeremy White wrote:
> Signed-off-by: Jeremy White
> ---
> main.js | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/main.js b/main.js
> index 2d8a1ff..173ff97 100644
> --- a/main.js
> +++ b/main.js
> @@ -145,7 +1
Signed-off-by: Jeremy White
---
main.js | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/main.js b/main.js
index 2d8a1ff..173ff97 100644
--- a/main.js
+++ b/main.js
@@ -145,7 +145,12 @@ SpiceMainConn.prototype.process_channel_message =
function(msg)
Verify stuff are freed correctly (like TLS context).
The different PKI file required are generated with
base values (localhost and rsa 1024).
Signed-off-by: Frediano Ziglio
---
server/tests/Makefile.am | 1 +
server/tests/pki/ca-cert.pem | 16
server/tests/pki/serve
Verify stuff are freed correctly (like TLS context).
The different PKI file required are generated with
base values (localhost and rsa 1024).
Signed-off-by: Frediano Ziglio
---
server/tests/Makefile.am | 1 +
server/tests/pki/ca-cert.pem | 16
server/tests/pki/serve
Add and remove some vmc device to check for leaking.
These combination assure that currently implemented type
of devices (webdav, usb and generic) are checked.
Signed-off-by: Frediano Ziglio
---
server/tests/test-leaks.c | 67 +--
1 file changed, 65 in
This reverts commit c3d237075b994fe67e58f2b3164cb579e6f4.
When you call gst_buffer_add_video_meta_full GStreamer assumes
that buffer is contiguous. This results usually in some pixel
shifts in the video. The pixel shifts you can see are artifacts
due to how the guest sends the frames.
Assumin
> Hi,
>
> On Tue, Feb 28, 2017 at 11:18:15AM +0100, Victor Toso wrote:
> > Hi,
> >
> > On Tue, Feb 28, 2017 at 04:56:54AM -0500, Frediano Ziglio wrote:
> > > >
> > > > From: Victor Toso
> > > >
> > > > Hi,
> > > >
> > > > This patch is actually an improvement of an old patch [0]. It fixes
> >
>
> >
> > Hi Snir,
> >
> > Regarding compression and another topic recently evoked, endianness, I
> > wonder
> > if encoding using LEB128 had been discussed?
> >
> > LEB128 encodes any value below 128 as 1 bytes, any value below ~16000 as 2
> > bytes, and so on. It is size and endianness indepe
The nested if could be confusing, no needs for them.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 41f24bb..2ad231e 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -2012,12
>
> On Fri, Mar 03, 2017 at 11:18:57AM +, Frediano Ziglio wrote:
> > This reverts commit c3d237075b994fe67e58f2b3164cb579e6f4.
> >
> > When you call gst_buffer_add_video_meta_full GStreamer assumes
> > that buffer is contiguous. This results usually in some pixels
> > shift in the video.
>
> On Tue, Mar 07, 2017 at 12:35:35PM +, Frediano Ziglio wrote:
> > Send header and reply together.
> > This potentially save up to 160 bytes on the network.
> > This as sending multiple chunks you can have different framing,
> > specifically:
> > - if you use TLS every chunk get encrypted se
On Tue, Mar 07, 2017 at 12:35:35PM +, Frediano Ziglio wrote:
> Send header and reply together.
> This potentially save up to 160 bytes on the network.
> This as sending multiple chunks you can have different framing,
> specifically:
> - if you use TLS every chunk get encrypted separately
> (r
On Fri, Mar 03, 2017 at 11:18:57AM +, Frediano Ziglio wrote:
> This reverts commit c3d237075b994fe67e58f2b3164cb579e6f4.
>
> When you call gst_buffer_add_video_meta_full GStreamer assumes
> that buffer is contiguous. This results usually in some pixels
> shift in the video. The pixels shif
On 03/07/2017 12:59 PM, Christophe Fergeau wrote:
On Mon, Mar 06, 2017 at 02:05:14PM -0500, Frediano Ziglio wrote:
3. main : It start with impressive compression but afterwards it mostly
depends on user behavior , for example copy\paste of text should be
compressed massively in main channel
se
Hi,
On 03/06/2017 09:05 PM, Frediano Ziglio wrote:
Hi,
Thanks all for your comments
On 03/03/2017 12:49 PM, Frediano Ziglio wrote:
Hey,
Do you have any measurements of how much bandwidth is saved on each
channel type on basic usage of linux/windows guests? Ideally, with
numbers about addit
Send header and reply together.
This potentially save up to 160 bytes on the network.
This as sending multiple chunks you can have different framing,
specifically:
- if you use TLS every chunk get encrypted separately
(reds-stream, currently usually 29 bytes for every chunks);
- tcp settings and
>
> On Mon, Mar 06, 2017 at 05:09:05PM +, Frediano Ziglio wrote:
> > Send header and reply together.
> > This potentially save up to 160 bytes on the network.
>
> Could you expand on how these bytes are saved ? Or is it better that
> everyone reading this log spends time investigating this th
Hi,
On Tue, Feb 28, 2017 at 11:18:15AM +0100, Victor Toso wrote:
> Hi,
>
> On Tue, Feb 28, 2017 at 04:56:54AM -0500, Frediano Ziglio wrote:
> > >
> > > From: Victor Toso
> > >
> > > Hi,
> > >
> > > This patch is actually an improvement of an old patch [0]. It fixes
> > > rhbz#1425443
> > > her
On Mon, Mar 06, 2017 at 05:09:05PM +, Frediano Ziglio wrote:
> Send header and reply together.
> This potentially save up to 160 bytes on the network.
Could you expand on how these bytes are saved ? Or is it better that
everyone reading this log spends time investigating this themselves ? :)
On Mon, Mar 06, 2017 at 02:05:14PM -0500, Frediano Ziglio wrote:
>
> > 3. main : It start with impressive compression but afterwards it mostly
> > depends on user behavior , for example copy\paste of text should be
> > compressed massively in main channel
> > server -> client:
> > 150.1?! (but jus
On Tue, 2017-03-07 at 03:18 -0500, Frediano Ziglio wrote:
> >
> > On Mon, 2017-03-06 at 18:22 +, Frediano Ziglio wrote:
> > > The default memset(0) on the node does not init it correctly.
> >
> > yeah, nice catch, INVALID_STAT_REF = ~0
> >
> > > Do so to avoid other nodes/counters appended t
>
> On Mon, 2017-03-06 at 18:22 +, Frediano Ziglio wrote:
> > The default memset(0) on the node does not init it correctly.
> yeah, nice catch, INVALID_STAT_REF = ~0
>
> > Do so to avoid other nodes/counters appended to unwanted nodes.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > ser
25 matches
Mail list logo
