On Mon, 2017-03-06 at 18:22 +, Frediano Ziglio wrote:
> The default memset(0) on the node does not init it correctly.
yeah, nice catch, INVALID_STAT_REF = ~0
> Do so to avoid other nodes/counters appended to unwanted nodes.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-channel.c | 2
On Sun, Mar 5, 2017 at 10:02 PM, Fabiano Fidêncio
wrote:
> On Sun, Mar 5, 2017 at 1:40 PM, Sameeh Jubran wrote:
> >
> >
> > On Sun, Mar 5, 2017 at 12:37 PM, Victor Toso
> wrote:
> >>
> >> Hi,
> >>
> >> On Sun, Mar 05, 2017 at 11:46:01AM +0200, Sameeh Jubran wrote:
> >> > Hi all,
> >> >
> >> > I
>
> Hi,
>
> Thanks all for your comments
>
>
> On 03/03/2017 12:49 PM, Frediano Ziglio wrote:
> >> Hey,
> >>
> >> Do you have any measurements of how much bandwidth is saved on each
> >> channel type on basic usage of linux/windows guests? Ideally, with
> >> numbers about additional CPU usage a
The default memset(0) on the node does not init it correctly.
Do so to avoid other nodes/counters appended to unwanted nodes.
Signed-off-by: Frediano Ziglio
---
server/red-channel.c | 2 ++
server/stat.h| 8
2 files changed, 10 insertions(+)
diff --git a/server/red-channel.c b/
Avoid usage of not initialized statistic node.
This happened for DisplayChannel which was initializing
statistics in the object constructor.
Signed-off-by: Frediano Ziglio
---
server/cursor-channel.c | 4 +++-
server/cursor-channel.h | 5 +++--
server/display-channel.c | 4 +++-
server/disp
Hi
- Original Message -
> On 03/03/17 18:42, Marc-André Lureau wrote:
> > Hi
> >
> > - Original Message -
> >> This allows us to inform the clients of this library if it was built
> >> with support for folder sharing or not.
> >>
> >> Signed-off-by: Eduardo Lima (Etrunko)
> >
>
Send header and reply together.
This potentially save up to 160 bytes on the network.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 58 +++---
1 file changed, 31 insertions(+), 27 deletions(-)
Changes since v1:
- added some comment;
- che
On Mon, Mar 06, 2017 at 11:36:16AM -0500, Frediano Ziglio wrote:
>
> >
> > On Mon, Mar 06, 2017 at 04:12:33PM +, Frediano Ziglio wrote:
> > > Send header and reply together
> >
> > The log is missing a "Why?"
> >
>
> Potentially to safe up to 160 bytes!
And this is not worth mentioning in
>
> On Mon, Mar 06, 2017 at 04:12:33PM +, Frediano Ziglio wrote:
> > Send header and reply together
>
> The log is missing a "Why?"
>
Potentially to safe up to 160 bytes!
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/reds.c | 56
> > +---
On Mon, Mar 06, 2017 at 04:12:32PM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> I can write a test (or better extend the leak one) but
> requires to add ca/certificate/private key.
Acked-by: Christophe Fergeau
> ---
> server/reds.c | 4
> 1 file changed, 4 inse
On Mon, Mar 06, 2017 at 04:12:33PM +, Frediano Ziglio wrote:
> Send header and reply together
The log is missing a "Why?"
>
> Signed-off-by: Frediano Ziglio
> ---
> server/reds.c | 56 +---
> 1 file changed, 29 insertions(+), 27 deletions
Signed-off-by: Frediano Ziglio
---
I can write a test (or better extend the leak one) but
requires to add ca/certificate/private key.
---
server/reds.c | 4
1 file changed, 4 insertions(+)
diff --git a/server/reds.c b/server/reds.c
index 2983aae..fc720a3 100644
--- a/server/reds.c
+++ b/ser
Send header and reply together
Signed-off-by: Frediano Ziglio
---
server/reds.c | 56 +---
1 file changed, 29 insertions(+), 27 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index fc720a3..e94d0c4 100644
--- a/server/reds.c
+++ b/ser
On Mon, Mar 06, 2017 at 09:42:13AM -0500, Frediano Ziglio wrote:
> >
> > Signed-off-by: Uri Lublin
> > ---
> > proxy.rst | 102
> > ++
> > 1 file changed, 102 insertions(+)
> > create mode 100644 proxy.rst
> >
> > diff --git a/proxy.
>
> Signed-off-by: Uri Lublin
> ---
> proxy.rst | 102
> ++
> 1 file changed, 102 insertions(+)
> create mode 100644 proxy.rst
>
> diff --git a/proxy.rst b/proxy.rst
> new file mode 100644
> index 000..9824a15
> --- /dev/null
> +
>
> Hi
>
> - Original Message -
> > >
> > > Hi
> > >
> > > - Original Message -
> > > > >
> > > > > Hi
> > > > >
> > > > > - Original Message -
> > > > > > Since 2.8, QEMU now longer creates QXL primary surfaces when using
> > > > > > GL.
> > > > > > This change broke
On 03/03/17 18:42, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
>> This allows us to inform the clients of this library if it was built
>> with support for folder sharing or not.
>>
>> Signed-off-by: Eduardo Lima (Etrunko)
>
> Interesting approach, but you should rather do that
Hi,
On Tue, Feb 28, 2017 at 01:44:42PM +, Daniel P. Berrange wrote:
> On Tue, Feb 28, 2017 at 02:37:25PM +0100, Victor Toso wrote:
> > From: Victor Toso
> >
> > Signed-off-by: Victor Toso
> > ---
> > AUTHORS | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/AUTHORS b/AUTHORS
On Wed, 2017-03-01 at 11:36 +0200, Snir Sheriber wrote:
>
>
> On 02/28/2017 11:06 PM, Jonathon Jongsma wrote:
> > On Tue, 2017-02-28 at 16:19 +0100, Christophe de Dinechin wrote:
> > > > On 28 Feb 2017, at 15:37, Jonathon Jongsma > > > >
> > > > wrote:
> > > >
> > > > On Tue, 2017-02-28 at 10:2
From: Victor Toso
gdk_seat_grab() expects that the widget is visible otherwise it will
always fail with GDK_GRAB_NOT_VIEWABLE. This means that we can check if
display is realized before running gdk_seat_grab().
Fixes a critical & warning introduced by 3f4c5bcc88ca5db125e
> Gdk-CRITICAL **: Win
>
> From: Victor Toso
>
> Signed-off-by: Victor Toso
> ---
> AUTHORS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/AUTHORS b/AUTHORS
> index 2b0fe24..99f6c18 100644
> --- a/AUTHORS
> +++ b/AUTHORS
> @@ -28,6 +28,7 @@ Patches also contributed by
> 소병철
> Cédric Bosdonnat
Signed-off-by: Uri Lublin
---
proxy.rst | 102 ++
1 file changed, 102 insertions(+)
create mode 100644 proxy.rst
diff --git a/proxy.rst b/proxy.rst
new file mode 100644
index 000..9824a15
--- /dev/null
+++ b/proxy.rst
@@ -0,0 +1,10
Hi Christophe,
I think it's best to keep the patches as-as, as it will make it simpler to
both review and revert in the future.
On Mon, Mar 6, 2017 at 2:25 PM, Christophe Fergeau
wrote:
> On Mon, Mar 06, 2017 at 01:23:43PM +0200, Lev Veyde wrote:
> > Hi,
> >
> > Attached are 3 patches: 2 patche
On Mon, Mar 06, 2017 at 01:23:43PM +0200, Lev Veyde wrote:
> Hi,
>
> Attached are 3 patches: 2 patches for adding general support for Microsoft
> Windows Server 2016,
> and an additional patch that adds the support to the installer itself.
For the series
Acked-by: Christophe Fergeau
I would squ
Hi,
Attached are 3 patches: 2 patches for adding general support for Microsoft
Windows Server 2016,
and an additional patch that adds the support to the installer itself.
--
Thanks in advance,
Lev Veyde.
(RHCE, RHCVA, MCITP)
From b2cc5a8b9d8866a9bdbc8289c4fcbd6ef192ccbf Mon Sep 17 00:00:00 2001
Hi
- Original Message -
> >
> > Hi
> >
> > - Original Message -
> > > >
> > > > Hi
> > > >
> > > > - Original Message -
> > > > > Since 2.8, QEMU now longer creates QXL primary surfaces when using
> > > > > GL.
> > > > > This change broke client-side mouse mode, because
>
> Hi
>
> - Original Message -
> > >
> > > Hi
> > >
> > > - Original Message -
> > > > Since 2.8, QEMU now longer creates QXL primary surfaces when using GL.
> > > > This change broke client-side mouse mode, because Spice server relies
> > > > on
> > > > primary surface conditi
Hi
- Original Message -
> >
> > Hi
> >
> > - Original Message -
> > > Since 2.8, QEMU now longer creates QXL primary surfaces when using GL.
> > > This change broke client-side mouse mode, because Spice server relies on
> > > primary surface conditions.
> > >
> > > When GL is en
> > On 3 Mar 2017, at 13:10, Marc-André Lureau < mlur...@redhat.com > wrote:
>
> > Hi
>
> > - Original Message -
>
> > > > Hi
> > >
> >
>
> > > > - Original Message -
> > >
> >
>
> > > > > These 2 patches attempt to join images split by RHEL7 graphic
> > > >
> > >
>
Hi,
On Mon, Mar 06, 2017 at 11:26:15AM +0100, Victor Toso wrote:
> Hi,
>
> On Mon, Mar 06, 2017 at 11:15:58AM +0100, Pavel Grunt wrote:
> > ACK
> >
> > Thanks,
> > Pavel
> >
> > I think some of these setting properties are deprecated
>
> Oh, true. The second one here is deprecated and ignored f
>
> Any comments?
>
Had a look to the patches and seems fine but I don't know how to
test them properly (and my Javascript skills are not that good either)
Frediano
> Thanks,
> Pavel
>
> On Tue, 2017-01-10 at 22:54 +0100, Pavel Grunt wrote:
> > Hi,
> >
> > These two patches add basic support
>
> Hi
>
> - Original Message -
> > Since 2.8, QEMU now longer creates QXL primary surfaces when using GL.
> > This change broke client-side mouse mode, because Spice server relies on
> > primary surface conditions.
> >
> > When GL is enabled, use GL scanout informations.
> > Mouse mode
Hi,
On Mon, Mar 06, 2017 at 11:15:58AM +0100, Pavel Grunt wrote:
> ACK
>
> Thanks,
> Pavel
>
> I think some of these setting properties are deprecated
Oh, true. The second one here is deprecated and ignored from gtk v3.10
onwards. I'll send a followup patch.
>
> On Mon, 2017-03-06 at 11:09 +010
ACK
Thanks,
Pavel
I think some of these setting properties are deprecated
On Mon, 2017-03-06 at 11:09 +0100, Victor Toso wrote:
> From: Victor Toso
>
> As gboolean is 4 bytes long while bool is 1 byte, valgrind will
> complain
> about it.
>
> Invalid write of size 4
> at 0xAE9F4FB: value_l
From: Victor Toso
As gboolean is 4 bytes long while bool is 1 byte, valgrind will complain
about it.
Invalid write of size 4
at 0xAE9F4FB: value_lcopy_boolean (gvaluetypes.c:78)
by 0xAE7CFD3: g_object_get_valist (gobject.c:2236)
by 0xAE7D40B: g_object_get (gobject.c:2324)
by 0x40758F
Hi
- Original Message -
> Since 2.8, QEMU now longer creates QXL primary surfaces when using GL.
> This change broke client-side mouse mode, because Spice server relies on
> primary surface conditions.
>
> When GL is enabled, use GL scanout informations.
> Mouse mode is always client when
On Fri, Mar 03, 2017 at 09:48:45PM -0300, Thiago Nascimento Araujo wrote:
> >> - Mensagem original -
> >> De: "Pavel Grunt"
> >> Para: "Thiago Nascimento Araujo" , "Jonathon
> >> Jongsma"
> >> Cc: spice-devel@lists.freedesktop.org
> >> Enviadas: Sexta-feira, 3 de março de 2017 6:20:13
>
On Thu, 2017-03-02 at 14:51 +0100, Pavel Grunt wrote:
> On Thu, 2017-03-02 at 10:07 +, Daniel P. Berrange wrote:
> > Consume the keymaps.csv file from a git submodule instead of
> > having
> > a private copy. This makes it easier to ensure all users of the
> > keymap
> > (libvirt, gtk-vnc, spic
>
> Hi Snir,
>
> Regarding compression and another topic recently evoked, endianness, I wonder
> if encoding using LEB128 had been discussed?
>
> LEB128 encodes any value below 128 as 1 bytes, any value below ~16000 as 2
> bytes, and so on. It is size and endianness independent. This means that
Any comments?
Thanks,
Pavel
On Tue, 2017-01-10 at 22:54 +0100, Pavel Grunt wrote:
> Hi,
>
> These two patches add basic support for Windows guests by handling
> image which does not have the topdown flag set.
>
> The fix is just to flip images horizontally.
>
> There are still some artifacts,
> > On 3 Mar 2017, at 13:17, Frediano Ziglio < fzig...@redhat.com > wrote:
>
> > > We have recently discussed the use of the bool type. What about sized int
> >
>
> > > types? What is the policy here?
> >
>
> > > Notably, on a part of the code I’m presently working on, I saw that
> >
>
> >
41 matches
Mail list logo
