Re: [Spice-devel] [PATCH spice-gtk v3] Switch over to using keycodemapdb submodule

On Thu, 2017-03-02 at 07:59 +0100, Pavel Grunt wrote: > On Mon, 2017-02-27 at 10:44 +, Daniel P. Berrange wrote: > > On Mon, Feb 27, 2017 at 11:37:44AM +0100, Pavel Grunt wrote: > > > Hello Daniel, > > > > > > On Mon, 2017-02-27 at 10:25 +, Daniel P. Berrange wrote: > > > > Consume the key

[Spice-devel] How to send a custom resolution message to windows/linux guest vdagent

Hello, Is there a way to send a spice message, connect to pipe, or any other method to contact vdservice/vdagent to create/simulate a resize to an arbitrary resolution or full screen effect caused by remote-viewer? Any other ways I can connect to the named pipes (windows guests or linux guests

Re: [Spice-devel] [PATCH spice-gtk v3] Switch over to using keycodemapdb submodule

On Mon, 2017-02-27 at 10:44 +, Daniel P. Berrange wrote: > On Mon, Feb 27, 2017 at 11:37:44AM +0100, Pavel Grunt wrote: > > Hello Daniel, > > > > On Mon, 2017-02-27 at 10:25 +, Daniel P. Berrange wrote: > > > Consume the keymaps.csv file from a git submodule instead of > > > having > > > a

Re: [Spice-devel] [PATCH] Don't close all but one display during reboot.

On Thu, 2017-02-23 at 16:25 +0200, Snir Sheriber wrote: > Hi, > > On 01/31/2017 10:24 PM, Jonathon Jongsma wrote: > > When a guest is rebooted, the QXL driver gets unloaded at some > > point in > > the reboot process. When the driver is unloaded, the spice server > > sets a > > single flag to FALS

Re: [Spice-devel] [PATCH spice-server v2 2/2] red-channel: Use a single structure to hold capabilities

On Wed, 2017-03-01 at 13:21 +, Frediano Ziglio wrote: > Common and channel capabilities are received together > and copied together. > As there is already a structure that holds both these capabilities > use it even for GObject property. > > Signed-off-by: Frediano Ziglio > --- >  server/curs

Re: [Spice-devel] [PATCH spice-server v2 1/2] red-channel: Use directly a GArray to pass capabilities

Yes. All of this duplicated code (that I wrote) has been bugging me for quite a while. Thanks for cleaning it up. Could you rephrase the commit summary to: "red-channel: Use GArray directly to pass capabilities" Acked-by: Jonathon Jongsma On Wed, 2017-03-01 at 13:21 +, Frediano Ziglio wro

Re: [Spice-devel] [PATCH spice-server v2] record: Allocate recording file globally from reds.c

On Wed, 2017-03-01 at 12:23 -0500, Frediano Ziglio wrote: > > > > Personally, I think that this would be better as two smaller > > commits. > > One changing the RedRecord implementation itself (adding > > refcounting, > > mutex locking, etc), and one changing which object allocates and > > owns >

Re: [Spice-devel] [PATCH spice-server v2] record: Allocate recording file globally from reds.c

> > Personally, I think that this would be better as two smaller commits. > One changing the RedRecord implementation itself (adding refcounting, > mutex locking, etc), and one changing which object allocates and owns > the RedRecord instance. The patch looks pretty good, but I have a few > additi

Re: [Spice-devel] [PATCH spice-server v2] record: Allocate recording file globally from reds.c

Personally, I think that this would be better as two smaller commits. One changing the RedRecord implementation itself (adding refcounting, mutex locking, etc), and one changing which object allocates and owns the RedRecord instance. The patch looks pretty good, but I have a few additional comments

[Spice-devel] [PATCH spice-server] tests: Allows to detect loop leaks in test-leaks

Signed-off-by: Frediano Ziglio --- server/tests/test-leaks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/tests/test-leaks.c b/server/tests/test-leaks.c index cd96bc8..b8521f4 100644 --- a/server/tests/test-leaks.c +++ b/server/tests/test-leaks.c @@ -47,6 +47,7 @@ static void leaks(

[Spice-devel] [PATCH spice-server] main-dispatcher: Remove watch leak

Watch was added but never removed. Signed-off-by: Frediano Ziglio --- server/main-dispatcher.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/server/main-dispatcher.c b/server/main-dispatcher.c index 09ac1cc..51d6004 100644 --- a/server/main-dispatcher.

Re: [Spice-devel] [PATCH spice-server] Release cursor as soon as possible

> > On Tue, Feb 28, 2017 at 03:20:09PM +, Frediano Ziglio wrote: > > Cursor resources (basically the shape of it) was retained till > > it was used however it was copied so there were no reason to not release > > this resource. > > > > Signed-off-by: Frediano Ziglio > > --- > > server/curso

Re: [Spice-devel] [spice-server v5 5/5] test-vdagent: Make test case more useful

> > This switches the test to using the GTest API, and add several tests > related to https://bugzilla.redhat.com/show_bug.cgi?id=1411194 > > This uses some API not available in glib 2.28, so this checks we have a > new enough glib before building this test, and disables warnings when > using too

Re: [Spice-devel] [PATCH spice-server] Release cursor as soon as possible

On Tue, Feb 28, 2017 at 03:20:09PM +, Frediano Ziglio wrote: > Cursor resources (basically the shape of it) was retained till > it was used however it was copied so there were no reason to not release > this resource. > > Signed-off-by: Frediano Ziglio > --- > server/cursor-channel.c

Re: [Spice-devel] [PATCH spice-server v2 1/2] reds: Free remaining configuration

> > On Wed, Mar 01, 2017 at 11:27:27AM +, Frediano Ziglio wrote: > > Free security, migration, sasl and name stuff. > > > > Signed-off-by: Frediano Ziglio > > --- > > server/reds.c | 43 +-- > > 1 file changed, 29 insertions(+), 14 deletions(-) > > >

[Spice-devel] [ANNOUNCE] libcacard 2.5.3 released

Hi, I am pleased to announce a new libcacard, with the following fixes: - fix memory leak in vcard_apdu_new - do not fail, if the caller didn't pick up response from previous call (to please opensc) - some scan-build errors fixed https://www.spice-space.org/download/libcacard/libcacard-2.5.3.ta

Re: [Spice-devel] [PATCH spice-server v2 2/2] tests: Add a test to detects some leaks freeing SpiceServer

I'd reword this to: "tests: Add basic spice_server_init()/spice_server_destroy() This can be used for very basic leak checks." Acked-by: Christophe Fergeau On Wed, Mar 01, 2017 at 11:27:28AM +, Frediano Ziglio wrote: > Cause allocation of some internal SpiceServer resources > which was not

Re: [Spice-devel] [PATCH spice-server v2 1/2] reds: Free remaining configuration

On Wed, Mar 01, 2017 at 11:27:27AM +, Frediano Ziglio wrote: > Free security, migration, sasl and name stuff. > > Signed-off-by: Frediano Ziglio > --- > server/reds.c | 43 +-- > 1 file changed, 29 insertions(+), 14 deletions(-) > > Changes since v2:

Re: [Spice-devel] [PATCH spice-protocol 2/2] agent: Add macro for clearing capability

On Tue, Feb 28, 2017 at 12:26:41PM -0500, Frediano Ziglio wrote: > > > > On Tue, 2017-02-28 at 09:29 -0500, Frediano Ziglio wrote: > > > > > > > > Related: > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1373725 > > > > --- > > > >  spice/vd_agent.h | 3 +++ > > > >  1 file changed, 3 insertio

Re: [Spice-devel] [spice-gtk v1] display-mjpeg: free queue

Acked-by: Christophe Fergeau On Wed, Mar 01, 2017 at 04:07:03PM +0100, Victor Toso wrote: > From: Victor Toso > > 24 bytes in 1 blocks are definitely lost in loss record 4,300 of 14,518 >at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) >by 0xB12C5B8: g_malloc (gmem.c:94) >by 0xB144B12

Re: [Spice-devel] [RFC PATCH libcacard] Update NEWS for 2.5.3 release

Hi, On Wed, Mar 01, 2017 at 04:44:40PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > NEWS | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/NEWS b/NEWS > index 7ab2eb6..7e8bc47 100644 > --- a/NEWS > +++ b/NEWS

[Spice-devel] [spice-gtk v1] display-mjpeg: free queue

From: Victor Toso 24 bytes in 1 blocks are definitely lost in loss record 4,300 of 14,518 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0xB12C5B8: g_malloc (gmem.c:94) by 0xB144B12: g_slice_alloc (gslice.c:1025) by 0xB14513D: g_slice_alloc0 (gslice.c:1051) by 0x50EE096: create_

[Spice-devel] [spice v11] dcc: handle preferred video codec message

From: Victor Toso [0] SPICE_MSGC_DISPLAY_PREFERRED_VIDEO_CODEC_TYPE This message provides a list of video codecs based on client's order of preference. We duplicate the video codecs array from reds.c and sort it using the order of codecs as reference. This message will not change an ongoing st

Re: [Spice-devel] [PATCH spice] gl: fix client mouse mode

> On 30 Jan 2017, at 13:50, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > Since 2.8, QEMU now longer creates QXL primary surfaces when using Typo, “no longer" > GL. This change broke client-side mouse mode, because Spice server > relies on primary surface conditions. > >

Re: [Spice-devel] [PATCH spice-protocol 2/2] agent: Add macro for clearing capability

> On 28 Feb 2017, at 18:26, Frediano Ziglio > wrote: > >> >> On Tue, 2017-02-28 at 09:29 -0500, Frediano Ziglio wrote: Related: https://bugzilla.redhat.com/show_bug.cgi?id=1373725 --- >>>

[Spice-devel] [PATCH spice-server v2 2/2] red-channel: Use a single structure to hold capabilities

Common and channel capabilities are received together and copied together. As there is already a structure that holds both these capabilities use it even for GObject property. Signed-off-by: Frediano Ziglio --- server/cursor-channel-client.c| 3 +- server/cursor-channel-client.h| 2 +-

[Spice-devel] [PATCH spice-server v2 0/2] Change the way we pass capabilities

This small set (maybe should be squashed) attempt to pass capabilities using a single RedChannelCapabilities (already existing) structure. Changes since v1: - use RedChannelCapabilities instead of 2 GArrays. Maybe the RedChannelCapabilities could be moved to a separate file (and maybe renamed Red

[Spice-devel] [PATCH spice-server 2/2] red-channel: Use a single structure to hold capabilities

Common and channel capabilities are received together and copied together. As there is already a structure that holds both these capabilities use it even for GObject property. Signed-off-by: Frediano Ziglio --- server/cursor-channel-client.c| 3 +- server/cursor-channel-client.h| 2 +-

[Spice-devel] [PATCH spice-server v2 1/2] red-channel: Use directly a GArray to pass capabilities

Capabilities where almost always passed using 2 arguments, a number of elements and an array but then before using these were converted to a GArray. Converting to GArray much earlier allows to easily pass the capabilities around. Signed-off-by: Frediano Ziglio --- I don't know if is worth definin

[Spice-devel] [PATCH spice-server 1/2] red-channel: Use directly a GArray to pass capabilities

Capabilities where almost always passed using 2 arguments, a number of elements and an array but then before using these were converted to a GArray. Converting to GArray much earlier allows to easily pass the capabilities around. Signed-off-by: Frediano Ziglio --- I don't know if is worth definin

Re: [Spice-devel] [spice-server v2] Make various functions static

On Wed, Mar 01, 2017 at 06:06:51AM -0500, Frediano Ziglio wrote: > > > > - glz_enc_dictionary_reset > > - monitors_config_new > > - red_channel_any_blocked > > - red_channel_no_item_being_sent > > - red_client_get_channel > > - reds_stream_write > > > > are only used in the file where they are de

[Spice-devel] [RFC PATCH libcacard] Update NEWS for 2.5.3 release

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- NEWS | 9 + 1 file changed, 9 insertions(+) diff --git a/NEWS b/NEWS index 7ab2eb6..7e8bc47 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,12 @@ +v2.5.3 +== + +- fix memory leak in vcard_apdu_new +- do not fail, if the caller di

Re: [Spice-devel] [PATCH spice] gl: fix client mouse mode

Am 01.03.2017 um 12:48 schrieb Frediano Ziglio: Am Mon, 30 Jan 2017 16:50:05 +0400 schrieb marcandre.lureau: > From: Marc-André Lureau > > Since 2.8, QEMU now longer creates QXL primary surfaces when using GL. > This change broke client-side mouse mode, because Spi

Re: [Spice-devel] [spice v10] dcc: handle preferred video codec message

Hi, Thanks again for the review. On Wed, Mar 01, 2017 at 05:20:20AM -0500, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > [0] SPICE_MSGC_DISPLAY_PREFERRED_VIDEO_CODEC_TYPE > > > > This message provides a list of video codecs based on client's order > > of preference. > > > > We dup

Re: [Spice-devel] [PATCH spice] gl: fix client mouse mode

Hi - Original Message - > > > > > > > Am Mon, 30 Jan 2017 16:50:05 +0400 schrieb marcandre.lureau: > > > From: Marc-André Lureau > > > > Since 2.8, QEMU now longer creates QXL primary surfaces when using GL. > > This change broke client-side mouse mode, because Spice server relies

Re: [Spice-devel] [PATCH spice] gl: fix client mouse mode

> Am Mon, 30 Jan 2017 16:50:05 +0400 schrieb marcandre.lureau: > > From: Marc-André Lureau > > > > Since 2.8, QEMU now longer creates QXL primary surfaces when using GL. > > This change broke client-side mouse mode, because Spice server relies on > > primary surface conditions. > > > > When GL is

Re: [Spice-devel] [PATCH spice] gl: fix client mouse mode

Am Mon, 30 Jan 2017 16:50:05 +0400 schrieb marcandre.lureau: > From: Marc-André Lureau > > Since 2.8, QEMU now longer creates QXL primary surfaces when using GL. > This change broke client-side mouse mode, because Spice server relies on > primary surface conditions. > > When GL is enabled, use GL

[Spice-devel] [PATCH spice-server v2 1/2] reds: Free remaining configuration

Free security, migration, sasl and name stuff. Signed-off-by: Frediano Ziglio --- server/reds.c | 43 +-- 1 file changed, 29 insertions(+), 14 deletions(-) Changes since v2: - pass RedServerConfig to reds_config_free; - minor style changes. diff --git a/

[Spice-devel] [PATCH spice-server v2 2/2] tests: Add a test to detects some leaks freeing SpiceServer

Cause allocation of some internal SpiceServer resources which was not free correctly. Using a leak detector this test results in errors if leaks happen. Signed-off-by: Frediano Ziglio --- server/tests/.gitignore | 1 + server/tests/Makefile.am | 1 + server/tests/test-leaks.c | 59 +

Re: [Spice-devel] [spice-server v2] Make various functions static

> > - glz_enc_dictionary_reset > - monitors_config_new > - red_channel_any_blocked > - red_channel_no_item_being_sent > - red_client_get_channel > - reds_stream_write > > are only used in the file where they are defined, so they can as well be > static. > I have a script that tells you the unus

Re: [Spice-devel] [PATCH spice-server 1a/3] red-channel: Use directly a GArray to pass capabilities

On Wed, Mar 01, 2017 at 05:39:09AM -0500, Frediano Ziglio wrote: > > > > On Tue, Feb 28, 2017 at 12:14:25PM -0500, Frediano Ziglio wrote: > > > > > > > > On Tue, Feb 28, 2017 at 09:43:33AM +, Frediano Ziglio wrote: > > > > > Capabilities where almost always passed using 2 arguments, > > > > >

[Spice-devel] [spice-server v2] Make various functions static

- glz_enc_dictionary_reset - monitors_config_new - red_channel_any_blocked - red_channel_no_item_being_sent - red_client_get_channel - reds_stream_write are only used in the file where they are defined, so they can as well be static. Signed-off-by: Christophe Fergeau --- server/display-channel.

Re: [Spice-devel] [PATCH spice-server] reds: Free remaining configuration

> > On Wed, Mar 01, 2017 at 09:57:29AM +, Frediano Ziglio wrote: > > Free security, migration, sasl and name stuff. > > > > Signed-off-by: Frediano Ziglio > > --- > > server/reds.c | 23 +++ > > 1 file changed, 19 insertions(+), 4 deletions(-) > > > > diff --git a/serve

Re: [Spice-devel] [PATCH spice-server 1a/3] red-channel: Use directly a GArray to pass capabilities

> > On Tue, Feb 28, 2017 at 12:14:25PM -0500, Frediano Ziglio wrote: > > > > > > On Tue, Feb 28, 2017 at 09:43:33AM +, Frediano Ziglio wrote: > > > > Capabilities where almost always passed using 2 arguments, > > > > a number of elements and an array but then before using > > > > these were c

Re: [Spice-devel] [PATCH spice-server] reds: Free remaining configuration

On Wed, Mar 01, 2017 at 09:57:29AM +, Frediano Ziglio wrote: > Free security, migration, sasl and name stuff. > > Signed-off-by: Frediano Ziglio > --- > server/reds.c | 23 +++ > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git a/server/reds.c b/server/red

Re: [Spice-devel] [spice v10] dcc: handle preferred video codec message

> > From: Victor Toso > > [0] SPICE_MSGC_DISPLAY_PREFERRED_VIDEO_CODEC_TYPE > > This message provides a list of video codecs based on client's order > of preference. > > We duplicate the video codecs array from reds.c and sort it using the > order of codecs as reference. > > This message will

[Spice-devel] Multi Console

Hi, first think i have to say is THANK YOU! Spice is the best think happened to the qmeu community since we need graphical consoles. I just have a short question about multiple console feature. I read that is still experimental? Is this still true? I found out that i need SPICE_DEBUG_ALLOW_M

[Spice-devel] [PATCH spice-server] reds: Free remaining configuration

Free security, migration, sasl and name stuff. Signed-off-by: Frediano Ziglio --- server/reds.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/server/reds.c b/server/reds.c index 898be92..eabb63f 100644 --- a/server/reds.c +++ b/server/reds.c @@ -364

Re: [Spice-devel] Multi-head Spice

On 02/28/2017 11:06 PM, Jonathon Jongsma wrote: On Tue, 2017-02-28 at 16:19 +0100, Christophe de Dinechin wrote: On 28 Feb 2017, at 15:37, Jonathon Jongsma wrote: On Tue, 2017-02-28 at 10:29 +0100, Christophe de Dinechin wrote: On 27 Feb 2017, at 23:18, Jonathon Jongsma I tried to setup a m