Re: [Spice-devel] [PATCH] smartcard: fix memory leak in vcard_apdu_new

2017-02-21 Thread Marc-André Lureau
thanks, applied - Original Message - > In the error path, 'new_apdu->a_data' is not freed. > This can be triggered by the guest continuely. > > Signed-off-by: Li Qiang > --- > src/card_7816.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/card_7816.c b

Re: [Spice-devel] [spice-gtk v1] gtk-session: Use GWeakRef

2017-02-21 Thread Victor Toso
Hi, On Tue, Feb 21, 2017 at 05:16:26PM +0100, Christophe Fergeau wrote: > On Mon, Feb 20, 2017 at 03:49:02PM +0100, Victor Toso wrote: > > From: Victor Toso > > > > The custom WeakRef structure was introduced in 9baba9fd89 (2012) to > > fix rhbz#743773. Since glib 2.32, GWeakRef was introduced a

Re: [Spice-devel] [spice-gtk v2 1/4] spice-channel: move out non blocking logic of _read_wire()

2017-02-21 Thread Christophe Fergeau
If you need this, this looks good, Acked-by: Christophe Fergeau On Fri, Feb 03, 2017 at 04:13:37PM +0100, Victor Toso wrote: > From: Victor Toso > > This patch introduces spice_channel_read_wire_nonblocking() helper > without changing any logic. > > Related: https://bugs.freedesktop.org/show_

Re: [Spice-devel] [spice-gtk v2 2/4] spice-channel: spice_channel_read_wire() improvements

2017-02-21 Thread Christophe Fergeau
On Fri, Feb 03, 2017 at 04:13:38PM +0100, Victor Toso wrote: > From: Victor Toso > > * Removes the reread label by having while(TRUE); > > The label is being used after g_coroutine_socket_wait() is called, > which is context switch while we can't do the reading as it would > block. Moving

Re: [Spice-devel] [spice-gtk v2 3/4] spice-channel: move out non blocking logic of _flush_wire()

2017-02-21 Thread Christophe Fergeau
Ok, Acked-by: Christophe Fergeau On Fri, Feb 03, 2017 at 04:13:39PM +0100, Victor Toso wrote: > From: Victor Toso > > This patch introduces spice_channel_flush_wire_nonblocking() helper > without changing any logic. > > Related: https://bugs.freedesktop.org/show_bug.cgi?id=96598 > Signed-off-

Re: [Spice-devel] [spice-gtk v2 2/4] spice-channel: spice_channel_read_wire() improvements

2017-02-21 Thread Christophe Fergeau
On Tue, Feb 21, 2017 at 06:11:54PM +0100, Christophe Fergeau wrote: > Looks good > > Acked-by: Christophe Fergeau I take that ACK back, this was meant to be sent for 3/4 ! Christophe > > On Fri, Feb 03, 2017 at 04:13:38PM +0100, Victor Toso wrote: > > From: Victor Toso > > > > * Removes the

Re: [Spice-devel] [spice-gtk v2 2/4] spice-channel: spice_channel_read_wire() improvements

2017-02-21 Thread Christophe Fergeau
Looks good Acked-by: Christophe Fergeau On Fri, Feb 03, 2017 at 04:13:38PM +0100, Victor Toso wrote: > From: Victor Toso > > * Removes the reread label by having while(TRUE); > > The label is being used after g_coroutine_socket_wait() is called, > which is context switch while we can't do

Re: [Spice-devel] [spice-gtk v2 4/4] spice-channel: make _flush_wire() compatible to _read_wire()

2017-02-21 Thread Christophe Fergeau
On Fri, Feb 03, 2017 at 04:13:40PM +0100, Victor Toso wrote: > From: Victor Toso > > * Keeping compatibility with spice_channel_read_wire() where we keep I would not talk about 'compatibility", just saying they are similar ? > the possible context switch of g_coroutine_socket_wait() in the end

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

2017-02-21 Thread Christophe Fergeau
On Sun, Feb 19, 2017 at 04:47:17PM +0200, Snir Sheriber wrote: > Remove handling with failures in the SASL authentication > process to separate function > --- > src/spice-channel.c | 44 +++- > 1 file changed, 27 insertions(+), 17 deletions(-) > > diff --gi

Re: [Spice-devel] [spice-gtk v1] gtk-session: Use GWeakRef

2017-02-21 Thread Christophe Fergeau
On Mon, Feb 20, 2017 at 03:49:02PM +0100, Victor Toso wrote: > From: Victor Toso > > The custom WeakRef structure was introduced in 9baba9fd89 (2012) to > fix rhbz#743773. Since glib 2.32, GWeakRef was introduced and it > behaves similarly to our WeakRef. > > Moving to GWeakRef to remove some co

Re: [Spice-devel] Spice protocol behind a Firewall

2017-02-21 Thread Uri Lublin
On 02/21/2017 04:44 PM, Oscar Segarra wrote: Hi Urii, What I meant is that VMs can move dynamically bethween hypervisors (or hosts) and therefore squid configuration may change according to where VMs are placed on. If you change the squid configuration dynamically you'll need to make sure a c

Re: [Spice-devel] Spice protocol behind a Firewall

2017-02-21 Thread Oscar Segarra
Hi Uri, If you change the squid configuration dynamically you'll need to make sure a client can to the VM. That may include migration. What would be interesting is habing a kind of health check that checks "Port telnet". And if a port is ready, add dinamically the rule to the squid server. Sorr

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

2017-02-21 Thread Snir Sheriber
Hi, On 02/20/2017 07:00 PM, Christophe de Dinechin wrote: On 19 Feb 2017, at 15:47, Snir Sheriber wrote: Remove handling with failures in the SASL authentication process to separate function --- src/spice-channel.c | 44 +++- 1 file changed, 27 insertion

Re: [Spice-devel] [spice-gtk v2 0/4] spice-channel read/flush wire functions

2017-02-21 Thread Victor Toso
Hi, On Fri, Feb 03, 2017 at 04:13:36PM +0100, Victor Toso wrote: > From: Victor Toso > > Changes v1->v2: > * using g_assert instead of g_assert_nonnull > * Adding https://bugs.freedesktop.org/show_bug.cgi?id=96598 in commit > * changed shortlog from patches 02/04 and 04/04 Friendly ping (not rea

Re: [Spice-devel] Spice protocol behind a Firewall

2017-02-21 Thread Oscar Segarra
Hi Urii, What I meant is that VMs can move dynamically bethween hypervisors (or hosts) and therefore squid configuration may change according to where VMs are placed on. What I can do is opening the whole rank 5634 - 6166 (accodring to https://access.redhat.com/documentation/en-US/Red_Hat_Enterpr

Re: [Spice-devel] Spice protocol behind a Firewall

2017-02-21 Thread Uri Lublin
On 02/21/2017 02:52 PM, Oscar Segarra wrote: Hi Uri, The problem comes when VMs can migrate between Hypervisors. It is, eventually the scenario can turn as follows: Hypervisor1 (10.0.0.1) <-- Stopped due to maintenance Hypervisor2 (10.0.0.2) VM1 (port 5900) VM2 (port 5901) VM3 (port

Re: [Spice-devel] Spice protocol behind a Firewall

2017-02-21 Thread Oscar Segarra
Hi Uri, The problem comes when VMs can migrate between Hypervisors. It is, eventually the scenario can turn as follows: Hypervisor1 (10.0.0.1) <-- Stopped due to maintenance Hypervisor2 (10.0.0.2) VM1 (port 5900) VM2 (port 5901) VM3 (port 5902) VM4 (port 5903) Thanks a lot! 2017

Re: [Spice-devel] Spice protocol behind a Firewall

2017-02-21 Thread Uri Lublin
On 02/21/2017 11:04 AM, Oscar Segarra wrote: Hi Uri, Thanks a lot for th example... It looks clarify the security/acl but what I'd like to know is if is there any known configuration for an scenario like this: Hypervisor1 (10.0.0.1) VM1 (port 5900) VM2 (port 5901) Hypervisor2 (10.0.0.2)

Re: [Spice-devel] Spice protocol behind a Firewall

2017-02-21 Thread Oscar Segarra
Thanks a lot Christophe for your clarifications...I will try and I will let you know! > 2.- How squid redirects requests to the correct hypervisor (where VM is > running) Is this any different than if these were for example http servers residing on the internal servers? Can't something like SPICE

Re: [Spice-devel] Spice protocol behind a Firewall

2017-02-21 Thread Christophe Fergeau
On Tue, Feb 21, 2017 at 11:30:03AM +0100, Oscar Segarra wrote: > Hi Christophe, > > I have already read this document... and I'm not able to translate it to > the scenario I've posted.. > > In this case I cannot see: > > 1.- Where configure ports Not familiar at all with squid, but I'd expect t

Re: [Spice-devel] Windows drivers for virgl?

2017-02-21 Thread Yan Vugenfirer
Hi Benrooz, I am adding Vadim to the thread. He is working on virtio-gpu for Windows. Best regards, Yan. > On 21 Feb 2017, at 12:39, Behrooz Shabani wrote: > > Hi All, > > I discussed the state of windows drivers on IRC with the developers awhile > back but as not everybody is on the channel

[Spice-devel] Windows drivers for virgl?

2017-02-21 Thread Behrooz Shabani
Hi All, I discussed the state of windows drivers on IRC with the developers awhile back but as not everybody is on the channel, I wanted to ask here as well: Are you aware of any implementation efforts regarding Windows drivers of virgl? Maybe someone can provide some insights on how to approach

Re: [Spice-devel] Spice protocol behind a Firewall

2017-02-21 Thread Oscar Segarra
Hi Christophe, I have already read this document... and I'm not able to translate it to the scenario I've posted.. In this case I cannot see: 1.- Where configure ports 2.- How squid redirects requests to the correct hypervisor (where VM is running) 3.- In my environment where I don't have oVirt.

Re: [Spice-devel] Spice protocol behind a Firewall

2017-02-21 Thread Christophe Fergeau
On Tue, Feb 21, 2017 at 10:04:52AM +0100, Oscar Segarra wrote: > Hi Uri, > > Thanks a lot for th example... It looks clarify the security/acl but what > I'd like to know is if is there any known configuration for an scenario > like this: > > Hypervisor1 (10.0.0.1) > VM1 (port 5900) > VM2

Re: [Spice-devel] Spice protocol behind a Firewall

2017-02-21 Thread Oscar Segarra
Hi Uri, Thanks a lot for th example... It looks clarify the security/acl but what I'd like to know is if is there any known configuration for an scenario like this: Hypervisor1 (10.0.0.1) VM1 (port 5900) VM2 (port 5901) Hypervisor2 (10.0.0.2) VM3 (port 5902) VM4 (port 5903) Of co

Re: [Spice-devel] Spice protocol behind a Firewall

2017-02-21 Thread Uri Lublin
On 02/19/2017 07:33 PM, Oscar Segarra wrote: Hi Uri, I have not been able to find the example you suggest... can you paste the url of the example? Hi Oscar, Disclaimer: This is just an example. There may be better more secure ways to do it. You should research and decide on a solution