Re: [Spice-devel] [spice-server] channel: Remove unused vfunc typedefs from header

2017-02-13 Thread Frediano Ziglio
> > They became unused more than 5 years ago in commit f84dfe > --- > server/red-channel.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/server/red-channel.h b/server/red-channel.h > index f2866f5..4430d0b 100644 > --- a/server/red-channel.h > +++ b/server/red-channel.h > @@ -112,8 +

[Spice-devel] [spice-server] channel: Remove unused vfunc typedefs from header

2017-02-13 Thread Christophe Fergeau
They became unused more than 5 years ago in commit f84dfe --- server/red-channel.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/server/red-channel.h b/server/red-channel.h index f2866f5..4430d0b 100644 --- a/server/red-channel.h +++ b/server/red-channel.h @@ -112,8 +112,6 @@ typedef void

[Spice-devel] [PATCH 1/2] authentication: Handle failed SASL authentication separately

2017-02-13 Thread Snir Sheriber
Remove handling with failures in the SASL authentication process to separate function and display the error message as reported by the SASL client (could also display SASL server error message if error number was sent to the client) --- src/spice-channel.c | 42 +---

[Spice-devel] [PATCH 2/2] authentication: Handle failed spice authentication

2017-02-13 Thread Snir Sheriber
Changing the name of the function that now handles failures in the spice authentication process separately from the sasl authentication failures and display more suitable error message. Resolves: rhbz#1365736 --- src/spice-channel.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[Spice-devel] [PATCH 0/2] Handle failed authentication

2017-02-13 Thread Snir Sheriber
These patches splits the handling of failed authentication into 2 separate patches: one for sasl authentication failure and the other one for spice authentication failure. The idea behind these is to: 1. make (small) improvement in error messages content 2. fix rhbz#1399077 3. preparation for disp

Re: [Spice-devel] [spice-server 01/10] Remove unused 3rd red_channel_register_client_cbs() arg

2017-02-13 Thread Frediano Ziglio
> > > > > On Fri, Feb 10, 2017 at 08:27:27AM -0500, Frediano Ziglio wrote: > > > > > > > > On Wed, Feb 08, 2017 at 12:10:52PM -0600, Jonathon Jongsma wrote: > > > > > On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote: > > > > > > It was probably meant to be used as a "user_data" argume

Re: [Spice-devel] [spice-server 03/10] Remove OutgoingHandlerInterface

2017-02-13 Thread Frediano Ziglio
> > On Fri, Feb 10, 2017 at 11:17:44AM -0500, Frediano Ziglio wrote: > > > > > > On Fri, Feb 10, 2017 at 10:36:10AM -0500, Frediano Ziglio wrote: > > > > So are you saying you prefer an heavy unsafe signal instead of a > > > > function call just for statistics that's disabled by default? > > > >

Re: [Spice-devel] [PATCH 1/7] qxl-wddm-dod: Return EDID data to the OS

2017-02-13 Thread Yuri Benditovich
Binary EDID block is generated by 3rd party app and converted to the text as is. As soon as it is accepted by OS, we think it is valid. I'll provide some decoding info after we finish the first round of discussion. Of couse it is also possible to present alpha chars as characters, if this is really

Re: [Spice-devel] [spice-server 04/10] Remove IncomingHandlerInterface::{alloc, release}_msg_buf

2017-02-13 Thread Frediano Ziglio
> > > > > On Wed, Feb 08, 2017 at 12:54:44PM -0600, Jonathon Jongsma wrote: > > > On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote: > > > > Similarly to the previous commits, this removes an indirection level, > > > > IncomingHandlerInterface stores pointers to > > > > alloc_recv_buf/r

Re: [Spice-devel] [PATCH 1/7] qxl-wddm-dod: Return EDID data to the OS

2017-02-13 Thread Frediano Ziglio
> > > > On 12 Feb 2017, at 14:09, Yuri Benditovich > > wrote: > > > > Solves failure of HLK "Test for EDID requirements" > > EDID contains capabilities and manufacturer data of > > the emulated display device. Main parameters are: > > Manufacturer code: QXL > > Product ID: 0001 > > Working freq

Re: [Spice-devel] [PATCH 1/7] qxl-wddm-dod: Return EDID data to the OS

2017-02-13 Thread Christophe de Dinechin
> On 12 Feb 2017, at 14:09, Yuri Benditovich > wrote: > > Solves failure of HLK "Test for EDID requirements" > EDID contains capabilities and manufacturer data of > the emulated display device. Main parameters are: > Manufacturer code: QXL > Product ID: 0001 > Working frequency: 75 Hz > > Sign

[Spice-devel] [PATCH spice-server 4/4] Provide and reuse default implementation for config_socket

2017-02-13 Thread Frediano Ziglio
Most channel don't need to do specific settings for the client socket so provide a default implementation to make easier to setup the client channnel. Signed-off-by: Frediano Ziglio --- server/inputs-channel.c | 6 -- server/main-channel.c | 6 -- server/red-channel-client.c |

[Spice-devel] [PATCH spice-server 1/4] Clear "msg" pointers after releasing

2017-02-13 Thread Frediano Ziglio
Avoid possible dandling pointers. Signed-off-by: Frediano Ziglio --- server/red-channel-client.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/server/red-channel-client.c b/server/red-channel-client.c index 06fb8a8..2450923 100644 --- a/server/red-channel-client.c +++ b/server/red-channe

[Spice-devel] [PATCH spice-server 3/4] Do not set TCP_NODELAY flag twice

2017-02-13 Thread Frediano Ziglio
TCP_NODELAY flag is set by default for all connection inside reds.c so there's no need to set again for the single client channel. Note that there are still some call to setsockopt to set this option but in this case the flag can reset the flag. Signed-off-by: Frediano Ziglio --- server/inputs-

[Spice-devel] [PATCH spice-server 2/4] Do not set not blocking flag twice

2017-02-13 Thread Frediano Ziglio
Non blocking flag is set for all connection inside reds.c so there's no need to set again for the single client channel. Signed-off-by: Frediano Ziglio --- server/common-graphics-channel.c | 11 --- server/sound.c | 11 --- 2 files changed, 22 deletions(-) diff

Re: [Spice-devel] [PATCH 7/7] qxl-wddm-dod: Set VSync notification period to 200 ms

2017-02-13 Thread Yuri Benditovich
On Mon, Feb 13, 2017 at 11:50 AM, Frediano Ziglio wrote: > > > > With default period of VSync interrupt notification > > (1sec/refresh rate) the driver with device rev.4 > > has a problem when the system starts running after > > restart. Until the issue is solved we set the notification > > perio

Re: [Spice-devel] [spice-server 04/10] Remove IncomingHandlerInterface::{alloc, release}_msg_buf

2017-02-13 Thread Frediano Ziglio
> > On Wed, Feb 08, 2017 at 12:54:44PM -0600, Jonathon Jongsma wrote: > > On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote: > > > Similarly to the previous commits, this removes an indirection level, > > > IncomingHandlerInterface stores pointers to > > > alloc_recv_buf/release_recv_buf

Re: [Spice-devel] [spice-server 03/10] Remove OutgoingHandlerInterface

2017-02-13 Thread Christophe Fergeau
On Fri, Feb 10, 2017 at 11:17:44AM -0500, Frediano Ziglio wrote: > > > > On Fri, Feb 10, 2017 at 10:36:10AM -0500, Frediano Ziglio wrote: > > > So are you saying you prefer an heavy unsafe signal instead of a > > > function call just for statistics that's disabled by default? > > > > My desktop i

Re: [Spice-devel] Help !!!!

2017-02-13 Thread Frediano Ziglio
> > On 02/10/2017 01:40 PM, Bernice Levin wrote: > > Hi Guys (Dolls) > > > > > > > > Please I need your help. I have installed KVM Hypervisor on OpenSUSE, I > > have everything working – installed VMs and have accessed them on > > localhost through Virt-viewer but cannot get access on the network

Re: [Spice-devel] [PATCH 4/5] DisplayChannel: use proper function name conventions

2017-02-13 Thread Frediano Ziglio
> > On Fri, 2017-02-10 at 06:57 -0500, Frediano Ziglio wrote: > > > > > > Change current_add_drawable() to display_channel_add_drawable() and > > > current_remove_drawable() to display_channel_remove_drawable(). > > > --- > > >  server/display-channel.c | 28 ++-- > > >  1

Re: [Spice-devel] [PATCH 7/7] qxl-wddm-dod: Set VSync notification period to 200 ms

2017-02-13 Thread Frediano Ziglio
> > With default period of VSync interrupt notification > (1sec/refresh rate) the driver with device rev.4 > has a problem when the system starts running after > restart. Until the issue is solved we set the notification > period to 200 ms, with this value both rev.3 and rev.4 > function correctly

Re: [Spice-devel] [PATCH 5/7] qxl-wddm-dod: Fix video modes enumeration

2017-02-13 Thread Yuri Benditovich
Depending on the order of tests, this also can cause some tests to fail, if they verify (explicitly or implicitly) presence of 1024x768. On Mon, Feb 13, 2017 at 11:17 AM, Frediano Ziglio wrote: > > > > When the video mode is changed and then the driver disabled and > > enabled, it did not enume

Re: [Spice-devel] [PATCH 5/7] qxl-wddm-dod: Fix video modes enumeration

2017-02-13 Thread Frediano Ziglio
> > When the video mode is changed and then the driver disabled and > enabled, it did not enumerate available video modes with lower > resolution than current one. All modes starting from 1024x768 > should be available regardless what is current resolution > on driver startup > > Signed-off-by: Y

Re: [Spice-devel] [PATCH 2/7] qxl-wddm-dod: Option to provide frequency data to the OS

2017-02-13 Thread Frediano Ziglio
> > Concentrate filling of signal info in single procedure. > Fill signal info with specific or default frequency data > according to the global flag of VSync support. > Note that the state of this flobal flag must be defined only > on driver startup and it can't be changed later. > I would add

Re: [Spice-devel] [PATCH 1/7] qxl-wddm-dod: Return EDID data to the OS

2017-02-13 Thread Frediano Ziglio
> > Solves failure of HLK "Test for EDID requirements" > EDID contains capabilities and manufacturer data of > the emulated display device. Main parameters are: > Manufacturer code: QXL > Product ID: 0001 > Working frequency: 75 Hz > > Signed-off-by: Yuri Benditovich > --- > qxldod/QxlDod.cpp |

Re: [Spice-devel] Xspice with --vdagent disables mouse

2017-02-13 Thread Jordan Sokolic
Hi, I managed to solve the issue by adding the -X flag to the arguments passed to spice-vdagentd. After some reading up on systemd and perusing some source code I narrowed the problem down to systemd-logind, specifically which session it reports as the active session. Xspice successfully launches