On Fri, 2017-02-10 at 10:45 +0100, Christophe de Dinechin wrote:
> Overall, I like the patches. But I wonder if it would make sense to
> switch to a doxygen format for large comments like this?
I personally don't see a huge advantage to using a tool like doxygen
here, since I rarely am interested
On Fri, 2017-02-10 at 06:56 -0500, Frediano Ziglio wrote:
> >
> >
[snip]
> > +/* Add a @drawable (with a shadow) to the current ring.
> > + * The return value indicates whether the new item should be added
> > to the
> > pipe */
>
> it's @drawable or @item ?
I guess it should be @item.
>
>
On Fri, 2017-02-10 at 06:57 -0500, Frediano Ziglio wrote:
> >
> > Change current_add_drawable() to display_channel_add_drawable() and
> > current_remove_drawable() to display_channel_remove_drawable().
> > ---
> > server/display-channel.c | 28 ++--
> > 1 file changed, 14
Hi Guys (Dolls)
Please I need your help. I have installed KVM Hypervisor on OpenSUSE, I have
everything working - installed VMs and have accessed them on localhost through
Virt-viewer but cannot get access on the network from a windows 10 PC on
remote-viewer. I think the problem is that there i
>
> On Fri, Feb 10, 2017 at 10:36:10AM -0500, Frediano Ziglio wrote:
> > So are you saying you prefer an heavy unsafe signal instead of a
> > function call just for statistics that's disabled by default?
>
> My desktop is built on such signals and works just fine, thank you ;)
These are patches
On Fri, Feb 10, 2017 at 04:54:50PM +0100, Michal Suchánek wrote:
> Of course, if you split the commit and bisection points to one of the
> commits that clearly change the behavior for a few message types it is
> then easy to check handling of those messages and fix it. If the
> bisection points to
On Fri, Feb 10, 2017 at 10:36:10AM -0500, Frediano Ziglio wrote:
> So are you saying you prefer an heavy unsafe signal instead of a
> function call just for statistics that's disabled by default?
My desktop is built on such signals and works just fine, thank you ;)
And yes, statistics gathering do
On Mon, 30 Jan 2017 13:11:40 +0100
Christophe Fergeau wrote:
> On Fri, Jan 27, 2017 at 03:37:17PM +0100, Michal Suchánek wrote:
> > On Wed, 25 Jan 2017 08:24:55 +0100
> > Christophe Fergeau wrote:
> >
> > > On Tue, Jan 24, 2017 at 07:52:11PM +0100, Michal Suchánek wrote:
> > > > On Tue, 24
>
> On Fri, Feb 10, 2017 at 04:47:15AM -0500, Frediano Ziglio wrote:
> > >
> > > On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote:
> > > > RedChannel uses OutgoingHandlerInterface to provide constant pointers
> > > > to
> > > > RedChannelClient methods. This OutgoingHandlerInterface st
On Fri, Feb 10, 2017 at 08:25:35AM -0500, Frediano Ziglio wrote:
> I personally would merge even without the others, just the comment
> require a next commit.
>
> Acked-by: Frediano Ziglio
Agreed, pushed after rewording the commit log.
Christophe
signature.asc
Description: PGP signature
_
On Wed, Feb 08, 2017 at 04:43:09PM -0600, Jonathon Jongsma wrote:
> On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote:
> > This commit removes IncomingHandlerInterface::on_error and
> > IncomingHandlerInterface::on_input. As with previous commits, these
> > vfuncs are always calling the m
On Fri, Feb 10, 2017 at 08:17:47AM -0500, Frediano Ziglio wrote:
> >
> > On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote:
> > > Similarly to the previous commits, this removes an indirection level,
> > > IncomingHandlerInterface stores pointers to
> > > alloc_recv_buf/release_recv_buf
On Wed, Feb 08, 2017 at 12:54:44PM -0600, Jonathon Jongsma wrote:
> On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote:
> > Similarly to the previous commits, this removes an indirection level,
> > IncomingHandlerInterface stores pointers to
> > alloc_recv_buf/release_recv_buf vfuncs, but
On Fri, 2017-02-10 at 09:47 -0500, Frediano Ziglio wrote:
> >
> > Hi Cory,
> >
> >
> > On 01/29/2017 04:38 PM, Cory Schwartz wrote:
> > > Hi,
> > >
> > > I noticed on the example page
> > > https://www.spice-space.org/spice-html5/spice.html
> > > that you are unable to connect to a websocket wh
>
> Hi Cory,
>
>
> On 01/29/2017 04:38 PM, Cory Schwartz wrote:
> > Hi,
> >
> > I noticed on the example page
> > https://www.spice-space.org/spice-html5/spice.html
> > that you are unable to connect to a websocket where SSL is not
> > implemented. The reason for this is that the original site
On Fri, Feb 10, 2017 at 04:47:15AM -0500, Frediano Ziglio wrote:
> >
> > On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote:
> > > RedChannel uses OutgoingHandlerInterface to provide constant pointers
> > > to
> > > RedChannelClient methods. This OutgoingHandlerInterface structure is
> >
smartcard_channel_client_pipe_add_push was just calling
red_channel_client_pipe_add_push without any cast or other
changes.
Signed-off-by: Frediano Ziglio
---
server/smartcard.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/server/smartcard.c b/server/smart
Do not make it assume vec contains IOV_MAX elements.
Signed-off-by: Frediano Ziglio
---
server/red-channel-client.c | 12 +++-
server/red-channel-client.h | 4 ++--
server/red-channel.h| 2 +-
3 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/server/red-channel-cl
This was always set to vec_buf.
Signed-off-by: Frediano Ziglio
---
server/red-channel-client-private.h | 3 +--
server/red-channel-client.c | 2 --
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/server/red-channel-client-private.h
b/server/red-channel-client-private.h
ind
On Fri, Feb 10, 2017 at 04:27:57AM -0500, Frediano Ziglio wrote:
> >
> > On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote:
> >
> > Although I think it's a little bit unfortunate that we need to expose
> > another function in red-channel.h, it does seem to make more sense this
> > way.
On Wed, Feb 08, 2017 at 12:17:01PM -0600, Jonathon Jongsma wrote:
> [1] speaking of which, why is it opaque instead of a RedChannelClient*?
> Maybe that will be addressed later in this series...
Yup, it's done down the road, see "rcc: Replace 'opaque' arg with typed
RedChannelClient"
Christophe
>
> On Fri, Feb 10, 2017 at 08:27:27AM -0500, Frediano Ziglio wrote:
> > >
> > > On Wed, Feb 08, 2017 at 12:10:52PM -0600, Jonathon Jongsma wrote:
> > > > On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote:
> > > > > It was probably meant to be used as a "user_data" argument for the
> >
On Fri, Feb 10, 2017 at 08:27:27AM -0500, Frediano Ziglio wrote:
> >
> > On Wed, Feb 08, 2017 at 12:10:52PM -0600, Jonathon Jongsma wrote:
> > > On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote:
> > > > It was probably meant to be used as a "user_data" argument for the
> > > > various c
>
> On Wed, Feb 08, 2017 at 12:10:52PM -0600, Jonathon Jongsma wrote:
> > On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote:
> > > It was probably meant to be used as a "user_data" argument for the
> > > various callbacks, but turns out not to be used.
> >
> > Hmm, it looks like the las
I personally would merge even without the others, just the comment
require a next commit.
Acked-by: Frediano Ziglio
Frediano
>
> Acked-by: Jonathon Jongsma
>
>
> On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote:
> > Minor refactoring in preparation for the next commits (and rega
>
> On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote:
> > This commit removes IncomingHandlerInterface::on_error and
> > IncomingHandlerInterface::on_input. As with previous commits, these
> > vfuncs are always calling the method, and RedChannel::init sets them
> > to
> > point to RedCh
On Fri, Feb 10, 2017 at 04:23:46AM -0500, Frediano Ziglio wrote:
> >
> > On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote:
> > > It was probably meant to be used as a "user_data" argument for the
> > > various callbacks, but turns out not to be used.
> >
> > Hmm, it looks like the last
On Wed, Feb 08, 2017 at 12:10:52PM -0600, Jonathon Jongsma wrote:
> On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote:
> > It was probably meant to be used as a "user_data" argument for the
> > various callbacks, but turns out not to be used.
>
> Hmm, it looks like the last use of this '
>
> On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote:
> > Similarly to the previous commits, this removes an indirection level,
> > IncomingHandlerInterface stores pointers to
> > alloc_recv_buf/release_recv_buf vfuncs, but these are always set to
> > RedChannel::alloc_recv_buf/RedChann
Hi,
On Fri, Feb 10, 2017 at 07:51:05AM -0500, Frediano Ziglio wrote:
> > [0] SPICE_MSGC_DISPLAY_PREFERRED_VIDEO_CODEC_TYPE
> >
> > This message provides a list of video codecs based on client's order
> > of preference.
> >
> > We duplicate the video codecs array from reds.c and sort it using the
> [0] SPICE_MSGC_DISPLAY_PREFERRED_VIDEO_CODEC_TYPE
>
> This message provides a list of video codecs based on client's order
> of preference.
>
> We duplicate the video codecs array from reds.c and sort it using the
> order of codecs as reference.
>
> This message will not change an ongoing stre
Signed-off-by: Frediano Ziglio
---
server/common-graphics-channel.c | 26 +++---
server/red-channel-client.c | 16 ++--
2 files changed, 25 insertions(+), 17 deletions(-)
diff --git a/server/common-graphics-channel.c b/server/common-graphics-channel.c
index 2
These patches try to add interface to support flush interface.
This interface helps improving bandwidth usage reducing bytes sent
through network.
The TCP_CORK is one possible usage of the library which actually
decreases packet numbers (not using SSL) by usually a 5-10%.
As you can see from
https:
The writing to network was always immediate.
Every write in the stream cause a write to the OS.
Can this have some penalty if you don't write large data as network
packets can be more fragmented or you encrypt data is smaller chunks
(when data are encrypted some padding is added then data is split
Signed-off-by: Frediano Ziglio
---
server/reds-stream.c | 34 +-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/server/reds-stream.c b/server/reds-stream.c
index 67968f9..6a35ff2 100644
--- a/server/reds-stream.c
+++ b/server/reds-stream.c
@@ -24,6 +
>
> Change current_add_drawable() to display_channel_add_drawable() and
> current_remove_drawable() to display_channel_remove_drawable().
> ---
> server/display-channel.c | 28 ++--
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/server/display-channe
>
> The code that manages pending QXL Drawable operations is fairly complex
> and difficult to understand. This is an attempt to start documenting
> that code to save time when we have to work on this code in the future.
> ---
> server/display-channel.c | 80
> +++
>
> On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote:
> > RedChannel uses OutgoingHandlerInterface to provide constant pointers
> > to
> > RedChannelClient methods. This OutgoingHandlerInterface structure is
> > then used in RedChannelClient to indirectly call these methods.
> >
> > Si
Overall, I like the patches. But I wonder if it would make sense to switch to a
doxygen format for large comments like this?
Christophe
> On 9 Feb 2017, at 20:46, Jonathon Jongsma wrote:
>
> On Fri, 2017-02-03 at 16:55 -0600, Jonathon Jongsma wrote:
>> Here's a slightly expanded and separated
>
> On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote:
> > Have the RedChannelClient callback call into a RedChannel callback
> > rather than doing the opposite. This will be useful in some
> > subsequent
> > refactoring of this code.
> > ---
> > server/red-channel-client.c | 2 ++
> >
>
> On Tue, 2017-02-07 at 11:59 +0100, Christophe Fergeau wrote:
> > It was probably meant to be used as a "user_data" argument for the
> > various callbacks, but turns out not to be used.
>
> Hmm, it looks like the last use of this 'data' variable was removed in
> 96e94c6f. That commit used g_ob
>
> Hey,
>
> This patch series removes IncomingHandlerInterface and
> OutgoingHandlerInterface
> which added a layer of indirection between RedChannel/RedChannelClient which
> is no longer useful now that RedChannel/RedChannelClient are real classes.
>
> Christophe
>
I agree with most of the c
42 matches
Mail list logo
