Hi,
On Thu, Dec 15, 2016 at 12:10:46PM -0500, Frediano Ziglio wrote:
> >
> > Hi,
> >
> > On Wed, Dec 14, 2016 at 05:07:17PM -0500, Frediano Ziglio wrote:
> > > >
> > > > Commit 5907b6cbb5c724f9729da59a644271b4258d122e started to handle
> > > > Lock/Unlock events from Session at VDAgent. That se
This helps us avoid stalled video streams.
Signed-off-by: Jeremy White
---
display.js | 8
1 file changed, 8 insertions(+)
diff --git a/display.js b/display.js
index d4baef7..c97f237 100644
--- a/display.js
+++ b/display.js
@@ -1114,6 +1114,14 @@ function handle_append_video_buffer_don
Signed-off-by: Jeremy White
---
display.js | 6 ++
1 file changed, 6 insertions(+)
diff --git a/display.js b/display.js
index 40a809e..c124483 100644
--- a/display.js
+++ b/display.js
@@ -1106,6 +1106,12 @@ function handle_append_video_buffer_done(e)
{
stream.append_okay = true
Signed-off-by: Jeremy White
---
display.js | 4
1 file changed, 4 insertions(+)
diff --git a/display.js b/display.js
index c124483..d4baef7 100644
--- a/display.js
+++ b/display.js
@@ -,7 +,11 @@ function handle_append_video_buffer_done(e)
{
if (STREAM_DEBUG > 0)
This involved a review of the Firefox parsing code along
with the official specifcation, and setting these fields
to the specified default values.
Signed-off-by: Jeremy White
---
webm.js | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/webm.js b/webm.js
i
Use spice_marshaller_add_by_ref_full() instead of _add_by_ref() to
handle the referenced data properly rather than passing the pipe item to
red_channel_client_init_send_data() to keep the pipe item alive
indirectly.
---
server/main-channel-client.c | 14 +++---
1 file changed, 11 insertion
From: Frediano Ziglio
Use spice_marshaller_add_by_ref_full() instead of
spice_marshaller_add_by_ref() to allow the marshaller to manage the
lifetime of the referenced data buffer rather than having to manage it
by passing a PipeItem to red_channel_client_init_send_data(). Since the
data is owned
The fill_bits() function marshalls some data by reference. This data is
owned by the RedDrawable that is owned by the Drawable that is owned by
the RedDrawablePipeItem. Instead of keeping the RedPipeItem alive by
passing it to red_channel_client_init_send_data(), simply reference the
Drawable and
The only time that the pipe item needs to be passed as the third
argument to red_channel_client_init_send_data() is when the pipe item
holds a data buffer that has been added to the marshaller by reference
(spice_marshaller_add_by_ref()) and needs to be kept alive until the
data has been sent. In a
---
server/spicevmc.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/server/spicevmc.c b/server/spicevmc.c
index a85c80a..32793bd 100644
--- a/server/spicevmc.c
+++ b/server/spicevmc.c
@@ -627,6 +627,12 @@ static void
spicevmc_red_channel_release_msg_rcv_buf(R
---
server/dcc-send.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/server/dcc-send.c b/server/dcc-send.c
index edeea62..db42ab8 100644
--- a/server/dcc-send.c
+++ b/server/dcc-send.c
@@ -1118,7 +1118,7 @@ static void red_marshall_qxl_copy_bits(RedChannelCl
This third argument (and the 'item' member of
RedChannelClient::priv::send_data) was a somewhat roundabout way to keep
the RedPipeItem alive until a message is sent, just in case some data
owned by that pipeitem was added to the marshaller by reference. This
was a rather confusing mechanism, howeve
Any data that is added to the marshaller by reference (using e.g.
spice_marshaller_add_by_ref_full()) is freed during
spice_marshaller_reset(). But the marshaller is not currently reset
until we begin to send the next message (in
red_channel_client_send_item()). This means that the sent message dat
A series of patches refactoring the somewhat-confusing
red_channel_client_init_send_data() function. The third argument to this
function is a RedPipeItem and it was never very obvious when or why we should
pass an item in this parameter. Sometimes callers passed NULL, and sometimes
they passed an i
---
server/smartcard-channel-client.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/server/smartcard-channel-client.c
b/server/smartcard-channel-client.c
index 347e177..aece01b 100644
--- a/server/smartcard-channel-client.c
+++ b/server/smartcard-channel-clie
From: Victor Toso
As we have UsbDk integration now which is well maintained upstream.
Signed-off-by: Victor Toso
---
doc/reference/Makefile.am| 2 -
src/Makefile.am | 3 -
src/usb-device-manager.c | 308 +++
src/win-usb-clerk.h | 3
Adam Jackson (1):
Use pci_io_write8 instead of outb
Christophe Fergeau (16):
Remove unused variables
Remove stray blank comment line
Use <> for system-includes
Fix compilation with newer Xorg versions
Add missing licence header
Add note about deprecated se
Hi,
On Thu, Dec 15, 2016 at 03:20:36PM +0100, Pavel Grunt wrote:
> Hi,
>
> On Fri, 2016-12-09 at 18:22 +0100, Victor Toso wrote:
> > From: Victor Toso
> >
> > As we have UsbDk integration now which is well maintained upstream.
>
> yes, it makes a sense
>
> >
> > Signed-off-by: Victor Toso
>
I like it. I'll include this in the new patch series.
On Sun, 2016-12-18 at 13:11 +, Frediano Ziglio wrote:
> Use spice_marshaller_add_by_ref_full() instead of
> spice_marshaller_add_by_ref() to allow the marshaller to manage the
> lifetime of the referenced data buffer rather than having to
---
src/spice-widget.c | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index 791f5b0..cf18fa6 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -1016,6 +1016,17 @@ static gboolean do_pointer_grab(SpiceD
---
src/spice-widget.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index bc705f8..791f5b0 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -120,6 +120,9 @@ static void size_allocate(GtkWidget *widget, GtkAllocation
*co
gdk_window_get_pointer has been deprecated since Gtk 3.0
---
src/spice-widget.c | 54 --
1 file changed, 44 insertions(+), 10 deletions(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index a27f5a2..ddaa10f 100644
--- a/src/spice-widget.
Create the cursor when the widget is realized
---
src/spice-widget.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index 72fbbc8..a27f5a2 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -460,12 +460,12 @@ stat
gdk_display_warp_pointer has been deprecated since Gtk 3.0
---
src/spice-widget.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index ddaa10f..bc705f8 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -119,6 +119
Hi,
this is a follow up to Francois's patches which avoided some deprecated
warnings in the SpiceDisplay widget. The main difference is the usage
of GdkSeat api that was introduced in Gtk 3.20.
v2 (Frediano's review):
- removed usage of deprecated function (gdk_display_warp_pointer,
gdk_window_
On 12/15/2016 03:04 PM, Christophe Fergeau wrote:
In newer X.org versions, it's no longer supported to modify the set of
FDs passed to a BlockHandler method to get notified when the FD has data
to be read. This was limited anyway as we could only get read events
this way, and had to do our own po
According to CPU consumption measurement, cursor position processing takes
in average approx 4% of rendering time, during short periods above 10%.
Measured on Win10, 4G, 4 CPU.
On Mon, Dec 19, 2016 at 12:26 PM, Christophe Fergeau
wrote:
> This is not the first time this is posted, but I still ha
On Mon, 2016-12-19 at 04:29 -0500, Frediano Ziglio wrote:
> >
> > ---
> > src/spice-widget.c | 26 ++
> > 1 file changed, 22 insertions(+), 4 deletions(-)
> >
> > diff --git a/src/spice-widget.c b/src/spice-widget.c
> > index a3d6526..cedc358 100644
> > --- a/src/spice-wi
Hi Frediano,
On Mon, 2016-12-19 at 04:25 -0500, Frediano Ziglio wrote:
> >
> > ---
> > src/spice-widget.c | 46 -
> > -
> > 1 file changed, 36 insertions(+), 10 deletions(-)
> >
> > diff --git a/src/spice-widget.c b/src/spice-widget.c
> > index a27f5a
>
> On 12/08/2016 08:32 PM, Frediano Ziglio wrote:
> > Sort based on coding style.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/inputs-channel.c | 2 +-
> > server/jpeg-encoder.c | 4 +++-
> > server/mjpeg-encoder.c | 8 +---
> > server/reds-stream.c| 13 +++--
On 12/08/2016 08:32 PM, Frediano Ziglio wrote:
Sort based on coding style.
Signed-off-by: Frediano Ziglio
---
server/inputs-channel.c | 2 +-
server/jpeg-encoder.c | 4 +++-
server/mjpeg-encoder.c | 8 +---
server/reds-stream.c| 13 +++--
server/spicevmc.c | 6 +++-
This is not the first time this is posted, but I still haven't seen any
strong rationale for doing it. Iirc you said you had numbers showing
this is important to have?
Christophe
On Mon, Dec 19, 2016 at 11:12:58AM +0200, Yuri Benditovich wrote:
> From: Yuri Benditovich
>
> Client mouse mode def
>
> ---
> src/spice-widget.c | 26 +++---
> 1 file changed, 19 insertions(+), 7 deletions(-)
>
> diff --git a/src/spice-widget.c b/src/spice-widget.c
> index cedc358..17cda84 100644
> --- a/src/spice-widget.c
> +++ b/src/spice-widget.c
> @@ -1015,6 +1015,18 @@ static gboolean
>
> ---
> src/spice-widget.c | 26 ++
> 1 file changed, 22 insertions(+), 4 deletions(-)
>
> diff --git a/src/spice-widget.c b/src/spice-widget.c
> index a3d6526..cedc358 100644
> --- a/src/spice-widget.c
> +++ b/src/spice-widget.c
> @@ -119,6 +119,9 @@ static void releas
>
> ---
> src/spice-widget.c | 46 --
> 1 file changed, 36 insertions(+), 10 deletions(-)
>
> diff --git a/src/spice-widget.c b/src/spice-widget.c
> index a27f5a2..a3d6526 100644
> --- a/src/spice-widget.c
> +++ b/src/spice-widget.c
> @@ -2355,11 +2355
From: Yuri Benditovich
Client mode of mouse pointer defined as display capability to
allow easy indication of mouse mode change
Signed-off-by: Yuri Benditovich
---
spice/protocol.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/spice/protocol.h b/spice/protocol.h
index d742eda..a5f9b97 10
From: Yuri Benditovich
Client mouse mode defined as display capability and indicated to guest
amont display capabilities
Yuri Benditovich (1):
introduce SPICE_DISPLAY_CAP_CLIENT_MOUSE capability
indicate client mouse mode to guest as capability
spice/protocol.h | 1 +
1 file changed, 1 ins
From: Yuri Benditovich
Raise indication of capabilities array yo guest also on changing
mouse mode; add 'client mouse' capability when active.
Signed-off-by: Yuri Benditovich
---
server/red-worker.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/server/red-worker.c b/server/red-wor
38 matches
Mail list logo
