Re: [Spice-devel] [spice-server v2 8/9] reds: add support to ranks for video codecs

2016-12-13 Thread Victor Toso
Hi, You rock. I'll use this as reference for future proposals, many thanks! On Wed, Dec 14, 2016 at 04:10:55AM +0100, Francois Gouget wrote: > > Client says that prefers vp8, maybe due hw decoding capability. > > So let's build a proper case for your proposal: > > There are two cases where the co

Re: [Spice-devel] [spice-server v2 8/9] reds: add support to ranks for video codecs

2016-12-13 Thread Francois Gouget
On Tue, 13 Dec 2016, Victor Toso wrote: > Hi, > > Thanks again for your feedback. > > On Tue, Dec 13, 2016 at 08:06:50PM +0100, Francois Gouget wrote: > > So your complexity objection is about the format in which to send the > > client's codec preferences to the server: you want to send it as an

Re: [Spice-devel] [spice-server v2 8/9] reds: add support to ranks for video codecs

2016-12-13 Thread Victor Toso
Hi, Thanks again for your feedback. On Tue, Dec 13, 2016 at 08:06:50PM +0100, Francois Gouget wrote: > So your complexity objection is about the format in which to send the > client's codec preferences to the server: you want to send it as an > array rather than as a single string. No. "gstreame

Re: [Spice-devel] MediaRedirection

2016-12-13 Thread Francois Gouget
On Mon, 12 Dec 2016, Kenny Zhang wrote: > hi, > > Recently I used spice as remote viewer with Qemu, it's powerful. > Compared with freerdp, the video player, only support media player, it's > limited, and I get yours MediaRedirection( > https://www.spice-space.org/page/Features/MediaRedirection),

Re: [Spice-devel] [PATCH spice-server 2/2] Add some debugging for GlzDictItem structure

2016-12-13 Thread Pavel Grunt
On Tue, 2016-12-13 at 14:31 +, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio Acked-by: Pavel Grunt > --- >  server/image-encoders.c | 26 ++ >  1 file changed, 26 insertions(+) > > diff --git a/server/image-encoders.c b/server/image-encoders.c > index b23cdf0

Re: [Spice-devel] [spice-server v2 8/9] reds: add support to ranks for video codecs

2016-12-13 Thread Francois Gouget
On Tue, 13 Dec 2016, Victor Toso wrote: [...] > > > To be able to select video-codecs based on both host and client > > > preferences. > > > > I guess that by client you mean the Spice client (spice-gtk). > > Any client.. but yeah, I'll implement things in spice-gtk. Ok. I was just checking clien

Re: [Spice-devel] [spice-server v2 8/9] reds: add support to ranks for video codecs

2016-12-13 Thread Victor Toso
Hi, On Tue, Dec 13, 2016 at 06:10:17PM +0100, Francois Gouget wrote: > On Tue, 13 Dec 2016, Victor Toso wrote: > [...] > > > Why do you need a rank? > > > > To be able to select video-codecs based on both host and client > > preferences. > > I guess that by client you mean the Spice client (spice-

Re: [Spice-devel] [PATCH] Do endian swapping.

2016-12-13 Thread Victor Toso
Hi, On Mon, Nov 28, 2016 at 03:08:34PM +0100, Michal Suchanek wrote: > This allows running big endian and little endian guest side by side using > cut&paste between them. > > There is some general design idea that swapping should come as cloce to > virtio_read/virtio_write as possible. In particul

Re: [Spice-devel] [spice-server v2 8/9] reds: add support to ranks for video codecs

2016-12-13 Thread Francois Gouget
On Tue, 13 Dec 2016, Victor Toso wrote: [...] > > Why do you need a rank? > > To be able to select video-codecs based on both host and client > preferences. I guess that by client you mean the Spice client (spice-gtk). Assuming that's desired, then what you need is a way for the Spice client to

[Spice-devel] [vdagent-win v2] VDService to notify VDAgent about session status

2016-12-13 Thread Victor Toso
Commit 5907b6cbb5c724f9729da59a644271b4258d122e started to handle Lock/Unlock events from Session at VDAgent. That seemed to work fine but as pointed by Andrei at [0], it does not cover the following situation: > It fails for next test-case: > > * Connect with RV to VM > * Lock VM (ctrl-alt-del) >

Re: [Spice-devel] [vdagent-win v1] vdagent-win: start vdagent with lock info from session

2016-12-13 Thread Victor Toso
Hi, On Mon, Dec 12, 2016 at 10:46:34PM +0100, Victor Toso wrote: > and maybe move the variable definition to the top? > > Acked-by: Victor Toso > > toso I'm removing the ack from this patch. Sorry for the noise. The issue is around the whole solution in verifying reliably the lock/unlock stat

Re: [Spice-devel] [vdagent-win v1] vdagent-win: start vdagent with lock info from session

2016-12-13 Thread Victor Toso
On Tue, Dec 13, 2016 at 04:15:25PM +0100, Victor Toso wrote: > Hi, > > On Mon, Dec 12, 2016 at 10:46:34PM +0100, Victor Toso wrote: > > and maybe move the variable definition to the top? > > > > Acked-by: Victor Toso > > > > toso > > I'm removing the ack from this patch. Sorry for the noise. >

Re: [Spice-devel] [PATCH spice-server 2/2] Add some debugging for GlzDictItem structure

2016-12-13 Thread Frediano Ziglio
> > On Tue, 2016-10-18 at 10:28 +0100, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > > --- > >  server/image-encoders.c | 27 ++- > >  1 file changed, 26 insertions(+), 1 deletion(-) > > > > diff --git a/server/image-encoders.c b/server/image-encoders.c > > i

[Spice-devel] [PATCH spice-server 2/2] Add some debugging for GlzDictItem structure

2016-12-13 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/image-encoders.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/server/image-encoders.c b/server/image-encoders.c index b23cdf0..a529968 100644 --- a/server/image-encoders.c +++ b/server/image-encoders.c @@ -20,6 +20,7 @@

[Spice-devel] [PATCH spice-server 2/2] Add some debugging for GlzDictItem structure

2016-12-13 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/image-encoders.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/server/image-encoders.c b/server/image-encoders.c index b23cdf0..a5ee622 100644 --- a/server/image-encoders.c +++ b/server/image-encoders.c @@ -20,6 +20,7 @@

Re: [Spice-devel] [PATCH spice-server 2/2] Add some debugging for GlzDictItem structure

2016-12-13 Thread Pavel Grunt
On Tue, 2016-10-18 at 10:28 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/image-encoders.c | 27 ++- >  1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/server/image-encoders.c b/server/image-encoders.c > index 951fe96..70eb2

Re: [Spice-devel] [PATCH spice-html5 v2] Refine the debug messages printed at stream debug level 1.

2016-12-13 Thread Pavel Grunt
Hi Jeremy, imo would be good to split to: 1) fix debug level 2) expand debug messages 3) move timeupdate to a higher debug level Pavel On Fri, 2016-12-09 at 14:52 -0600, Jeremy White wrote: > Signed-off-by: Jeremy White > --- > v2: Turns out my working copy had a subtly different (and better) >