Hi,
> >> On a quick glance I'd blame the guest for sending corrupted commands.
> >> Strange though that it happens on migration only, so there could be
> >> a host issue too. Or a timing issue triggered by migration.
> >>
> >> Which migration phase?
> >
> > This is the point at which it switche
The spice_marshaller_add_ref() family of functions is confusing since it
sounds like you're incrementing a reference on the marshaller. What it
is actually doing is adding a data buffer to the marshaller by reference
rather than by value. Changing the function names to _add_by_ref() makes
this clea
Looks fine to me.
Acked-by: Jonathon Jongsma
On Mon, 2016-12-05 at 14:59 +0100, Victor Toso wrote:
> From: Victor Toso
>
> This patch creates display_channel_get_video_codecs() helper to let
> stream.c get the video-codecs without accessing the internal
> structure
> of DisplayChannel.
>
> As
On Mon, 2016-12-05 at 12:16 +, Frediano Ziglio wrote:
> Allow to dynamically remove QXL interfaces. This could be used to
> support hot swapping of QXL cards.
> This code is actually not used in any way.
> QXL interfaces are destroyed by spice_server_destroy automatically.
>
> Signed-off-by: F
looks like it's already acked by Pavel, but
Acked-by: Jonathon Jongsma
On Mon, 2016-12-05 at 12:16 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> Acked-by: Pavel Grunt
> ---
> server/tests/replay.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/se
Acked-by: Jonathon Jongsma
On Mon, 2016-12-05 at 12:16 +, Frediano Ziglio wrote:
> Avoid leaking it.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/reds.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/server/reds.c b/server/reds.c
> index 95295c8..d350331 100644
> ---
Acked-by: Jonathon Jongsma
On Mon, 2016-12-05 at 12:16 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/reds.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/server/reds.c b/server/reds.c
> index 17e5ada..95295c8 100644
> --- a/server/reds.c
> +++ b/se
Acked-by: Jonathon Jongsma
On Mon, 2016-12-05 at 12:16 +, Frediano Ziglio wrote:
> Avoid leaking this channel.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/reds.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/server/reds.c b/server/reds.c
> index 479a815..17e5ada 1006
Acked-by: Jonathon Jongsma
On Mon, 2016-12-05 at 12:15 +, Frediano Ziglio wrote:
> Make finalization of DisplayChannel consistent with other code.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/display-channel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --gi
On Mon, Dec 5, 2016 at 2:51 PM, Frediano Ziglio wrote:
> ping
>
> Maybe this requires some follow ups for VgaDevice and
> possibly avoinind taking into account moves during mapping
> computation.
>
>
Indeed, it seems GetMaxSourceMappingHeight(NULL, 0,...) will be also
correct.
>From other side, I
On Mon, Nov 28, 2016 at 1:03 PM, Frediano Ziglio wrote:
> Doing some fast check on Windows 8.1 you could note that
> moving windows you got a weird effect were windows were a
> bit misaligned.
> As documented in DXGKARG_PRESENT_DISPLAYONLY page
> NumMoves/pMoves fields point to an array of screen
On Mon, 2016-12-05 at 11:06 -0500, Frediano Ziglio wrote:
> >
> > It works only with glib2 >= 2.32
> > ---
> > configure.ac | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/configure.ac b/configure.ac
> > index c978b924..1400c503 100644
> > --- a/configure.ac
> > +++ b/configure
>
> It works only with glib2 >= 2.32
> ---
> configure.ac | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index c978b924..1400c503 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -149,7 +149,10 @@ PKG_CHECK_MODULES([SPICE_PROTOCOL], [spice-protocol
On 12/04/2016 09:11 AM, Snir Sheriber wrote:
> Hi,
>
> I've tried your x11spice utility , works well!
Great!
>
> We were thinking about doing something similar for Wayland, have you
> thought how it can be done under Wayland? basically the main difference
> is getting the post-compositor-buffer
It works only with glib2 >= 2.32
---
configure.ac | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configure.ac b/configure.ac
index c978b924..1400c503 100644
--- a/configure.ac
+++ b/configure.ac
@@ -149,7 +149,10 @@ PKG_CHECK_MODULES([SPICE_PROTOCOL], [spice-protocol >=
$SPICE_PROTOCOL_MI
We are already using it
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index cd78f08f..c978b924 100644
--- a/configure.ac
+++ b/configure.ac
@@ -148,7 +148,7 @@ SPICE_PROTOCOL_MIN_VER=0.12.12
PKG_CHECK_MODULES([SPICE_PROTOCOL], [sp
---
configure.ac | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/configure.ac b/configure.ac
index 4fa4c836..cd78f08f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -148,23 +148,27 @@ SPICE_PROTOCOL_MIN_VER=0.12.12
PKG_CHECK_MODULES([SPICE_PROTOCOL], [spic
Hi,
On Mon, Dec 05, 2016 at 09:39:51AM -0500, Frediano Ziglio wrote:
> > >
> > > From: Victor Toso
> > >
> > > Signed-off-by: Victor Toso
> > > ---
> > > .mailmap | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/.mailmap b/.mailmap
> > > index c05ba00..d66229a 100644
> >
> >
> > From: Victor Toso
> >
> > Signed-off-by: Victor Toso
> > ---
> > .mailmap | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/.mailmap b/.mailmap
> > index c05ba00..d66229a 100644
> > --- a/.mailmap
> > +++ b/.mailmap
> > @@ -8,3 +8,4 @@
> >
> >
> >
> > +
>
> Ack
>
> On Thu, Dec 01, 2016 at 03:43:01PM -0600, Jonathon Jongsma wrote:
> > On Thu, 2016-12-01 at 11:24 +, Frediano Ziglio wrote:
> > > This code is the same inside __new_channel but will set the
> > > RedsStream from RedChannel.
> >
> > Shouldn't this code be removed from __new_channel() then?
On Thu, Dec 01, 2016 at 03:43:01PM -0600, Jonathon Jongsma wrote:
> On Thu, 2016-12-01 at 11:24 +, Frediano Ziglio wrote:
> > This code is the same inside __new_channel but will set the
> > RedsStream from RedChannel.
>
> Shouldn't this code be removed from __new_channel() then?
I agree that
Hi,
On Fri, Dec 02, 2016 at 01:09:54PM -0500, Frediano Ziglio wrote:
> > Indeed, it seems that it can be improved but I'm not sure how it should
> > be designed?
> >
> > Nowadays:
> >
> > host calls reds:spice_server_set_video_codecs() that calls
> > reds_on_vc_change() which end up sending
> > RE
Hey,
On Sun, Dec 04, 2016 at 06:29:12PM +0200, Yuri Benditovich wrote:
> Signed-off-by: Yuri Benditovich
> ---
> Changelog | 7 +++
> 1 file changed, 7 insertions(+)
> create mode 100644 Changelog
>
> diff --git a/Changelog b/Changelog
> new file mode 100644
> index 000..4946ad9
> ---
On Fri, Dec 02, 2016 at 06:37:26PM +0100, Victor Toso wrote:
> > I prefer accessors.
>
> Should I drop also the change from G_PARAM_WRITABLE to
> G_PARAM_READWRITE or should I drop the patch entirely?
You can go with both :)
>
> > Also streaming code should have access to this information, in a
From: Victor Toso
This patch creates display_channel_get_video_codecs() helper to let
stream.c get the video-codecs without accessing the internal structure
of DisplayChannel.
As video-codecs is a property of DisplayChannel, this change means
making this property readable as well.
Signed-off-by
>
> From: Victor Toso
>
> Signed-off-by: Victor Toso
> ---
> .mailmap | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.mailmap b/.mailmap
> index c05ba00..d66229a 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -8,3 +8,4 @@
>
>
>
> +
Acked-by: Frediano Ziglio
Still thanks
On Mon, Dec 05, 2016 at 09:10:48AM +0100, Pavel Grunt wrote:
> We are already using it.
>
> Also add support for generating deprecation warnings for the usage
> of possibly unavailable functions.
Fwiw, I would have split this in 2 patches, the "also" is a strong hint
;)
Christophe
> ---
> conf
From: Victor Toso
Signed-off-by: Victor Toso
---
.mailmap | 1 +
1 file changed, 1 insertion(+)
diff --git a/.mailmap b/.mailmap
index c05ba00..d66229a 100644
--- a/.mailmap
+++ b/.mailmap
@@ -8,3 +8,4 @@
+
--
2.9.3
___
Spice-devel mailin
ping
Maybe this requires some follow ups for VgaDevice and
possibly avoinind taking into account moves during mapping
computation.
Frediano
>
> Doing some fast check on Windows 8.1 you could note that
> moving windows you got a weird effect were windows were a
> bit misaligned.
> As documented
>
> We are already using it.
>
> Also add support for generating deprecation warnings for the usage
> of possibly unavailable functions.
> ---
> configure.ac | 14 +-
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 4fa4c836..af2
>
> There is an explicit check for the version
> ---
> server/tests/test-codecs-parsing.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Frediano Ziglio
Frediano
> diff --git a/server/tests/test-codecs-parsing.c
> b/server/tests/test-codecs-parsing.c
> index 0e23553b..c1b3276d 100644
Allow to dynamically remove QXL interfaces. This could be used to
support hot swapping of QXL cards.
This code is actually not used in any way.
QXL interfaces are destroyed by spice_server_destroy automatically.
Signed-off-by: Frediano Ziglio
Acked-by: Jonathon Jongsma
---
server/reds.c | 7 +++
Make finalization of DisplayChannel consistent with other code.
Signed-off-by: Frediano Ziglio
---
server/display-channel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/display-channel.c b/server/display-channel.c
index 061a99d..bd9d2be 100644
--- a/server/displ
Avoid leaking it.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/server/reds.c b/server/reds.c
index 95295c8..d350331 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3602,6 +3602,11 @@ SPICE_GNUC_VISIBLE void spice_server_destroy(Spic
Avoid leaking this channel.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 4
1 file changed, 4 insertions(+)
diff --git a/server/reds.c b/server/reds.c
index 479a815..17e5ada 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3592,6 +3592,10 @@ SPICE_GNUC_VISIBLE void spice_server_des
Signed-off-by: Frediano Ziglio
---
server/reds.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/server/reds.c b/server/reds.c
index 17e5ada..95295c8 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3592,6 +3592,8 @@ SPICE_GNUC_VISIBLE void spice_server_destroy(SpiceServer
*reds)
se
Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
---
server/red-replay-qxl.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
index 2176068..aeaa545 100644
--- a/server/red-replay-qxl.c
+++ b/server/red-replay-qxl.c
@@ -48,6 +48,7 @@
Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
---
server/tests/replay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/tests/replay.c b/server/tests/replay.c
index f32fa2f..23d4125 100644
--- a/server/tests/replay.c
+++ b/server/tests/replay.c
@@ -221,7 +221,6
There could be still some data pending.
Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
---
server/tests/replay.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/server/tests/replay.c b/server/tests/replay.c
index 23d4125..8ec65d6 100644
--- a/serve
These patches start destroying objects upon destruction.
Lot of the objects are just allocated but never freed.
This however make hardier to understand automatically leaks
as objects are still linked together.
Currently spice_server_destroy is not called so objects
are freed only when program ends
red_channel_client_handle_message can handle base messages
so reuse it.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 16 +---
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index ed20125..04e08a2 100644
--- a/server/sound.c
+++ b/
Signed-off-by: Frediano Ziglio
---
server/sound.c | 51 +--
1 file changed, 21 insertions(+), 30 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 191e4fe..ed20125 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -824,12 +824,11 @@
Signed-off-by: Frediano Ziglio
---
server/sound.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 04e08a2..de2f0b3 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -93,8 +93,8 @@ GType snd_channel_client_get_type(void) G_
This code is the same inside __new_channel but will set the
RedsStream from RedChannel.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 46 +-
1 file changed, 45 insertions(+), 1 deletion(-)
diff --git a/server/sound.c b/server/sound.c
index 534f2
Signed-off-by: Frediano Ziglio
---
server/sound.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index de2f0b3..7b35c87 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -386,7 +386,6 @@ static int snd_playback_send_migrate(PlaybackChan
This patch is quite huge but have some benefits:
- reduce dependency (DummyChannel* and some RedChannelClient internals);
- reuse RedChannelClient instead of reading from the RedsStream
directly.
You can see that SndChannelClient has much less field
as the code to read/write from/to client is re
Signed-off-by: Frediano Ziglio
---
server/red-channel-client-private.h | 11 +++
server/red-channel-client.c | 12 ++--
server/red-channel-client.h | 13 -
3 files changed, 17 insertions(+), 19 deletions(-)
diff --git a/server/red-channel-client-privat
Signed-off-by: Frediano Ziglio
---
server/sound.c | 19 ---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index d3b4bbd..2a4472c 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -1433,10 +1433,26 @@ snd_channel_init(SndChannel *s
Almost identical beside the type.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 53 +++
1 file changed, 16 insertions(+), 37 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index fed6062..a4313c4 100644
--- a/server/sound.c
+++ b/s
Signed-off-by: Frediano Ziglio
---
server/sound.c | 19 ---
1 file changed, 19 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 2a4472c..fed6062 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -816,23 +816,6 @@ snd_channel_client_release_recv_buf(RedChannelClie
We support only a single client so don't waste code just
to check this.
The worst stuff can happen is that we'll migrate multiple
connections.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 35 +--
1 file changed, 5 insertions(+), 30 deletions(-)
diff --git
Signed-off-by: Frediano Ziglio
---
server/Makefile.am| 4 +-
server/dummy-channel-client.c | 138 +---
server/dummy-channel-client.h | 64 +
server/dummy-channel.c| 94 +
server/dummy-channel.h
These objects were used by the sound channel as
this channel read/write to/from client directly.
This make the code of this channel quite different
from the other ones.
Also this reduce code duplication from RedChannelClient
and increase encapsulation.
Also there are multiple cleanup following this
On 12/05/2016 11:46 AM, Dr. David Alan Gilbert wrote:
* Gerd Hoffmann (kra...@redhat.com) wrote:
On Fr, 2016-12-02 at 17:44 +, Dr. David Alan Gilbert wrote:
Hi Gerd,
I've got a moderately repeatable crash with spice playing
a video + postcopy. Some of the time I just get a warning
(that
> From: Victor Toso
>
> Including g_clear_pointer() in glib-compat.h and using it to avoid
> warnings in odd situations.
>
> Signed-off-by: Victor Toso
Acked
> ---
> server/display-channel.c | 8 +++-
> server/glib-compat.h | 19 +++
> 2 files changed, 22 insertions(
* Gerd Hoffmann (kra...@redhat.com) wrote:
> On Fr, 2016-12-02 at 17:44 +, Dr. David Alan Gilbert wrote:
> > Hi Gerd,
> > I've got a moderately repeatable crash with spice playing
> > a video + postcopy. Some of the time I just get a warning
> > (that I also get in precopy) but sometimes it
On Fri, 2016-12-02 at 11:31 -0500, Frediano Ziglio wrote:
> >
> > As data is packae in a single piece of memory send it
> > altogether.
> >
>
> typo: packaged
>
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/smartcard-channel-client.c | 5 +
> > 1 file changed, 1 insertion(+), 4 de
On Fr, 2016-12-02 at 17:44 +, Dr. David Alan Gilbert wrote:
> Hi Gerd,
> I've got a moderately repeatable crash with spice playing
> a video + postcopy. Some of the time I just get a warning
> (that I also get in precopy) but sometimes it turns into
> a backtrace;
>
> This is:
> f24 guest
There is an explicit check for the version
---
server/tests/test-codecs-parsing.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/server/tests/test-codecs-parsing.c
b/server/tests/test-codecs-parsing.c
index 0e23553b..c1b3276d 100644
--- a/server/tests/test-codecs-parsing.c
+++ b/server/tes
We are already using it.
Also add support for generating deprecation warnings for the usage
of possibly unavailable functions.
---
configure.ac | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/configure.ac b/configure.ac
index 4fa4c836..af271e46 100644
--- a/conf
60 matches
Mail list logo
