From: Victor Toso
As spice_usb_device_manager_get() can be NULL
Signed-off-by: Victor Toso
---
src/channel-usbredir.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
index add7d5e..4837d68 100644
--- a/src/channel-usbredir
From: Victor Toso
Otherwise application will not be able to know the reason for failure.
Signed-off-by: Victor Toso
---
src/usb-device-manager.c | 2 +-
src/win-usb-dev.c| 4 ++--
src/win-usb-dev.h| 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/usb-dev
From: Victor Toso
No need for if else here.
Signed-off-by: Victor Toso
---
src/win-usb-dev.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/win-usb-dev.c b/src/win-usb-dev.c
index 1cf9f21..a857b02 100644
--- a/src/win-usb-dev.c
+++ b/src/win-usb-dev.c
@@ -108,1
From: Victor Toso
g_udev_client_new() can fail in more then one situation in its
initable_init() method.
Signed-off-by: Victor Toso
---
src/usb-device-manager.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c
index 3d4bd98..ae73a02 10
From: Victor Toso
This fixes a hanging on mingw-spice-gtk when the GUdevClient fails to
initialize due problems in the UsbDk installation.
The libusb_exit() will be called on priv->ctx in
g_udev_client_initable_init() and also it will be called on NULL at
g_udev_client_finalize(), making the app
On Fri, 2016-11-11 at 12:08 +, Frediano Ziglio wrote:
> Avoid not constant globals.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/dummy-channel.c | 5 ++-
> server/event-loop.c | 23 ++-
> server/red-channel-client.c | 32 +++
> server/red-co
Hi,
On Mon, Nov 14, 2016 at 12:33:46PM -0600, Jonathon Jongsma wrote:
> hmm, you're right. But it's a little bit weird that we don't flush this
> message but we do all other file-transfer messages. That means that for
> zero-length files we'll never receive GError reports for failed
> sending/flus
Acked-by: Jonathon Jongsma
On Mon, 2016-11-14 at 09:32 +, Frediano Ziglio wrote:
> The common function is supposed to clear the state of SndWorker
> so clear even volume which now is in SndWorker
>
> Signed-off-by: Frediano Ziglio
> ---
> server/sound.c | 4 ++--
> 1 file changed, 2 inser
On Mon, 2016-11-14 at 09:32 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/sound.c | 63 --
>
> 1 file changed, 35 insertions(+), 28 deletions(-)
>
> diff --git a/server/sound.c b/server/sound.c
> index c078f
On Mon, 2016-11-14 at 09:32 +, Frediano Ziglio wrote:
> These function were really similar.
> Factor out a new snd_get_best_rate to avoid code duplication.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/sound.c | 27 +--
> 1 file changed, 9 insertions(+), 18 deleti
On Mon, 2016-11-14 at 09:32 +, Frediano Ziglio wrote:
> This field is common to SpicePlaybackState and SpiceRecordState
> which are based on SndWorker.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/sound.c | 45 +++--
> 1 file changed, 23 insertion
Trusting that you've tested it and it works as expected (I haven't):
Acked-by: Jonathon Jongsma
On Mon, 2016-11-14 at 11:28 +, Frediano Ziglio wrote:
> The top down flag can be specified using negative heights.
>
> According to
> https://msdn.microsoft.com/en-us/library/windows/desktop/dd
On Fri, 2016-11-11 at 23:53 +0100, Victor Toso wrote:
> Hi,
>
> On Fri, Nov 11, 2016 at 04:05:21PM -0600, Jonathon Jongsma wrote:
> >
> > On Fri, 2016-11-11 at 14:27 +0100, Victor Toso wrote:
> > >
> > > From: Victor Toso
> > >
> > > This fixes the situation when VDAgent receives 0 byte messag
On Mon, Nov 14, 2016 at 05:35:02PM +, Frediano Ziglio wrote:
> +spice-server-enums.c: spice-server.h spice-server-enums.tmpl.c
> + $(AM_V_GEN)glib-mkenums --template spice-server-enums.tmpl.c $^ > $@
Note that the @^ becomes slightly wrong here as we are going to be
passing spice-server-en
Acked-by: Jonathon Jongsma
On Mon, 2016-11-14 at 09:25 +, Frediano Ziglio wrote:
> Include common and libraries includes before local ones as
> stated by style.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/dcc-send.c | 6 +++---
> server/red-replay-qxl.c | 3 ++-
> server/sound
Syntax checker complained about autoconf variable expansion used
inside Makefile.am.
This patch uses template files instead of options.
This also reduces quoting making template code more readable.
Signed-off-by: Frediano Ziglio
---
server/Makefile.am | 34 +++--
On Mon, Nov 14, 2016 at 12:18:13PM -0500, Frediano Ziglio wrote:
> > On Mon, Nov 14, 2016 at 12:46:26PM +, Frediano Ziglio wrote:
> > > Syntax checker complained about autoconf variable expansion used
> > > inside Makefile.am.
> > > This patch uses template files instead of options.
> > > This
> On Mon, Nov 14, 2016 at 12:46:26PM +, Frediano Ziglio wrote:
> > Syntax checker complained about autoconf variable expansion used
> > inside Makefile.am.
> > This patch uses template files instead of options.
> > This also reduces quoting making template code more readable.
> >
> > Signed-of
On Mon, Nov 14, 2016 at 12:46:26PM +, Frediano Ziglio wrote:
> Syntax checker complained about autoconf variable expansion used
> inside Makefile.am.
> This patch uses template files instead of options.
> This also reduces quoting making template code more readable.
>
> Signed-off-by: Frediano
Acked-by: Christophe Fergeau
On Mon, Nov 14, 2016 at 04:55:22PM +, Frediano Ziglio wrote:
> The verify macro used currently has some problem
> as it raise a warning in RHEL6.
> As suggested in verify.h use verify_expr macro
> to avoid the warning.
>
> Signed-off-by: Frediano Ziglio
> ---
>
Acked-by: Christophe Fergeau
(a submodule update will need be done first).
On Mon, Nov 14, 2016 at 04:56:13PM +, Frediano Ziglio wrote:
> The verify macro used currently has some problem
> as it raise a warning in RHEL6.
> Use new SPICE_VERIFY macro defined in spice-common
> to avoid this i
>
> On Mon, Nov 14, 2016 at 03:11:31PM +, Frediano Ziglio wrote:
> > The verify macro used currently has some problem
> > as it raise a warning in RHEL6.
> > As suggested in verify.h use verify_expr macro
> > to avoid the warning.
>
>
>
> > diff --git a/server/red-common.h b/server/red-comm
The verify macro used currently has some problem
as it raise a warning in RHEL6.
Use new SPICE_VERIFY macro defined in spice-common
to avoid this issue.
Signed-off-by: Frediano Ziglio
---
server/cache-item.tmpl.c | 2 +-
server/dcc.c | 2 +-
server/display-channel.c | 4 ++--
s
The verify macro used currently has some problem
as it raise a warning in RHEL6.
As suggested in verify.h use verify_expr macro
to avoid the warning.
Signed-off-by: Frediano Ziglio
---
common/macros.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/common/macros.h b/common/macros.h
index
On Mon, Nov 14, 2016 at 03:11:31PM +, Frediano Ziglio wrote:
> The verify macro used currently has some problem
> as it raise a warning in RHEL6.
> As suggested in verify.h use verify_expr macro
> to avoid the warning.
> diff --git a/server/red-common.h b/server/red-common.h
> index 190fd9c.
The verify macro used currently has some problem
as it raise a warning in RHEL6.
As suggested in verify.h use verify_expr macro
to avoid the warning.
Signed-off-by: Frediano Ziglio
---
server/cache-item.tmpl.c | 2 +-
server/dcc.c | 2 +-
server/display-channel.c | 4 ++--
serv
On Mon, Nov 14, 2016 at 04:35:24AM -0500, Frediano Ziglio wrote:
> >
> > From: Jonathon Jongsma
> >
> > Add a 'self' parameter to all of the char device virtual functions so
> > that we don't have to play games with the 'opaque' pointer.
>
> I would ack this.
> Just as a did minor changes can s
Hi,
On Mon, Nov 14, 2016 at 11:20:31AM +, Frediano Ziglio wrote:
> spice_usbredir_channel_get_spice_usb_device is used only if LZ4
> is enabled so avoid to define if not used as this cause a
> compile error.
>
> Signed-off-by: Frediano Ziglio
Acked-by: Victor Toso
> ---
> src/channel-usbre
Syntax checker complained about autoconf variable expansion used
inside Makefile.am.
This patch uses template files instead of options.
This also reduces quoting making template code more readable.
Signed-off-by: Frediano Ziglio
---
server/Makefile.am | 34 +++--
From: Yuri Benditovich
When mouse mode (client/server) changed, spice server
notifies QXL instance to allow QEMU to optimize cursor-related
traffic from guest to host.
Signed-off-by: Yuri Benditovich
---
server/red-qxl.c | 4
server/spice-qxl.h | 1 +
2 files changed, 5 insertions(+)
d
From: Yuri Benditovich
Published to 'spice-devel' list for reference only.
QXL device uses mouse mode change indication from spice
server and indicates this change to guest driver.
Requires updated spice-protocol and spice-server,
otherwise works and before without mouse mode change callback.
Yu
From: Yuri Benditovich
QXL device will read current mouse mode upon indication
of mouse mode change.
Signed-off-by: Yuri Benditovich
---
include/ui/qemu-spice.h | 14 ++
ui/spice-core.c | 5 +
2 files changed, 19 insertions(+)
diff --git a/include/ui/qemu-spice.h b/in
From: Yuri Benditovich
Extended QXLRom structure to keep current mouse mode.
Added interrupt status bit to indicate mouse mode change to guest.
Signed-off-by: Yuri Benditovich
---
spice/qxl_dev.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h
index 9e7
From: Yuri Benditovich
When spice server changes mouse mode (server/client) it
informs QXL device via callback. QXL device keeps current
mouse mode in ROM area and issues interrupt to guest driver.
Guest driver can read current mode from ROM and optimize its
behavior in case the mouse is in 'clie
GCond/GMutex interface is different between Glib 2.32 and
previous versions. Use pthread for compatibility.
Signed-off-by: Frediano Ziglio
---
server/gstreamer-encoder.c | 31 ---
1 file changed, 16 insertions(+), 15 deletions(-)
This is more an alternative way to
"g
>
> On Mon, 2016-10-31 at 07:01 -0400, Frediano Ziglio wrote:
> > >
> > > On Mon, 2016-10-31 at 06:17 -0400, Frediano Ziglio wrote:
> > > > ping
> > > >
> > > > >
> > > > > The top down flag can be specified using negative heights.
> > >
> > > Will the resulting bitmap be upside down ? Or it d
The top down flag can be specified using negative heights.
According to
https://msdn.microsoft.com/en-us/library/windows/desktop/dd183376(v=vs.85).aspx:
"The height of the bitmap, in pixels. If biHeight is positive, the
bitmap is a bottom-up DIB and its origin is the lower-left corner.
If biHeigh
spice_usbredir_channel_get_spice_usb_device is used only if LZ4
is enabled so avoid to define if not used as this cause a
compile error.
Signed-off-by: Frediano Ziglio
---
src/channel-usbredir.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
On Mon, 2016-11-14 at 05:03 -0500, Frediano Ziglio wrote:
> >
> > Causing build failures on win32
> > .libs/vncdisplaykeymap.o: In function
> > `vnc_display_keymap_gdk2xtkbd_table':
> > /builddir/build/BUILD/spice-gtk-0.33.19-
> > efbfd/build_win32/src/../../src/vncdisplaykeymap.c:198:
> > un
>
> Causing build failures on win32
> .libs/vncdisplaykeymap.o: In function `vnc_display_keymap_gdk2xtkbd_table':
>
> /builddir/build/BUILD/spice-gtk-0.33.19-efbfd/build_win32/src/../../src/vncdisplaykeymap.c:198:
> undefined reference to `GDK_IS_WIN32_WINDOW'
> collect2: error: ld returned
On Mon, Nov 14, 2016 at 04:42:46AM -0500, Frediano Ziglio wrote:
> >
> > Some C-specific warnings were turned off as the spice module used to
> > ship a C++ spice client. It's long gone, so we can reenable these
> > warnings.
> > There were warnings disabled for tunnel support and CEGUI usage whic
>
> Some C-specific warnings were turned off as the spice module used to
> ship a C++ spice client. It's long gone, so we can reenable these
> warnings.
> There were warnings disabled for tunnel support and CEGUI usage which
> have both been removed too.
> -Wno-format-nonliteral was disabled twice
>
> From: Jonathon Jongsma
>
> Add a 'self' parameter to all of the char device virtual functions so
> that we don't have to play games with the 'opaque' pointer.
I would ack this.
Just as a did minor changes can somebody confirm?
Frediano
> ---
> server/char-device.c | 31 +
>
> Pass the new sound channel to these functions rather than setting
> worker->connection before calling the function and expecting it to be
> set when the function is called. The fewer unenforced assumptions that
> must be true for a function to work properly, the easier it will be to
> maintain
Signed-off-by: Frediano Ziglio
---
server/sound.c | 63 --
1 file changed, 35 insertions(+), 28 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index c078f28..915756f 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -166,12 +16
The common function is supposed to clear the state of SndWorker
so clear even volume which now is in SndWorker
Signed-off-by: Frediano Ziglio
---
server/sound.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 915756f..937eafb 100644
-
These function were really similar.
Factor out a new snd_get_best_rate to avoid code duplication.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 27 +--
1 file changed, 9 insertions(+), 18 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 5b2062b..c078
Changes since v1:
- removed merged patches;
- rebased on master;
- clarify some cap parameter should specify opus cap;
- added other minor patches.
Frediano Ziglio (4):
sound: Move frequency field to SndWorker
sound: Reuse code for spice_server_get_best_{record,playback}_rate
sound: Remove s
This field is common to SpicePlaybackState and SpiceRecordState
which are based on SndWorker.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 45 +++--
1 file changed, 23 insertions(+), 22 deletions(-)
diff --git a/server/sound.c b/server/sound.c
inde
Include common and libraries includes before local ones as
stated by style.
Signed-off-by: Frediano Ziglio
---
server/dcc-send.c | 6 +++---
server/red-replay-qxl.c | 3 ++-
server/sound.c | 2 +-
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/server/dcc-send.c b/s
Causing build failures on win32
.libs/vncdisplaykeymap.o: In function `vnc_display_keymap_gdk2xtkbd_table':
/builddir/build/BUILD/spice-gtk-0.33.19-efbfd/build_win32/src/../../src/vncdisplaykeymap.c:198:
undefined reference to `GDK_IS_WIN32_WINDOW'
collect2: error: ld returned 1 exit status
51 matches
Mail list logo
