On Fri, 2016-11-04 at 13:16 +, Frediano Ziglio wrote:
> Allocate recording file globally from reds.c.
I think this line makes more sense as the commit summary
Acked-by: Jonathon Jongsma
> This will allow to register multiple screen VM or recording
> additional stuff like sound.
> The mutex
On Fri, 2016-11-04 at 13:16 +, Frediano Ziglio wrote:
> Time is always the the current real time so avoid to compute
> it for every call but move to red-record-qxl.c.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-record-qxl.c | 11 ---
> server/red-record-qxl.h | 4 ++--
> s
Would be nice if we could somehow maintain backward compatibility, but
i don't think it's worth the effort to maintain it.
Acked-by: Jonathon Jongsma
On Fri, 2016-11-04 at 13:16 +, Frediano Ziglio wrote:
> 0 as version was never used so don't allow it
>
> Signed-off-by: Frediano Ziglio
>
A few minor wording suggestions. The subject should say "Replicate
wakeups properly".
On Fri, 2016-11-04 at 13:16 +, Frediano Ziglio wrote:
> Instead of waking up the command loop for every command queued
add a comma after queued
> handle saved wakeups and replicate these.
> This better repr
>
> Hey,
>
> On Wed, Nov 09, 2016 at 09:13:32AM +, Frediano Ziglio wrote:
> > The small code in m4/manywarnings.m4 wrongly detects if
> > -Wno-missing-field-initializers is needed. This happens if
> > -Wunused-variable is set. In this case the code fails to compile
> > due to -Werror even if
Acked-by: Jonathon Jongsma
On Fri, 2016-11-04 at 13:16 +, Frediano Ziglio wrote:
> The functions declared in that header are all exported by the
> library.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/Makefile.am | 2 +-
> server/red-replay-qxl.c | 1 -
> server/red-replay-qxl
Acked-by: Jonathon Jongsma
On Fri, 2016-11-04 at 13:16 +, Frediano Ziglio wrote:
> SpiceBlend and SpiceCopy are just different names for the same
> structure.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-parse-qxl.c | 15 ---
> 1 file changed, 4 insertions(+), 11 dele
Hey,
I'm very late to the party, just a few comments,
On Tue, Oct 11, 2016 at 02:06:27PM +0200, Sergio L. Pascual wrote:
> I've just spent some time tuning an Ubuntu 16.04 (I know Fedora is
> preferred around here, but a lot of clients seem to prefer Ubuntu and
> its derivatives) desktop for VDI u
ACK series except for 4/5 "syntax-check: Avoid unwanted autoconf
replacements in Makefile.am"
Christophe
On Wed, Nov 09, 2016 at 04:00:07PM +, Frediano Ziglio wrote:
> Frediano Ziglio (5):
> syntax-check: Remove space at end of line
> syntax-check: Remove empty line at end of file
> syn
nack, better to switch to --template rather than obfuscating this
generation even more.
On Wed, Nov 09, 2016 at 04:00:11PM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/Makefile.am | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/serv
Document what the messages are meant to do.
Signed-off-by: Frediano Ziglio
---
spice/vd_agent.h | 13 +
1 file changed, 13 insertions(+)
diff --git a/spice/vd_agent.h b/spice/vd_agent.h
index c49f596..b95f924 100644
--- a/spice/vd_agent.h
+++ b/spice/vd_agent.h
@@ -66,10 +66,23 @@ e
Signed-off-by: Frediano Ziglio
---
server/red-channel.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/server/red-channel.c b/server/red-channel.c
index 9279882..0936548 100644
--- a/server/red-channel.c
+++ b/server/red-channel.c
@@ -841,4 +841,3 @@ void red_channel_disconnect_client(RedChan
Due to syntax-check limitation this free calls results in
a syntax error.
Signed-off-by: Frediano Ziglio
---
server/mjpeg-encoder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/mjpeg-encoder.c b/server/mjpeg-encoder.c
index d95c645..21778b8 100644
--- a/server/mjpeg
Signed-off-by: Frediano Ziglio
---
server/red-client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/red-client.c b/server/red-client.c
index f7f4562..de40acf 100644
--- a/server/red-client.c
+++ b/server/red-client.c
@@ -16,7 +16,7 @@
*/
#ifdef HAVE_CONFIG_H
-#in
Signed-off-by: Frediano Ziglio
---
.gitlab-ci.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 9b2ae2d..ca57ff5 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -1,7 +1,7 @@
image: fedora:latest
before_script:
- - dnf install 'd
Signed-off-by: Frediano Ziglio
---
server/Makefile.am | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/server/Makefile.am b/server/Makefile.am
index ca67be1..3a0c71e 100644
--- a/server/Makefile.am
+++ b/server/Makefile.am
@@ -1,4 +1,5 @@
NULL =
+AT = @
SUBDIRS = . tests
Frediano Ziglio (5):
syntax-check: Remove space at end of line
syntax-check: Remove empty line at end of file
syntax-check: Include config.h file #include <>
syntax-check: Avoid unwanted autoconf replacements in Makefile.am
syntax-check: Silent a wrong positive
.gitlab-ci.yml |
Trivial.
Acked-by: Jonathon Jongsma
On Wed, 2016-11-09 at 14:19 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/main-channel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/main-channel.c b/server/main-channel.c
> index b900b6
Looks fine to me.
Acked-by: Jonathon Jongsma
On Wed, 2016-11-09 at 11:47 +0100, Christophe Fergeau wrote:
> Before this commit, udscs_read_callback is supposed to free the
> 'data'
> buffer unless it calls udscs_destroy_connection(). It's currently not
> doing this, causing a potential double f
>
> Due to the use of static inline functions, the headers uses
> G_GNUC_UNUSED, which the sc_avoid_attribute_unused_in_header test
> complains about.
> ---
> cfg.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/cfg.mk b/cfg.mk
> index 8809df0..3e5d345 100644
> --- a/cfg.mk
> +++ b/
Hey, only this patch from the series was not reviewed, anyone up for it?
Christophe
On Thu, Oct 27, 2016 at 04:12:13PM +0200, Christophe Fergeau wrote:
> Due to the use of static inline functions, the headers uses
> G_GNUC_UNUSED, which the sc_avoid_attribute_unused_in_header test
> complains abo
On Fri, Oct 28, 2016 at 11:27:02AM +0200, Francois Gouget wrote:
> This gains us automatic support for whichever compilers GLib supports in
> this macro when used in projects that use GLib.
>
> Signed-off-by: Francois Gouget
Looks good to me, though the #endif /* __GNUC__ */ needs to be changed
On Fri, Oct 28, 2016 at 11:57:33AM +0200, Francois Gouget wrote:
> Signed-off-by: Francois Gouget
> ---
>
> This is an alternative take on the previous patch: instead of reusing
> the GLib macro it just duplicates its logic.
Why alternative? I think I would take both patches ;) We'd have a MSVC
Hey,
On Fri, Oct 28, 2016 at 11:27:02AM +0200, Francois Gouget wrote:
> This gains us automatic support for whichever compilers GLib supports in
> this macro when used in projects that use GLib.
>
> Signed-off-by: Francois Gouget
> ---
>
> This can make sense if we consider GLib to be a platfor
Signed-off-by: Frediano Ziglio
---
server/main-channel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/main-channel.c b/server/main-channel.c
index b900b62..6449c16 100644
--- a/server/main-channel.c
+++ b/server/main-channel.c
@@ -318,7 +318,7 @@ int main_channel_get
Before this commit, udscs_read_callback is supposed to free the 'data'
buffer unless it calls udscs_destroy_connection(). It's currently not
doing this, causing a potential double free in error cases. The udscs
code would also leak the 'data' buffer if no udscs_read_callback is set.
This commit mo
>
> On Wed, Nov 09, 2016 at 10:32:40AM +, Frediano Ziglio wrote:
> > CxImage is used for image conversion for clipboard support.
> > CxImage have currently some issue:
> > - library is old and unsupported;
> > - required an old libpng library.
> > Currently the MingW binary we distribute due t
Hey,
On Wed, Nov 09, 2016 at 09:13:32AM +, Frediano Ziglio wrote:
> The small code in m4/manywarnings.m4 wrongly detects if
> -Wno-missing-field-initializers is needed. This happens if
> -Wunused-variable is set. In this case the code fails to compile
> due to -Werror even if -Wno-missing-fiel
On Wed, Nov 09, 2016 at 10:32:40AM +, Frediano Ziglio wrote:
> CxImage is used for image conversion for clipboard support.
> CxImage have currently some issue:
> - library is old and unsupported;
> - required an old libpng library.
> Currently the MingW binary we distribute due to some
> issue
Remove CxImage linking.
Support Windows BMP format.
Signed-off-by: Frediano Ziglio
---
Makefile.am | 4 +-
configure.ac | 3 -
vdagent/image.cpp | 182 ++
vdagent/image.h | 13
4 files changed, 158 insertions(+), 44 delet
Signed-off-by: Frediano Ziglio
---
Makefile.am | 6 +-
configure.ac | 3 +
vdagent/image.cpp| 8 +-
vdagent/imagepng.cpp | 244 +++
vdagent/imagepng.h | 25 ++
5 files changed, 277 insertions(+), 9 deletions(-)
cre
CxImage is used for image conversion for clipboard support.
CxImage have currently some issue:
- library is old and unsupported;
- required an old libpng library.
Currently the MingW binary we distribute due to some
issue have PNG disabled (so no clipboard image support).
Note that currently we sup
Signed-off-by: Frediano Ziglio
---
Makefile.am | 17 +++-
vdagent/imagetest.cpp | 77 +++
2 files changed, 93 insertions(+), 1 deletion(-)
create mode 100644 vdagent/imagetest.cpp
diff --git a/Makefile.am b/Makefile.am
index 0f67
Signed-off-by: Frediano Ziglio
---
vdagent/imagepng.cpp | 133 ---
1 file changed, 127 insertions(+), 6 deletions(-)
diff --git a/vdagent/imagepng.cpp b/vdagent/imagepng.cpp
index c5d3791..a4a27db 100644
--- a/vdagent/imagepng.cpp
+++ b/vdagent/ima
This will make easier to change code that handle images.
Signed-off-by: Frediano Ziglio
---
Makefile.am | 2 ++
vdagent/image.cpp | 86 +
vdagent/image.h | 46
vdagent/vdagent.cpp | 57 +--
They were very outdated
---
vdagent/vdagent.rc | 10 +-
vdservice/vdservice.rc | 10 +-
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/vdagent/vdagent.rc b/vdagent/vdagent.rc
index 0973068..4a5c330 100644
--- a/vdagent/vdagent.rc
+++ b/vdagent/vdagent.rc
@@ -5
The versions/copyright in vdservice.rc and vdagent.rc are very outdated.
Updating them automatically at configure time should ensure they are
updated more often.
The generated .rc files are kept in git as they are needed for VC++
builds.
---
configure.ac | 8 +++-
vdagent/vdagent.rc
Signed-off-by: Frediano Ziglio
---
server/tests/gst-test.c | 61 +++--
1 file changed, 59 insertions(+), 2 deletions(-)
Changes since v2:
- use a gst_buffer_new_wrapped_full replacement;
- use 1.0 style for gst_bus_set_sync_handler.
(all comments by Ch
Add an utility to make possible to check various features of
VideoEncoder.
2 GStreamer plugins are used in a chain like this:
(1) input pipeline -> (2) video encoder -> (3) output pipeline
While converting output from (1) is compared with output of (3)
making sure the streaming is working correct
The top down flag can be specified using negative heights.
Signed-off-by: Frediano Ziglio
---
server/spice-bitmap-utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/spice-bitmap-utils.c b/server/spice-bitmap-utils.c
index 72a9285..439f05d 100644
--- a/server/spice
These formats were tested manually using gst-test utility
in server/tests.
Signed-off-by: Frediano Ziglio
---
server/gstreamer-encoder.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Changes since v2:
- extended commit message.
diff --git a/server/gstreamer-encoder.c b/server/gstrea
This patch series add some tests fot Gstreamer.
Frediano Ziglio (5):
Handle top down bitmaps dumping
Simplify gstreamer 0.10 compatibility
Add an helper to test VideoEncoder
gstreamer: Do not warn for tested formats
Compatibility for GStreamer 0.10 for test utility
server/gstreamer-enc
Signed-off-by: Frediano Ziglio
---
server/gstreamer-encoder.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c
index 3d5f8a0..54e1b2e 100644
--- a/server/gstreamer-encoder.c
+++ b/server/gstreamer-encoder.c
@@ -969,11
> On Fri, Oct 21, 2016 at 01:40:38PM +0100, Frediano Ziglio wrote:
> > Add an utility to make possible to check various features of
> > VideoEncoder.
> > 2 GStreamer plugins are used in a chain like this:
> > (1) input pipeline -> (2) video encoder -> (3) output pipeline
> > While converting ou
On Wed, Nov 09, 2016 at 04:17:19AM -0500, Frediano Ziglio wrote:
> >
> >
> > From the commit log, I have no idea why/how they were tested now. If you
> > tested them locally, just mention this in the log.
> >
>
> This was tested with the utility at 4/6 and the script at 6/6.
>
> Maybe:
>
> "T
>
>
> From the commit log, I have no idea why/how they were tested now. If you
> tested them locally, just mention this in the log.
>
This was tested with the utility at 4/6 and the script at 6/6.
Maybe:
"These formats were tested manually using a small test utility."
> Acked-by: Christophe
> On Fri, Oct 21, 2016 at 01:40:37PM +0100, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/gstreamer-encoder.c | 6 +-
> > 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c
> > index 53dfb
The small code in m4/manywarnings.m4 wrongly detects if
-Wno-missing-field-initializers is needed. This happens if
-Wunused-variable is set. In this case the code fails to compile
due to -Werror even if -Wno-missing-field-initializers would be
perfectly fine.
Signed-off-by: Frediano Ziglio
---
m
48 matches
Mail list logo
