---
Changes in v2:
- pass 'channel' property to char device constructor
- assert that 'channel' device is non-null in char device set_property
- minor indentation fix
server/spicevmc.c | 83 ---
1 file changed, 61 insertions(+), 22 deletions(
On Fri, 2016-11-04 at 13:34 -0400, Frediano Ziglio wrote:
> >
> >
> > ---
> > Possible fixup to Frediano's proposed patch. In general, GObject
> > _new()
> > functions should try not to do more than call g_object_new(). This
> > is mostly
> > to
> > make things simpler for language bindings, but
> On Mon, Oct 31, 2016 at 9:47 AM, Javier Celaya < javier.cel...@flexvdi.com >
> wrote:
> > Hi,
>
> > El dom, 30-10-2016 a las 10:50 +0200, Sameeh Jubran escribió:
>
> > > Hi Fabio,
>
> > >
>
> > > I still suspect that the performance issue is caused by the mouse. As
>
> > > you can see in f
>
> ---
> Possible fixup to Frediano's proposed patch. In general, GObject _new()
> functions should try not to do more than call g_object_new(). This is mostly
> to
> make things simpler for language bindings, but I think it's good practice to
> do
> as much initialization via the GObject constru
---
Possible fixup to Frediano's proposed patch. In general, GObject _new()
functions should try not to do more than call g_object_new(). This is mostly to
make things simpler for language bindings, but I think it's good practice to do
as much initialization via the GObject construction framework a
Use g_param_spec_object() instead of g_param_spec_pointer() for the
'client' and 'channel' properties now that these types are GObjects.
This improves refcounting and typesafety slightly.
---
server/red-channel-client.c | 32
1 file changed, 16 insertions(+), 16 de
Hey Christophe,
Thanks for driving for a release; it is much appreciated.
On 10/28/2016 05:18 AM, Christophe Fergeau wrote:
> xspice needs to be updated to cope with some X.Org 1.19 API changes,
> better to make that explicit at configure time rather than letting
> people discover the hard way (i
>
> On Fri, 2016-11-04 at 07:56 -0400, Frediano Ziglio wrote:
> > The subject is a bit confusing to me.
> > Looks like is nor a "what" not a "why", just a statement.
> >
> > >
> > >
> > > From: Jonathon Jongsma
> > >
> > > Previously, spicevmc_device_connect() created a channel, which then
>
On Fri, 2016-11-04 at 07:56 -0400, Frediano Ziglio wrote:
> The subject is a bit confusing to me.
> Looks like is nor a "what" not a "why", just a statement.
>
> >
> >
> > From: Jonathon Jongsma
> >
> > Previously, spicevmc_device_connect() created a channel, which then
> > internally created
Hey,
I've just pushed uploaded a new Windows SPICE vdagent release.
The changes since the 0.7.3 release are:
v0.8.0
==
- add multi monitor/dynamic resolution support on Win8+
when the qxl-wddm-dod driver is used
- disable drag and drop when the screen is locked
- dynamic resolution/monitor
ping
> Add an utility to make possible to check various features of
> VideoEncoder.
> 2 GStreamer plugins are used in a chain like this:
> (1) input pipeline -> (2) video encoder -> (3) output pipeline
> While converting output from (1) is compared with output of (3)
> making sure the streamin
The changes to support audio make the format not compatible as
older version are not able to skip the new data.
Signed-off-by: Frediano Ziglio
---
server/red-record-qxl.c | 2 +-
server/red-replay-qxl.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/red-record-qxl.
Allocate recording file globally from reds.c.
This will allow to register multiple screen VM or recording
additional stuff like sound.
The mutex code added to red-record-qxl.c is required to avoid
mixing writing from multiple threads.
Signed-off-by: Frediano Ziglio
---
server/red-record-qxl.c |
Instead of waking up the command loop for every command queued
handle saved wakeups and replicate these.
This better reproduce what happened in the server.
Signed-off-by: Frediano Ziglio
---
server/red-replay-qxl.c | 2 +-
server/tests/replay.c | 4
2 files changed, 1 insertion(+), 5 dele
0 as version was never used so don't allow it
Signed-off-by: Frediano Ziglio
---
server/red-replay-qxl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
index 680e212..79e00e5 100644
--- a/server/red-replay-qxl.c
+++ b/server/
This patch allow to record playback and replay with spice-server-replay
utility using the a new --audio option.
The main concern I have is the way the sound is reproduced.
The audio is correctly passed to the client however this is not that
useful for automated testing.
Also to allow the audio to b
The functions declared in that header are all exported by the
library.
Signed-off-by: Frediano Ziglio
---
server/Makefile.am | 2 +-
server/red-replay-qxl.c | 1 -
server/red-replay-qxl.h | 35 ---
server/spice-replay.h | 37 ++
Time is always the the current real time so avoid to compute
it for every call but move to red-record-qxl.c.
Signed-off-by: Frediano Ziglio
---
server/red-record-qxl.c | 11 ---
server/red-record-qxl.h | 4 ++--
server/red-worker.c | 14 +++---
3 files changed, 17 insertions
SpiceBlend and SpiceCopy are just different names for the same
structure.
Signed-off-by: Frediano Ziglio
---
server/red-parse-qxl.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/server/red-parse-qxl.c b/server/red-parse-qxl.c
index d75e27e..aa911f3 100644
-
This patchset contains different changes to replay/record code.
Beside some minor changes and style some prepare for some future
changes like multi monitor and audio recording.
Last 2 patches are RFC adding audio playback support.
Frediano Ziglio (8):
red-parse-qxl: Use same fuction to parse ble
Instead of having channel and device object create one the other
create the objects at the beginning and then join them.
This make explicit the code that links the two objects and separate
the objects creation from the linking.
Also remove some boilerplate code.
Signed-off-by: Frediano Ziglio
-
The subject is a bit confusing to me.
Looks like is nor a "what" not a "why", just a statement.
>
> From: Jonathon Jongsma
>
> Previously, spicevmc_device_connect() created a channel, which then
> internally created a device. Then we returned the internal device from
> the channel to the caller
From: Jonathon Jongsma
Add a 'self' parameter to all of the char device virtual functions so
that we don't have to play games with the 'opaque' pointer.
---
server/char-device.c | 31 +--
server/char-device.h | 20 ++--
server
From: Jonathon Jongsma
Previously, spicevmc_device_connect() created a channel, which then
internally created a device. Then we returned the internal device from
the channel to the caller. The channel essentially owned the device, but
it makes more sense for the device to own the channel, because
Changes since v1:
- merged 2 patches;
- rebased on master.
Original comment:
It's an attempt to clarify ownership between the channel and device a bit, and
adds a few additional minor cleanups.
Jonathon Jongsma (2):
spicevmc: Channel is owned by device
char-device: add 'self' param to vfuncs
>
> After renaming the object to RedVmcChannel, the local variables still
> used the old 'state' terminology. Changing these variables to 'channel'
> makes things a bit more consistent.
> ---
> server/spicevmc.c | 146
> +++---
> 1 file changed, 7
>
> A more permissive licence is more in line with what Microsoft requires
> for its WHQL certification
> ---
>
> Hey,
>
> After some internal discussion, it was decided to relicense this new QXL
> driver
> to Apache licence v2, this should make it easier to accept internal
> contribution and ru
A more permissive licence is more in line with what Microsoft requires
for its WHQL certification
---
Hey,
After some internal discussion, it was decided to relicense this new QXL driver
to Apache licence v2, this should make it easier to accept internal
contribution and run it through the WHQL (
On Thu, Nov 03, 2016 at 06:42:38PM +, Emil Velikov wrote:
> Hi guys,
>
> On 2 November 2016 at 16:31, Christophe Fergeau wrote:
> > Hey,
> >
> > On Mon, Oct 31, 2016 at 08:00:09AM -0400, Frediano Ziglio wrote:
> >> > diff --git a/drivers/gpu/drm/qxl/qxl_display.c
> >> > b/drivers/gpu/drm/qxl/
On Thu, Nov 03, 2016 at 06:08:39PM +0100, Gerd Hoffmann wrote:
> > Or maybe other parts of the
> > kernel/userspace rely on this rounding down.
>
> This is where I suspect we could run in trouble. Odd resolutions simply
> don't happen on physical hardware, all usual resolutions are a multiple
> o
>
> This helper function does nothing but cast the return from
> red_channel_client_get_channel(), and it has a confusing name
> (_get_state(), but returns a channel)
Acked-by: Frediano Ziglio
> ---
> server/spicevmc.c | 20 +++-
> 1 file changed, 7 insertions(+), 13 deletions(
>
> From: Yuri Benditovich
>
> Version information in INF file is configured by
> environment variables.
> The same version information placed in driver binary.
> To set required version from external build engine,
> define following environment variables:
> VERSION_V1, VERSION_V2, VERSION_V3, V
32 matches
Mail list logo
