From: Yuri Benditovich
Version information in INF file is configured by
environment variables.
The same version information placed in driver binary.
To set required version from external build engine,
define following environment variables:
VERSION_V1, VERSION_V2, VERSION_V3, VERSION_V4
Signed-o
QQL - yes, seems like typo, will fix it
Updating the version: typically in external configuration, like brew spec
file
0.13 - next version according to latest discussion in [spice-list]
100 - designating win 10.0
6 - just because we do not have anything other clearly defined.
On Tue, Nov 1, 2016 a
Acked-by: Jonathon Jongsma
I was just thinking I should do this. Now I don't have to ;)
On Tue, 2016-11-01 at 16:44 +, Frediano Ziglio wrote:
> Avoid to use RedCharDeviceSpiceVmcPrivate as already private inside
> C file.
> Use proper type for RedCharDeviceSpiceVmc::channel.
>
> Signed-off
On Tue, 2016-11-01 at 06:28 -0400, Frediano Ziglio wrote:
> >
> >
> > On Mon, 2016-10-31 at 10:44 -0400, Frediano Ziglio wrote:
> > >
> > > >
> > > >
> > > >
> > > > The destructor function was calling reds_cleanup() for each
> > > > server
> > > > at
> > > > application exit. But reds_cleanu
- renamed spicevmc to RedVmcChannel (due to acked patch);
- added a fixup.
Frediano Ziglio (1):
fixup! Manage lifetime of RedVmcChannel
Jonathon Jongsma (1):
Manage lifetime of RedVmcChannel
server/spicevmc.c | 27 ---
1 file changed, 20 insertions(+), 7 deletions(-)
Avoid to use RedCharDeviceSpiceVmcPrivate as already private inside
C file.
Use proper type for RedCharDeviceSpiceVmc::channel.
Signed-off-by: Frediano Ziglio
---
server/spicevmc.c | 22 ++
1 file changed, 6 insertions(+), 16 deletions(-)
diff --git a/server/spicevmc.c b/ser
From: Jonathon Jongsma
Store the channel in the char device object, and unref it in dispose.
Previously, we were just creating a channel and allowing it to leak.
There may be better long-term solutions, but this works for now.
---
server/spicevmc.c | 25 -
1 file changed,
---
This patch removes the 'opaque' property from RedCharDevice and the 'opaque'
argument from the char device vfuncs. It required some
minor refactoring to achieve this.
server/char-device.c | 31 ++---
server/char-device.h | 15 ++
server/reds.c
Hi again,
On Tue, Nov 01, 2016 at 05:08:58PM +0100, Victor Toso wrote:
> Hi,
>
> On Mon, Oct 31, 2016 at 03:11:05PM +, Pavel Duda wrote:
> > Hello,
> > I'm experiencing weird bug on Fedora 24 when using mouse in client mode
> > together with IBM Sametime.
>
> Is it possible to test with Fedo
Hi,
On Mon, Oct 31, 2016 at 03:11:05PM +, Pavel Duda wrote:
> Hello,
> I'm experiencing weird bug on Fedora 24 when using mouse in client mode
> together with IBM Sametime.
Is it possible to test with Fedora 25? It should have at least this
patch [0] which is mostly related to server-side mod
minor & major macros were moved to sysmacros.h
usbutil.c: In function ‘spice_usbutil_get_sysfs_attribute’:
usbutil.c:110:14: warning: ‘__major_from_sys_types’ is deprecated:
In the GNU C Library, `major' is defined by .
For historical compatibility, it is currently defined by
as well, but w
On Tue, 2016-11-01 at 11:18 -0400, Frediano Ziglio wrote:
> >
> > On Tue, 2016-11-01 at 14:12 +0100, Victor Toso wrote:
> > > Hi,
> > >
> > > On Tue, Nov 01, 2016 at 12:02:45PM +0100, Pavel Grunt wrote:
> > > > Signed-off-by: Pavel Grunt
> > > > ---
> > > > v2: added test for RED_STATISTICS
> >
>
> From: Yuri Benditovich
>
> Version information in INF file is configured by
> environment variables.
> The same version information placed in driver binary.
> To set required version from external build engine,
> define following environment variables:
> _VERSION_V1_, _VERSION_V2_, _VERSION_
Call red_client_add_channel at the end of initialisation.
This respect the previous order.
After returning from a successful red_client_add_channel another
thread could call some function in this RedChannelClient so make sure
is fully initalized. Not doing so for instance could cause a
disconnectio
From: Yuri Benditovich
Version information in INF file is configured by
environment variables.
The same version information placed in driver binary.
To set required version from external build engine,
define following environment variables:
_VERSION_V1_, _VERSION_V2_, _VERSION_V3_, _VERSION_V4_
>
> On Tue, 2016-11-01 at 14:12 +0100, Victor Toso wrote:
> > Hi,
> >
> > On Tue, Nov 01, 2016 at 12:02:45PM +0100, Pavel Grunt wrote:
> > > Signed-off-by: Pavel Grunt
> > > ---
> > > v2: added test for RED_STATISTICS
> > > ---
> > > .gitlab-ci.yml | 18 ++
> > > 1 file changed,
>
> ---
> common/log.c| 2 +-
> python_modules/demarshal.py | 2 +-
> tests/test-logging.c| 2 +-
> tests/test-marshallers.c| 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/common/log.c b/common/log.c
> index 20d4597..28f518b 100644
> --- a/
> Internal types use the 'Red' prefix by convention, rather than the
> 'Spice' prefix. In addition, this type inherits from RedChannel, so
> makes the code a lot clearer to call it a 'channel' rather than a
> 'state'.
Acked-by: Frediano Ziglio
> ---
> server/spicevmc.c | 161
> +++
ACK
On Tue, 2016-11-01 at 11:08 +, Frediano Ziglio wrote:
> Style fixes
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-client.c | 15 +--
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/server/red-client.c b/server/red-client.c
> index 3984672..9b7d76e
On Tue, Nov 01, 2016 at 02:13:22PM +0100, Pavel Grunt wrote:
> ---
> common/log.c| 2 +-
> python_modules/demarshal.py | 2 +-
> tests/test-logging.c| 2 +-
> tests/test-marshallers.c| 2 +-
Acked-by: Victor Toso
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
On Tue, 2016-11-01 at 11:07 +, Frediano Ziglio wrote:
> id field of RedChannelClient is not used and marked as debugging.
> Also it's value is quite confusing.
>
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> server/red-channel-client-private.h | 1 -
> server/red-channel-cl
On Tue, 2016-11-01 at 14:12 +0100, Victor Toso wrote:
> Hi,
>
> On Tue, Nov 01, 2016 at 12:02:45PM +0100, Pavel Grunt wrote:
> > Signed-off-by: Pavel Grunt
> > ---
> > v2: added test for RED_STATISTICS
> > ---
> > .gitlab-ci.yml | 18 ++
> > 1 file changed, 18 insertions(+)
> >
Ack
On Tue, 2016-11-01 at 11:08 +, Frediano Ziglio wrote:
> Fix style
>
> Signed-off-by: Frediano Ziglio
> ---
> server/dummy-channel-client.c | 3 ++-
> server/red-channel-client.c | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/server/dummy-channel-client.c
Ack
On Mon, 2016-10-24 at 15:28 +0200, Victor Toso wrote:
> From: Victor Toso
>
> Signed-off-by: Victor Toso
> ---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index dd2d373..17f48d1 100644
> --- a/configure.ac
> +++ b/c
Hi,
Thanks for your interest in Spice
On Mon, Oct 31, 2016 at 08:52:42PM +0300, Krutskikh Ivan wrote:
> Hi everyone!
>
> My team was given a task of creating a centralized computing
> infrastructure with additional features:
>
> 1) Most of it services and client machines run in vm's on servers.
>
On Tue, 2016-11-01 at 09:06 -0400, Frediano Ziglio wrote:
> >
> > Signed-off-by: Pavel Grunt
>
> Do you have some gitlab result logs for this?
yes, in my fork:
https://gitlab.com/xerus/spice/builds/5739770
Thanks,
Pavel
>
> Frediano
>
> > ---
> > v2: added test for RED_STATISTICS
> > ---
>
---
common/log.c| 2 +-
python_modules/demarshal.py | 2 +-
tests/test-logging.c| 2 +-
tests/test-marshallers.c| 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/common/log.c b/common/log.c
index 20d4597..28f518b 100644
--- a/common/log.c
+++ b/comm
Hi,
On Tue, Nov 01, 2016 at 12:02:45PM +0100, Pavel Grunt wrote:
> Signed-off-by: Pavel Grunt
> ---
> v2: added test for RED_STATISTICS
> ---
> .gitlab-ci.yml | 18 ++
> 1 file changed, 18 insertions(+)
> create mode 100644 .gitlab-ci.yml
>
> diff --git a/.gitlab-ci.yml b/.gitla
>
> Signed-off-by: Pavel Grunt
Do you have some gitlab result logs for this?
Frediano
> ---
> v2: added test for RED_STATISTICS
> ---
> .gitlab-ci.yml | 18 ++
> 1 file changed, 18 insertions(+)
> create mode 100644 .gitlab-ci.yml
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci
>
> Signed-off-by: Francois Gouget
> ---
> server/gstreamer-encoder.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c
> index 6afc7e4..f9cd3ca 100644
> --- a/server/gstreamer-encoder.c
> +++ b/server/gstreamer-en
>
> In commit beec1b41, we manually limited this property value in
> _set_property(). But there's a simpler way to do it: via the param spec
> for the property.
>
> This also means that we can remove the warning log in red_worker_new()
> since GObject will automatically warn if a property is assi
Revert file change.
glib-compat.h include is still necessary for RHEL6 compatibility.
Signed-off-by: Frediano Ziglio
---
server/red-channel-client.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/server/red-channel-client.c b/server/red-channel-client.c
index 1907714..1b57ae6 100644
--- a/s
It's already defined in the same file some lines above.
Signed-off-by: Frediano Ziglio
---
server/red-channel.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/server/red-channel.h b/server/red-channel.h
index 5908a75..0aa72c5 100644
--- a/server/red-channel.h
+++ b/server/red-channel.h
@@ -1
There was a chance that on error GQueue were not
initialized but an attempt to destroy it is made.
This ensures GQueue is initialized as soon as
possible. Note that red_channel_client_initable_init
is called after all init and construction callbacks.
Signed-off-by: Frediano Ziglio
---
server/red
>
> ---
> v2: applied Frediano's suggestions
> ---
> server/dcc-send.c| 2 +-
> server/main-channel-client.c | 3 +++
> server/red-channel.c | 11 ++-
> 3 files changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/server/dcc-send.c b/server/dcc-send.c
> index
>
> It is more a feature for developers, not force them.
>
> Signed-off-by: Pavel Grunt
> ---
> server/Makefile.am | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/server/Makefile.am b/server/Makefile.am
> index 2a6010b..0514a2c 100644
> --- a/server/Makefile.am
> +++ b/server/Makefile.
These fields need just channel to be set to be initialized.
Move their initialization to constructor to make sure
they are initialized as soon as possible.
Signed-off-by: Frediano Ziglio
---
server/dummy-channel-client.c | 2 --
server/red-channel-client.c | 18 +-
2 files cha
---
v2: applied Frediano's suggestions
---
server/dcc-send.c| 2 +-
server/main-channel-client.c | 3 +++
server/red-channel.c | 11 ++-
3 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/server/dcc-send.c b/server/dcc-send.c
index 01722c5..5f9ea45 100644
It is more a feature for developers, not force them.
Signed-off-by: Pavel Grunt
---
server/Makefile.am | 1 -
1 file changed, 1 deletion(-)
diff --git a/server/Makefile.am b/server/Makefile.am
index 2a6010b..0514a2c 100644
--- a/server/Makefile.am
+++ b/server/Makefile.am
@@ -3,7 +3,6 @@ SUBDIR
From: Jonathon Jongsma
Signed-off-by: Jonathon Jongsma
Acked-by: Frediano Ziglio
---
server/main-dispatcher.c| 12 ++---
server/red-channel-client.c | 1 -
server/red-client.c | 117
server/red-client.h | 29 +++
serv
From: Jonathon Jongsma
Also move the RedClient struct out of the header to avoid accessing the
internals from other files.
Signed-off-by: Jonathon Jongsma
Acked-by: Frediano Ziglio
---
server/Makefile.am | 2 +
server/char-device.c | 6 +-
server/common-graphics-
Signed-off-by: Pavel Grunt
---
v2: added test for RED_STATISTICS
---
.gitlab-ci.yml | 18 ++
1 file changed, 18 insertions(+)
create mode 100644 .gitlab-ci.yml
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
new file mode 100644
index 000..b3996c8
--- /dev/null
+++ b/.gitlab-ci
Fix style
Signed-off-by: Frediano Ziglio
---
server/dummy-channel-client.c | 3 ++-
server/red-channel-client.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/server/dummy-channel-client.c b/server/dummy-channel-client.c
index e43546c..a39941c 100644
--- a/server/dummy
From: Jonathon Jongsma
Switch from a Ring to a GList so that we can hide the internals of
RedClient in a future commit.
Signed-off-by: Jonathon Jongsma
Acked-by: Frediano Ziglio
---
server/red-channel.h | 1 -
server/reds-private.h | 3 +--
server/reds.c | 54 ++
From: Jonathon Jongsma
**FIXME: introduces crash when session vdagent connects
Instead of requiring the channel client to lock the client's lock,
re-arrange things so that all of the locking can be internal to
RedClient methods. So instead of having a pre-create validate function,
we simply move
I put some additional patches related to last GObject patches
from refactory branch.
Some fixup are really small (like style changes).
Acked some patches.
Frediano Ziglio (8):
red-channel-client: Init pipe field during init
red-channel-client: Move incoming/ougoing initialization to
constr
Make the order of initialization closer to what it was before
conversion to GObject.
Signed-off-by: Frediano Ziglio
Acked-by: Jonathon Jongsma
---
server/red-channel-client.c | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/server/red-channel-cl
Style fixes
Signed-off-by: Frediano Ziglio
---
server/red-client.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/server/red-client.c b/server/red-client.c
index 3984672..9b7d76e 100644
--- a/server/red-client.c
+++ b/server/red-client.c
@@ -38,10 +38,11 @@ s
id field of RedChannelClient is not used and marked as debugging.
Also it's value is quite confusing.
Signed-off-by: Frediano Ziglio
---
server/red-channel-client-private.h | 1 -
server/red-channel-client.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/server/red-channel-client-p
Remove unused declarations and refs field
Signed-off-by: Frediano Ziglio
---
server/red-client.c | 1 -
server/red-client.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/server/red-client.c b/server/red-client.c
index 42ba140..f7f4562 100644
--- a/server/red-client.c
+++ b/server/red-clie
Style.
Signed-off-by: Frediano Ziglio
---
server/red-client.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/server/red-client.h b/server/red-client.h
index 1bf5ab8..dfa94aa 100644
--- a/server/red-client.h
+++ b/server/red-client.h
@@ -31,7 +31,8 @@ G_BEGIN_DECLS
#define
>
> On Mon, 2016-10-31 at 10:44 -0400, Frediano Ziglio wrote:
> > >
> > >
> > > The destructor function was calling reds_cleanup() for each server
> > > at
> > > application exit. But reds_cleanup() only cleans up a couple of
> > > statistics-related variables. We should actually free the server
On Mon, 2016-10-31 at 17:15 +0100, Victor Toso wrote:
> Hi,
>
> On Thu, Oct 27, 2016 at 04:07:15PM -0500, Jonathon Jongsma wrote:
> > Seems OK to me. Looks like it was deprecated in Feb 2012. Anybody
> > else
> > have objections?
>
> None. I also think it is safe to remove it now.
> Pushed all
53 matches
Mail list logo
