On Mon, 2016-10-31 at 12:59 -0400, Frediano Ziglio wrote:
> >
> >
> > Add a 'self' parameter to all of the char device virtual functions
> > so
> > that we don't have to play games with the 'opaque' pointer.
>
> From the patch looks like the opaque parameter can be removed.
Unfortunately, I don
On Mon, 2016-10-31 at 10:44 -0400, Frediano Ziglio wrote:
> >
> >
> > The destructor function was calling reds_cleanup() for each server
> > at
> > application exit. But reds_cleanup() only cleans up a couple of
> > statistics-related variables. We should actually free the servers
> > by
> > call
On Mon, 2016-10-31 at 10:32 -0400, Frediano Ziglio wrote:
> >
> >
> > ---
> > server/display-channel.c | 3 +++
> > server/sound.c | 1 +
> > 2 files changed, 4 insertions(+)
> >
> > diff --git a/server/display-channel.c b/server/display-channel.c
> > index b483b57..e46d067 100644
> >
On Mon, 2016-10-31 at 06:16 -0400, Frediano Ziglio wrote:
> >
> >
> > On Fri, 2016-10-28 at 11:59 +0100, Frediano Ziglio wrote:
> > >
> > > A bit more similar to previous
> >
> > The patch looks fine to me, but it's not clear to me why it's an
> > improvement. Can you expand on that in the comm
In commit beec1b41, we manually limited this property value in
_set_property(). But there's a simpler way to do it: via the param spec
for the property.
This also means that we can remove the warning log in red_worker_new()
since GObject will automatically warn if a property is assigned a value
ou
On Mon, 2016-10-31 at 19:06 +0100, Victor Toso wrote:
> Hi,
>
> On Mon, Oct 31, 2016 at 01:31:00PM -0400, Jeremy Bicha wrote:
> >
> > On Mon, Oct 31, 2016 at 1:09 PM, Victor Toso
> > wrote:
> > >
> > > * spice-vdagent makes some interactions with the guest possible;
> > > clipboard exchange b
Group the options more logically and improve their descriptions.
In the Xorg configuration, always show the default in the
commented-out sample.
Signed-off-by: Francois Gouget
---
examples/spiceqxl.xorg.conf.example | 166 +++-
scripts/Xspice
On Mon, 2016-10-31 at 07:49 -0400, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> >
> > To avoid checking for error in all the path use setjmp/longjmp.
> > This allow to jump directly to the error handling code in
> > spice_replay_next_cmd.
> >
> > Signed-off-by: Frediano Zigli
Acked-by: Jonathon Jongsma
On Mon, 2016-10-31 at 10:23 +, Frediano Ziglio wrote:
> These functions were implementing the same stuff as empty
> messages functions provided by RedChannel so reuse them.
>
> The implementation seems a bit different but the result
> is the same. Specifically:
>
Signed-off-by: Francois Gouget
---
src/channel-display-gst.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
index 5fb0b77..5ebfc53 100644
--- a/src/channel-display-gst.c
+++ b/src/channel-display-gst.c
@@ -446,6 +446,13 @@ static g
Signed-off-by: Francois Gouget
---
src/channel-display-gst.c | 41 -
src/channel-display-mjpeg.c | 8 +---
src/channel-display-priv.h | 4 +++-
src/channel-display.c | 7 ++-
4 files changed, 50 insertions(+), 10 deletions(-)
diff --git
By removing the stream's video encoder we force the stream to send
future frames using the fallback code, that is as regular screen
updates.
However note that we keep the stream object: we have to. Otherwise
future frames would trigger the creation of a new stream object with a
new video encode
The error is sent using the existing client stream report message where
the dropped frame count is maxed out while the received frame count is
zero. Servers that recognize it can then switch to sending regular
screen updates for that area so the client is not stuck with a frozen
area on the screen.
We run the VP8 encoder in real time mode so it uses only the minimum
amount of time needed to encode each frame. However by default it
only uses one thread so that for large/complex frames it may run at
less than the source fps. Besides resulting in dropped frames this
blocks the main server thread
Hi,
On Mon, Oct 31, 2016 at 01:31:00PM -0400, Jeremy Bicha wrote:
> On Mon, Oct 31, 2016 at 1:09 PM, Victor Toso wrote:
> > * spice-vdagent makes some interactions with the guest possible;
> > clipboard exchange between client <-> guest is possible thanks to this
> > daemon; copying files ove
Hi everyone!
My team was given a task of creating a centralized computing infrastructure
with additional features:
1) Most of it services and client machines run in vm's on servers. (Mostly
modern or legacy windows os)
2) All of screen sessions are being recorded as video files in streaming
codec
On Mon, Oct 31, 2016 at 1:09 PM, Victor Toso wrote:
> * spice-vdagent makes some interactions with the guest possible;
> clipboard exchange between client <-> guest is possible thanks to this
> daemon; copying files over drag-and-drop as well; and a few other
> features
Does it make perform
Hi,
On Mon, Oct 31, 2016 at 12:48:51PM -0400, Jeremy Bicha wrote:
> I added spice-vdagent to Ubuntu GNOME 16.10's default install so that
> it will work better in the GNOME Boxes app.
Great to hear.
>
> Should qemu-guest-agent and spice-webdavd be installed by default too?
>
> I'm thinking about
>
> Add a 'self' parameter to all of the char device virtual functions so
> that we don't have to play games with the 'opaque' pointer.
From the patch looks like the opaque parameter can be removed.
> ---
> server/char-device.c | 8
> server/char-device.h | 13 +
> server/
I added spice-vdagent to Ubuntu GNOME 16.10's default install so that
it will work better in the GNOME Boxes app.
Should qemu-guest-agent and spice-webdavd be installed by default too?
I'm thinking about mentioning these packages to other Ubuntu flavors
in case they want to add them to the defaul
Hi,
On Mon, Oct 31, 2016 at 05:18:54PM +0100, Pavel Grunt wrote:
> Signed-off-by: Pavel Grunt
Acked-by: Victor Toso
We could also considering removing the .travis.yml unless we find an
automated way to update https://github.com/SPICE repo ...
> ---
> .gitlab-ci.yml | 12
> 1 fil
Signed-off-by: Pavel Grunt
---
.gitlab-ci.yml | 12
1 file changed, 12 insertions(+)
create mode 100644 .gitlab-ci.yml
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
new file mode 100644
index 000..0d2e7eb
--- /dev/null
+++ b/.gitlab-ci.yml
@@ -0,0 +1,12 @@
+image: fedora:latest
>
> From: Christophe Fergeau
>
> It's more natural to do things this way with glib, and this allows to
> remove some coupling between Reds and RedCharDeviceVDIPort. Before this
> commit, the RedCharDeviceVDIPort has to provide a on_free_self_token()
> because Reds needs to know about it. With a
Hi,
On Thu, Oct 27, 2016 at 04:07:15PM -0500, Jonathon Jongsma wrote:
> Seems OK to me. Looks like it was deprecated in Feb 2012. Anybody else
> have objections?
None. I also think it is safe to remove it now.
Pushed all the acked patches.
Cheers,
toso
>
>
> On Thu, 2016-10-27 at 18:41 +020
Hi,
On Mon, Oct 31, 2016 at 04:51:25PM +0100, Pavel Grunt wrote:
> Hello,
>
> thanks to Victor we have a gitlab mirror of SPICE repositories at:
> https://gitlab.com/spice/
>
> The big advantage is that it offers ci runners using images from Docker Hub.
> It allows us to use Fedora as a test base
Hi,
On Mon, Oct 31, 2016 at 04:51:26PM +0100, Pavel Grunt wrote:
> Signed-off-by: Pavel Grunt
> ---
> .gitlab-ci.yml | 8
> 1 file changed, 8 insertions(+)
> create mode 100644 .gitlab-ci.yml
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> new file mode 100644
> index 000..26266
On Mon, Oct 31, 2016 at 9:47 AM, Javier Celaya
wrote:
> Hi,
>
> El dom, 30-10-2016 a las 10:50 +0200, Sameeh Jubran escribió:
> > Hi Fabio,
> >
> > I still suspect that the performance issue is caused by the mouse. As
> > you can see in flexVDI's repository (
> > https://github.com/flexVDI/qxl-do
Hello,
thanks to Victor we have a gitlab mirror of SPICE repositories at:
https://gitlab.com/spice/
The big advantage is that it offers ci runners using images from Docker Hub.
It allows us to use Fedora as a test base and get our other upstream
components (dependencies like spice-protocol) from
Signed-off-by: Pavel Grunt
---
.gitlab-ci.yml | 8
1 file changed, 8 insertions(+)
create mode 100644 .gitlab-ci.yml
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
new file mode 100644
index 000..26266c6
--- /dev/null
+++ b/.gitlab-ci.yml
@@ -0,0 +1,8 @@
+image: fedora:latest
+
+befo
>
> The destructor function was calling reds_cleanup() for each server at
> application exit. But reds_cleanup() only cleans up a couple of
> statistics-related variables. We should actually free the servers by
> calling spice_server_destroy(). This left reds_cleanup() unused, so the
> contents of
>
> ---
> server/display-channel.c | 3 +++
> server/sound.c | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/server/display-channel.c b/server/display-channel.c
> index b483b57..e46d067 100644
> --- a/server/display-channel.c
> +++ b/server/display-channel.c
> @@ -1904,6 +19
On 10/31/2016 01:25 PM, Frediano Ziglio wrote:
This remove a writable global variable.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/reds.c b/server/reds.c
index 19ca568..c40ff1e 100644
--- a/server/reds.c
+++ b/serv
>
> When the QXL driver receives a QXL_INTERRUPT_CLIENT_MONITORS_CONFIG
> interrupt,
> we currently always notify userspace that there was some hotplug event.
>
> However, gnome-shell/mutter is reacting to this event by attempting a
> resolution change, which it does by issueing drmModeRmFB, drmM
Hi
- Original Message -
> To avoid checking for error in all the path use setjmp/longjmp.
> This allow to jump directly to the error handling code in
> spice_replay_next_cmd.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-replay-qxl.c | 142
>
On Mon, 2016-10-31 at 07:35 -0400, Frediano Ziglio wrote:
> >
> > The use of drm_cvt_mode() in qxl_add_monitors_config_modes() means
> > that
> > the resolutions we are going to present to user-space are going to
> > be
> > rounded down to a multiple of 8. In the QXL arbitrary resolution
> > case,
>
> qdev->gem.objects was initialized directly in qxl_device_init() rather
> than going through qxl_gem_init(), and qxl_gem_fini() was never called.
>
Considering "qxl_gem_fini() was never called" did we have a leak?
> Signed-off-by: Christophe Fergeau
> ---
> drivers/gpu/drm/qxl/qxl_kms.c |
>
> The use of drm_cvt_mode() in qxl_add_monitors_config_modes() means that
> the resolutions we are going to present to user-space are going to be
> rounded down to a multiple of 8. In the QXL arbitrary resolution case,
> this is not useful.
> This commit forces the actual width/height that was r
>
> qxl_crtc_set_from_monitors_config() is defined in qxl_drv.h but never
> implemented.
>
> Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
> ---
> drivers/gpu/drm/qxl/qxl_drv.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/g
>
> The message has to be terminated by a newline as it's not going to get
> added automatically.
>
> Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
> ---
> drivers/gpu/drm/qxl/qxl_fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/qxl
>
> They are not used outside of their respective source file
>
> Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
> ---
> drivers/gpu/drm/qxl/qxl_cmd.c | 2 +-
> drivers/gpu/drm/qxl/qxl_display.c | 4 ++--
> drivers/gpu/drm/qxl/qxl_drv.h | 3 ---
> 3 files changed, 3 inse
This remove a writable global variable.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/reds.c b/server/reds.c
index 19ca568..c40ff1e 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3599,7 +3599,7 @@ static const Enum
On Mon, 2016-10-31 at 07:01 -0400, Frediano Ziglio wrote:
> >
> > On Mon, 2016-10-31 at 06:17 -0400, Frediano Ziglio wrote:
> > > ping
> > >
> > > >
> > > > The top down flag can be specified using negative heights.
> >
> > Will the resulting bitmap be upside down ? Or it depends on the
> > ima
>
> On Mon, 2016-10-31 at 06:17 -0400, Frediano Ziglio wrote:
> > ping
> >
> > >
> > > The top down flag can be specified using negative heights.
>
> Will the resulting bitmap be upside down ? Or it depends on the image
> viewer ?
>
> Pavel
>
According to
https://msdn.microsoft.com/en-us/li
On Mon, 2016-10-31 at 06:17 -0400, Frediano Ziglio wrote:
> ping
>
> >
> > The top down flag can be specified using negative heights.
Will the resulting bitmap be upside down ? Or it depends on the image
viewer ?
Pavel
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/spice-bitmap-u
Got it. So DrvXXX is still the final leaves. Thank you very much ：）
> On Oct 31, 2016, at 5:57 PM, Frediano Ziglio wrote:
>
>>
>> Hi experts,
>>
>> Recently I’m studying QXL XDDM driver to see how the display are
>> accelerated.
>>
>> One thing I do not understand is that I thought some
On 10/31/2016 11:57 AM, Frediano Ziglio wrote:
Hi experts,
Recently I’m studying QXL XDDM driver to see how the display are
accelerated.
One thing I do not understand is that I thought some updates should be
missing on clients.
Say in the implementation of DrvBitBlt function, if it i
Hi Frediano,
On Fri, 2016-10-21 at 13:40 +0100, Frediano Ziglio wrote:
> These patches attempt to provide some additional testing
> to VideoEncoder.
> Mainly "Add an helper to test VideoEncoder" add an utility
> that helps doing some test.
> The "RFC EXAMPLE Some automatic check on video encoders"
These functions were implementing the same stuff as empty
messages functions provided by RedChannel so reuse them.
The implementation seems a bit different but the result
is the same. Specifically:
- RedEmptyMsgPipeItem::msg is int while RedVerbItem::verb was
uint16_t however this data goes into
Ack
On Mon, 2016-10-31 at 09:51 +, Frediano Ziglio wrote:
> red_drawable_unref declaration was moved to red-parse-qxl.h.
> Result is that only RedDispatcher know of the existence of
> RedWorker.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/image-encoders.c | 2 +-
> 1 file changed, 1 i
ping
>
> The top down flag can be specified using negative heights.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/spice-bitmap-utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/spice-bitmap-utils.c b/server/spice-bitmap-utils.c
> index 72a9285..439f05
>
> On Fri, 2016-10-28 at 11:59 +0100, Frediano Ziglio wrote:
> > A bit more similar to previous
>
> The patch looks fine to me, but it's not clear to me why it's an
> improvement. Can you expand on that in the commit log at least?
>
Not that I found a problem (currently) with the change howeve
>
> On Fri, Oct 28, 2016 at 11:59:54AM +0100, Frediano Ziglio wrote:
> > These fields need just channel to be set to be initialized.
> > Move their initialization to constructor to make sure
> > they are initialized as soon as possible.
>
> Why?
>
Read previous reply to "red-channel-client: In
>
> On Fri, Oct 28, 2016 at 11:59:53AM +0100, Frediano Ziglio wrote:
> > There was a chance that on error GQueue were not
> > initialized but an attempt to destroy it is made.
> > This assure GQueue is initialized as soon as
>
> s/assure/ensures
>
Fixed, thanks
> > possible. Note that red_chan
>
> Hi experts,
>
> Recently I’m studying QXL XDDM driver to see how the display are
> accelerated.
>
> One thing I do not understand is that I thought some updates should be
> missing on clients.
> Say in the implementation of DrvBitBlt function, if it is not supported.
> the implem
red_drawable_unref declaration was moved to red-parse-qxl.h.
Result is that only RedDispatcher know of the existence of RedWorker.
Signed-off-by: Frediano Ziglio
---
server/image-encoders.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/image-encoders.c b/server/image
>
> On Fri, 2016-10-28 at 06:46 -0400, Frediano Ziglio wrote:
> > >
> > >
> > > In commit beec1b41, we manually limited this property value in
> > > _set_property(). But there's a simpler way to do it: via the param
> > > spec
> > > for the property.
> > >
> > > This also means that we can remo
Hi experts,
Recently I’m studying QXL XDDM driver to see how the display are accelerated.
One thing I do not understand is that I thought some updates should be
missing on clients.
Say in the implementation of DrvBitBlt function, if it is not supported. the
implemention will punt to EngBi
Hi,
El dom, 30-10-2016 a las 10:50 +0200, Sameeh Jubran escribió:
> Hi Fabio,
>
> I still suspect that the performance issue is caused by the mouse. As
> you can see in flexVDI's repository (
> https://github.com/flexVDI/qxl-dod/blob/master/qxldod/QxlDod.h) the
> function "EnablePointer" always r
58 matches
Mail list logo
