Re: [Spice-devel] [PATCH spice-server v8 11/12] fixup! Convert RedChannel hierarchy to GObject

2016-10-24 Thread Jonathon Jongsma
On Mon, 2016-10-24 at 09:40 +0100, Frediano Ziglio wrote: > Move virtual method check back to initialisation. > Moving to method itself and just giving warning and > returning cause different regression from design prospective > and security. > > Signed-off-by: Frediano Ziglio > --- >  server/red

Re: [Spice-devel] [spice v1 10/10] dcc: handle preferred video codec message

2016-10-24 Thread Victor Toso
Hi, On Mon, Oct 24, 2016 at 11:21:24AM -0400, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > SPICE_MSGC_DISPLAY_PREFERRED_VIDEO_CODEC_TYPE can be used to set the > > preferred order of video codecs to be used based in client's > > preference. > > > > A new function is introduced in r

Re: [Spice-devel] [spice-common v1] protocol: add preferred video codec message

2016-10-24 Thread Victor Toso
Hi, On Mon, Oct 24, 2016 at 11:06:10AM -0400, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > Client might want to choose a preferred video codec for streaming for > > different reasons which having hardware decoder support being the most > > interest one. > > > > This message allows

Re: [Spice-devel] [spice v1 10/10] dcc: handle preferred video codec message

2016-10-24 Thread Frediano Ziglio
> > From: Victor Toso > > SPICE_MSGC_DISPLAY_PREFERRED_VIDEO_CODEC_TYPE can be used to set the > preferred order of video codecs to be used based in client's > preference. > > A new function is introduced in reds.c to update its video codec: > reds_set_video_codecs_from_client_preferred_msg() -

Re: [Spice-devel] [spice-common v1] protocol: add preferred video codec message

2016-10-24 Thread Frediano Ziglio
> > From: Victor Toso > > Client might want to choose a preferred video codec for streaming for > different reasons which having hardware decoder support being the most > interest one. > > This message allows the client to send a combination of video codec > type with a ranking value of SpiceVi

[Spice-devel] [spice-gtk v1 7/7] spicy: implement preferred video codec type

2016-10-24 Thread Victor Toso
From: Victor Toso Similar to preferred video compression, a radio button showing mjpeg, vp8 and h264 in case server has the proper [0] capability [0] SPICE_DISPLAY_CAP_PREF_VIDEO_CODEC_TYPE Signed-off-by: Victor Toso --- src/spicy.c | 41 + 1 file chang

[Spice-devel] [spice v1 08/10] reds: set video codec in a different function

2016-10-24 Thread Victor Toso
From: Victor Toso Small refactor. This will be useful in the next two patches. Signed-off-by: Victor Toso --- server/reds.c | 31 --- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/server/reds.c b/server/reds.c index fc116e0..b5d1270 100644 --- a/ser

[Spice-devel] [spice-gtk v1 5/7] Update spice-common

2016-10-24 Thread Victor Toso
From: Victor Toso Francois Gouget (1): codegen: Fix compatibility with Python 2.6 Frediano Ziglio (6): Start adding protocol file documentation Start writing some documentation on protocol Extended protocol documentation More work on attribute protocol documentation

[Spice-devel] [v1] Add preferred video codec type message

2016-10-24 Thread Victor Toso
From: Victor Toso Hi, The main idea here is to provide a way to chose codec type for video stream. At this moment, the main purpose is making streaming in different formats easy to test. Ideally in the future, client could send upfront to the server what client can hw decode. As discussed previ

[Spice-devel] [spice-gtk v1 6/7] channel-display: implement preferred video codec msgc

2016-10-24 Thread Victor Toso
From: Victor Toso * SPICE_MSGC_DISPLAY_PREFERRED_VIDEO_CODEC_TYPE This message was introduced in spice-protocol v0.12.13 in order to request to server to encode new video streams with specific video-codec. Signed-off-by: Victor Toso --- configure.ac | 2 +- doc/refere

[Spice-devel] [spice v1 07/10] Update spice-common

2016-10-24 Thread Victor Toso
From: Victor Toso Frediano Ziglio (6): Start adding protocol file documentation Start writing some documentation on protocol Extended protocol documentation More work on attribute protocol documentation Fix BNF notation in documentation Add protocol documentati

[Spice-devel] [spice v1 10/10] dcc: handle preferred video codec message

2016-10-24 Thread Victor Toso
From: Victor Toso SPICE_MSGC_DISPLAY_PREFERRED_VIDEO_CODEC_TYPE can be used to set the preferred order of video codecs to be used based in client's preference. A new function is introduced in reds.c to update its video codec: reds_set_video_codecs_from_client_preferred_msg() - it only update the

[Spice-devel] [spice v1 09/10] reds: add support to ranks for video codecs

2016-10-24 Thread Victor Toso
From: Victor Toso SpiceVideoCodecRank was recently introduce in spice-protocol as a client side preference for video codecs. This patch implements a new value to the preference introduced in 497fcbb0a315b034ba keeping it backwards compatible. The new value is the SpiceVideoCodecRank and should b

[Spice-devel] [spice-protocol v1 3/4] enums: Move auto generated SpiceDataCompressionType

2016-10-24 Thread Victor Toso
From: Victor Toso This header is auto generated from spice_codegen.py tool in spice-common repository and thus, it changes what was included manually. Move SpiceDataCompressionType struct to comply with spice_codegen.py. This header was generated with: ./spice_codegen.py -e spice.proto ../spic

[Spice-devel] [spice-protocol v1 2/4] build-sys: post-release bump

2016-10-24 Thread Victor Toso
From: Victor Toso Signed-off-by: Victor Toso --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index dd2d373..17f48d1 100644 --- a/configure.ac +++ b/configure.ac @@ -2,7 +2,7 @@ AC_PREREQ([2.57]) m4_define([SPICE_MAJOR], 0) m4_

[Spice-devel] [spice-common v1] protocol: add preferred video codec message

2016-10-24 Thread Victor Toso
From: Victor Toso Client might want to choose a preferred video codec for streaming for different reasons which having hardware decoder support being the most interest one. This message allows the client to send a combination of video codec type with a ranking value of SpiceVideoCodecRank. Sign

[Spice-devel] [spice-protocol v1 4/4] protocol: add preferred video codec message

2016-10-24 Thread Victor Toso
From: Victor Toso Client might want to choose a preferred video codec for streaming for different reasons which having hardware decoder support being the most interest one. This message allows the client to send a combination of video codec type with a ranking value of SpiceVideoCodecRank. Sign

Re: [Spice-devel] [PATCH v2 0/4] Protocol file syntax documentation

2016-10-24 Thread Frediano Ziglio
> > On Mon, Oct 17, 2016 at 01:58:33PM +0200, Victor Toso wrote: > > > > As we have start changing spice.proto to define the spice/enums.h > > header, I think we should move spice.proto to spice-protocol code. > > > We are still missing messages.h autogeneration (which is what caused > some bre

Re: [Spice-devel] [PATCH v2 0/4] Protocol file syntax documentation

2016-10-24 Thread Christophe Fergeau
On Mon, Oct 17, 2016 at 01:58:33PM +0200, Victor Toso wrote: > > As we have start changing spice.proto to define the spice/enums.h > header, I think we should move spice.proto to spice-protocol code. We are still missing messages.h autogeneration (which is what caused some breakage last time iir

Re: [Spice-devel] Very poor video performance using Virt Viewer compared to RDP

2016-10-24 Thread Brad Wilson
Ok, so I installed the AC97 audio drivers to fix my audio device in the guest vm.  Using Virt-Viewer with qxl, the video streaming has improved and I am seeing closer to 1.5Mbps network traffic now when watching hd videos but the quality is still suffering a bit.  What I would like to know is if

Re: [Spice-devel] Very poor video performance using Virt Viewer compared to RDP

2016-10-24 Thread Brad Wilson
Ok, So is there a command I can initiate to re-evaluate the bandwidth availability or a way to check to see the results are correct?  I've got a gigabit connection and I want it to use as much as possible to provide the maximum user experience for my VDI users. Like I said, RDP uses 15Mbps which

Re: [Spice-devel] [PATCH spice-server v8 01/12] Convert RedChannel hierarchy to GObject

2016-10-24 Thread Frediano Ziglio
. > diff --git a/server/red-channel.h b/server/red-channel.h > index 5299646..f95151c 100644 > --- a/server/red-channel.h > +++ b/server/red-channel.h > @@ -24,6 +24,7 @@ > > #include > #include > +#include > #include > #include > > @@ -34,6 +35,8 @@ > #include "stat.h" > #inclu

[Spice-devel] [PATCH spice-server v8 08/12] fixup! Convert RedChannel hierarchy to GObject

2016-10-24 Thread Frediano Ziglio
Return constant from red_channel_get_local_capabilities Signed-off-by: Frediano Ziglio --- server/red-channel.c | 2 +- server/red-channel.h | 2 +- server/reds.c| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/server/red-channel.c b/server/red-channel.c index 7a033

[Spice-devel] [PATCH spice-server v8 03/12] fixup! Convert RedChannel hierarchy to GObject

2016-10-24 Thread Frediano Ziglio
Simplify getting RedsState from DisplayChannel. Signed-off-by: Frediano Ziglio --- server/display-channel.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 59e6c8d..bcf26bb 100644 --- a/server/display-channel.c +

[Spice-devel] [PATCH spice-server v8 11/12] fixup! Convert RedChannel hierarchy to GObject

2016-10-24 Thread Frediano Ziglio
Move virtual method check back to initialisation. Moving to method itself and just giving warning and returning cause different regression from design prospective and security. Signed-off-by: Frediano Ziglio --- server/red-channel.c | 19 ++- server/red-channel.h | 2 -- 2 files

[Spice-devel] [PATCH spice-server v8 07/12] fixup! Convert RedChannel hierarchy to GObject

2016-10-24 Thread Frediano Ziglio
Remove unused red_channel_handle_migrate_data_get_serial Signed-off-by: Frediano Ziglio --- server/red-channel.c | 10 -- server/red-channel.h | 3 --- 2 files changed, 13 deletions(-) diff --git a/server/red-channel.c b/server/red-channel.c index f9973fe..7a03307 100644 --- a/server/r

[Spice-devel] [PATCH spice-server v8 10/12] fixup! Convert RedChannel hierarchy to GObject

2016-10-24 Thread Frediano Ziglio
Removed some space changes Signed-off-by: Frediano Ziglio --- server/sound.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/server/sound.c b/server/sound.c index 9edfa8a..c222c8d 100644 --- a/server/sound.c +++ b/server/sound.c @@ -1063,7 +1063,6 @@ SPICE_GNUC_VISIBLE void spice_server_pl

[Spice-devel] [PATCH spice-server v8 06/12] fixup! Convert RedChannel hierarchy to GObject

2016-10-24 Thread Frediano Ziglio
Removed not necessary SpiceVmcStatePrivate structure Signed-off-by: Frediano Ziglio --- server/spicevmc.c | 143 -- 1 file changed, 64 insertions(+), 79 deletions(-) diff --git a/server/spicevmc.c b/server/spicevmc.c index d92a0fe..0f4c618 100

[Spice-devel] [PATCH spice-server v8 04/12] fixup! Convert RedChannel hierarchy to GObject

2016-10-24 Thread Frediano Ziglio
ring_add was prepending channels Signed-off-by: Frediano Ziglio --- server/reds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/reds.c b/server/reds.c index d06e5d5..3256385 100644 --- a/server/reds.c +++ b/server/reds.c @@ -455,7 +455,7 @@ void stat_remove_counter(R

[Spice-devel] [PATCH spice-server v8 02/12] fixup! Convert RedChannel hierarchy to GObject

2016-10-24 Thread Frediano Ziglio
Remove double statement terminators. Signed-off-by: Frediano Ziglio --- server/display-channel.c | 2 +- server/red-channel.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index decdfee..59e6c8d 100644 --- a/server/

[Spice-devel] [PATCH spice-server v8 00/12] Refactory patches updates

2016-10-24 Thread Frediano Ziglio
Some different fixup with updates and small changes. Frediano Ziglio (11): fixup! Convert RedChannel hierarchy to GObject fixup! Convert RedChannel hierarchy to GObject fixup! Convert RedChannel hierarchy to GObject fixup! Convert RedChannel hierarchy to GObject fixup! Convert RedChannel