>
> SmartCardChannelClient is already defined in smartcard.h which
> is included in the smartcard-channel-client.h header.
>
> Signed-off-by: Francois Gouget
> ---
>
> This patch series is nice and really does help.
> I would add this patch to it.
>
Is there something missing?
> server/smar
>
> Signed-off-by: Francois Gouget
> ---
> spice/vd_agent.h | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/spice/vd_agent.h b/spice/vd_agent.h
> index 445b458..c49f596 100644
> --- a/spice/vd_agent.h
> +++ b/spice/vd_agent.h
> @@ -180,6 +180,12 @@ enum {
>
On Mon, 17 Oct 2016, Francois Gouget wrote:
[...]
> > Imo this SPICE_NO_DEPRECATED is only meant to be used internally by
> > spice-gtk even if this is not really documented. I would not consider it
> > breakage if this was removed, or changed in incompatible ways.
> > And it turns out it's actuall
On Mon, 17 Oct 2016, Brad Wilson wrote:
> Ok, so I installed the AC97 audio drivers to fix my audio device in
> the guest vm. Using Virt-Viewer with qxl, the video streaming has
> improved and I am seeing closer to 1.5Mbps network traffic now when
> watching hd videos but the quality is still
SmartCardChannelClient is already defined in smartcard.h which
is included in the smartcard-channel-client.h header.
Signed-off-by: Francois Gouget
---
This patch series is nice and really does help.
I would add this patch to it.
server/smartcard-channel-client.h | 1 -
1 file changed, 1 delet
Signed-off-by: Francois Gouget
---
spice/vd_agent.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/spice/vd_agent.h b/spice/vd_agent.h
index 445b458..c49f596 100644
--- a/spice/vd_agent.h
+++ b/spice/vd_agent.h
@@ -180,6 +180,12 @@ enum {
VD_AGENT_CLIPBOARD_
Already defined in dcc.h.
Signed-off-by: Frediano Ziglio
---
server/stream.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/server/stream.h b/server/stream.h
index 77223c8..a415e43 100644
--- a/server/stream.h
+++ b/server/stream.h
@@ -42,9 +42,6 @@
#define RED_STREAM_DEFAULT_LOW_START_B
Definitions are all in red-channel.h
Signed-off-by: Frediano Ziglio
---
server/red-worker.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/red-worker.h b/server/red-worker.h
index dc2ff24..cf61a67 100644
--- a/server/red-worker.h
+++ b/server/red-worker.h
@@ -21,7 +21
These are already defined in red-channel.h which is included in
red-channel-client.h header.
Signed-off-by: Frediano Ziglio
---
server/red-channel-client.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/server/red-channel-client.h b/server/red-channel-client.h
index 9cc5245..c2c6407 10064
Quite questionable patch.
Mostly as come typedef are not defined in the place they
naturally should be.
Signed-off-by: Frediano Ziglio
---
server/main-channel-client.h | 5 +
server/main-channel.h| 1 -
server/red-channel-client.h | 1 -
server/stream.h | 6 ++
4 fi
These patches try to solve (or at least minimize) RHEL6
compatibilty issues.
Beside the last one other patches are small and
sensible and do not break defined rules.
Frediano Ziglio (9):
Define a compatibility include for GLib
Include GLib compatibility header where needed
Avoid to typedef t
Signed-off-by: Frediano Ziglio
---
server/dcc.c | 1 +
server/main-channel.c | 3 ++-
server/red-qxl.c | 1 +
server/reds.c | 1 +
server/sound.c| 1 +
server/stream.c | 1 +
6 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/server/dcc.c b/server/dc
Signed-off-by: Frediano Ziglio
---
server/dcc.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/server/dcc.h b/server/dcc.h
index 2456f09..7a07981 100644
--- a/server/dcc.h
+++ b/server/dcc.h
@@ -25,6 +25,7 @@
#include "pixmap-cache.h"
#include "red-worker.h"
#include "display-limits.h"
+#
DisplayChannelClientPrivate is already defined in dcc.h which
is included in dcc-private.h header.
Signed-off-by: Frediano Ziglio
---
server/dcc-private.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/server/dcc-private.h b/server/dcc-private.h
index de6ea92..f3aba50 100644
--- a/server/dcc
Signed-off-by: Frediano Ziglio
---
server/cursor-channel-client.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/cursor-channel-client.h b/server/cursor-channel-client.h
index 2336b95..fab6837 100644
--- a/server/cursor-channel-client.h
+++ b/server/cursor-channel-clie
Signed-off-by: Frediano Ziglio
---
server/char-device.c| 1 +
server/red-channel-client.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/server/char-device.c b/server/char-device.c
index 4f01d3c..7775c07 100644
--- a/server/char-device.c
+++ b/server/char-device.c
@@ -25,6 +25,7 @@
Signed-off-by: Frediano Ziglio
---
server/Makefile.am | 1 +
server/glib-compat.h | 47 +++
2 files changed, 48 insertions(+)
create mode 100644 server/glib-compat.h
diff --git a/server/Makefile.am b/server/Makefile.am
index 036abcd..dff1ad2 100644
These patches try to solve (or at least minimize) RHEL6
compatibilty issues.
Beside the last one other patches are small and
sensible and do not break defined rules.
Frediano Ziglio (9):
Include GLib compatibility header where needed
Avoid to typedef twice CursorChannel
Avoid to typedef twic
Hi,
On Mon, Oct 17, 2016 at 02:38:29PM +0200, Pavel Grunt wrote:
> Hey,
>
> On Sat, 2016-10-15 at 14:15 +0200, victort...@redhat.com wrote:
> > From: Victor Toso
> >
> > As manual states below, text could be NULL for different reasons and
> > we should handle that. I've included a debug message
Hey,
On Sat, 2016-10-15 at 14:15 +0200, victort...@redhat.com wrote:
> From: Victor Toso
>
> As manual states below, text could be NULL for different reasons and
> we should handle that. I've included a debug message to help
> identifying possible regressions from wayland's clipboard.
>
> This
On Thu, 1 Sep 2016, Christophe Fergeau wrote:
> On Thu, Aug 11, 2016 at 04:28:58PM +0200, Francois Gouget wrote:
> >
> > The following patch broke compilation of xf86-video-qxl:
> >
> > commit b41220b1441b8adea6db9a98e9da1b43a8f426bb
> > Author: Christophe Fergeau
> > Date: Thu Mar 5 15:28:22
Hi,
> > Not sure if I understand you correctly - but you should not modify
> > enums.h by yourself. As the first line of the file says, it should
> > be generated by spice_codegen.py (spice-common repository), eg:
> >
> > ./spice_codegen.py -e spice.proto ../spice-protocol/spice/enums.h
So, that
>
> From: Jonathon Jongsma
>
> Encapsulate MainChannel a bit better in preparation for proting to
> GObject.
> ---
> server/main-channel-client.c | 24 +++-
> server/main-channel.c| 15 +++
> server/main-channel.h| 2 ++
> 3 files changed, 28 ins
>
> I'm not sure that needed as it seems getpeername/getsockname
> accept int fd and return -1 for fd=-1
>
> Signed-off-by: Uri Lublin
> ---
> server/main-channel.c | 16 ++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/server/main-channel.c b/server/main-ch
>
> In both image_encoders_restore_glz_dictionary() and
> image_encoders_get_glz_dictionary() shared-dict may
> be NULL if size is too large, and the server gets
> size from the network.
>
> Both functions end up calling glz_enc_dictionary_create()
> that calls glz_dictionary_window_create() wher
>
> Hi Victor,
>
> On Sat, 2016-10-15 at 15:38 +0200, Victor Toso wrote:
> > Hi,
> >
> > On Thu, Sep 29, 2016 at 12:28:44PM +0100, Frediano Ziglio wrote:
> > > Small update for this patchset:
> > > - fix headers in "Extended protocol documentation";
> > > - added some more documentation on attri
>
> This patch prevents possible memory leak.
>
> Found by coverity.
>
> Signed-off-by: Uri Lublin
> ---
> server/red-parse-qxl.c | 11 +++
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/server/red-parse-qxl.c b/server/red-parse-qxl.c
> index d75e27e..4dcf4ee 10064
>
> Also replaced "continue" in while block with an empty
> block (added curly braces).
>
I think you split this in 7/8.
> Found by coverity.
>
> Signed-off-by: Uri Lublin
> ---
> server/red-record-qxl.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/server/r
>
> Spice coding style suggests to use curly braces
> for while blocks.
>
> Signed-off-by: Uri Lublin
> ---
> server/red-record-qxl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/red-record-qxl.c b/server/red-record-qxl.c
> index 8af2c9c..adc487b 100644
>
>
> Signed-off-by: Uri Lublin
> ---
> server/inputs-channel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/server/inputs-channel.c b/server/inputs-channel.c
> index 840d5e9..ee81bb4 100644
> --- a/server/inputs-channel.c
> +++ b/server/inputs-channel.c
> @@ -285,6 +285,7 @@ static i
> This patch prevents a leak in case the function returns early
>
> Found by coverity.
>
> Signed-off-by: Uri Lublin
> ---
> server/mjpeg-encoder.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/server/mjpeg-encoder.c b/server/mjpeg-encoder.c
> index 1649516..d95c64
>
> It shadows the outer one.
>
> Signed-off-by: Uri Lublin
> ---
>
> Possibly more meaningful names than container and container2
> should be used
>
> ---
> server/display-channel.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/server/display-channel.c b/ser
32 matches
Mail list logo
