Re: [Spice-devel] Very poor video performance using Virt Viewer compared to RDP

2016-10-15 Thread Victor Toso
Hi! On Fri, Oct 14, 2016 at 04:55:35PM +0200, Francois Gouget wrote: > On Thu, 13 Oct 2016, Frediano Ziglio wrote: > [...] > > I discovered where the main lag came quite by "accident". To test > > I used one small utility and this utility don't have a way to change > > parameters (like bandwidth)

Re: [Spice-devel] [PATCH v2 0/4] Protocol file syntax documentation

2016-10-15 Thread Victor Toso
Hi, On Thu, Sep 29, 2016 at 12:28:44PM +0100, Frediano Ziglio wrote: > Small update for this patchset: > - fix headers in "Extended protocol documentation"; > - added some more documentation on attributes. > > Frediano Ziglio (4): > Start adding protocol file documentation > Start writing some

Re: [Spice-devel] usbredirparser: fix EAGAIN error in *_do_write()

2016-10-15 Thread Victor Toso
Hi, On Sat, Oct 15, 2016 at 12:28:21PM +, Dmitriy Samborskiy wrote: > > From your description looks like the patch is reversed. > > Yes, it's reversed, sorry. > > > I'm not that familiar with usbredir code but looking at the code > > if usbredirparser_do_write returns 0 the server should just

Re: [Spice-devel] usbredirparser: fix EAGAIN error in *_do_write()

2016-10-15 Thread Dmitriy Samborskiy
> From your description looks like the patch is reversed. Yes, it's reversed, sorry. > I'm not that familiar with usbredir code but looking at the code > if usbredirparser_do_write returns 0 the server should just loop > again. You are right. I found this bug when I debugged the usbredir sources

[Spice-devel] [spice-gtk v2] clipboard: Fix crash by handling error

2016-10-15 Thread victortoso
From: Victor Toso As manual states below, text could be NULL for different reasons and we should handle that. I've included a debug message to help identifying possible regressions from wayland's clipboard. This crash is a regression from 7b0de6217670e0f668aff2949f "The text parameter to callb

Re: [Spice-devel] [spice-gtk v1] clipboard: Fix crash by handling error

2016-10-15 Thread Victor Toso
Hi, On Fri, Oct 14, 2016 at 05:32:25PM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > From: Victor Toso > > > > As manual states below, text could be NULL for different reasons and > > we should handle that. I've included a debug message to help > > identifying possible