Re: [Spice-devel] [PATCH 4/7] Add InputsChannelPrivate struct

2016-10-12 Thread Jonathon Jongsma
On Wed, 2016-10-12 at 06:55 -0400, Frediano Ziglio wrote: > > > > > > Prepare for GObject port > > Nacked > > > > > --- > >  server/inputs-channel.c | 68 > >  ++--- > >  1 file changed, 36 insertions(+), 32 deletions(-) > > > > diff --git a/server/i

Re: [Spice-devel] [PATCH spice-gtk v2 0/4]Add more tests for the session's uri

2016-10-12 Thread Marc-André Lureau
Hi - Original Message - > Hi, > > I plan to merge both uri parsers (one is in spice-session, one in spice-uri). > These patches add more to tests to avoid regressions. > > v2 per Victor review splits IPv6 tests and checks for expected warnings > v1: https://lists.freedesktop.org/archives

Re: [Spice-devel] [PATCH spice-gtk v2 0/4]Add more tests for the session's uri

2016-10-12 Thread Marc-André Lureau
- Original Message - > Hi > > - Original Message - > > Hi, > > > > I plan to merge both uri parsers (one is in spice-session, one in > > spice-uri). > > These patches add more to tests to avoid regressions. > > > > v2 per Victor review splits IPv6 tests and checks for expected

[Spice-devel] [PATCH spice-gtk v2 4/4] test-session: Add IPv6 tests

2016-10-12 Thread Pavel Grunt
--- tests/session.c | 157 +--- 1 file changed, 105 insertions(+), 52 deletions(-) diff --git a/tests/session.c b/tests/session.c index 494e92f..09856b3 100644 --- a/tests/session.c +++ b/tests/session.c @@ -1,5 +1,16 @@ #include +typedef st

[Spice-devel] [PATCH spice-gtk v2 1/4] test-session: Test alternative way for setting port

2016-10-12 Thread Pavel Grunt
Acked-by: Victor Toso --- tests/session.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/session.c b/tests/session.c index 00076f2..a6276c2 100644 --- a/tests/session.c +++ b/tests/session.c @@ -24,6 +24,12 @@ static void test_session_uri(void) { NULL, "5930",

[Spice-devel] [PATCH spice-gtk v2 2/4] test-session: Also test hostname, username and password

2016-10-12 Thread Pavel Grunt
--- tests/session.c | 45 + 1 file changed, 41 insertions(+), 4 deletions(-) diff --git a/tests/session.c b/tests/session.c index a6276c2..74d32f2 100644 --- a/tests/session.c +++ b/tests/session.c @@ -8,47 +8,81 @@ static void test_session_uri(void)

[Spice-devel] [PATCH spice-gtk v2 3/4] test-session: Test invalid URIs

2016-10-12 Thread Pavel Grunt
--- tests/session.c | 126 +++- 1 file changed, 124 insertions(+), 2 deletions(-) diff --git a/tests/session.c b/tests/session.c index 74d32f2..494e92f 100644 --- a/tests/session.c +++ b/tests/session.c @@ -1,6 +1,127 @@ #include -static voi

[Spice-devel] [PATCH spice-gtk v2 0/4]Add more tests for the session's uri

2016-10-12 Thread Pavel Grunt
Hi, I plan to merge both uri parsers (one is in spice-session, one in spice-uri). These patches add more to tests to avoid regressions. v2 per Victor review splits IPv6 tests and checks for expected warnings v1: https://lists.freedesktop.org/archives/spice-devel/2016-May/029261.html Thanks, Pav

Re: [Spice-devel] [PATCH 5/7] Don't increment num_clients_mig_wait twice

2016-10-12 Thread Pavel Grunt
On Wed, 2016-10-12 at 10:13 -0400, Frediano Ziglio wrote: > > > > On Wed, 2016-10-12 at 06:57 -0400, Frediano Ziglio wrote: > > > > > > > > > > > > When MainChannelClient was split to a separate file, the > > > > responsibility > > > > for incrementing this field was supposed to belong to the >

Re: [Spice-devel] [PATCH 5/7] Don't increment num_clients_mig_wait twice

2016-10-12 Thread Frediano Ziglio
> > On Wed, 2016-10-12 at 06:57 -0400, Frediano Ziglio wrote: > > > > > > > > > When MainChannelClient was split to a separate file, the > > > responsibility > > > for incrementing this field was supposed to belong to the > > > MainChannel > > > function (main_channel_connect_semi_seamless()), b

Re: [Spice-devel] [PATCH 5/7] Don't increment num_clients_mig_wait twice

2016-10-12 Thread Jonathon Jongsma
On Wed, 2016-10-12 at 06:57 -0400, Frediano Ziglio wrote: > > > > > > When MainChannelClient was split to a separate file, the > > responsibility > > for incrementing this field was supposed to belong to the > > MainChannel > > function (main_channel_connect_semi_seamless()), but by mistake it >

Re: [Spice-devel] [PATCH 5/7] Don't increment num_clients_mig_wait twice

2016-10-12 Thread Frediano Ziglio
> > When MainChannelClient was split to a separate file, the responsibility > for incrementing this field was supposed to belong to the MainChannel > function (main_channel_connect_semi_seamless()), but by mistake it was > incremented both there and in the client function > (main_channel_client_co

Re: [Spice-devel] [PATCH 4/7] Add InputsChannelPrivate struct

2016-10-12 Thread Frediano Ziglio
> > Prepare for GObject port Nacked > --- > server/inputs-channel.c | 68 > ++--- > 1 file changed, 36 insertions(+), 32 deletions(-) > > diff --git a/server/inputs-channel.c b/server/inputs-channel.c > index 85ca155..dfb7ba6 100644 > --- a/server/i

Re: [Spice-devel] [PATCH 2/7] Use macros for casting Channel types

2016-10-12 Thread Frediano Ziglio
> > In preparation for converting RedChannel to GObject, switch to using > RED_CHANNEL()-type macros for casting. For now they just do a regular > cast, but it helps reduce the size of the GObject patch to make it > easier to review. > --- > server/common-graphics-channel.c | 2 +- > server/curs

[Spice-devel] [PATCH spice-server] fixup! Move CommonGraphicsChannel to a new file

2016-10-12 Thread Frediano Ziglio
Do not include red-worker.h if not necessary. Signed-off-by: Frediano Ziglio --- server/common-graphics-channel.h | 2 +- server/cursor-channel.c | 1 + server/cursor-channel.h | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) Beside this small patch, which basically move

Re: [Spice-devel] [PATCH spice-server v2 7/8] Convert RedChannel heirarchy to GObject

2016-10-12 Thread Frediano Ziglio
> On Tue, 2016-10-11 at 09:55 -0400, Frediano Ziglio wrote: > > >  > > > > > diff --git a/server/cursor-channel.h b/server/cursor-channel.h > > > > > index a3ddaa3..8b3bc17 100644 > > > > > --- a/server/cursor-channel.h > > > > > +++ b/server/cursor-channel.h > > > > > @@ -19,6 +19,17 @@ > > > > >