On Mon, 2016-10-10 at 12:48 -0400, Frediano Ziglio wrote:
> >
> > Subject: [Spice-devel] [PATCH spice-server v2 7/8] Convert
> > RedChannel heirarchy to GObject
> >
>
> Small spell, it's "hierarchy".
>
> >
> > From: Jonathon Jongsma
> >
> > FIXME: this commit appears to introduce a vdagent-
On Mon, 2016-10-10 at 12:20 -0400, Frediano Ziglio wrote:
> >
> >
> > From: Jonathon Jongsma
> >
> > Encapsulate private data for CommonGraphicsChannel and prepare for
> > GObject conversion.
>
> This object has all the fields with accessors... not a really private
> I would say. Is not possib
Acked-by: Jonathon Jongsma
On Mon, 2016-10-10 at 19:27 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> docs/spice_style.txt | 9 -
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
> index 026a354..cd87
On Mon, 2016-10-10 at 14:11 -0400, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> >
> > Hi,
> >
> > On Mon, Oct 10, 2016 at 12:54:26PM -0400, Frediano Ziglio wrote:
> > >
> > > Hi,
> > > I noted that in recent patches we started using this style:
> > >
> > > static void
> >
Convert a couple of additional casts
---
One additional fixup on top of Frediano's with some additional cases mentioned
by Pavel
server/inputs-channel.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/server/inputs-channel.c b/server/inputs-channel.c
index 83c
Signed-off-by: Frediano Ziglio
---
docs/spice_style.txt | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index 026a354..cd874df 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@ -198,7 +198,14 @@ void function(ty
Hi
- Original Message -
> Hi,
>
> On Mon, Oct 10, 2016 at 12:54:26PM -0400, Frediano Ziglio wrote:
> > Hi,
> > I noted that in recent patches we started using this style:
> >
> > static void
> > function_name(type name)
> > {
> > }
> >
> > instead of the "classic" (in our code)
> >
>
Hi,
On Mon, Oct 10, 2016 at 12:54:26PM -0400, Frediano Ziglio wrote:
> Hi,
> I noted that in recent patches we started using this style:
>
> static void
> function_name(type name)
> {
> }
>
> instead of the "classic" (in our code)
>
> static void function_name(type name)
> {
> }
>
> Personal
Hi,
I noted that in recent patches we started using this style:
static void
function_name(type name)
{
}
instead of the "classic" (in our code)
static void function_name(type name)
{
}
Personally I like the first and I don't complain (and other people
seems to not complain too) however someti
> Subject: [Spice-devel] [PATCH spice-server v2 7/8] Convert RedChannel
> heirarchy to GObject
>
Small spell, it's "hierarchy".
> From: Jonathon Jongsma
>
> FIXME: this commit appears to introduce a vdagent-related crash in
> vdi_port_read_one_msg_from_device(). sin->st is NULL.
If this is s
>
> From: Jonathon Jongsma
>
> Encapsulate private data for CommonGraphicsChannel and prepare for
> GObject conversion.
This object has all the fields with accessors... not a really private
I would say. Is not possible to implement in a different way using
this structure in CursorChannelPrivate
Avoid lines with more than 100 characters
Signed-off-by: Frediano Ziglio
---
server/common-graphics-channel.c | 3 +-
server/common-graphics-channel.h | 15 +++--
server/cursor-channel.c | 3 +-
server/cursor-channel.h | 6 +-
server/display-channel.c | 3 +-
s
Avoid lines with more than 100 characters
Signed-off-by: Frediano Ziglio
---
server/dcc.c| 3 ++-
server/red-worker.c | 9 ++---
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/server/dcc.c b/server/dcc.c
index 021c241..3519d2e 100644
--- a/server/dcc.c
+++ b/server/dc
Use parenthesis to enclose macro parameters.
More CURSOR_CHANNEL to implementation, not used externally.
Signed-off-by: Frediano Ziglio
---
server/cursor-channel.c | 2 ++
server/cursor-channel.h | 1 -
server/display-channel.h | 2 +-
server/inputs-channel.h | 3 ++-
server/main-channel.h
Added some fixup:
- proposals from Pavel;
- split long line to follow our style.
Frediano Ziglio (3):
fixup! Use macros for casting Channel types
fixup! Add CommonGraphicsChannelPrivate struct
fixup! Convert RedChannel heirarchy to GObject
Jonathon Jongsma (4):
Move CommonGraphicsChannel
From: Jonathon Jongsma
In preparation for converting RedChannel to GObject, switch to using
RED_CHANNEL()-type macros for casting. For now they just do a regular
cast, but it helps reduce the size of the GObject patch to make it
easier to review.
---
server/common-graphics-channel.c | 2 +-
serv
From: Pavel Grunt
---
server/Makefile.am | 4 ++--
server/red-worker.c | 6 ++
server/red-worker.h | 1 -
3 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/server/Makefile.am b/server/Makefile.am
index 3382946..036abcd 100644
--- a/server/Makefile.am
+++ b/server/Makefile.am
@@
From: Jonathon Jongsma
Encapsulate private data for CommonGraphicsChannel and prepare for
GObject conversion.
---
server/common-graphics-channel.c | 34 --
server/common-graphics-channel.h | 14 ++
server/cursor-channel-client.c | 2 +-
server/curso
From: Jonathon Jongsma
Move out of red-worker.c. This requires a little bit of minor
refactoring to avoid accessing some RedWorker internals in the
constructor function, etc.
---
server/Makefile.am | 2 +
server/common-graphics-channel.c | 129
Hey,
On Mon, Oct 10, 2016 at 05:12:53PM +0200, Pavel Grunt wrote:
> On Mon, 2016-10-10 at 17:03 +0200, Christophe Fergeau wrote:
> > Hey,
> >
> > On Mon, Oct 10, 2016 at 04:09:11PM +0200, Pavel Grunt wrote:
> > > The configuration messages are sent only when agent is running.
> > >
> > > It is h
On Mon, 2016-10-10 at 17:03 +0200, Christophe Fergeau wrote:
> Hey,
>
> On Mon, Oct 10, 2016 at 04:09:11PM +0200, Pavel Grunt wrote:
> > The configuration messages are sent only when agent is running.
> >
> > It is happening all the time that the configuration message was
> > technically not succ
Hey,
On Mon, Oct 10, 2016 at 04:09:11PM +0200, Pavel Grunt wrote:
> The configuration messages are sent only when agent is running.
>
> It is happening all the time that the configuration message was
> technically not successful (linux guest supports only width of
> multiple of 8) and in fact it
Hi Marc-André,
On Mon, 2016-10-10 at 08:37 -0400, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> > When the guest receives the monitor configuration message, it
> > replies
> > (through spice-server) by destroying the primary surface, which
> > makes
> > the SpiceDisplay disable
Hi
- Original Message -
> Hi,
>
> On 10/10/2016 02:38 PM, Marc-André Lureau wrote:
> > Hi
> >
> > - Original Message -
> >> Hi,
> >>
> >> On 10/10/2016 11:49 AM, Marc-André Lureau wrote:
> >>> Hi
> >>>
> >>> - Original Message -
> Hi All,
>
> I noticed that
Hi,
On 10/10/2016 02:38 PM, Marc-André Lureau wrote:
Hi
- Original Message -
Hi,
On 10/10/2016 11:49 AM, Marc-André Lureau wrote:
Hi
- Original Message -
Hi All,
I noticed that there have been a few spice-gtk builds fixing
the bugs I was hitting, thank you for that.
I had
Hi
- Original Message -
> Hi,
>
> On 10/10/2016 11:49 AM, Marc-André Lureau wrote:
> > Hi
> >
> > - Original Message -
> >> Hi All,
> >>
> >> I noticed that there have been a few spice-gtk builds fixing
> >> the bugs I was hitting, thank you for that.
> >>
> >> I had to install th
Hi
- Original Message -
> When the guest receives the monitor configuration message, it replies
> (through spice-server) by destroying the primary surface, which makes
> the SpiceDisplay disabled if its "resize-guest" property is used.
> This change of the display state (disabled/enabled)
Hi,
On 10/10/2016 11:49 AM, Marc-André Lureau wrote:
Hi
- Original Message -
Hi All,
I noticed that there have been a few spice-gtk builds fixing
the bugs I was hitting, thank you for that.
I had to install them manually from koji, since they are
not yet listed in bodhi. Can you plea
When the guest receives the monitor configuration message, it replies
(through spice-server) by destroying the primary surface, which makes
the SpiceDisplay disabled if its "resize-guest" property is used.
This change of the display state (disabled/enabled) leads to sending
a new monitor config mes
THanks :) No problem. Just were asking :)
On Mon, Oct 10, 2016 at 1:55 PM, Pavel Grunt wrote:
> On Mon, 2016-10-10 at 13:14 +0200, Oliver Gutierrez wrote:
> > This patch has not been pushed yet. Is there any problem?
>
> Sorry for the delay Oliver
> It is pushed
> Pavel
>
>
> > On Wed, Oct 5, 20
On Mon, 2016-10-10 at 13:14 +0200, Oliver Gutierrez wrote:
> This patch has not been pushed yet. Is there any problem?
Sorry for the delay Oliver
It is pushed
Pavel
> On Wed, Oct 5, 2016 at 8:06 AM, Pavel Grunt
> wrote:
> > Hi Oliver,
> >
> > it looks good to me :)
> >
> > Acked-by: Pavel Gru
This patch has not been pushed yet. Is there any problem?
On Wed, Oct 5, 2016 at 8:06 AM, Pavel Grunt wrote:
> Hi Oliver,
>
> it looks good to me :)
>
> Acked-by: Pavel Grunt
>
> Thanks,
> Pavel
>
> On Mon, 2016-10-03 at 14:09 +0200, Oliver Gutierrez wrote:
> > ---
> > enums.js| 9 +++
Hi
- Original Message -
> Hi All,
>
> I noticed that there have been a few spice-gtk builds fixing
> the bugs I was hitting, thank you for that.
>
> I had to install them manually from koji, since they are
> not yet listed in bodhi. Can you please create bodhi
> updates for these ? :
>
On Fri, 2016-10-07 at 17:01 -0500, Jonathon Jongsma wrote:
> In preparation for converting RedChannel to GObject, switch to using
> RED_CHANNEL()-type macros for casting. For now they just do a
> regular
> cast, but it helps reduce the size of the GObject patch to make it
> easier to review.
I agre
Hi,
On Fri, 2016-10-07 at 17:01 -0500, Jonathon Jongsma wrote:
> Move out of red-worker.c. This requires a little bit of minor
> refactoring to avoid accessing some RedWorker internals in the
> constructor function, etc.
> ---
> server/Makefile.am | 2 +
> server/common-graphics-c
Hi All,
I noticed that there have been a few spice-gtk builds fixing
the bugs I was hitting, thank you for that.
I had to install them manually from koji, since they are
not yet listed in bodhi. Can you please create bodhi
updates for these ? :
https://bodhi.fedoraproject.org/updates/?packages
36 matches
Mail list logo
