Re: [Spice-devel] [PATCH] Basic SPICE port implementation

2016-10-04 Thread Pavel Grunt
Hi Oliver, it looks good to me :) Acked-by: Pavel Grunt Thanks, Pavel On Mon, 2016-10-03 at 14:09 +0200, Oliver Gutierrez wrote: > --- >  enums.js|  9 ++ >  main.js |  3 ++ >  port.js | 85 > + >  spice.html

Re: [Spice-devel] [spice-html5 stream 4/5] Setting src to null generates console log messages.

2016-10-04 Thread Pavel Grunt
Hi, maybe: "Use empty image instead of null to avoid warnings" On Wed, 2016-09-28 at 15:32 -0500, Jeremy White wrote: > Instead, let's set it to an empty gif.  Should have the > same benefit. > > Signed-off-by: Jeremy White Acked-by: Pavel Grunt > --- >  display.js | 2 +- >  utils.js   | 5 +++

Re: [Spice-devel] [PATCH spice-server v2 1/7] Split RedCharDeviceSmartcard and SmartCardChannelClient

2016-10-04 Thread Jonathon Jongsma
On Fri, 2016-09-30 at 14:21 +0100, Frediano Ziglio wrote: > --- >  server/Makefile.am|   2 + >  server/smartcard-channel-client.c | 300 > +++ >  server/smartcard-channel-client.h |  96 ++ >  server/smartcard.c| 360 ++--

Re: [Spice-devel] [PATCH xf86-video-qxl] Fix crash caused by attempting to access the screen pixmap before it is created

2016-10-04 Thread Christophe Fergeau
Hey Hans, On Tue, Oct 04, 2016 at 02:08:13PM +0200, Hans de Goede wrote: > qxl_resize_primary_to_virtual() was using pScrn->pScreen != NULL to check > if createScreenResources has been called. But starting with xserver 1.19 > pScrn->pScreen is non NULL even before createScreenResources is called,

[Spice-devel] [PATCH xf86-video-qxl] Fix crash caused by attempting to access the screen pixmap before it is created

2016-10-04 Thread Hans de Goede
qxl_resize_primary_to_virtual() was using pScrn->pScreen != NULL to check if createScreenResources has been called. But starting with xserver 1.19 pScrn->pScreen is non NULL even before createScreenResources is called, causing an invalid access to the screenPixmap in qxl_resize_primary_to_virtual()

Re: [Spice-devel] [PATCH xf86-video-qxl] Adjust xspice_wakeup_handler() prototype for building xspice with server 1.19

2016-10-04 Thread Hans de Goede
Hi, On 03-10-16 12:04, Christophe Fergeau wrote: On Thu, Sep 29, 2016 at 01:03:01PM +0200, Hans de Goede wrote: Signed-off-by: Hans de Goede --- src/spiceqxl_main_loop.c | 4 1 file changed, 4 insertions(+) diff --git a/src/spiceqxl_main_loop.c b/src/spiceqxl_main_loop.c index db89b6d

Re: [Spice-devel] [PATCH v2 0/4] Protocol file syntax documentation

2016-10-04 Thread Frediano Ziglio
> > On Fri, Sep 30, 2016 at 01:13:04PM +0200, Victor Toso wrote: > > On Fri, Sep 30, 2016 at 07:08:55AM -0400, Frediano Ziglio wrote: > > > Just to make it clear... do you mean spice-server repository? > > > > Yes. We already have the (old) docs there and I don't see a reason to > > move it to pr

Re: [Spice-devel] [PATCH qxl-wddm-dod 2/8] Mark all functions that should go to non paged sections

2016-10-04 Thread Frediano Ziglio
> > On Wed, Sep 28, 2016 at 10:29:48AM -0400, Frediano Ziglio wrote: > > > This is extremely dangerous!, this can be working without any errors most > > > of > > > the time but in a rare cases this could > > > cause a crash - in case a non pageable function made pageable by this > > > patch - > >

Re: [Spice-devel] [PATCH spice-server] fixup! Convert RedChannelClient hierarchy to GObject

2016-10-04 Thread Christophe Fergeau
On Tue, Oct 04, 2016 at 04:11:43AM -0400, Frediano Ziglio wrote: > > > > On Fri, Sep 30, 2016 at 02:57:14PM +0100, Frediano Ziglio wrote: > > > Split lines with more than 100 characters > > > > > diff --git a/server/main-channel-client.h b/server/main-channel-client.h > > > index f95ddef..360c61e

Re: [Spice-devel] [PATCH v3 2/8] replay: Handle errors reading strings from record file

2016-10-04 Thread Frediano Ziglio
> > On Tue, Sep 20, 2016 at 12:00:45PM -0400, Frediano Ziglio wrote: > > > > > > On Fri, 2016-09-16 at 12:32 +0100, Frediano Ziglio wrote: > > > > > > I like the idea, but I'm not a big fan of the implementation here. This > > > function makes two hard assumptions. It assumes that it is called w

Re: [Spice-devel] [PATCH spice-server] fixup! Convert RedChannelClient hierarchy to GObject

2016-10-04 Thread Frediano Ziglio
> > On Fri, Sep 30, 2016 at 02:57:14PM +0100, Frediano Ziglio wrote: > > Split lines with more than 100 characters > > > diff --git a/server/main-channel-client.h b/server/main-channel-client.h > > index f95ddef..360c61e 100644 > > --- a/server/main-channel-client.h > > +++ b/server/main-channel-