On Tue, Sep 20, 2016 at 12:00:45PM -0400, Frediano Ziglio wrote:
> >
> > On Fri, 2016-09-16 at 12:32 +0100, Frediano Ziglio wrote:
> >
> > I like the idea, but I'm not a big fan of the implementation here. This
> > function makes two hard assumptions. It assumes that it is called with
> > a forma
On Wed, Sep 28, 2016 at 10:29:48AM -0400, Frediano Ziglio wrote:
> > This is extremely dangerous!, this can be working without any errors most of
> > the time but in a rare cases this could
> > cause a crash - in case a non pageable function made pageable by this patch
> > -
> > which can be hard
On Wed, Sep 28, 2016 at 10:30:16AM -0500, Jonathon Jongsma wrote:
> Yes, I agree that it's strange, and I don't like it. But as part of the
> refactoring, I decided to keep the "dummy" channel client idea and just
> port it to a GObject style. I did not want to do a lot of intrusive re-
> designing
From: Victor Toso
With -Wall a few -Wunused-variable and -Wunused-but-set-variable;
With -Wextra lots of -Wunused-parameter and a few -Wsign-compare.
Signed-off-by: Victor Toso
---
tests/coroutine.c | 2 +-
tests/file-transfer.c | 27 +--
tests/mock-acl-helper.
Hi,
On Mon, Oct 03, 2016 at 09:29:34AM +0200, Pavel Grunt wrote:
> Hi,
>
> I get few more under tests directory, mostly -Wunused-parameter:
> https://paste.fedoraproject.org/442506/
Right! I build with -Wall by default but to catch those it is necessary
to include -Wextra as well! I'll send a fix
I've tested both this patch series and the video ones.
In Firefox works without any problems. In Chrome I have no audio at all,
but I do not have it also with master.
Cheers
On Mon, Oct 3, 2016 at 10:21 AM, Pavel Grunt wrote:
> Hi,
>
> looks good to me, ACK
>
> Pavel
>
> On Wed, 2016-09-28 at
OMG. THe patch attached to same thread. Now is Ok
On Mon, Oct 3, 2016 at 2:10 PM, Oliver Gutierrez
wrote:
> Forget this one. Missing one file.
>
> On Mon, Oct 3, 2016 at 2:02 PM, Oliver Gutierrez
> wrote:
>
>> ---
>> enums.js| 9 +
>> main.js | 3 +++
>> spice.html
Forget this one. Missing one file.
On Mon, Oct 3, 2016 at 2:02 PM, Oliver Gutierrez
wrote:
> ---
> enums.js| 9 +
> main.js | 3 +++
> spice.html | 13 +
> spice_auto.html | 13 +
> spicemsg.js | 18 ++
> utils.js
---
enums.js| 9 ++
main.js | 3 ++
port.js | 85 +
spice.html | 13 +
spice_auto.html | 13 +
spicemsg.js | 18
utils.js| 7 +
7 files changed, 148 insertions(+
---
enums.js| 9 +
main.js | 3 +++
spice.html | 13 +
spice_auto.html | 13 +
spicemsg.js | 18 ++
utils.js| 7 +++
6 files changed, 63 insertions(+)
diff --git a/enums.js b/enums.js
index 301fea0..b6e013c 10
On Thu, Sep 29, 2016 at 01:03:01PM +0200, Hans de Goede wrote:
> Signed-off-by: Hans de Goede
> ---
> src/spiceqxl_main_loop.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/spiceqxl_main_loop.c b/src/spiceqxl_main_loop.c
> index db89b6d..0ac1f3e 100644
> --- a/src/spiceqxl_m
On Fri, Sep 30, 2016 at 02:57:14PM +0100, Frediano Ziglio wrote:
> Split lines with more than 100 characters
> diff --git a/server/main-channel-client.h b/server/main-channel-client.h
> index f95ddef..360c61e 100644
> --- a/server/main-channel-client.h
> +++ b/server/main-channel-client.h
> @@ -21
Hey,
On Mon, Oct 03, 2016 at 08:45:35AM +0200, Hans de Goede wrote:
> Hi All,
>
> See: https://bugzilla.redhat.com/show_bug.cgi?id=1381045
>
> Also why is Alon still the maintainer of xorg-x11-drv-qxl in
> Fedora ? It would IMHO be better if the spice-team would
> maintain it.
He never orphane
On Fri, Sep 30, 2016 at 05:13:44PM +0200, Fabiano Fidêncio wrote:
> On Fri, Sep 30, 2016 at 1:48 PM, Victor Toso wrote:
> > Hi again!
> >
> > On Wed, Jun 22, 2016 at 04:48:39PM +0200, Victor Toso wrote:
> >> Hi all,
> >>
> >> I created a spice group in gitlab [0] mirroring the repository from
> >>
Hey,
On Fri, Sep 30, 2016 at 01:48:45PM +0200, Victor Toso wrote:
> So, I put this on hold for some time but it would be great to discuss
> this once more.
>
> Last week I started to play with continuous integration in gitlab [0]
> which can be very useful to track if given commit is breaking
> b
On Wed, 2016-09-28 at 15:32 -0500, Jeremy White wrote:
> Otherwise, we end up discarding stream data messages, and our decode
> can become corrupted, notably on Chrome.
>
> This way, we should not lose any messages while we are waiting for
> source buffer creation.
>
> Signed-off-by: Jeremy White
On Wed, 2016-09-28 at 15:32 -0500, Jeremy White wrote:
> Signed-off-by: Jeremy White
Acked-by: Pavel Grunt
> ---
> display.js | 9 ++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/display.js b/display.js
> index 9fc13c0..6c6b962 100644
> --- a/display.js
> +++ b/disp
On Wed, 2016-09-28 at 15:32 -0500, Jeremy White wrote:
> Signed-off-by: Jeremy White
Acked-by: Pavel Grunt
> ---
> spiceconn.js | 27 +--
> 1 file changed, 17 insertions(+), 10 deletions(-)
>
> diff --git a/spiceconn.js b/spiceconn.js
> index 9651b47..33e7388 100644
> --
On Wed, 2016-09-28 at 15:32 -0500, Jeremy White wrote:
> Signed-off-by: Jeremy White
Acked-by: Pavel Grunt
> ---
> display.js | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/display.js b/display.js
> index d9bdd9f..e26bff8 100644
> --- a/display.js
> +++ b/display.j
Why not,
Acked-by: Christophe Fergeau
On Fri, Sep 30, 2016 at 05:11:48PM +0200, victort...@redhat.com wrote:
> From: Victor Toso
>
> To follow test-spice-uri and test-file-transfer standard.
> ---
> tests/Makefile.am | 26 +-
> tests/usb-acl-helper.c | 2 +-
> 2
On Fri, Sep 30, 2016 at 01:13:04PM +0200, Victor Toso wrote:
> On Fri, Sep 30, 2016 at 07:08:55AM -0400, Frediano Ziglio wrote:
> > Just to make it clear... do you mean spice-server repository?
>
> Yes. We already have the (old) docs there and I don't see a reason to
> move it to protocol/common/w
Hi Pavel,
The Uint8Array is an event. i don't know if there are more events than port
opened or port closed. The value 0 is sent when the port device file is
opened in the VM side and the 1 is sent when in the VM side you close
device file, so I left it as is because I don't know if there are othe
Hi,
looks good to me, ACK
Pavel
On Wed, 2016-09-28 at 15:25 -0500, Jeremy White wrote:
> Firefox and Chrome have both drifted somewhat over the past
> few years, and audio playback is no longer as robust in spice-html5
> as it once was.
>
> Further, the MediaSource specification is a bit more s
Hi,
I get few more under tests directory, mostly -Wunused-parameter:
https://paste.fedoraproject.org/442506/
On Fri, 2016-09-30 at 17:11 +0200, victort...@redhat.com wrote:
> From: Victor Toso
>
> file-transfer.c: In function
> ‘transfer_on_init_async_cb_agent_cancel’:
> file-transfer.c:316:19:
24 matches
Mail list logo
