On Fri, Sep 30, 2016 at 1:48 PM, Victor Toso wrote:
> Hi again!
>
> On Wed, Jun 22, 2016 at 04:48:39PM +0200, Victor Toso wrote:
>> Hi all,
>>
>> I created a spice group in gitlab [0] mirroring the repository from
>> freedesktop which should be updated every hour.
>>
>> [0] https://gitlab.com/grou
From: Victor Toso
file-transfer.c: In function ‘transfer_on_init_async_cb_agent_cancel’:
file-transfer.c:316:19: warning: unused variable ‘cancellable’
[-Wunused-variable]
GCancellable *cancellable;
^~~
pipe.c: In function ‘test_pipe_readblock’:
pipe.c:91:12: warnin
From: Victor Toso
Hi,
First patch fixes a few harmless compiler warnings. I put it in a single
patch as I did not see a strong reason to split.
Second patch sets the test binaries to have 'test-' as prefix.
Make check result:
PASS: test-util
PASS: test-coroutine
PASS: test-session
PASS: test-s
From: Victor Toso
To follow test-spice-uri and test-file-transfer standard.
---
tests/Makefile.am | 26 +-
tests/usb-acl-helper.c | 2 +-
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 6d9cfeb..3a0188d 10
Split lines with more than 100 characters
Signed-off-by: Frediano Ziglio
---
server/cursor-channel-client.c| 6 --
server/cursor-channel-client.h| 15 ++-
server/dcc.c | 6 --
server/dcc.h | 15 ++-
server/dummy-
Remove old arrays if present.
Signed-off-by: Frediano Ziglio
---
server/red-channel-client.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/server/red-channel-client.c b/server/red-channel-client.c
index 5b209d8..546d58d 100644
--- a/server/red-channel-client.c
+++ b/server/red-channel-cl
Reduce diff.
Remove some style changes.
Use declarations instead of moving functions.
Signed-off-by: Frediano Ziglio
---
server/red-channel-client.c | 171 +++---
server/red-channel.h | 2 +-
server/reds.h | 1 -
server/s
Remove base from SmartCardChannelClientPrivate.
Public have already the base.
Signed-off-by: Frediano Ziglio
---
server/smartcard-channel-client.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/server/smartcard-channel-client.c
b/server/smartcard-channel-client.c
index afd0899..beda2fc 1006
Style changes.
New code should respect style.
Signed-off-by: Frediano Ziglio
---
server/smartcard-channel-client.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/server/smartcard-channel-client.c
b/server/smartcard-channel-client.c
index 76b8eed..afd0899 100644
--- a/
---
server/Makefile.am| 2 +
server/smartcard-channel-client.c | 300 +++
server/smartcard-channel-client.h | 96 ++
server/smartcard.c| 360 ++
server/smartcard.h| 21 +++
5
Initialise id field in DisplayChannelClient.
This line was removed.
Signed-off-by: Frediano Ziglio
---
server/dcc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/server/dcc.c b/server/dcc.c
index bb85861..08866c9 100644
--- a/server/dcc.c
+++ b/server/dcc.c
@@ -521,6 +521,7 @@ DisplayChann
Convert the RedChannelClient heirarchy into GObjects. Since the existing
constructors could fail and return NULL, I inherited the base channel
client from GInitable, which introduces a dependency on gio.
When using private structs with GObject, there's a maximum size of (I
think) 64k, which was ex
This patchset contains my split of the patches and some
proposed changes to the second big patch.
Frediano Ziglio (7):
Split RedCharDeviceSmartcard and SmartCardChannelClient
Convert RedChannelClient hierarchy to GObject
fixup! Convert RedChannelClient hierarchy to GObject
fixup! Convert R
Hi,
On Thu, Sep 29, 2016 at 09:46:04AM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
why not? :)
Acked-by: Victor Toso
> ---
> server/display-channel.c | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/server/display-channel.c b/server/disp
Hi again!
On Wed, Jun 22, 2016 at 04:48:39PM +0200, Victor Toso wrote:
> Hi all,
>
> I created a spice group in gitlab [0] mirroring the repository from
> freedesktop which should be updated every hour.
>
> [0] https://gitlab.com/groups/spice
https://gitlab.com/spice works too.
>
> But I would l
On Fri, 2016-09-30 at 07:02 -0400, Frediano Ziglio wrote:
> >
> > Hi Frediano!
> >
> > Thank you for looking into it
> >
> > imho it is confusing to document spice-protocol which is defined
> > in
> > spice-common in spice server git repository.
> >
> > ^ that sentence is strange
> >
>
>
> A
Hi,
On Fri, Sep 30, 2016 at 07:08:55AM -0400, Frediano Ziglio wrote:
> >
> > Hi,
> >
> > On Fri, Sep 30, 2016 at 08:44:53AM +0200, Pavel Grunt wrote:
> > > Hi Frediano!
> > >
> > > Thank you for looking into it
> > >
> > > imho it is confusing to document spice-protocol which is defined in
> > >
>
> Hi,
>
> On Fri, Sep 30, 2016 at 08:44:53AM +0200, Pavel Grunt wrote:
> > Hi Frediano!
> >
> > Thank you for looking into it
> >
> > imho it is confusing to document spice-protocol which is defined in
> > spice-common in spice server git repository.
> >
> > ^ that sentence is strange
> >
> > I
Hi,
On Fri, Sep 30, 2016 at 08:44:53AM +0200, Pavel Grunt wrote:
> Hi Frediano!
>
> Thank you for looking into it
>
> imho it is confusing to document spice-protocol which is defined in
> spice-common in spice server git repository.
>
> ^ that sentence is strange
>
> I know the documentation files
>
> Hi Frediano!
>
> Thank you for looking into it
>
> imho it is confusing to document spice-protocol which is defined in
> spice-common in spice server git repository.
>
> ^ that sentence is strange
>
All protocol files (spice.proto and python code) are in spice-common,
not in spice-protoco
Hi Oliver,
I tested it (in FF) and it works nicely, I just have minor comments:
in the console:
SPICE port com.spice.fc.1 event data: Uint8Array { 0=0}
SPICE port com.spice.fc.1 message text: CHILI
SPICE port com.spice.fc.1 event data: Uint8Array { 0=1}
1) what is the Uint8Array - it has just one
21 matches
Mail list logo
