Re: [Spice-devel] [NSIS] Add Display Version as a postfix to the Display Name.

2016-09-03 Thread Yedidyah Bar David
On Fri, Sep 2, 2016 at 9:23 AM, Christophe Fergeau wrote: > Hey, > > On Thu, Sep 01, 2016 at 05:43:36PM +0300, Yedidyah Bar David wrote: >> On Tue, Aug 30, 2016 at 7:26 PM, Christophe Fergeau >> wrote: >> > Hey, >> > >> > On Mon, Aug 29, 2016 at 03:47:44PM +0300, Yedidyah Bar David wrote: >> >>

Re: [Spice-devel] [spice-gtk v3 7/7] Sync only on focus change

2016-09-03 Thread Marc-André Lureau
Hi - Original Message - > > > > Hi > > > > - Original Message - > > > Limit the virtual keystrokes sent to the remote machine. > > > The modifiers are synced only when the application receive or lose > > > the focus. This reduce a lot the possible virtual keystrokes sent > > > to

Re: [Spice-devel] [spice-gtk v3 7/7] Sync only on focus change

2016-09-03 Thread Frediano Ziglio
> > Hi > > - Original Message - > > Limit the virtual keystrokes sent to the remote machine. > > The modifiers are synced only when the application receive or lose > > the focus. This reduce a lot the possible virtual keystrokes sent > > to the guest to synchronize the modifiers. > > This

Re: [Spice-devel] [spice-gtk v3 7/7] Sync only on focus change

2016-09-03 Thread Marc-André Lureau
Hi - Original Message - > Limit the virtual keystrokes sent to the remote machine. > The modifiers are synced only when the application receive or lose > the focus. This reduce a lot the possible virtual keystrokes sent > to the guest to synchronize the modifiers. > This affect the situati

[Spice-devel] [spice-gtk v3 0/7] Modifiers handling change

2016-09-03 Thread Frediano Ziglio
This patchset change the way modifiers are handled. The most important patch is the last which do syncronization when window is focused or unfocused following user interaction. This reduces spurious key insertion. Changes since v2: - added rationale to "Add set_keyboard_lock_modifiers" (Marc-André

[Spice-devel] [spice-gtk v3 5/7] Implements set_keyboard_lock_modifiers for Windows

2016-09-03 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- src/spice-gtk-keyboard.c | 408 +++ src/spice-gtk-keyboard.h | 8 + tests/Makefile.am| 8 + tests/keyboard-test.c| 98 4 files changed, 522 insertions(+) create mode 100644 tests/keyboard

[Spice-devel] [spice-gtk v3 1/7] Move code to handle modifier in a specific file

2016-09-03 Thread Frediano Ziglio
Allows to extend it in the future. This code is OS dependent and is not a good idea to keep with SpiceGtkSession. Signed-off-by: Frediano Ziglio --- src/Makefile.am | 2 ++ src/spice-gtk-keyboard.c | 91 src/spice-gtk-keyboard.h | 34 +++

[Spice-devel] [spice-gtk v3 6/7] Add can_set_keyboard_lock_modifiers function

2016-09-03 Thread Frediano Ziglio
Allows to understand if we can set client modifiers Signed-off-by: Frediano Ziglio --- src/spice-gtk-keyboard.c | 13 + src/spice-gtk-keyboard.h | 2 ++ 2 files changed, 15 insertions(+) diff --git a/src/spice-gtk-keyboard.c b/src/spice-gtk-keyboard.c index b0f6b86..22d9f60 100644

[Spice-devel] [spice-gtk v3 4/7] Add os_is_64bit utility function

2016-09-03 Thread Frediano Ziglio
Allow to know if the system is 64 bit or not. Signed-off-by: Frediano Ziglio --- src/spice-util-priv.h | 3 +++ src/spice-util.c | 42 ++ 2 files changed, 45 insertions(+) diff --git a/src/spice-util-priv.h b/src/spice-util-priv.h index 38b0deb..790

[Spice-devel] [spice-gtk v3 3/7] Avoid too much #ifdef inside set_keyboard_lock_modifiers functions

2016-09-03 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- src/spice-gtk-keyboard.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/spice-gtk-keyboard.c b/src/spice-gtk-keyboard.c index af9c81e..6db53b4 100644 --- a/src/spice-gtk-keyboard.c +++ b/src/spice-gtk-keyboard.c @@ -140,11 +140,

[Spice-devel] [spice-gtk v3 7/7] Sync only on focus change

2016-09-03 Thread Frediano Ziglio
Limit the virtual keystrokes sent to the remote machine. The modifiers are synced only when the application receive or lose the focus. This reduce a lot the possible virtual keystrokes sent to the guest to synchronize the modifiers. This affect the situations where modifiers are configured differen

[Spice-devel] [spice-gtk v3 2/7] Add set_keyboard_lock_modifiers

2016-09-03 Thread Frediano Ziglio
Code from commit 063c1b9c0627c87eb7f5369c4a6b9776a22e5c7d. This code will be used to set local key modifiers allowing syncronization from guest to client. Signed-off-by: Frediano Ziglio --- src/spice-gtk-keyboard.c | 73 src/spice-gtk-keyboard.h |

Re: [Spice-devel] [spice-gtk 9/9] Sync only on focus change

2016-09-03 Thread Frediano Ziglio
Finally found some time to work on this patchset. > > Hi > > On Wed, Jun 8, 2016 at 1:10 PM, Frediano Ziglio wrote: > > Limit the virtual keystrokes sent to the remote machine. > > The modifiers are synced only when the application receive or lose > > the focus. This reduce a lot the possible v

Re: [Spice-devel] [PATCH 1/6] [spice-proto] Add support to ssh channel

2016-09-03 Thread Fabiano Fidêncio
On Sat, Sep 3, 2016 at 2:29 PM, Fabiano Fidêncio wrote: > On Sat, Sep 3, 2016 at 2:02 PM, Victor Toso wrote: >> Hi, >> >> On Sat, Sep 03, 2016 at 01:49:07PM +0200, Fabiano Fidêncio wrote: >>> --- >> >> Could you please include some documentation about the protocol in the >> commit log? Check webd

Re: [Spice-devel] [PATCH 1/6] [spice-proto] Add support to ssh channel

2016-09-03 Thread Fabiano Fidêncio
On Sat, Sep 3, 2016 at 2:02 PM, Victor Toso wrote: > Hi, > > On Sat, Sep 03, 2016 at 01:49:07PM +0200, Fabiano Fidêncio wrote: >> --- > > Could you please include some documentation about the protocol in the > commit log? Check webdav ~ 6e5ea8d802ac8 or port ~ f188fb7a89086 Okay, I'll send a v2 a

Re: [Spice-devel] [PATCH 1/6] [spice-proto] Add support to ssh channel

2016-09-03 Thread Victor Toso
Hi, On Sat, Sep 03, 2016 at 01:49:07PM +0200, Fabiano Fidêncio wrote: > --- Could you please include some documentation about the protocol in the commit log? Check webdav ~ 6e5ea8d802ac8 or port ~ f188fb7a89086 toso > spice.proto | 4 > 1 file changed, 4 insertions(+) > > diff --git a/

[Spice-devel] [PATCH 4/6] [spice] Associate org.spice-space.ssh.0 port to a ssh channel

2016-09-03 Thread Fabiano Fidêncio
For example, with qemu, a ssh channel can be created this way: -chardev spiceport,name=org.spice-space.ssh.0,... And redirected to a virtio port: -device virserialport,...,name=org.spice-space.ssh.0 Signed-off-by: Fabiano Fidêncio --- server/reds.c | 3 +++ 1 file changed, 3 insertions(+) dif

[Spice-devel] [PATCH 3/6] [spice] spice-common submodule update

2016-09-03 Thread Fabiano Fidêncio
The update is needed in order to introduce support to the brand new SSH_SPICE_CHANNEL. Signed-off-by: Fabiano Fidêncio --- spice-common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-common b/spice-common index 38047fb..a6e090d 16 --- a/spice-common +++ b/spice-com

[Spice-devel] [PATCH 5/6] [spice-gtk] spice-common submodule update

2016-09-03 Thread Fabiano Fidêncio
The update is needed in order to introduce support to the brand new SSH_SPICE_CHANNEL. Signed-off-by: Fabiano Fidêncio --- spice-common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-common b/spice-common index 62f3024..a6e090d 16 --- a/spice-common +++ b/spice-com

[Spice-devel] [PATCH 2/6] [spice-common] Add support to ssh channel

2016-09-03 Thread Fabiano Fidêncio
--- spice/enums.h | 1 + 1 file changed, 1 insertion(+) diff --git a/spice/enums.h b/spice/enums.h index 1d0c2db..1d61daf 100644 --- a/spice/enums.h +++ b/spice/enums.h @@ -422,6 +422,7 @@ enum { SPICE_CHANNEL_USBREDIR, SPICE_CHANNEL_PORT, SPICE_CHANNEL_WEBDAV, +SPICE_CHANNEL_S

[Spice-devel] [RFC] Adding support to ssh-agent-forward

2016-09-03 Thread Fabiano Fidêncio
Howdy! Here is a small patch series adding support to ssh-agent-forward. This patch series have been tested using a usable (but not 100% working) spice-ssh-agent[0]. The spice-related part seems to be working fine. There are still a few improvements to be done on spice-ssh-agent[0[, but that shou

[Spice-devel] [PATCH 1/6] [spice-proto] Add support to ssh channel

2016-09-03 Thread Fabiano Fidêncio
--- spice.proto | 4 1 file changed, 4 insertions(+) diff --git a/spice.proto b/spice.proto index 0bfc515..eb99742 100644 --- a/spice.proto +++ b/spice.proto @@ -1423,6 +1423,9 @@ channel PortChannel : SpicevmcChannel { channel WebDAVChannel : PortChannel { }; +channel SshChannel : PortC

[Spice-devel] [PATCH 6/6] [spice-gtk] Add channel-ssh

2016-09-03 Thread Fabiano Fidêncio
The brand new channel-ssh has been created in order to do the communication between the guest and the client's ssh agent. With the new agent and a little bit of configuration on the guest we are able to forward the ssh-agent through a spice channel. The configuration needed on the guest side (part