[Spice-devel] [PATCH spice-gtk] Translate file transfer error messages

2016-08-31 Thread Jonathon Jongsma
If we are to ever display error messages to a user in a UI, they need to be translated. --- po/POTFILES.in | 1 + src/channel-main.c | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/po/POTFILES.in b/po/POTFILES.in index ad12609..db42281 100644 --- a/po/POTFILES.in +++

Re: [Spice-devel] [PATCH spice-gtk v2] Add ability to get sizes from SpiceFileTransferTask

2016-08-31 Thread Jonathon Jongsma
On Wed, 2016-08-31 at 21:10 +0200, Victor Toso wrote: > Hi, > > On Wed, Aug 31, 2016 at 12:16:50PM -0500, Jonathon Jongsma wrote: > > > > If a client is handling multiple SpiceFileTransferTasks at one > > time, > > it's not currently possible to provide a single overall progress to > > the > > us

Re: [Spice-devel] [PATCH 01/10] Use cursor_item_ref()

2016-08-31 Thread Victor Toso
Hi, On Wed, Aug 31, 2016 at 11:54:37AM -0500, Jonathon Jongsma wrote: > Use the existing function rather than incrementing the ref directly. > --- > server/cursor-channel.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/server/cursor-channel.c b/server/cursor-channel.

Re: [Spice-devel] [PATCH spice-gtk v2] Add ability to get sizes from SpiceFileTransferTask

2016-08-31 Thread Victor Toso
Hi, On Wed, Aug 31, 2016 at 12:16:50PM -0500, Jonathon Jongsma wrote: > If a client is handling multiple SpiceFileTransferTasks at one time, > it's not currently possible to provide a single overall progress to the > user. The only information that the client can get is the percentage > progress.

[Spice-devel] [PATCH spice-gtk v2] Add ability to get sizes from SpiceFileTransferTask

2016-08-31 Thread Jonathon Jongsma
If a client is handling multiple SpiceFileTransferTasks at one time, it's not currently possible to provide a single overall progress to the user. The only information that the client can get is the percentage progress. This patch adds two new properties: - total-bytes: the size of the file transf

[Spice-devel] [PATCH 03/10] Move CursorChannelClient to separate file

2016-08-31 Thread Jonathon Jongsma
--- server/Makefile.am | 2 + server/cursor-channel-client.c | 118 + server/cursor-channel-client.h | 50 + server/cursor-channel.c| 96 - server/cursor-channel.h| 12 + se

[Spice-devel] [PATCH 08/10] Add RedChannelClientPrivate struct

2016-08-31 Thread Jonathon Jongsma
Encapsulate private data and prepare for port to GObject --- server/Makefile.am | 1 + server/cursor-channel.c | 3 +- server/dcc-send.c | 12 +- server/dcc.c| 7 +- server/red-channel-client-private.h | 77 + serve

[Spice-devel] [PATCH 07/10] Add MainChannelClientPrivate struct

2016-08-31 Thread Jonathon Jongsma
Encapsulate private data and prepare for port to GObject --- server/main-channel-client.c | 141 +++ 1 file changed, 74 insertions(+), 67 deletions(-) diff --git a/server/main-channel-client.c b/server/main-channel-client.c index bd339d0..d6e7fe4 100644 ---

[Spice-devel] [PATCH 10/10] Rename RCC_TO_DCC() to DISPLAY_CHANNEL_CLIENT()

2016-08-31 Thread Jonathon Jongsma
Prepare for port to GObject --- server/dcc-send.c| 86 server/dcc.c | 6 ++-- server/dcc.h | 2 +- server/display-channel.c | 4 +-- 4 files changed, 49 insertions(+), 49 deletions(-) diff --git a/server/dcc-send.

[Spice-devel] [PATCH 06/10] Add InputsChannelClientPrivate struct

2016-08-31 Thread Jonathon Jongsma
Encapsulate private data and prepare for port to GObject. --- server/inputs-channel-client.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/server/inputs-channel-client.c b/server/inputs-channel-client.c index ce21b9c..a6a77d2 100644 --- a/server/

[Spice-devel] [PATCH 04/10] Generate GTypes for spice-server enums

2016-08-31 Thread Jonathon Jongsma
--- server/Makefile.am | 31 +++ 1 file changed, 31 insertions(+) diff --git a/server/Makefile.am b/server/Makefile.am index 968829a..771b33f 100644 --- a/server/Makefile.am +++ b/server/Makefile.am @@ -68,6 +68,8 @@ libspice_serverinclude_HEADERS = \

[Spice-devel] [PATCH 05/10] Add SmartCardChannelClientPrivate struct

2016-08-31 Thread Jonathon Jongsma
Prepare to port to GObject by encapsulating all private data --- server/smartcard.c | 87 +- 1 file changed, 47 insertions(+), 40 deletions(-) diff --git a/server/smartcard.c b/server/smartcard.c index 74c2b18..8d22be4 100644 --- a/server/smartc

[Spice-devel] [PATCH 09/10] Add DisplayChannelClientPrivate and CursorChannelPrivate structs

2016-08-31 Thread Jonathon Jongsma
These need to be introduced at the same time since cache-item.tmpl.c assumes that both of these classes will have a cache in the same place: either within the channel client struct itself or (now) within a priv struct owned by the channel client. This encapsulates private data and prepares for por

[Spice-devel] [PATCH 00/10] Backported patches for spice-server refactory (Aug 31)

2016-08-31 Thread Jonathon Jongsma
This is the final series of patches before we start the GObject conversion of RedChannel/RedChannelClient/etc. The patch series factored out some changes that were unrelated to splitting up the files, so I hope these are a bit easier to review. Jonathon Jongsma (10): Use cursor_item_ref() Move

[Spice-devel] [PATCH 01/10] Use cursor_item_ref()

2016-08-31 Thread Jonathon Jongsma
Use the existing function rather than incrementing the ref directly. --- server/cursor-channel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/server/cursor-channel.c b/server/cursor-channel.c index 1e753c7..cb3aa49 100644 --- a/server/cursor-channel.c +++ b/server/cursor-c

Re: [Spice-devel] Fwd: Question from a chinese programmer

2016-08-31 Thread Christophe Fergeau
Hey, On Fri, Aug 26, 2016 at 07:57:16AM +0800, Kop Yiddish wrote: > -- 转发的邮件 -- > 发件人:"Kop Yiddish" > 日期:2016年8月25日 21:20 > 主题:Question from a chinese programmer > 收件人: > 抄送: > > hi, sir, > How are you? > I'm a programmer from china ,i have some questions about your patchwork in

Re: [Spice-devel] unclear main-channel documentation

2016-08-31 Thread Christophe Fergeau
Hey, On Thu, Aug 18, 2016 at 10:49:51PM +0300, Alex Roithman wrote: > Documentation is still not clear. It is impossible to understand how to > call the guest request to get the data selection from client clipboard. > > About: spice-client-glib, 'main-clipboard-selection-request' signal. In > whi

[Spice-devel] [spice-gtk v2 2/2] clipboard: Use gtk_clipboard_request_text for text data

2016-08-31 Thread Christophe Fergeau
Currently, when the agent asks us for VD_AGENT_CLIPBOARD_UTF8_TEXT data, spice-gtk looks up for the first X11 target which would provide it with UTF8_TEXT data, and uses that for the clipboard request. This means we will use UTF8_STRING as the target for gtk_clipboard_request_contents(). However,

[Spice-devel] [spice-gtk v2 1/2] clipboard: Add fixup_clipboard_text helper

2016-08-31 Thread Christophe Fergeau
This makes clipboard_received_cb a bit shorter, and will be useful in the next commit. --- src/spice-gtk-session.c | 69 +++-- 1 file changed, 44 insertions(+), 25 deletions(-) diff --git a/src/spice-gtk-session.c b/src/spice-gtk-session.c index 6cdae87

Re: [Spice-devel] DisplayChannel, Stream and StreamAgent redefinitions

2016-08-31 Thread Francois Gouget
On Tue, 30 Aug 2016, Christophe Fergeau wrote: > Hey, > > For what it's worth, these 2 attached patches allow to compile on el6 > (at least few weeks ago, did not try again just now). I have a set of similar patches on my GitHub extras-centos branch. https://github.com/fgouget/spice/tree/extras-

Re: [Spice-devel] [spice-gtk 1/2] clipboard: Add fixup_clipboard_text helper

2016-08-31 Thread Pavel Grunt
On Wed, 2016-08-31 at 10:52 +0200, Christophe Fergeau wrote: > On Mon, Aug 15, 2016 at 12:37:51PM +0200, Pavel Grunt wrote: > > > Hi Christophe, > > > > On Wed, 2016-08-10 at 12:26 +0200, Christophe Fergeau wrote: > > > > > This makes clipboard_received_cb a bit shorter, and will be useful > > >

Re: [Spice-devel] [spice-gtk 1/2] clipboard: Add fixup_clipboard_text helper

2016-08-31 Thread Christophe Fergeau
On Mon, Aug 15, 2016 at 12:37:51PM +0200, Pavel Grunt wrote: > Hi Christophe, > > On Wed, 2016-08-10 at 12:26 +0200, Christophe Fergeau wrote: > > This makes clipboard_received_cb a bit shorter, and will be useful > > in the next commit. > > --- > >  src/spice-gtk-session.c | 63 > > +

Re: [Spice-devel] [spice-gtk 2/2] clipboard: Use gtk_clipboard_request_text for text data

2016-08-31 Thread Christophe Fergeau
On Mon, Aug 15, 2016 at 12:56:44PM +0200, Pavel Grunt wrote: > Hi, > > On Wed, 2016-08-10 at 12:26 +0200, Christophe Fergeau wrote: > > Currently, when the agent asks us for VD_AGENT_CLIPBOARD_UTF8_TEXT data, > > spice-gtk looks up for the first X11 target which would provide it with > > UTF8_TEXT