Re: [Spice-devel] [spice-gtk v2] Initialise gettext library properly

2016-08-18 Thread Marc-André Lureau
Hi - Original Message - > This will allow internationalisation to work correctly. > > Signed-off-by: Frediano Ziglio > --- > src/Makefile.am | 3 +++ > src/channel-usbredir.c| 2 +- > src/desktop-integration.c | 2 +- > src/spice-channel.c | 2 +- > src/spice-cmd

[Spice-devel] unclear main-channel documentation

2016-08-18 Thread Alex Roithman
Documentation is still not clear. It is impossible to understand how to call the guest request to get the data selection from client clipboard. About: spice-client-glib, 'main-clipboard-selection-request' signal. In which cases this signal can be emitted?.. How to use the spice-client-glib for gue

Re: [Spice-devel] [PATCH 01/11] Move RedChannelClient to separate file

2016-08-18 Thread Jonathon Jongsma
On Fri, 2016-08-12 at 03:55 -0400, Frediano Ziglio wrote: > > > > > > Reduce direct access to RedChannelClient, and get ready to convert > > to > > GObject. > > This patch should be mechanical but I'm having some problems > reviewing. > I have to do some magic about new files, the diff is terrib

Re: [Spice-devel] [PATCH qxl-wddm-dod 07/26] Do not use virtual functions for code that must not be paged

2016-08-18 Thread Frediano Ziglio
> > > > From: Sandy Stutsman > > > > There is no way to guarantee that the static vtable will be in > > non-pageable memory. This patch converts 3 virtual non-pageble functions > > to functions private to each device class, the parent class will make > > an explicit call (based on a new device

Re: [Spice-devel] DisplayChannel, Stream and StreamAgent redefinitions

2016-08-18 Thread Frediano Ziglio
> > The commit below causes compilation errors on RHEL 6.8 :-( > (gcc 4.4.7) > > CC red-worker.lo > In file included from display-channel.h:43, > from red-worker.c:47: > stream.h:46: error: redefinition of typedef 'DisplayChannel' > dcc.h:44: note: previous declaration of '

[Spice-devel] [client v3 1/2] streaming: Send a special stream report to signal streaming errors

2016-08-18 Thread Francois Gouget
Servers that recognize this special report then stop streaming (sending regular screen updates instead) while older ones essentially ignore it. Signed-off-by: Francois Gouget --- Changes from v2: * Keep taking a SpiceDisplayChannel* in display_update_stream_report(). * Fix the caps check. sr

[Spice-devel] [spice v3 2/2] streaming: Stop streaming if the client reports a streaming error

2016-08-18 Thread Francois Gouget
Signed-off-by: Francois Gouget --- server/dcc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/server/dcc.c b/server/dcc.c index d387e8b..ddc23e2 100644 --- a/server/dcc.c +++ b/server/dcc.c @@ -930,6 +930,15 @@ static int dcc_handle_stream_report(DisplayChannelClient *dcc,

[Spice-devel] DisplayChannel, Stream and StreamAgent redefinitions

2016-08-18 Thread Francois Gouget
The commit below causes compilation errors on RHEL 6.8 :-( (gcc 4.4.7) CC red-worker.lo In file included from display-channel.h:43, from red-worker.c:47: stream.h:46: error: redefinition of typedef 'DisplayChannel' dcc.h:44: note: previous declaration of 'DisplayChannel' wa

Re: [Spice-devel] [client v2 1/3] streaming: Modify display_update_stream_report() to take a SpiceChannel

2016-08-18 Thread Frediano Ziglio
> > On Thu, 18 Aug 2016, Frediano Ziglio wrote: > > > > > > > This makes it consistent with the other channel-display functions. > > > > > > Signed-off-by: Francois Gouget > > > --- > > > > > > This patch makes sense on its own and can be applied even if the > > > other two in the series are

Re: [Spice-devel] [client v2 1/3] streaming: Modify display_update_stream_report() to take a SpiceChannel

2016-08-18 Thread Francois Gouget
On Thu, 18 Aug 2016, Frediano Ziglio wrote: > > > > This makes it consistent with the other channel-display functions. > > > > Signed-off-by: Francois Gouget > > --- > > > > This patch makes sense on its own and can be applied even if the > > other two in the series are not. > > > > > > I p

Re: [Spice-devel] [client v2 2/3] streaming: Send a special stream report to signal streaming errors

2016-08-18 Thread Victor Toso
Hi, I plan to give closer look soon, just one note below On Thu, Aug 18, 2016 at 05:57:58PM +0200, Francois Gouget wrote: > Servers that recognize this special report then stop streaming (sending > regular screen updates instead) while older ones essentially ignore it. > > Signed-off-by: Francoi

[Spice-devel] [spice] streaming: Always delegate bit rate control to the video encoder

2016-08-18 Thread Francois Gouget
The video encoders already have sophisticated bit rate control code that can react to both stream reports sent by the client, and server frame drop notifications. Furthermore they can adjust both the frame rate and the image quality to best match the network conditions. But if the client cannot se

Re: [Spice-devel] [client v2 1/3] streaming: Modify display_update_stream_report() to take a SpiceChannel

2016-08-18 Thread Frediano Ziglio
> > This makes it consistent with the other channel-display functions. > > Signed-off-by: Francois Gouget > --- > > This patch makes sense on its own and can be applied even if the > other two in the series are not. > > I prefer the actual version. Frediano > src/channel-display.c | 12 ++

[Spice-devel] [client v2 1/3] streaming: Modify display_update_stream_report() to take a SpiceChannel

2016-08-18 Thread Francois Gouget
This makes it consistent with the other channel-display functions. Signed-off-by: Francois Gouget --- This patch makes sense on its own and can be applied even if the other two in the series are not. src/channel-display.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) di

[Spice-devel] [spice v2 3/3] streaming: Stop streaming if the client reports a streaming error

2016-08-18 Thread Francois Gouget
Signed-off-by: Francois Gouget --- server/dcc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/server/dcc.c b/server/dcc.c index d387e8b..ddc23e2 100644 --- a/server/dcc.c +++ b/server/dcc.c @@ -930,6 +930,15 @@ static int dcc_handle_stream_report(DisplayChannelClient *dcc,

[Spice-devel] [client v2 2/3] streaming: Send a special stream report to signal streaming errors

2016-08-18 Thread Francois Gouget
Servers that recognize this special report then stop streaming (sending regular screen updates instead) while older ones essentially ignore it. Signed-off-by: Francois Gouget --- This round sends the error report as soon as the stream is created, and whenever a message with an invalid stream id

Re: [Spice-devel] [PATCH v10] Implementing WDDM interface to support multiple monitors and arbitrary resolution

2016-08-18 Thread Frediano Ziglio
> > The Direct3D 9 API operates on either the Windows XP display driver > model (XPDM) or the Windows Vista display driver model (WDDM), depending > on the operating system installed. > > This patch implements the WDDM interface while using the CCD API to do > so. Moreover it introduces multiple

[Spice-devel] [spice-gtk v2] Initialise gettext library properly

2016-08-18 Thread Frediano Ziglio
This will allow internationalisation to work correctly. Signed-off-by: Frediano Ziglio --- src/Makefile.am | 3 +++ src/channel-usbredir.c| 2 +- src/desktop-integration.c | 2 +- src/spice-channel.c | 2 +- src/spice-cmdline.c | 2 +- src/spice-glib-main.c | 5

Re: [Spice-devel] [PATCH] Add missing libX11 reference to build system

2016-08-18 Thread Ian Stakenvicius
On 18/08/16 10:14 AM, Ian Stakenvicius wrote: > On 18/08/16 04:15 AM, Marc-André Lureau wrote: >> Hi >> >> - Original Message - >>> GTK on its own is not enough to ensure libX11 is properly linked with >>> libspice-client-gtk. This patch adds X11_LIBS to SPICE_GTK_LIBADD_COMMON >>> (and X1

Re: [Spice-devel] [protocol 0/3] Fixing the *_DEPRECATED set of macros

2016-08-18 Thread Francois Gouget
On Thu, 11 Aug 2016, Francois Gouget wrote: [...] > So here is the proposed solution: > > * spice-protocol's SPICE_DEPRECATED is in a public header so keep it as > is. Extend it to mean the user wants to use deprecated APIs. This > includes: > - Defining deprecated APIs and macros (as befo

Re: [Spice-devel] [PATCH] Add missing libX11 reference to build system

2016-08-18 Thread Ian Stakenvicius
On 18/08/16 04:15 AM, Marc-André Lureau wrote: > Hi > > - Original Message - >> GTK on its own is not enough to ensure libX11 is properly linked with >> libspice-client-gtk. This patch adds X11_LIBS to SPICE_GTK_LIBADD_COMMON >> (and X11_CFLAGS to a relevant section as well) in src/Makefi

[Spice-devel] [PATCH spice-gtk] build-sys: require recent pkg-config

2016-08-18 Thread marcandre . lureau
From: Marc-André Lureau So we can drop the AC_SUBST for _CFLAGS & _LIBS variable (since 0.24 but there is no clean way to check that before PKG_PREREQ in 0.29, released last year) Signed-off-by: Marc-André Lureau --- configure.ac | 24 1 file changed, 4 insertions(+),

Re: [Spice-devel] [PATCH] Add missing libX11 reference to build system

2016-08-18 Thread Marc-André Lureau
Hi - Original Message - > GTK on its own is not enough to ensure libX11 is properly linked with > libspice-client-gtk. This patch adds X11_LIBS to SPICE_GTK_LIBADD_COMMON > (and X11_CFLAGS to a relevant section as well) in src/Makefile.am, and > performs an approriate pkg-config based che