On Wed, 2016-07-27 at 12:29 -0400, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> >
> >
> > By the way, this egl initialization in the realize handler is
> > actually
> > breaking spice-gtk with newer gtk+ (specifically gtk+ master). The
> > cairo widget stops redrawing until t
Hi
- Original Message -
>
> By the way, this egl initialization in the realize handler is actually
> breaking spice-gtk with newer gtk+ (specifically gtk+ master). The
> cairo widget stops redrawing until the widget gets resized, and then it
> freezes again until the next resize. When I c
hi
- Original Message -
> Hi,
>
>
> On 07/11/2016 06:16 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > While reviewing lz4 patch, I found that there are potential leaks. This
> > is untested, fyi. It would be nice if someone could confirm with running
> > ASA
Hi,
On 07/11/2016 06:16 PM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
While reviewing lz4 patch, I found that there are potential leaks. This
is untested, fyi. It would be nice if someone could confirm with running
ASAN for example.
Thanks for reviewing this:)
I've made some
On Wed, 2016-07-27 at 10:31 -0400, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> >
> >
> > - Original Message -
> > >
> > > When using GtkDrawingArea and EGL was not used, it was still
> > > initialized.
> > > This produced warning messages on systems where EGL is not
Hi,
On Wed, Jul 13, 2016 at 04:30:02PM +0200, Domenico Falco wrote:
> Hello!
>
> Thank you for everything, spice is an excellent solution for virtualization.
> But i have a little problem:
>
> - I configured the server (debian jessie) with qemu and spice.
> - Installed a virtual machine with win
Hi
- Original Message -
>
> - Original Message -
> > When using GtkDrawingArea and EGL was not used, it was still initialized.
> > This produced warning messages on systems where EGL is not supported.
>
> Not sure it's really a big problem since we require GL anyway.
>
> Which s
Hi
On Wed, Jul 27, 2016 at 3:56 PM, Marc-André Lureau
wrote:
> Hi
>
> - Original Message -
> > When using GtkDrawingArea and EGL was not used, it was still initialized.
> > This produced warning messages on systems where EGL is not supported.
>
> Not sure it's really a big problem since
On 07/27/2016 12:15 PM, Christophe Fergeau wrote:
On Mon, Jul 25, 2016 at 06:37:00PM +0200, Francois Gouget wrote:
On Sun, 24 Jul 2016, Uri Lublin wrote:
[...]
This patch prevents a crash as few lines below there is access
to agent->video_encoder->codec_type.
I think it would be better to make
On 07/25/2016 07:37 PM, Francois Gouget wrote:
On Sun, 24 Jul 2016, Uri Lublin wrote:
[...]
This patch prevents a crash as few lines below there is access
to agent->video_encoder->codec_type.
I think it would be better to make the check it in
dcc_create_stream(), and replace the patch here to a
On Wed, Jul 27, 2016 at 03:31:10PM +0200, Fabiano Fidêncio wrote:
> >> diff --git a/src/vmcstream.c b/src/vmcstream.c
> >> index c536f71..32d8b5e 100644
> >> --- a/src/vmcstream.c
> >> +++ b/src/vmcstream.c
> >> @@ -399,9 +399,13 @@ spice_vmc_output_stream_write_finish(GOutputStream
> >> *stream,
Hi
- Original Message -
> When using GtkDrawingArea and EGL was not used, it was still initialized.
> This produced warning messages on systems where EGL is not supported.
Not sure it's really a big problem since we require GL anyway.
Which system doesn't support egl?
>
> Move spice_eg
When using GtkDrawingArea and EGL was not used, it was still initialized.
This produced warning messages on systems where EGL is not supported.
Move spice_egl_init from drawing_area_realize to gl_scanout.
Drawing_area_realize is no longer needed.
---
Changes since v1:
- changed from recursive cal
On Wed, Jul 27, 2016 at 12:42 PM, Fabiano Fidêncio wrote:
> On Wed, Jul 27, 2016 at 12:39 PM, Christophe Fergeau
> wrote:
>> On Wed, Jul 27, 2016 at 11:17:38AM +0200, Fabiano Fidêncio wrote:
>>> This bogus code was introduced when switching to GTask API. Seems that
>>> while writing those patches
On Wed, Jul 27, 2016 at 12:39 PM, Christophe Fergeau
wrote:
> On Wed, Jul 27, 2016 at 11:17:38AM +0200, Fabiano Fidêncio wrote:
>> This bogus code was introduced when switching to GTask API. Seems that
>> while writing those patches I just overlooked this part and set the wrong
>> result for the t
On Wed, Jul 27, 2016 at 11:17:38AM +0200, Fabiano Fidêncio wrote:
> This bogus code was introduced when switching to GTask API. Seems that
> while writing those patches I just overlooked this part and set the wrong
> result for the task. As part of the problems introduced (and now fixed)
> you can
On Wed, 2016-07-27 at 09:49 +0100, Frediano Ziglio wrote:
> Windows does not like Pause key sent with same scancodes as Break.
> Although is the same physical key the two functions send two completely
> different set of codes. On key press a E1 1D 45 sequence is generated
> while on key release a E
Hi Marc-André,
On Wed, 2016-07-27 at 13:16 +0400, Marc-André Lureau wrote:
> Hi
>
> On Tue, Jul 26, 2016 at 7:55 PM, Pavel Grunt wrote:
> >
> > Check for current size of monitors stored in display channels and avoid
> > sending request to resize if it matches new requested size.
> >
>
> For t
This bogus code was introduced when switching to GTask API. Seems that
while writing those patches I just overlooked this part and set the wrong
result for the task. As part of the problems introduced (and now fixed)
you can notice that no output stream was being sent to the guest.
Signed-off-by:
Hi
On Tue, Jul 26, 2016 at 7:55 PM, Pavel Grunt wrote:
> Check for current size of monitors stored in display channels and avoid
> sending request to resize if it matches new requested size.
>
For the same reason as previous patch, I don't think that assumption
work as there might be pending con
On Mon, Jul 25, 2016 at 06:37:00PM +0200, Francois Gouget wrote:
> On Sun, 24 Jul 2016, Uri Lublin wrote:
> [...]
> > This patch prevents a crash as few lines below there is access
> > to agent->video_encoder->codec_type.
> >
> > I think it would be better to make the check it in
> > dcc_create_st
Hi
On Tue, Jul 26, 2016 at 7:55 PM, Pavel Grunt wrote:
> It helps to get the real display configuration from display channels
> instead of relying on the last requested monitor config.
>
I don't understand well what that patch is supposed to fix. However,
it is not a good idea to check against t
Windows does not like Pause key sent with same scancodes as Break.
Although is the same physical key the two functions send two completely
different set of codes. On key press a E1 1D 45 sequence is generated
while on key release a E1 9D C5 is generated. Also some hardware
keyboards send press+rele
Hi Frediano,
On Tue, 2016-07-26 at 13:32 +0100, Frediano Ziglio wrote:
> Windows does not like Pause key sent with same scancodes as Break.
> Although is the same physical key the two functions send two completely
> different set of codes.
> Tested with Linux and Windows clients.
> Tested with Lin
On Tue, Jul 26, 2016 at 02:35:53PM +0300, Uri Lublin wrote:
> On 07/25/2016 07:51 PM, Francois Gouget wrote:
> > On Mon, 25 Jul 2016, Frediano Ziglio wrote:
> > [...]
> > > > > -"client-tokens-interval",
> > > > > REDS_TOKENS_TO_SEND,
> > > > > -"sel
Hey,
On Wed, Jul 27, 2016 at 04:34:18AM +0200, Fabiano Fidêncio wrote:
> This bogus code was introduced when switching to GTask API. Seems that
> while writing those patches I just overlooked this part and set the wrong
> result for the task. As part of the problems introduced (and now fixed)
> yo
26 matches
Mail list logo
