On Mon, Jul 25, 2016 at 6:40 PM, Pavel Grunt wrote:
> Spotted by coverity
Although I remember seeing free (NULL); crashing in some really old
BDSs, it's a no-op in pretty much any modern system.
> ---
> python_modules/demarshal.py | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> di
Signed-off-by: Francois Gouget
---
As far as I can tell there is no way to tell the server that the stream
creation failed. So the client will still receive the video as a stream
and won't be able to display it. But at least it will not crash.
src/channel-display.c | 49 ++
On Mon, 25 Jul 2016, Frediano Ziglio wrote:
[...]
> > > -"client-tokens-interval", REDS_TOKENS_TO_SEND,
> > > -"self-tokens", REDS_NUM_INTERNAL_AGENT_MESSAGES,
> > > +"client-tokens-interval",
> > > (guint64)REDS_TOKENS_TO_SEN
On Mon, 25 Jul 2016, Frediano Ziglio wrote:
[...]
> I think in this case the frames are encoded as images. What also worry
> me is that at this point we did all streams computation/detection but
> then we can't stream so we are wasting lot of CPU time for nothing.
> Would not be more sensible to
On Sun, 24 Jul 2016, Uri Lublin wrote:
[...]
> This patch prevents a crash as few lines below there is access
> to agent->video_encoder->codec_type.
>
> I think it would be better to make the check it in
> dcc_create_stream(), and replace the patch here to assert.
I think it makes more sense to h
Spotted by coverity
---
python_modules/demarshal.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/python_modules/demarshal.py b/python_modules/demarshal.py
index 2252f37..de2ccd0 100644
--- a/python_modules/demarshal.py
+++ b/python_modules/demarshal.py
@@ -1098,8 +1098,7 @
> On 07/22/2016 09:11 PM, Francois Gouget wrote:
> > Without a video encoder no frame will be streamed anyway.
> > This fixes the case where the client does not support any of the
> > server's codecs, such as if it was compiled with --enable-gstvideo=no
> > --disable-builtin-mjpeg.
> >
> > Signed-o
>
> On 07/22/2016 08:39 PM, Francois Gouget wrote:
> > g_object_new is a variadic function which take property values.
> > As compiler cannot check if these property values are correct
> > make sure they are using casts.
> > This actully fix a crash in reds.c for 32 bit architectures.
> >
> > Base
